Title: [138248] trunk
Revision
138248
Author
dominik.rottsc...@intel.com
Date
2012-12-20 06:09:05 -0800 (Thu, 20 Dec 2012)

Log Message

[EFL] MiniBrowser does not play Infinite Gangnam Style
https://bugs.webkit.org/show_bug.cgi?id=103531

Reviewed by Kenneth Rohde Christiansen.

.:

WebAudio now switched to ON for EFL.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Specifying additional define to avoid deprecation warning.

No new tests, compile time change which doesn't affect behavior.

* PlatformEfl.cmake:

Source/WebKit2:

WebAudio preference now defaults to switched on.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):

Tools:

For EFL we would like this feature to be built by default.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Marked remaining webaudio failures.

* platform/efl/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (138247 => 138248)


--- trunk/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,14 @@
+2012-12-20  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] MiniBrowser does not play Infinite Gangnam Style
+        https://bugs.webkit.org/show_bug.cgi?id=103531
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        WebAudio now switched to ON for EFL.
+
+        * Source/cmake/OptionsEfl.cmake:
+
 2012-12-19  Yael Aharon  <yael.aha...@intel.com>
 
         [EFL] Allow the build system to find OpenGL ES

Modified: trunk/LayoutTests/ChangeLog (138247 => 138248)


--- trunk/LayoutTests/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/LayoutTests/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,14 @@
+2012-12-20  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] MiniBrowser does not play Infinite Gangnam Style
+        https://bugs.webkit.org/show_bug.cgi?id=103531
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Marked remaining webaudio failures.
+
+        * platform/efl/TestExpectations:
+
 2012-12-20  Csaba Osztrogonác  <o...@webkit.org>
 
         Unreviewed gardening, skip a crashing test to paint the bots green.

Modified: trunk/LayoutTests/platform/efl/TestExpectations (138247 => 138248)


--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 14:09:05 UTC (rev 138248)
@@ -646,6 +646,13 @@
 webkit.org/b/100519 fast/images/paletted-png-with-color-profile.html [ Skip ]
 
 #////////////////////////////////////////////////////////////////////////////////////////
+# CRASHES
+#////////////////////////////////////////////////////////////////////////////////////////
+
+webkit.org/b/105299 webaudio/_javascript_audionode.html [ Crash ]
+webkit.org/b/105299 webaudio/_javascript_audionode-upmix2-8channel-input.html [ Pass Crash ]
+
+#////////////////////////////////////////////////////////////////////////////////////////
 # FLAKY TESTS
 #////////////////////////////////////////////////////////////////////////////////////////
 
@@ -762,6 +769,8 @@
 webkit.org/b/105280 http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html [ Failure Pass ]
 webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html [ Failure Pass ]
 
+webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure Pass ]
+
 #////////////////////////////////////////////////////////////////////////////////////////
 # FAILING TESTS
 #////////////////////////////////////////////////////////////////////////////////////////
@@ -1159,11 +1168,6 @@
 webkit.org/b/88080 pointer-lock [ Skip ]
 webkit.org/b/88080 http/tests/pointer-lock [ Skip ]
 
-# Requires WEB_AUDIO support.
-webkit.org/b/91738 webaudio [ Skip ]
-webkit.org/b/91738 inspector-protocol/nmi-webaudio.html [ Skip ]
-webkit.org/b/91738 inspector-protocol/nmi-webaudio-leak-test.html [ Skip ]
-
 # Requires MEDIA_STREAM support.
 webkit.org/b/87662 fast/mediastream [ Skip ]
 
@@ -1729,5 +1733,26 @@
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ]
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ]
 
-# Failing touch events case 
-webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] 
+# Failing touch events case
+webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ]
+
+# WebAudio remaining issues
+webkit.org/b/105289 webaudio/mediastreamaudiosourcenode.html [ Failure ]
+webkit.org/b/105289 webaudio/mediastreamaudiodestinationnode.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-square.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-sine.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-custom.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-triangle.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-sawtooth.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/aac/vbr-128kbps-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/mp3/128kbps-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/wav/24bit-44khz.html [ Failure ]
+webkit.org/b/105294 webaudio/codec-tests/wav/24bit-22khz-resample.html [ Failure ]
+webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ]
+webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ]
+webkit.org/b/105297 webaudio/audiobuffersource-loop-points.html [ Failure ]
+webkit.org/b/105297 webaudio/audiobuffersource-playbackrate.html [ Failure ]
+webkit.org/b/105298 webaudio/decode-audio-data-basic.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (138247 => 138248)


--- trunk/Source/WebCore/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Source/WebCore/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,16 @@
+2012-12-20  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] MiniBrowser does not play Infinite Gangnam Style
+        https://bugs.webkit.org/show_bug.cgi?id=103531
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Specifying additional define to avoid deprecation warning.
+
+        No new tests, compile time change which doesn't affect behavior.
+
+        * PlatformEfl.cmake:
+
 2012-12-19  Simon Hausmann  <simon.hausm...@digia.com>, Jedrzej Nowacki <jedrzej.nowa...@digia.com>
 
         [Qt] JS bridge does not transmit QVariants anymore in Qt5

Modified: trunk/Source/WebCore/PlatformEfl.cmake (138247 => 138248)


--- trunk/Source/WebCore/PlatformEfl.cmake	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2012-12-20 14:09:05 UTC (rev 138248)
@@ -232,6 +232,8 @@
         ${GSTREAMER_INTERFACES_LIBRARIES}
         ${GSTREAMER_PBUTILS_LIBRARIES}
     )
+    # Avoiding a GLib deprecation warning due to GStreamer API using deprecated classes.
+    set_source_files_properties(platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp PROPERTIES COMPILE_DEFINITIONS "GLIB_DISABLE_DEPRECATION_WARNINGS=1")
 endif ()
 
 if (ENABLE_VIDEO)

Modified: trunk/Source/WebKit2/ChangeLog (138247 => 138248)


--- trunk/Source/WebKit2/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Source/WebKit2/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,15 @@
+2012-12-20  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] MiniBrowser does not play Infinite Gangnam Style
+        https://bugs.webkit.org/show_bug.cgi?id=103531
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        WebAudio preference now defaults to switched on.
+
+        * UIProcess/API/efl/EwkViewImpl.cpp:
+        (EwkViewImpl::EwkViewImpl):
+
 2012-12-20  Huang Dongsung  <luxte...@company100.net>
 
         Remove GraphicsLayer::setGraphicsLayerFactory().

Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (138247 => 138248)


--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp	2012-12-20 14:09:05 UTC (rev 138248)
@@ -164,6 +164,9 @@
     m_pageProxy->fullScreenManager()->setWebView(m_view);
     m_pageProxy->pageGroup()->preferences()->setFullScreenEnabled(true);
 #endif
+#if ENABLE(WEB_AUDIO)
+    m_pageProxy->pageGroup()->preferences()->setWebAudioEnabled(true);
+#endif
 
     m_pageProxy->pageGroup()->preferences()->setOfflineWebApplicationCacheEnabled(true);
 

Modified: trunk/Source/cmake/OptionsEfl.cmake (138247 => 138248)


--- trunk/Source/cmake/OptionsEfl.cmake	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-12-20 14:09:05 UTC (rev 138248)
@@ -85,6 +85,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIBRATION ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_INTENTS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_INTENTS_TAG ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING ON)

Modified: trunk/Tools/ChangeLog (138247 => 138248)


--- trunk/Tools/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Tools/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,14 @@
+2012-12-20  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] MiniBrowser does not play Infinite Gangnam Style
+        https://bugs.webkit.org/show_bug.cgi?id=103531
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        For EFL we would like this feature to be built by default.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2012-12-20  Csaba Osztrogonác  <o...@webkit.org>
 
         [Qt] EWS bots should call qmake always

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (138247 => 138248)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-12-20 14:09:05 UTC (rev 138248)
@@ -430,7 +430,7 @@
       define => "ENABLE_WEBGL", default => (isAppleMacWebKit() || isGtk() || isEfl()), value => \$webglSupport },
 
     { option => "web-audio", desc => "Toggle Web Audio support",
-      define => "ENABLE_WEB_AUDIO", default => 0, value => \$webAudioSupport },
+      define => "ENABLE_WEB_AUDIO", default => (isEfl()), value => \$webAudioSupport },
 
     { option => "web-intents", desc => "Toggle Web Intents support",
       define => "ENABLE_WEB_INTENTS", default => isEfl(), value => \$webIntentsSupport },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to