Title: [139616] trunk
- Revision
- 139616
- Author
- vse...@chromium.org
- Date
- 2013-01-14 08:46:58 -0800 (Mon, 14 Jan 2013)
Log Message
Web Inspector: Audit Tool's False Positive on Set-Cookie header
https://bugs.webkit.org/show_bug.cgi?id=106794
Reviewed by Pavel Feldman.
Source/WebCore:
Header value is now returned as undefined if there is no such header as it was before regression.
Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._headerValue):
LayoutTests:
* http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139615 => 139616)
--- trunk/LayoutTests/ChangeLog 2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/LayoutTests/ChangeLog 2013-01-14 16:46:58 UTC (rev 139616)
@@ -1,3 +1,14 @@
+2013-01-14 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: Audit Tool's False Positive on Set-Cookie header
+ https://bugs.webkit.org/show_bug.cgi?id=106794
+
+ Reviewed by Pavel Feldman.
+
+ * http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
+ * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
+ * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
+
2013-01-14 Tommy Widenflycht <tom...@google.com>
MediaStream API: Update the track accessors on MediaStream to match the latest specification
Copied: trunk/LayoutTests/http/tests/inspector/audits/resources/abe.png (from rev 139615, trunk/LayoutTests/inspector/audits/resources/abe.png)
(Binary files differ)
Added: trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt (0 => 139616)
--- trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt 2013-01-14 16:46:58 UTC (rev 139616)
@@ -0,0 +1,4 @@
+Tests there is no false positive Set-Cookie audit error.
+Page reloaded.
+Success, no Set-Cookie headers found.
+
Added: trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html (0 => 139616)
--- trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html 2013-01-14 16:46:58 UTC (rev 139616)
@@ -0,0 +1,25 @@
+<html>
+<head>
+<script src=""
+<script>
+var test = function()
+{
+ InspectorTest.reloadPage(step1);
+
+ function step1()
+ {
+ WebInspector.showPanel("network");
+ var requests = WebInspector.panels.network.requests;
+ for (var i = 0; i < requests.length; ++i)
+ InspectorTest.assertTrue(requests[i].responseHeaderValue("Set-Cookie") === undefined);
+ InspectorTest.addResult("Success, no Set-Cookie headers found.");
+ InspectorTest.completeTest();
+ }
+}
+</script>
+</head>
+<body _onload_="runTest()">
+Tests there is no false positive Set-Cookie audit error.
+<img src=""
+</body>
+</html>
Deleted: trunk/LayoutTests/inspector/audits/resources/abe.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (139615 => 139616)
--- trunk/Source/WebCore/ChangeLog 2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/Source/WebCore/ChangeLog 2013-01-14 16:46:58 UTC (rev 139616)
@@ -1,3 +1,19 @@
+2013-01-14 Vsevolod Vlasov <vse...@chromium.org>
+
+ Web Inspector: Audit Tool's False Positive on Set-Cookie header
+ https://bugs.webkit.org/show_bug.cgi?id=106794
+
+ Reviewed by Pavel Feldman.
+
+ Header value is now returned as undefined if there is no such header as it was before regression.
+
+ Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
+
+ * inspector/front-end/AuditRules.js:
+ (WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
+ * inspector/front-end/NetworkRequest.js:
+ (WebInspector.NetworkRequest.prototype._headerValue):
+
2013-01-14 Eric Carlson <eric.carl...@apple.com>
Do not pass nil when initializing legible output
Modified: trunk/Source/WebCore/inspector/front-end/AuditRules.js (139615 => 139616)
--- trunk/Source/WebCore/inspector/front-end/AuditRules.js 2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/Source/WebCore/inspector/front-end/AuditRules.js 2013-01-14 16:46:58 UTC (rev 139616)
@@ -1058,6 +1058,8 @@
if (error)
return callback(null);
+ if (!headers.length)
+ return callback(null);
for (var i = 0; i < headers.length; ++i) {
var header = headers[i];
if (header.disabled)
Modified: trunk/Source/WebCore/inspector/front-end/NetworkRequest.js (139615 => 139616)
--- trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-01-14 16:46:58 UTC (rev 139616)
@@ -714,6 +714,8 @@
if (headers[i].name.toLowerCase() === headerName)
values.push(headers[i].value);
}
+ if (!values.length)
+ return undefined;
// Set-Cookie values should be separated by '\n', not comma, otherwise cookies could not be parsed.
if (headerName === "set-cookie")
return values.join("\n");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
