Title: [143526] trunk/Source/WebCore
- Revision
- 143526
- Author
- ad...@chromium.org
- Date
- 2013-02-20 16:00:33 -0800 (Wed, 20 Feb 2013)
Log Message
[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396
Reviewed by Kentaro Hara.
This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.
* bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143525 => 143526)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 23:59:55 UTC (rev 143525)
+++ trunk/Source/WebCore/ChangeLog 2013-02-21 00:00:33 UTC (rev 143526)
@@ -1,3 +1,16 @@
+2013-02-20 Adam Klein <ad...@chromium.org>
+
+ [v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
+ https://bugs.webkit.org/show_bug.cgi?id=110396
+
+ Reviewed by Kentaro Hara.
+
+ This is in preparation for a refactor to expose a simplified
+ WrapperGrouper interface to V8 wrapper classes enabling them to
+ specify multiple roots per wrapper object.
+
+ * bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
+
2013-02-20 Levi Weintraub <le...@chromium.org>
Line layout (but not pref widths) double-counts word spacing when between inlines
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (143525 => 143526)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2013-02-20 23:59:55 UTC (rev 143525)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2013-02-21 00:00:33 UTC (rev 143526)
@@ -311,7 +311,7 @@
MutationObserver* observer = static_cast<MutationObserver*>(object);
HashSet<Node*> observedNodes = observer->getObservedNodes();
for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNodes.end(); ++it)
- m_grouper.addNodeToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
+ m_grouper.addObjectToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
} else {
ActiveDOMObject* activeDOMObject = type->toActiveDOMObject(wrapper);
if (activeDOMObject && activeDOMObject->hasPendingActivity())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
