Title: [147244] trunk/Source/WebCore
- Revision
- 147244
- Author
- jsb...@chromium.org
- Date
- 2013-03-29 12:56:59 -0700 (Fri, 29 Mar 2013)
Log Message
IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
https://bugs.webkit.org/show_bug.cgi?id=113594
Reviewed by Tony Chang.
Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.
Test: http/tests/inspector/indexeddb/database-structure.html
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147243 => 147244)
--- trunk/Source/WebCore/ChangeLog 2013-03-29 19:51:22 UTC (rev 147243)
+++ trunk/Source/WebCore/ChangeLog 2013-03-29 19:56:59 UTC (rev 147244)
@@ -1,5 +1,20 @@
2013-03-29 Joshua Bell <jsb...@chromium.org>
+ IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
+ https://bugs.webkit.org/show_bug.cgi?id=113594
+
+ Reviewed by Tony Chang.
+
+ Split out from another patch: rather than m_foo = true; ... m_foo = false; use
+ the handy WTF::TemporaryChange scoped variable change doohickey.
+
+ Test: http/tests/inspector/indexeddb/database-structure.html
+
+ * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+ (WebCore::IDBDatabaseBackendImpl::close):
+
+2013-03-29 Joshua Bell <jsb...@chromium.org>
+
[V8] IndexedDB: Exceptions thrown inconsistently for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113091
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp (147243 => 147244)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2013-03-29 19:51:22 UTC (rev 147243)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2013-03-29 19:56:59 UTC (rev 147244)
@@ -38,6 +38,7 @@
#include "IDBTransactionBackendImpl.h"
#include "IDBTransactionCoordinator.h"
#include "SharedBuffer.h"
+#include <wtf/TemporaryChange.h>
namespace WebCore {
@@ -1334,7 +1335,7 @@
// To avoid that situation, don't proceed in case of reentrancy.
if (m_closingConnection)
return;
- m_closingConnection = true;
+ TemporaryChange<bool> closingConnection(m_closingConnection, true);
processPendingCalls();
// FIXME: Add a test for the m_pendingOpenCalls cases below.
@@ -1351,7 +1352,6 @@
if (m_factory)
m_factory->removeIDBDatabaseBackend(m_identifier);
}
- m_closingConnection = false;
}
void CreateObjectStoreAbortOperation::perform(IDBTransactionBackendImpl* transaction)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
