Title: [150701] trunk/Tools
- Revision
- 150701
- Author
- rn...@webkit.org
- Date
- 2013-05-25 19:57:51 -0700 (Sat, 25 May 2013)
Log Message
Teach webkitbot and WKR how to respond to yt?
https://bugs.webkit.org/show_bug.cgi?id=116775
Reviewed by Andreas Kling.
* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi): Fixed the usage string.
(Hi.execute): Made it more generic so that it works in WKR.
(YouThere): Added.
(YouThere.execute): Added.
* Scripts/webkitpy/tool/commands/newcommitbot.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (150700 => 150701)
--- trunk/Tools/ChangeLog 2013-05-26 02:48:46 UTC (rev 150700)
+++ trunk/Tools/ChangeLog 2013-05-26 02:57:51 UTC (rev 150701)
@@ -1,3 +1,17 @@
+2013-05-25 Ryosuke Niwa <rn...@webkit.org>
+
+ Teach webkitbot and WKR how to respond to yt?
+ https://bugs.webkit.org/show_bug.cgi?id=116775
+
+ Reviewed by Andreas Kling.
+
+ * Scripts/webkitpy/tool/bot/irc_command.py:
+ (Hi): Fixed the usage string.
+ (Hi.execute): Made it more generic so that it works in WKR.
+ (YouThere): Added.
+ (YouThere.execute): Added.
+ * Scripts/webkitpy/tool/commands/newcommitbot.py:
+
2013-05-25 Simon Fraser <simon.fra...@apple.com>
Try to fix the EFL build.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (150700 => 150701)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2013-05-26 02:48:46 UTC (rev 150700)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2013-05-26 02:57:51 UTC (rev 150701)
@@ -111,10 +111,10 @@
class Hi(IRCCommand):
usage_string = "hi"
- help_string = "Retrieves a random quip from Bugzilla."
+ help_string = "Responds with hi."
def execute(self, nick, args, tool, sheriff):
- if len(args) and re.match(r'webkitbot_*\s*!\s*', ' '.join(args)):
+ if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
return "%s: hi %s!" % (nick, nick)
quips = tool.bugs.quips()
quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
@@ -129,6 +129,14 @@
return nick + ": pong"
+class YouThere(IRCCommand):
+ usage_string = "yt?"
+ help_string = "Responds with yes."
+
+ def execute(self, nick, args, tool, sheriff):
+ return "%s: yes" % nick
+
+
class Restart(IRCCommand):
usage_string = "restart"
help_string = "Restarts sherrifbot. Will update its WebKit checkout, and re-join the channel momentarily."
@@ -298,6 +306,7 @@
"roll-chromium-deps": RollChromiumDEPS,
"rollout": Rollout,
"whois": Whois,
+ "yt?": YouThere,
}
# Add revert as an "easter egg" command. Why?
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py (150700 => 150701)
--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2013-05-26 02:48:46 UTC (rev 150700)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2013-05-26 02:57:51 UTC (rev 150701)
@@ -37,6 +37,7 @@
from webkitpy.tool.bot.irc_command import Hi
from webkitpy.tool.bot.irc_command import PingPong
from webkitpy.tool.bot.irc_command import Restart
+from webkitpy.tool.bot.irc_command import YouThere
from webkitpy.tool.bot.ircbot import IRCBot
from webkitpy.tool.commands.queues import AbstractQueue
from webkitpy.tool.commands.stepsequence import StepSequenceErrorHandler
@@ -52,6 +53,7 @@
"hi": Hi,
"ping": PingPong,
"restart": Restart,
+ "yt?": YouThere,
}
_maximum_number_of_revisions_to_avoid_spamming_irc = 10
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
