Title: [151641] trunk/LayoutTests
Revision
151641
Author
ser...@webkit.org
Date
2013-06-17 07:32:02 -0700 (Mon, 17 Jun 2013)

Log Message

Remove invalid checks from block-cursor-overtype-mode.html
https://bugs.webkit.org/show_bug.cgi?id=117587

Reviewed by Darin Adler.

The test uses an array of ">" "<" symbols to perform comparisons
between consecutive positions of the block cursor. Since those
checks are done for each pair of consecutive characters the total
amount of checks is lengthOfTheWord - 1. We were adding an extra
symbol that was not used at all in the test.

* editing/selection/block-cursor-overtype-mode.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (151640 => 151641)


--- trunk/LayoutTests/ChangeLog	2013-06-17 13:57:45 UTC (rev 151640)
+++ trunk/LayoutTests/ChangeLog	2013-06-17 14:32:02 UTC (rev 151641)
@@ -1,3 +1,18 @@
+2013-06-17  Sergio Villar Senin  <svil...@igalia.com>
+
+        Remove invalid checks from block-cursor-overtype-mode.html
+        https://bugs.webkit.org/show_bug.cgi?id=117587
+
+        Reviewed by Darin Adler.
+
+        The test uses an array of ">" "<" symbols to perform comparisons
+        between consecutive positions of the block cursor. Since those
+        checks are done for each pair of consecutive characters the total
+        amount of checks is lengthOfTheWord - 1. We were adding an extra
+        symbol that was not used at all in the test.
+
+        * editing/selection/block-cursor-overtype-mode.html:
+
 2013-06-17  Zoltan Arvai  <zar...@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening. Correcting rebaselining after r151634.

Modified: trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html (151640 => 151641)


--- trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html	2013-06-17 13:57:45 UTC (rev 151640)
+++ trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html	2013-06-17 14:32:02 UTC (rev 151641)
@@ -57,10 +57,10 @@
 
     internals.toggleOverwriteModeEnabled(document);
 
-    verifyBlockCursorLeftPositionAndWidth("ltrtext", ["<", "<", "<"]);
-    verifyBlockCursorLeftPositionAndWidth("ltrtext-rtl", ["<", "<", "<"]);
-    verifyBlockCursorLeftPositionAndWidth("rtltext", [">", ">", ">"]);
-    verifyBlockCursorLeftPositionAndWidth("rtltext-rtl", [">", ">", ">"]);
+    verifyBlockCursorLeftPositionAndWidth("ltrtext", ["<", "<"]);
+    verifyBlockCursorLeftPositionAndWidth("ltrtext-rtl", ["<", "<"]);
+    verifyBlockCursorLeftPositionAndWidth("rtltext", [">", ">"]);
+    verifyBlockCursorLeftPositionAndWidth("rtltext-rtl", [">", ">"]);
     verifyBlockCursorLeftPositionAndWidth("mixed", [">", ">", "<", "<", "<"]);
     verifyBlockCursorLeftPositionAndWidth("mixed-rtl", [">", ">", ">", "<", "<"]);
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to