Title: [166326] trunk/Source/WebKit2
- Revision
- 166326
- Author
- commit-qu...@webkit.org
- Date
- 2014-03-26 16:35:39 -0700 (Wed, 26 Mar 2014)
Log Message
-[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.
https://bugs.webkit.org/show_bug.cgi?id=130804
Patch by Cody Krieger <c...@apple.com> on 2014-03-26
Reviewed by Dan Bernstein.
The existing implementations of these methods are mis-cased
("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" —
note the "EL" in both cases). This results in us getting
auto-synthesized getters for the HTMLInputElementIsUserEdited and
HTMLTextAreaElementIsUserEdited properties, which will return NO
unconditionally.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
Fix the capitalization of -HTMLInputElementIsUserEdited and
-HTMLTextAreaElementIsUserEdited.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166325 => 166326)
--- trunk/Source/WebKit2/ChangeLog 2014-03-26 23:26:48 UTC (rev 166325)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-26 23:35:39 UTC (rev 166326)
@@ -1,3 +1,22 @@
+2014-03-26 Cody Krieger <c...@apple.com>
+
+ -[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.
+
+ https://bugs.webkit.org/show_bug.cgi?id=130804
+
+ Reviewed by Dan Bernstein.
+
+ The existing implementations of these methods are mis-cased
+ ("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" —
+ note the "EL" in both cases). This results in us getting
+ auto-synthesized getters for the HTMLInputElementIsUserEdited and
+ HTMLTextAreaElementIsUserEdited properties, which will return NO
+ unconditionally.
+
+ * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
+ Fix the capitalization of -HTMLInputElementIsUserEdited and
+ -HTMLTextAreaElementIsUserEdited.
+
2014-03-26 Andy Estes <aes...@apple.com>
[Cocoa] Expose DownloadProxy::cancel()
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm (166325 => 166326)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2014-03-26 23:26:48 UTC (rev 166325)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2014-03-26 23:35:39 UTC (rev 166326)
@@ -78,12 +78,12 @@
_nodeHandle->setHTMLInputElementAutofilled(isAutoFilled);
}
-- (BOOL)HTMLInputELementIsUserEdited
+- (BOOL)HTMLInputElementIsUserEdited
{
return _nodeHandle->htmlInputElementLastChangeWasUserEdit();
}
-- (BOOL)HTMLTextAreaELementIsUserEdited
+- (BOOL)HTMLTextAreaElementIsUserEdited
{
return _nodeHandle->htmlTextAreaElementLastChangeWasUserEdit();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
