Title: [167702] trunk/Tools
- Revision
- 167702
- Author
- commit-qu...@webkit.org
- Date
- 2014-04-23 02:39:51 -0700 (Wed, 23 Apr 2014)
Log Message
[GTK] run-webkit-tests script is failing to invoke run-launcher
https://bugs.webkit.org/show_bug.cgi?id=132051
Patch by Lorenzo Tilve <lti...@igalia.com> on 2014-04-23
Reviewed by Philippe Normand.
After the WK1 support was dropped, if run-webkit-tests is executed
without --no-show-results parameter, the launcher is being called
using a -2 parameter that is it causing the run-launcher to break.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.show_results_html_file):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (167701 => 167702)
--- trunk/Tools/ChangeLog 2014-04-23 07:34:01 UTC (rev 167701)
+++ trunk/Tools/ChangeLog 2014-04-23 09:39:51 UTC (rev 167702)
@@ -1,3 +1,17 @@
+2014-04-23 Lorenzo Tilve <lti...@igalia.com>
+
+ [GTK] run-webkit-tests script is failing to invoke run-launcher
+ https://bugs.webkit.org/show_bug.cgi?id=132051
+
+ Reviewed by Philippe Normand.
+
+ After the WK1 support was dropped, if run-webkit-tests is executed
+ without --no-show-results parameter, the launcher is being called
+ using a -2 parameter that is it causing the run-launcher to break.
+
+ * Scripts/webkitpy/port/gtk.py:
+ (GtkPort.show_results_html_file):
+
2014-04-22 Tim Horton <timothy_hor...@apple.com>
DumpRenderTree generates black snapshots on some platforms
Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (167701 => 167702)
--- trunk/Tools/Scripts/webkitpy/port/gtk.py 2014-04-23 07:34:01 UTC (rev 167701)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py 2014-04-23 09:39:51 UTC (rev 167702)
@@ -184,8 +184,6 @@
# or teach run-launcher how to call run-safari and move this down to Port.
def show_results_html_file(self, results_filename):
run_launcher_args = ["file://%s" % results_filename]
- if self.get_option('webkit_test_runner'):
- run_launcher_args.append('-2')
# FIXME: old-run-webkit-tests also added ["-graphicssystem", "raster", "-style", "windows"]
# FIXME: old-run-webkit-tests converted results_filename path for cygwin.
self._run_script("run-launcher", run_launcher_args)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
