Title: [167737] trunk/Source/WebKit/efl
- Revision
- 167737
- Author
- commit-qu...@webkit.org
- Date
- 2014-04-23 19:25:08 -0700 (Wed, 23 Apr 2014)
Log Message
[EFL][WK1] Add *const* keyword to _get() APIs
https://bugs.webkit.org/show_bug.cgi?id=132094
Patch by Hyowon Kim <hw1008....@samsung.com> on 2014-04-23
Reviewed by Gyuyoung Kim.
Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
We need to add *const* keyword to those APIs.
* ewk/ewk_history.cpp:
(ewk_history_limit_get):
* ewk/ewk_history.h:
* ewk/ewk_js.cpp:
(ewk_js_object_type_get):
* ewk/ewk_js.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (167736 => 167737)
--- trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:25:08 UTC (rev 167737)
@@ -1,3 +1,20 @@
+2014-04-23 Hyowon Kim <hw1008....@samsung.com>
+
+ [EFL][WK1] Add *const* keyword to _get() APIs
+ https://bugs.webkit.org/show_bug.cgi?id=132094
+
+ Reviewed by Gyuyoung Kim.
+
+ Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
+ We need to add *const* keyword to those APIs.
+
+ * ewk/ewk_history.cpp:
+ (ewk_history_limit_get):
+ * ewk/ewk_history.h:
+ * ewk/ewk_js.cpp:
+ (ewk_js_object_type_get):
+ * ewk/ewk_js.h:
+
2014-04-22 Ryuan Choi <ryuan.c...@samsung.com>
[EFL][WK1] There are many failures in fast/forms since r163033
Modified: trunk/Source/WebKit/efl/ewk/ewk_history.cpp (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:25:08 UTC (rev 167737)
@@ -219,7 +219,7 @@
return core->backListCount();
}
-int ewk_history_limit_get(Ewk_History* history)
+int ewk_history_limit_get(const Ewk_History* history)
{
EWK_HISTORY_CORE_GET_OR_RETURN(history, core, 0);
return core->capacity();
Modified: trunk/Source/WebKit/efl/ewk/ewk_history.h (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:25:08 UTC (rev 167737)
@@ -251,7 +251,7 @@
*
* @return maximum number of entries this history will hold.
*/
-EAPI int ewk_history_limit_get(Ewk_History *history);
+EAPI int ewk_history_limit_get(const Ewk_History *history);
/**
* Set maximum capacity of given history.
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.cpp (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:25:08 UTC (rev 167737)
@@ -693,7 +693,7 @@
#endif
}
-Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object* jsObject)
+Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object* jsObject)
{
#if ENABLE(NETSCAPE_PLUGIN_API)
EINA_SAFETY_ON_NULL_RETURN_VAL(jsObject, EWK_JS_OBJECT_OBJECT);
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.h (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:25:08 UTC (rev 167737)
@@ -191,7 +191,7 @@
* @return @c EWK_JS_OBJECT if it is an object, @c EWK_JS_ARRAY if it is an array and
* @c EWK_JS_FUNCTION if it is a function.
*/
-EAPI Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object *obj);
+EAPI Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object *obj);
/**
* Sets the type this object represents.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
