Title: [186255] trunk
Revision
186255
Author
commit-qu...@webkit.org
Date
2015-07-02 20:08:44 -0700 (Thu, 02 Jul 2015)

Log Message

[EFL] test_ewk2_application_cache_manager has been failed since r185527
https://bugs.webkit.org/show_bug.cgi?id=146016

Patch by Przemek Piorkowski <piorkowskiprzemys...@gmail.com> on 2015-07-02
Reviewed by Gyuyoung Kim.

In order to handle properly WebApplicationCacheManagerProxy implementation which use
.:

WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

* Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL.

Source/WebCore:

WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

* PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files.

Source/WebKit2:

WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.

* UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
(TEST_F): enable ewk_application_cache_manager as it is passing now.

Modified Paths

Diff

Modified: trunk/ChangeLog (186254 => 186255)


--- trunk/ChangeLog	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/ChangeLog	2015-07-03 03:08:44 UTC (rev 186255)
@@ -1,3 +1,16 @@
+2015-07-02  Przemek Piorkowski  <piorkowskiprzemys...@gmail.com>
+
+        [EFL] test_ewk2_application_cache_manager has been failed since r185527
+        https://bugs.webkit.org/show_bug.cgi?id=146016
+
+        Reviewed by Gyuyoung Kim.
+
+        In order to handle properly WebApplicationCacheManagerProxy implementation which use
+        WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
+        Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+        * Source/cmake/OptionsEfl.cmake: set ENABLE_PUBLIC_SUFFIX_LIST to ON for EFL.
+
 2015-06-30  Andy VanWagoner  <thetalecraf...@gmail.com>
 
         Implement ECMAScript Internationalization API

Modified: trunk/Source/WebCore/ChangeLog (186254 => 186255)


--- trunk/Source/WebCore/ChangeLog	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebCore/ChangeLog	2015-07-03 03:08:44 UTC (rev 186255)
@@ -1,3 +1,16 @@
+2015-07-02  Przemek Piorkowski  <piorkowskiprzemys...@gmail.com>
+
+        [EFL] test_ewk2_application_cache_manager has been failed since r185527
+        https://bugs.webkit.org/show_bug.cgi?id=146016
+
+        Reviewed by Gyuyoung Kim.
+
+        In order to handle properly WebApplicationCacheManagerProxy implementation which use
+        WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL. 
+        Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+        * PlatformEfl.cmake: PublicSuffixSoup.cpp added to source files.
+
 2015-07-02  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r186251.

Modified: trunk/Source/WebCore/PlatformEfl.cmake (186254 => 186255)


--- trunk/Source/WebCore/PlatformEfl.cmake	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2015-07-03 03:08:44 UTC (rev 186255)
@@ -248,6 +248,7 @@
     platform/posix/FileSystemPOSIX.cpp
     platform/posix/SharedBufferPOSIX.cpp
 
+    platform/soup/PublicSuffixSoup.cpp
     platform/soup/SharedBufferSoup.cpp
     platform/soup/URLSoup.cpp
 

Modified: trunk/Source/WebKit2/ChangeLog (186254 => 186255)


--- trunk/Source/WebKit2/ChangeLog	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-03 03:08:44 UTC (rev 186255)
@@ -1,3 +1,17 @@
+2015-07-02  Przemek Piorkowski  <piorkowskiprzemys...@gmail.com>
+
+        [EFL] test_ewk2_application_cache_manager has been failed since r185527
+        https://bugs.webkit.org/show_bug.cgi?id=146016
+
+        Reviewed by Gyuyoung Kim.
+
+        In order to handle properly WebApplicationCacheManagerProxy implementation which use
+        WebsiteDataRecord it is necessary to enable PUBLIC_SUFFIX_LIST for EFL.
+        Implementation of PUBLIC_SUFFIX_LIST already exists for soup so EFL can use it as well.
+
+        * UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
+        (TEST_F): enable ewk_application_cache_manager as it is passing now.
+
 2015-07-02  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r186247 and r186250.

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp (186254 => 186255)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp	2015-07-03 03:08:44 UTC (rev 186255)
@@ -95,7 +95,7 @@
     return ECORE_CALLBACK_CANCEL;
 }
 
-TEST_F(EWK2UnitTestBase, DISABLED_ewk_application_cache_manager)
+TEST_F(EWK2UnitTestBase, ewk_application_cache_manager)
 {
     std::unique_ptr<EWK2UnitTestServer> httpServer = std::make_unique<EWK2UnitTestServer>();
     httpServer->run(serverCallback);

Modified: trunk/Source/cmake/OptionsEfl.cmake (186254 => 186255)


--- trunk/Source/cmake/OptionsEfl.cmake	2015-07-03 02:40:00 UTC (rev 186254)
+++ trunk/Source/cmake/OptionsEfl.cmake	2015-07-03 03:08:44 UTC (rev 186255)
@@ -107,6 +107,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_PROCESS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOSNIFF PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PICTURE_SIZES PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SECCOMP_FILTERS PUBLIC OFF)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to