Title: [193858] trunk/Source/WebInspectorUI
- Revision
- 193858
- Author
- bb...@apple.com
- Date
- 2015-12-09 13:34:52 -0800 (Wed, 09 Dec 2015)
Log Message
Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked
https://bugs.webkit.org/show_bug.cgi?id=152076
Reviewed by Timothy Hatcher.
When computing the new width or height of the inspector, take the zoom level into
account. window.inner{Width,Height} are in document pixels, but we need to specify
device pixels to InspectorFrontendHost.
* UserInterface/Base/Main.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (193857 => 193858)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 21:22:03 UTC (rev 193857)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-09 21:34:52 UTC (rev 193858)
@@ -1,3 +1,16 @@
+2015-12-09 Brian Burg <bb...@apple.com>
+
+ Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked
+ https://bugs.webkit.org/show_bug.cgi?id=152076
+
+ Reviewed by Timothy Hatcher.
+
+ When computing the new width or height of the inspector, take the zoom level into
+ account. window.inner{Width,Height} are in document pixels, but we need to specify
+ device pixels to InspectorFrontendHost.
+
+ * UserInterface/Base/Main.js:
+
2015-12-08 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Workaround arrow function issue in TimelineOverviewGraph.js
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (193857 => 193858)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 21:22:03 UTC (rev 193857)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-12-09 21:34:52 UTC (rev 193858)
@@ -1586,7 +1586,10 @@
if (delta < 0 && clientPosition > firstClientPosition)
return;
- var dimension = Math.max(0, window[windowProperty] - delta);
+ let dimension = Math.max(0, window[windowProperty] - delta);
+ // If zoomed in/out, there be greater/fewer document pixels shown, but the inspector's
+ // width or height should be the same in device pixels regardless of the document zoom.
+ dimension *= InspectorFrontendHost.zoomFactor();
if (this._dockSide === "bottom")
InspectorFrontendHost.setAttachedWindowHeight(dimension);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
