Title: [193865] trunk/LayoutTests
Revision
193865
Author
beid...@apple.com
Date
2015-12-09 14:22:26 -0800 (Wed, 09 Dec 2015)

Log Message

Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152078

Reviewed by Alex Christensen.

* platform/mac-wk1/TestExpectations:
* storage/indexeddb/createIndex-after-failure-expected.txt:
* storage/indexeddb/resources/createIndex-after-failure.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (193864 => 193865)


--- trunk/LayoutTests/ChangeLog	2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/ChangeLog	2015-12-09 22:22:26 UTC (rev 193865)
@@ -1,3 +1,14 @@
+2015-12-09  Brady Eidson  <beid...@apple.com>
+
+        Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=152078
+
+        Reviewed by Alex Christensen.
+
+        * platform/mac-wk1/TestExpectations:
+        * storage/indexeddb/createIndex-after-failure-expected.txt:
+        * storage/indexeddb/resources/createIndex-after-failure.js:
+
 2015-12-09  Ryan Haddad  <ryanhad...@apple.com>
 
         Baseline fast/dom/HTMLProgressElement/native-progress-bar.html for iOS

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193864 => 193865)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-09 22:22:26 UTC (rev 193865)
@@ -92,7 +92,6 @@
 storage/indexeddb/unblocked-version-changes.html [ Skip ]
 
 # IDB tests with text failures                                                             
-storage/indexeddb/createIndex-after-failure.html [ Failure ]
 storage/indexeddb/cursor-continue.html [ Failure ]
 storage/indexeddb/database-closepending-flag.html [ Failure ]
 storage/indexeddb/database-deletepending-flag.html [ Failure ]

Modified: trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt (193864 => 193865)


--- trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt	2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/storage/indexeddb/createIndex-after-failure-expected.txt	2015-12-09 22:22:26 UTC (rev 193865)
@@ -1,4 +1,4 @@
-Test IndexedDB's basics.
+Test createIndex failing due to a ConstraintError
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
@@ -17,17 +17,8 @@
 Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
 Now requesting object2
 now we wait.
-deleteIndexAfterGet()
-Expecting exception from objectStore.deleteIndex('index')
-PASS Exception was thrown.
-PASS code is DOMException.NOT_FOUND_ERR
-PASS ename is 'NotFoundError'
-Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
-Expecting exception from objectStore.deleteIndex('index')
-PASS Exception was thrown.
-PASS code is DOMException.NOT_FOUND_ERR
-PASS ename is 'NotFoundError'
-Exception message: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
+Error function called: (AbortError) undefined
+PASS Abort function called: (ConstraintError) undefined
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js (193864 => 193865)


--- trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js	2015-12-09 22:11:41 UTC (rev 193864)
+++ trunk/LayoutTests/storage/indexeddb/resources/createIndex-after-failure.js	2015-12-09 22:22:26 UTC (rev 193865)
@@ -3,12 +3,13 @@
     importScripts('shared.js');
 }
 
-description("Test IndexedDB's basics.");
+description("Test createIndex failing due to a ConstraintError");
 
 indexedDBTest(prepareDatabase);
 function prepareDatabase(event)
 {
     trans = event.target.transaction;
+    trans._onabort_ = abortCallback;
     db = event.target.result;
 
     db.createObjectStore("objectStore");
@@ -29,18 +30,20 @@
     // confused and crash, or think the index still exists.
     evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
     debug("Now requesting object2");
+    
+    // None of the following 3 lines will actually do anything because the call to createIndex will forcefully abort the transaction.
     var req3 = objectStore.get("object2");
-    req3._onsuccess_ = deleteIndexAfterGet;
-    req3._onerror_ = unexpectedErrorCallback;
+    req3._onsuccess_ = unexpectedSuccessCallback;
+    req3._onerror_ = errorCallback;
+    
     debug("now we wait.");
 }
 
-function deleteIndexAfterGet() {
-    // so we will delete it next, but it should already be gone... right?
-    debug("deleteIndexAfterGet()");
-    // the index should still be gone, and this should not crash.
-    evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
-    evalAndExpectException("objectStore.deleteIndex('index')", "DOMException.NOT_FOUND_ERR", "'NotFoundError'");
+function errorCallback() {
+    debug("Error function called: (" + event.target.error.name + ") " + event.target.error.message);
+}
 
+function abortCallback() {
+    testPassed("Abort function called: (" + event.target.error.name + ") " + event.target.error.message);
     finishJSTest();
-}
\ No newline at end of file
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to