Title: [200574] trunk/Source/WebInspectorUI
- Revision
- 200574
- Author
- mattba...@apple.com
- Date
- 2016-05-09 07:59:23 -0700 (Mon, 09 May 2016)
Log Message
Web Inspector: Cleanup issue tree elements in the Debugger sidebar
https://bugs.webkit.org/show_bug.cgi?id=157469
<rdar://problem/26162999>
Reviewed by Timothy Hatcher.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
Don't add duplicate issue tree elements.
(WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
Remove issues from the correct tree outline.
* UserInterface/Views/IssueTreeElement.css:
(.issue .icon):
(.issue.warning .icon):
(.issue.error .icon):
Match dashboard icons.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200573 => 200574)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:52:19 UTC (rev 200573)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-09 14:59:23 UTC (rev 200574)
@@ -1,5 +1,26 @@
2016-05-09 Matt Baker <mattba...@apple.com>
+ Web Inspector: Cleanup issue tree elements in the Debugger sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=157469
+ <rdar://problem/26162999>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WebInspector.DebuggerSidebarPanel):
+ (WebInspector.DebuggerSidebarPanel.prototype._addIssue):
+ Don't add duplicate issue tree elements.
+ (WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
+ Remove issues from the correct tree outline.
+
+ * UserInterface/Views/IssueTreeElement.css:
+ (.issue .icon):
+ (.issue.warning .icon):
+ (.issue.error .icon):
+ Match dashboard icons.
+
+2016-05-09 Matt Baker <mattba...@apple.com>
+
Web Inspector: Show in progress message in Timeline views that do not show data until the recording finishes
https://bugs.webkit.org/show_bug.cgi?id=156761
<rdar://problem/25970771>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200573 => 200574)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-09 14:52:19 UTC (rev 200573)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-09 14:59:23 UTC (rev 200574)
@@ -866,11 +866,15 @@
_addIssue(issueMessage)
{
+ let issueTreeElement = this._scriptsContentTreeOutline.findTreeElement(issueMessage);
+ if (issueTreeElement)
+ return issueTreeElement;
+
let parentTreeElement = this._addTreeElementForSourceCodeToTreeOutline(issueMessage.sourceCodeLocation.sourceCode, this._scriptsContentTreeOutline);
if (!parentTreeElement)
return null;
- var issueTreeElement = new WebInspector.IssueTreeElement(issueMessage);
+ issueTreeElement = new WebInspector.IssueTreeElement(issueMessage);
parentTreeElement.insertChild(issueTreeElement, insertionIndexForObjectInListSortedByFunction(issueTreeElement, parentTreeElement.children, this._compareDebuggerTreeElements));
if (parentTreeElement.children.length === 1)
@@ -892,8 +896,8 @@
_handleIssuesCleared(event)
{
- var currentTreeElement = this._contentTreeOutline.children[0];
- var issueTreeElements = [];
+ let currentTreeElement = this._scriptsContentTreeOutline.children[0];
+ let issueTreeElements = [];
while (currentTreeElement && !currentTreeElement.root) {
if (currentTreeElement instanceof WebInspector.IssueTreeElement)
@@ -901,8 +905,7 @@
currentTreeElement = currentTreeElement.traverseNextTreeElement(false, null, true);
}
- for (var issueTreeElement of issueTreeElements)
- issueTreeElement.parent.removeChild(issueTreeElement);
+ issueTreeElements.forEach((treeElement) => treeElement.parent.removeChild(treeElement));
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css (200573 => 200574)
--- trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css 2016-05-09 14:52:19 UTC (rev 200573)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.css 2016-05-09 14:59:23 UTC (rev 200574)
@@ -24,10 +24,13 @@
*/
.issue .icon {
- background-image: url(../Images/Warning.svg);
- content: '';
+ content: "";
}
+.issue.warning .icon {
+ background-image: url(../Images/IssuesEnabled.svg);
+}
+
.issue.error .icon {
- background-image: url(../Images/Error.svg);
+ background-image: url(../Images/ErrorsEnabled.svg);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
