Title: [213346] trunk/LayoutTests
- Revision
- 213346
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-02 20:27:42 -0800 (Thu, 02 Mar 2017)
Log Message
[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168343
<rdar://problem/30823389>
Patch by Antoine Quint <grao...@apple.com> on 2017-03-02
Reviewed by Simon Fraser.
Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.
* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
* platform/ios-simulator/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213345 => 213346)
--- trunk/LayoutTests/ChangeLog 2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/ChangeLog 2017-03-03 04:27:42 UTC (rev 213346)
@@ -1,3 +1,17 @@
+2017-03-02 Antoine Quint <grao...@apple.com>
+
+ [iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=168343
+ <rdar://problem/30823389>
+
+ Reviewed by Simon Fraser.
+
+ Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.
+
+ * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
+ * platform/ios-simulator/TestExpectations:
+
2017-03-02 Jiewen Tan <jiewen_...@apple.com>
WebCrypto API support for AES-GCM
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (213345 => 213346)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt 2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt 2017-03-03 04:27:42 UTC (rev 213346)
@@ -3,6 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
PASS window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded') is false
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html (213345 => 213346)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html 2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html 2017-03-03 04:27:42 UTC (rev 213346)
@@ -12,10 +12,12 @@
const media = document.querySelector("video");
media.addEventListener("play", event => {
- pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
- window.requestAnimationFrame(() => {
- shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
- finishJSTest();
+ shouldBecomeDifferent("window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width", "0", () => {
+ pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
+ window.requestAnimationFrame(() => {
+ shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
+ finishJSTest();
+ });
});
});
});
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (213345 => 213346)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-03 04:27:42 UTC (rev 213346)
@@ -2848,8 +2848,6 @@
media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html [ Skip ]
-webkit.org/b/168343 media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html [ Pass Timeout ]
-
webkit.org/b/168668 media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html [ Pass Failure ]
# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
