Title: [218848] trunk/Source/_javascript_Core
- Revision
- 218848
- Author
- sbar...@apple.com
- Date
- 2017-06-27 15:43:20 -0700 (Tue, 27 Jun 2017)
Log Message
Remove an inaccurate comment inside DFGClobberize.h
https://bugs.webkit.org/show_bug.cgi?id=163874
Reviewed by Filip Pizlo.
The comment said that Clobberize may or may not be sound if run prior to
doing type inference. This is not correct, though. Clobberize *must* be sound
prior do doing type inference since we use it inside the BytecodeParser, which
is the very first thing the DFG does.
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (218847 => 218848)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-27 22:39:21 UTC (rev 218847)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-27 22:43:20 UTC (rev 218848)
@@ -1,5 +1,20 @@
2017-06-27 Saam Barati <sbar...@apple.com>
+ Remove an inaccurate comment inside DFGClobberize.h
+ https://bugs.webkit.org/show_bug.cgi?id=163874
+
+ Reviewed by Filip Pizlo.
+
+ The comment said that Clobberize may or may not be sound if run prior to
+ doing type inference. This is not correct, though. Clobberize *must* be sound
+ prior do doing type inference since we use it inside the BytecodeParser, which
+ is the very first thing the DFG does.
+
+ * dfg/DFGClobberize.h:
+ (JSC::DFG::clobberize):
+
+2017-06-27 Saam Barati <sbar...@apple.com>
+
Function constructor needs to follow the spec and validate parameters and body independently
https://bugs.webkit.org/show_bug.cgi?id=173303
<rdar://problem/32732526>
Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (218847 => 218848)
--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2017-06-27 22:39:21 UTC (rev 218847)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2017-06-27 22:43:20 UTC (rev 218848)
@@ -74,10 +74,9 @@
// - Broadly, we don't say that we're reading something if that something is
// immutable.
//
- // - We try to make this work even prior to type inference, just so that we
- // can use it for IR dumps. No promises on whether the answers are sound
- // prior to type inference - though they probably could be if we did some
- // small hacking.
+ // - This must be sound even prior to type inference. We use this as early as
+ // bytecode parsing to determine at which points in the program it's legal to
+ // OSR exit.
//
// - If you do read(Stack) or read(World), then make sure that readTop() in
// PreciseLocalClobberize is correct.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
