Title: [226207] trunk/LayoutTests
- Revision
- 226207
- Author
- jlew...@apple.com
- Date
- 2017-12-20 17:49:00 -0800 (Wed, 20 Dec 2017)
Log Message
Unreviewed, rolling out r226155.
This caused test failures.
Reverted changeset:
"Web Inspector: add TestPage.debug() to inspect evaluations
being sent to Inspector page"
https://bugs.webkit.org/show_bug.cgi?id=181005
https://trac.webkit.org/changeset/226155
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (226206 => 226207)
--- trunk/LayoutTests/ChangeLog 2017-12-21 01:39:08 UTC (rev 226206)
+++ trunk/LayoutTests/ChangeLog 2017-12-21 01:49:00 UTC (rev 226207)
@@ -1,3 +1,16 @@
+2017-12-20 Matt Lewis <jlew...@apple.com>
+
+ Unreviewed, rolling out r226155.
+
+ This caused test failures.
+
+ Reverted changeset:
+
+ "Web Inspector: add TestPage.debug() to inspect evaluations
+ being sent to Inspector page"
+ https://bugs.webkit.org/show_bug.cgi?id=181005
+ https://trac.webkit.org/changeset/226155
+
2017-12-20 Brady Eidson <beid...@apple.com>
Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.
Modified: trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js (226206 => 226207)
--- trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js 2017-12-21 01:39:08 UTC (rev 226206)
+++ trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js 2017-12-21 01:49:00 UTC (rev 226207)
@@ -97,8 +97,8 @@
let initializationCodeString = `(${runInitializationMethodsInFrontend.toString()})([${TestPage._initializers}]);`;
let testFunctionCodeString = `(${runTestMethodInFrontend.toString()})(${testFunction.toString()});`;
- TestPage.evaluateInWebInspector(initializationCodeString);
- TestPage.evaluateInWebInspector(testFunctionCodeString);
+ testRunner.evaluateInWebInspector(initializationCodeString);
+ testRunner.evaluateInWebInspector(testFunctionCodeString);
}
function runTestHTTPS()
@@ -139,20 +139,6 @@
window.alert(message);
}
-// Use this to dump evaluations that are sent from the TestPage to the InspectorTest page.
-TestPage.debug = function()
-{
- this.dumpInspectorPageEvaluations = true;
-}
-
-TestPage.evaluateInWebInspector = function(code)
-{
- if (this.dumpInspectorPageEvaluations)
- this.debugLog(code);
-
- testRunner.evaluateInWebInspector(code);
-}
-
// Add and clear test output from the results window.
TestPage.addResult = function(text)
{
@@ -176,7 +162,7 @@
TestPage.dispatchEventToFrontend = function(eventName, data)
{
let dispatchEventCodeString = `InspectorTest.dispatchEventToListeners(${JSON.stringify(eventName)}, ${JSON.stringify(data)});`;
- this.evaluateInWebInspector(dispatchEventCodeString);
+ testRunner.evaluateInWebInspector(dispatchEventCodeString);
};
TestPage.allowUncaughtExceptions = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
