Title: [230406] releases/WebKitGTK/webkit-2.20
Revision
230406
Author
carlo...@webkit.org
Date
2018-04-09 05:13:57 -0700 (Mon, 09 Apr 2018)

Log Message

Merge r229499 - AX: AOM: More accessibility events support
https://bugs.webkit.org/show_bug.cgi?id=183023
<rdar://problem/37764380>

Reviewed by Chris Fleizach.

Source/WebCore:

The test is crashing when we call updateBackingStore when
the AXObjectCache object is gone. Added a check to fix that.

Modified the test by using the right format of setTimeout and extended the delay.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):

LayoutTests:

* accessibility/mac/AOM-events-webarea-crash.html:

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog (230405 => 230406)


--- releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog	2018-04-09 12:13:51 UTC (rev 230405)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog	2018-04-09 12:13:57 UTC (rev 230406)
@@ -1,3 +1,13 @@
+2018-03-09  Nan Wang  <n_w...@apple.com>
+
+        AX: AOM: More accessibility events support
+        https://bugs.webkit.org/show_bug.cgi?id=183023
+        <rdar://problem/37764380>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/mac/AOM-events-webarea-crash.html:
+
 2018-03-07  Zalan Bujtas  <za...@apple.com>
 
         Invalid innerTextRenderer in RenderTextControlSingleLine::styleDidChange()

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog (230405 => 230406)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-04-09 12:13:51 UTC (rev 230405)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-04-09 12:13:57 UTC (rev 230406)
@@ -1,3 +1,19 @@
+2018-03-09  Nan Wang  <n_w...@apple.com>
+
+        AX: AOM: More accessibility events support
+        https://bugs.webkit.org/show_bug.cgi?id=183023
+        <rdar://problem/37764380>
+
+        Reviewed by Chris Fleizach.
+
+        The test is crashing when we call updateBackingStore when 
+        the AXObjectCache object is gone. Added a check to fix that.
+
+        Modified the test by using the right format of setTimeout and extended the delay.
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::updateBackingStore):
+
 2018-03-12  Danyao Wang  <dan...@chromium.org>
 
         Add a query and fragment exception to history API's unique origin restriction.

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/accessibility/AccessibilityObject.cpp (230405 => 230406)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/accessibility/AccessibilityObject.cpp	2018-04-09 12:13:51 UTC (rev 230405)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/accessibility/AccessibilityObject.cpp	2018-04-09 12:13:57 UTC (rev 230406)
@@ -1765,6 +1765,9 @@
 #if HAVE(ACCESSIBILITY)
 void AccessibilityObject::updateBackingStore()
 {
+    if (!axObjectCache())
+        return;
+    
     // Updating the layout may delete this object.
     RefPtr<AccessibilityObject> protectedThis(this);
     if (auto* document = this->document()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to