Title: [236513] trunk/Source/WebKit
- Revision
- 236513
- Author
- cdu...@apple.com
- Date
- 2018-09-26 11:45:23 -0700 (Wed, 26 Sep 2018)
Log Message
Unreviewed, apply post-landing review comments after r236512.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateSubframe):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236512 => 236513)
--- trunk/Source/WebKit/ChangeLog 2018-09-26 18:38:26 UTC (rev 236512)
+++ trunk/Source/WebKit/ChangeLog 2018-09-26 18:45:23 UTC (rev 236513)
@@ -1,5 +1,13 @@
2018-09-26 Chris Dumez <cdu...@apple.com>
+ Unreviewed, apply post-landing review comments after r236512.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::didCreateMainFrame):
+ (WebKit::WebPageProxy::didCreateSubframe):
+
+2018-09-26 Chris Dumez <cdu...@apple.com>
+
UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it
https://bugs.webkit.org/show_bug.cgi?id=189927
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236512 => 236513)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-26 18:38:26 UTC (rev 236512)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-26 18:45:23 UTC (rev 236513)
@@ -3357,6 +3357,9 @@
void WebPageProxy::didCreateMainFrame(uint64_t frameID)
{
+ // The DecidePolicyForNavigationActionSync IPC is synchronous and may therefore get processed before the DidCreateMainFrame one.
+ // When this happens, decidePolicyForNavigationActionSync() calls didCreateMainFrame() and we need to ignore the DidCreateMainFrame
+ // IPC when it later gets processed.
if (m_mainFrame && m_mainFrame->frameID() == frameID)
return;
@@ -3383,6 +3386,9 @@
MESSAGE_CHECK(m_mainFrame);
+ // The DecidePolicyForNavigationActionSync IPC is synchronous and may therefore get processed before the DidCreateSubframe one.
+ // When this happens, decidePolicyForNavigationActionSync() calls didCreateSubframe() and we need to ignore the DidCreateSubframe
+ // IPC when it later gets processed.
if (m_process->webFrame(frameID))
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
