Title: [236533] trunk
- Revision
- 236533
- Author
- achristen...@apple.com
- Date
- 2018-09-26 16:35:14 -0700 (Wed, 26 Sep 2018)
Log Message
Unreviewed, rolling out r236524.
Broke API tests
Reverted changeset:
"URLWithUserTypedString should return nil for URLs deemed to
be invalid by WebCore::URL"
https://bugs.webkit.org/show_bug.cgi?id=189979
https://trac.webkit.org/changeset/236524
Modified Paths
Property Changed
Diff
Modified: trunk/LayoutTests/ChangeLog (236532 => 236533)
--- trunk/LayoutTests/ChangeLog 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/LayoutTests/ChangeLog 2018-09-26 23:35:14 UTC (rev 236533)
@@ -1,3 +1,16 @@
+2018-09-26 Alex Christensen <achristen...@webkit.org>
+
+ Unreviewed, rolling out r236524.
+
+ Broke API tests
+
+ Reverted changeset:
+
+ "URLWithUserTypedString should return nil for URLs deemed to
+ be invalid by WebCore::URL"
+ https://bugs.webkit.org/show_bug.cgi?id=189979
+ https://trac.webkit.org/changeset/236524
+
2018-09-26 Per Arne Vollan <pvol...@apple.com>
WebVTT cue alignment broken
Index: trunk/LayoutTests/http/tests/media/video-play-stall.html
===================================================================
--- trunk/LayoutTests/http/tests/media/video-play-stall.html 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/LayoutTests/http/tests/media/video-play-stall.html 2018-09-26 23:35:14 UTC (rev 236533)
Property changes: trunk/LayoutTests/http/tests/media/video-play-stall.html
Deleted: svn:mergeinfo
-/trunk/LayoutTests/http/tests/media/video-play-stall.html:53455
\ No newline at end of property
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236532 => 236533)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-26 23:35:14 UTC (rev 236533)
@@ -1,3 +1,16 @@
+2018-09-26 Alex Christensen <achristen...@webkit.org>
+
+ Unreviewed, rolling out r236524.
+
+ Broke API tests
+
+ Reverted changeset:
+
+ "URLWithUserTypedString should return nil for URLs deemed to
+ be invalid by WebCore::URL"
+ https://bugs.webkit.org/show_bug.cgi?id=189979
+ https://trac.webkit.org/changeset/236524
+
2018-09-26 Chris Dumez <cdu...@apple.com>
Ignore-opens-during-unload counter of a parent should apply to its children during beforeunload event
Index: trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html
===================================================================
--- trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html 2018-09-26 23:35:14 UTC (rev 236533)
Property changes: trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html
Deleted: svn:mergeinfo
-/trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html:53455
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (236532 => 236533)
--- trunk/Source/WebCore/ChangeLog 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/Source/WebCore/ChangeLog 2018-09-26 23:35:14 UTC (rev 236533)
@@ -1,3 +1,16 @@
+2018-09-26 Alex Christensen <achristen...@webkit.org>
+
+ Unreviewed, rolling out r236524.
+
+ Broke API tests
+
+ Reverted changeset:
+
+ "URLWithUserTypedString should return nil for URLs deemed to
+ be invalid by WebCore::URL"
+ https://bugs.webkit.org/show_bug.cgi?id=189979
+ https://trac.webkit.org/changeset/236524
+
2018-09-26 Per Arne Vollan <pvol...@apple.com>
WebVTT cue alignment broken
Modified: trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm (236532 => 236533)
--- trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-09-26 23:35:14 UTC (rev 236533)
@@ -853,9 +853,6 @@
} else
result = [NSURL URLWithString:@""];
- if (!WebCore::URL(result).isValid())
- return nil;
-
return result;
}
static NSData *dataWithUserTypedString(NSString *string)
Modified: trunk/Tools/ChangeLog (236532 => 236533)
--- trunk/Tools/ChangeLog 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/Tools/ChangeLog 2018-09-26 23:35:14 UTC (rev 236533)
@@ -1,3 +1,16 @@
+2018-09-26 Alex Christensen <achristen...@webkit.org>
+
+ Unreviewed, rolling out r236524.
+
+ Broke API tests
+
+ Reverted changeset:
+
+ "URLWithUserTypedString should return nil for URLs deemed to
+ be invalid by WebCore::URL"
+ https://bugs.webkit.org/show_bug.cgi?id=189979
+ https://trac.webkit.org/changeset/236524
+
2018-09-26 James Savage <james.sav...@apple.com>
Allow override of viewport configuration.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm (236532 => 236533)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm 2018-09-26 23:23:53 UTC (rev 236532)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm 2018-09-26 23:35:14 UTC (rev 236533)
@@ -192,8 +192,6 @@
NSString *encodedHostName = WebCore::encodeHostName(@"http://.com");
EXPECT_TRUE(encodedHostName == nil);
-
- EXPECT_TRUE(WebCore::URLWithUserTypedString(@"https://a@/b", nil) == nil);
}
TEST(WebCore, URLExtras_Nil)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
