Title: [240164] releases/WebKitGTK/webkit-2.22
- Revision
- 240164
- Author
- mcatanz...@igalia.com
- Date
- 2019-01-18 12:28:42 -0800 (Fri, 18 Jan 2019)
Log Message
Merge r240158 - FetchResponse::url should return the empty string for tainted responses
https://bugs.webkit.org/show_bug.cgi?id=193553
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
(fetchNoCors):
Source/WebCore:
Check whether the response is tainted in FetchResponse::url, to match
the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::url const):
LayoutTests:
* http/wpt/fetch/response-opaque-clone.html:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (240163 => 240164)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,12 @@
+2019-01-18 Ali Juma <aj...@chromium.org>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ * http/wpt/fetch/response-opaque-clone.html:
+
2019-01-04 Brent Fulgham <bfulg...@apple.com>
Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox
Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html (240163 => 240164)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/http/wpt/fetch/response-opaque-clone.html 2019-01-18 20:28:42 UTC (rev 240164)
@@ -16,6 +16,7 @@
assert_equals(response.type, "opaque", testName + " type");
assert_equals(response.status, 0, testName + " status");
assert_equals(response.statusText, "", testName + " statusText");
+ assert_equals(response.url, "", testName + " url");
assert_false(response.redirected, testName + " redirected");
assert_true(response.headers.values().next().done, testName + " headers");
assert_equals(response.body, null, testName + " opaque response body should be null");
Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog (240163 => 240164)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog 2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/imported/w3c/ChangeLog 2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,13 @@
+2019-01-18 Ali Juma <aj...@chromium.org>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ * web-platform-tests/fetch/api/basic/mode-no-cors.sub.any.js:
+ (fetchNoCors):
+
2018-09-15 Rob Buis <rb...@igalia.com>
XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (240163 => 240164)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2019-01-18 20:28:42 UTC (rev 240164)
@@ -1,3 +1,16 @@
+2019-01-18 Ali Juma <aj...@chromium.org>
+
+ FetchResponse::url should return the empty string for tainted responses
+ https://bugs.webkit.org/show_bug.cgi?id=193553
+
+ Reviewed by Youenn Fablet.
+
+ Check whether the response is tainted in FetchResponse::url, to match
+ the behavior described in https://fetch.spec.whatwg.org/#concept-filtered-response-opaque.
+
+ * Modules/fetch/FetchResponse.cpp:
+ (WebCore::FetchResponse::url const):
+
2019-01-04 Brent Fulgham <bfulg...@apple.com>
Parsed protocol of _javascript_ URLs with embedded newlines and carriage returns do not match parsed protocol in Chrome and Firefox
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp (240163 => 240164)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp 2019-01-18 20:12:38 UTC (rev 240163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/fetch/FetchResponse.cpp 2019-01-18 20:28:42 UTC (rev 240164)
@@ -205,7 +205,7 @@
const String& FetchResponse::url() const
{
if (m_responseURL.isNull()) {
- URL url = ""
+ URL url = ""
url.removeFragmentIdentifier();
m_responseURL = url.string();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
