Title: [240173] trunk/Source/WebInspectorUI
- Revision
- 240173
- Author
- drou...@apple.com
- Date
- 2019-01-18 14:21:02 -0800 (Fri, 18 Jan 2019)
Log Message
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'resource.finished')
https://bugs.webkit.org/show_bug.cgi?id=193589
Reviewed by Joseph Pecoraro.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.get supportsSave):
(WI.NetworkTableContentView.prototype._HARResources):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240172 => 240173)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-18 21:33:34 UTC (rev 240172)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-18 22:21:02 UTC (rev 240173)
@@ -1,3 +1,14 @@
+2019-01-18 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'resource.finished')
+ https://bugs.webkit.org/show_bug.cgi?id=193589
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype.get supportsSave):
+ (WI.NetworkTableContentView.prototype._HARResources):
+
2019-01-17 Truitt Savell <tsav...@apple.com>
Unreviewed, rolling out r240124.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (240172 => 240173)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-18 21:33:34 UTC (rev 240172)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-18 22:21:02 UTC (rev 240173)
@@ -224,7 +224,7 @@
get supportsSave()
{
- return this._filteredEntries.some((entry) => entry.resource.finished);
+ return this._canExportHAR();
}
get saveData()
@@ -1890,6 +1890,11 @@
let resources = this._filteredEntries.map((x) => x.resource);
const supportedHARSchemes = new Set(["http", "https", "ws", "wss"]);
return resources.filter((resource) => {
+ if (!resource) {
+ // DOM node entries are also added to `_filteredEntries`.
+ return false;
+ }
+
if (!resource.finished)
return false;
if (!resource.requestSentDate)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
