Title: [240187] trunk/Tools
- Revision
- 240187
- Author
- aakash_j...@apple.com
- Date
- 2019-01-18 16:10:19 -0800 (Fri, 18 Jan 2019)
Log Message
[build.webkit.org] api tests failures are incorrectly named as unit test failures
https://bugs.webkit.org/show_bug.cgi?id=193595
Reviewed by Lucas Forschler.
* BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
* BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py (240186 => 240187)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py 2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py 2019-01-19 00:10:19 UTC (rev 240187)
@@ -90,7 +90,7 @@
self.addStep(self.LayoutTestClass())
if platform.startswith('win') or platform.startswith('mac') or platform.startswith('ios-simulator'):
- self.addStep(RunUnitTests())
+ self.addStep(RunAPITests())
self.addStep(RunPythonTests())
self.addStep(RunPerlTests())
self.addStep(RunBindingsTests())
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (240186 => 240187)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-01-19 00:10:19 UTC (rev 240187)
@@ -503,12 +503,12 @@
return RunWebKitTests.start(self)
-class RunUnitTests(TestWithFailureCount):
+class RunAPITests(TestWithFailureCount):
name = "run-api-tests"
- description = ["unit tests running"]
- descriptionDone = ["unit-tests"]
+ description = ["api tests running"]
+ descriptionDone = ["api-tests"]
command = ["python", "./Tools/Scripts/run-api-tests", "--no-build", WithProperties("--%(configuration)s"), "--verbose"]
- failedTestsFormatString = "%d unit test%s failed or timed out"
+ failedTestsFormatString = "%d api test%s failed or timed out"
def start(self):
appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (240186 => 240187)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py 2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py 2019-01-19 00:10:19 UTC (rev 240187)
@@ -260,13 +260,13 @@
self.assertResults(SUCCESS, ['webkit-32bit-jsc-test'], 0, ' 0 failures found.')
-class RunUnitTestsTest(unittest.TestCase):
+class RunAPITestsTest(unittest.TestCase):
def assertFailures(self, expected_failure_count, stdio):
if expected_failure_count:
rc = 1
expected_results = FAILURE
plural_suffix = "" if expected_failure_count == 1 else "s"
- expected_text = '%d unit test%s failed or timed out' % (expected_failure_count, plural_suffix)
+ expected_text = '%d api test%s failed or timed out' % (expected_failure_count, plural_suffix)
else:
rc = 0
expected_results = SUCCESS
@@ -273,7 +273,7 @@
expected_text = 'run-api-tests'
cmd = StubRemoteCommand(rc, stdio)
- step = RunUnitTests()
+ step = RunAPITests()
step.commandComplete(cmd)
actual_results = step.evaluateCommand(cmd)
actual_failure_count = step.failedTestCount
Modified: trunk/Tools/ChangeLog (240186 => 240187)
--- trunk/Tools/ChangeLog 2019-01-19 00:08:21 UTC (rev 240186)
+++ trunk/Tools/ChangeLog 2019-01-19 00:10:19 UTC (rev 240187)
@@ -1,3 +1,14 @@
+2019-01-18 Aakash Jain <aakash_j...@apple.com>
+
+ [build.webkit.org] api tests failures are incorrectly named as unit test failures
+ https://bugs.webkit.org/show_bug.cgi?id=193595
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
+ * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
+
2019-01-18 Chris Dumez <cdu...@apple.com>
Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
