Title: [247374] trunk/LayoutTests
- Revision
- 247374
- Author
- cdu...@apple.com
- Date
- 2019-07-11 16:47:06 -0700 (Thu, 11 Jul 2019)
Log Message
[iOS] fast/events/ios/rotation/orientationchange-event-listener-on.body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=199732
<rdar://problem/52693087>
Reviewed by Alex Christensen.
Stop logging in each event listener to not be reliant on the order in which listener are called.
Instead, simply make sure all event listeners that should be called were actually called.
* fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt:
* fast/events/ios/rotation/orientationchange-event-listener-on.body.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (247373 => 247374)
--- trunk/LayoutTests/ChangeLog 2019-07-11 23:30:02 UTC (rev 247373)
+++ trunk/LayoutTests/ChangeLog 2019-07-11 23:47:06 UTC (rev 247374)
@@ -1,3 +1,17 @@
+2019-07-11 Chris Dumez <cdu...@apple.com>
+
+ [iOS] fast/events/ios/rotation/orientationchange-event-listener-on.body.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=199732
+ <rdar://problem/52693087>
+
+ Reviewed by Alex Christensen.
+
+ Stop logging in each event listener to not be reliant on the order in which listener are called.
+ Instead, simply make sure all event listeners that should be called were actually called.
+
+ * fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt:
+ * fast/events/ios/rotation/orientationchange-event-listener-on.body.html:
+
2019-07-11 Ryosuke Niwa <rn...@webkit.org>
Make the test added in r247327 more reliable.
Modified: trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt (247373 => 247374)
--- trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt 2019-07-11 23:30:02 UTC (rev 247373)
+++ trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt 2019-07-11 23:47:06 UTC (rev 247374)
@@ -4,11 +4,8 @@
Before rotation
-PASS In body's onorientationchange event handler
-PASS In window's orientationchange event listener
-PASS In body's onresize event handler
-PASS In window's resize event listener
After rotation
+PASS eventListenerCalls is 4
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body.html (247373 => 247374)
--- trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body.html 2019-07-11 23:30:02 UTC (rev 247373)
+++ trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body.html 2019-07-11 23:47:06 UTC (rev 247374)
@@ -30,34 +30,38 @@
testRunner.runUIScript(getRotationUIScript(), function(result) {
debug('After rotation');
-
+ shouldBe("eventListenerCalls", "4");
finishJSTest();
});
}
+
+ eventListenerCalls = 0;
window.addEventListener('resize', function() {
- testPassed("In window's resize event listener");
+ ++eventListenerCalls;
}, false);
window.addEventListener('orientationchange', function() {
- testPassed("In window's orientationchange event listener");
+ ++eventListenerCalls;
}, false);
document.body.addEventListener('resize', function() {
testFailed("In body's resize event listener");
+ ++eventListenerCalls;
}, false);
document.body.addEventListener('orientationchange', function() {
testFailed("In body's orientationchange event listener");
+ ++eventListenerCalls;
}, false);
function bodyOrientationChange()
{
- testPassed("In body's onorientationchange event handler");
+ ++eventListenerCalls;
}
function bodyResize()
{
- testPassed("In body's onresize event handler");
+ ++eventListenerCalls;
}
window.addEventListener('load', doTest, false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
