Title: [254658] trunk/Source/WebKit
Revision
254658
Author
ross.kirsl...@sony.com
Date
2020-01-15 17:43:26 -0800 (Wed, 15 Jan 2020)

Log Message

[PlayStation] Add stub for WebPopupMenu::setUpPlatformData
https://bugs.webkit.org/show_bug.cgi?id=206323

Reviewed by Don Olmstead.

* SourcesGTK.txt:
* SourcesWPE.txt:
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Removed.
* WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Removed.
Bring GTK/WPE stub down for broader use.

Modified Paths

Removed Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254657 => 254658)


--- trunk/Source/WebKit/ChangeLog	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/ChangeLog	2020-01-16 01:43:26 UTC (rev 254658)
@@ -1,5 +1,20 @@
 2020-01-15  Ross Kirsling  <ross.kirsl...@sony.com>
 
+        [PlayStation] Add stub for WebPopupMenu::setUpPlatformData
+        https://bugs.webkit.org/show_bug.cgi?id=206323
+
+        Reviewed by Don Olmstead.
+
+        * SourcesGTK.txt:
+        * SourcesWPE.txt:
+        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
+        (WebKit::WebPopupMenu::setUpPlatformData):
+        * WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Removed.
+        * WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Removed.
+        Bring GTK/WPE stub down for broader use.
+
+2020-01-15  Ross Kirsling  <ross.kirsl...@sony.com>
+
         [PlayStation] Add stubs for WebEditorClient
         https://bugs.webkit.org/show_bug.cgi?id=206320
 

Modified: trunk/Source/WebKit/SourcesGTK.txt (254657 => 254658)


--- trunk/Source/WebKit/SourcesGTK.txt	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/SourcesGTK.txt	2020-01-16 01:43:26 UTC (rev 254658)
@@ -404,7 +404,6 @@
 WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp
 WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp
 WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp
-WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp
 
 WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
 

Modified: trunk/Source/WebKit/SourcesWPE.txt (254657 => 254658)


--- trunk/Source/WebKit/SourcesWPE.txt	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/SourcesWPE.txt	2020-01-16 01:43:26 UTC (rev 254658)
@@ -243,7 +243,6 @@
 
 WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp
 WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
-WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp
 
 WebProcess/WebPage/AcceleratedSurface.cpp
 

Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp (254657 => 254658)


--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp	2020-01-16 01:43:26 UTC (rev 254658)
@@ -28,6 +28,7 @@
 #include "WebPageProxyMessages.h"
 #include "WebProcess.h"
 #include <WebCore/FrameView.h>
+#include <WebCore/NotImplemented.h>
 #include <WebCore/PopupMenuClient.h>
 
 namespace WebKit {
@@ -136,4 +137,11 @@
 {
 }
 
+#if !PLATFORM(COCOA) && !PLATFORM(WIN)
+void WebPopupMenu::setUpPlatformData(const WebCore::IntRect&, PlatformPopupMenuData&)
+{
+    notImplemented();
+}
+#endif
+
 } // namespace WebKit

Deleted: trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp (254657 => 254658)


--- trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp	2020-01-16 01:43:26 UTC (rev 254658)
@@ -1,41 +0,0 @@
-/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
- * Portions Copyright (c) 2010 Motorola Mobility, Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "WebPopupMenu.h"
-
-#include "PlatformPopupMenuData.h"
-#include <WebCore/NotImplemented.h>
-
-namespace WebKit {
-using namespace WebCore;
-
-void WebPopupMenu::setUpPlatformData(const IntRect&, PlatformPopupMenuData&)
-{
-    notImplemented();
-}
-
-} // namespace WebKit

Deleted: trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp (254657 => 254658)


--- trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp	2020-01-16 01:40:16 UTC (rev 254657)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp	2020-01-16 01:43:26 UTC (rev 254658)
@@ -1,38 +0,0 @@
-/*
- * Copyright (C) 2014 Igalia S.L.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "WebPopupMenu.h"
-
-#include <WebCore/NotImplemented.h>
-
-namespace WebKit {
-
-void WebPopupMenu::setUpPlatformData(const WebCore::IntRect&, PlatformPopupMenuData&)
-{
-    notImplemented();
-}
-
-} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to