Title: [257008] trunk/Source/WebKit
Revision
257008
Author
commit-qu...@webkit.org
Date
2020-02-19 17:12:26 -0800 (Wed, 19 Feb 2020)

Log Message

Avoid preconnecting to custom URL schemes
https://bugs.webkit.org/show_bug.cgi?id=207964

Patch by Ben Nham <n...@apple.com> on 2020-02-19
Reviewed by Ryosuke Niwa.

This makes NetworkProcess::preconnectTo not preconnect to custom URL schemes. This matches
the existing behavior in NetworkConnectionToWebProcess::preconnectTo.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (257007 => 257008)


--- trunk/Source/WebKit/ChangeLog	2020-02-20 01:12:26 UTC (rev 257007)
+++ trunk/Source/WebKit/ChangeLog	2020-02-20 01:12:26 UTC (rev 257008)
@@ -1,3 +1,16 @@
+2020-02-19  Ben Nham  <n...@apple.com>
+
+        Avoid preconnecting to custom URL schemes
+        https://bugs.webkit.org/show_bug.cgi?id=207964
+
+        Reviewed by Ryosuke Niwa.
+
+        This makes NetworkProcess::preconnectTo not preconnect to custom URL schemes. This matches
+        the existing behavior in NetworkConnectionToWebProcess::preconnectTo.
+
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::preconnectTo):
+
 2020-02-19  Chris Dumez  <cdu...@apple.com>
 
         Regression(r247567) HTTP Disk cache capacity is no longer set

Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (257007 => 257008)


--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-20 01:12:26 UTC (rev 257007)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-20 01:12:26 UTC (rev 257008)
@@ -1304,6 +1304,11 @@
 void NetworkProcess::preconnectTo(PAL::SessionID sessionID, const URL& url, const String& userAgent, WebCore::StoredCredentialsPolicy storedCredentialsPolicy)
 {
 #if ENABLE(SERVER_PRECONNECT)
+#if ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)
+    if (supplement<LegacyCustomProtocolManager>()->supportsScheme(url.protocol().toString()))
+        return;
+#endif
+
     NetworkLoadParameters parameters;
     parameters.request = ResourceRequest { url };
     if (!userAgent.isEmpty()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to