Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (257043 => 257044)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 06:24:43 UTC (rev 257044)
@@ -1,3 +1,16 @@
+2020-02-19 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r257029.
+ https://bugs.webkit.org/show_bug.cgi?id=207996
+
+ Doesn't fix the issue (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "[iOS] Rename NSUserDefaultsSPI.h"
+ https://bugs.webkit.org/show_bug.cgi?id=207977
+ https://trac.webkit.org/changeset/257029
+
2020-02-19 Per Arne Vollan <pvol...@apple.com>
[iOS] Rename NSUserDefaultsSPI.h
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (257043 => 257044)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 06:24:43 UTC (rev 257044)
@@ -164,7 +164,7 @@
A3AB6E651F3D217F009C14B1 /* SystemSleepListenerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */; };
A3C66CDC1F462D6A009E6EE9 /* SessionID.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */; };
A3C66CDD1F462D6A009E6EE9 /* SessionID.h in Headers */ = {isa = PBXBuildFile; fileRef = A3C66CDB1F462D6A009E6EE9 /* SessionID.h */; };
- C15CBB3523F3548A00300CC7 /* UserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ C15CBB3523F3548A00300CC7 /* NSUserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDACB3602387425B0018D7CE /* MediaToolboxSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */; };
CDACB361238742740018D7CE /* MediaToolboxSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */; };
CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CDF91112220E4EEC001EA39E /* CelestialSPI.h */; };
@@ -341,7 +341,7 @@
A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SystemSleepListenerMac.mm; sourceTree = "<group>"; };
A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SessionID.cpp; sourceTree = "<group>"; };
A3C66CDB1F462D6A009E6EE9 /* SessionID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SessionID.h; sourceTree = "<group>"; };
- C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UserDefaultsSPI.h; sourceTree = "<group>"; };
+ C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSUserDefaultsSPI.h; sourceTree = "<group>"; };
C2147A4A1EFD0AA600056FA5 /* CopyPALHeaders.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = CopyPALHeaders.xcconfig; sourceTree = "<group>"; };
CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = MediaToolboxSoftLink.cpp; sourceTree = "<group>"; };
CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MediaToolboxSoftLink.h; sourceTree = "<group>"; };
@@ -445,6 +445,7 @@
0C2DA1361F3BEB4900DBC317 /* NSURLConnectionSPI.h */,
0C2DA1371F3BEB4900DBC317 /* NSURLDownloadSPI.h */,
0C2DA1381F3BEB4900DBC317 /* NSURLFileTypeMappingsSPI.h */,
+ C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */,
570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */,
EB707FA4239737F80059053A /* OSVariantSPI.h */,
0C2DA1391F3BEB4900DBC317 /* PassKitSPI.h */,
@@ -454,7 +455,6 @@
570AB8F020AE2E8D00B8BE87 /* SecKeyProxySPI.h */,
0C2DA13C1F3BEB4900DBC317 /* ServersSPI.h */,
0C2DA12B1F3BEB4900DBC317 /* URLFormattingSPI.h */,
- C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */,
0C2DA13D1F3BEB4900DBC317 /* WebFilterEvaluatorSPI.h */,
);
path = cocoa;
@@ -806,6 +806,7 @@
0C2DA1521F3BEB4900DBC317 /* NSURLConnectionSPI.h in Headers */,
0C2DA1531F3BEB4900DBC317 /* NSURLDownloadSPI.h in Headers */,
0C2DA1541F3BEB4900DBC317 /* NSURLFileTypeMappingsSPI.h in Headers */,
+ C15CBB3523F3548A00300CC7 /* NSUserDefaultsSPI.h in Headers */,
0C77859C1F45130F00F4EBB6 /* NSViewSPI.h in Headers */,
0C77859D1F45130F00F4EBB6 /* NSWindowSPI.h in Headers */,
570AB8F920AF6E3D00B8BE87 /* NSXPCConnectionSPI.h in Headers */,
@@ -837,7 +838,6 @@
2E1342CC215AA10A007199D2 /* UIKitSoftLink.h in Headers */,
0C5AF9221F43A4C7002EAC02 /* UIKitSPI.h in Headers */,
0C2DA1471F3BEB4900DBC317 /* URLFormattingSPI.h in Headers */,
- C15CBB3523F3548A00300CC7 /* UserDefaultsSPI.h in Headers */,
0C2DA1591F3BEB4900DBC317 /* WebFilterEvaluatorSPI.h in Headers */,
A10826F91F576292004772AC /* WebPanel.h in Headers */,
);
Copied: trunk/Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h (from rev 257043, trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h) (0 => 257044)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h (rev 0)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h 2020-02-20 06:24:43 UTC (rev 257044)
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+@interface NSObject (PrivateKVOMethods)
+- (void)_notifyObserversOfChangeFromValuesForKeys:(NSDictionary<NSString *, id> *)oldValues toValuesForKeys:(NSDictionary<NSString *, id> *)newValues;
+@end
Deleted: trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h (257043 => 257044)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h 2020-02-20 06:24:43 UTC (rev 257044)
@@ -1,30 +0,0 @@
-/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-@interface NSObject (PrivateKVOMethods)
-- (void)_notifyObserversOfChangeFromValuesForKeys:(NSDictionary<NSString *, id> *)oldValues toValuesForKeys:(NSDictionary<NSString *, id> *)newValues;
-@end
Modified: trunk/Source/WebKit/ChangeLog (257043 => 257044)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 06:24:43 UTC (rev 257044)
@@ -1,3 +1,16 @@
+2020-02-19 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r257029.
+ https://bugs.webkit.org/show_bug.cgi?id=207996
+
+ Doesn't fix the issue (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "[iOS] Rename NSUserDefaultsSPI.h"
+ https://bugs.webkit.org/show_bug.cgi?id=207977
+ https://trac.webkit.org/changeset/257029
+
2020-02-19 Brian Burg <bb...@apple.com>
Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
Modified: trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.h (257043 => 257044)
--- trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.h 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.h 2020-02-20 06:24:43 UTC (rev 257044)
@@ -25,7 +25,7 @@
#pragma once
-#import <pal/spi/cocoa/UserDefaultsSPI.h>
+#import <pal/spi/cocoa/NSUserDefaultsSPI.h>
#import <wtf/Vector.h>
#import <wtf/text/WTFString.h>