Title: [279493] trunk/Source/WebInspectorUI
- Revision
- 279493
- Author
- pan...@apple.com
- Date
- 2021-07-01 18:36:04 -0700 (Thu, 01 Jul 2021)
Log Message
Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
https://bugs.webkit.org/show_bug.cgi?id=227597
Reviewed by Devin Rousso.
As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
(`resources-container`) was sized to the full height of the container, leaving no space for the other sections
to be shown. Removing the `height: 100%;` declaration resolves this by allowing the flex container to lay out
its children as needed. Because the resources container has no maximum height constraint, it still occupies the
remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
just as they did before r279271.
* UserInterface/Views/SourcesNavigationSidebarPanel.css:
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (279492 => 279493)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-07-02 01:08:44 UTC (rev 279492)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-07-02 01:36:04 UTC (rev 279493)
@@ -1,3 +1,20 @@
+2021-07-01 Patrick Angle <pan...@apple.com>
+
+ Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
+ https://bugs.webkit.org/show_bug.cgi?id=227597
+
+ Reviewed by Devin Rousso.
+
+ As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
+ (`resources-container`) was sized to the full height of the container, leaving no space for the other sections
+ to be shown. Removing the `height: 100%;` declaration resolves this by allowing the flex container to lay out
+ its children as needed. Because the resources container has no maximum height constraint, it still occupies the
+ remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
+ just as they did before r279271.
+
+ * UserInterface/Views/SourcesNavigationSidebarPanel.css:
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):
+
2021-06-30 Patrick Angle <pan...@apple.com>
Web Inspector: Styles: Autocomplete should support function completions
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css (279492 => 279493)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2021-07-02 01:08:44 UTC (rev 279492)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2021-07-02 01:36:04 UTC (rev 279493)
@@ -131,7 +131,6 @@
}
.sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container) {
- height: 100%;
overflow-y: auto;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
