Diff
Modified: trunk/Source/WebKit/ChangeLog (284330 => 284331)
--- trunk/Source/WebKit/ChangeLog 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/ChangeLog 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,31 @@
2021-10-16 David Kilzer <ddkil...@apple.com>
+ [WebAuthn] Many Objective-C classes leak their instance variables
+ <https://webkit.org/b/231834>
+ <rdar://problem/84317190>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:
+ (-[_WKAuthenticationExtensionsClientInputs dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm:
+ (-[_WKPublicKeyCredentialCreationOptions dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm:
+ (-[_WKPublicKeyCredentialDescriptor dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm:
+ (-[_WKPublicKeyCredentialEntity dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm:
+ (-[_WKPublicKeyCredentialParameters dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm:
+ (-[_WKPublicKeyCredentialRelyingPartyEntity dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm:
+ (-[_WKPublicKeyCredentialRequestOptions dealloc]):
+ * UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm:
+ (-[_WKPublicKeyCredentialUserEntity dealloc]):
+ - Add -dealloc methods that release instance variables.
+
+2021-10-16 David Kilzer <ddkil...@apple.com>
+
_WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
<https://webkit.org/b/231830>
<rdar://problem/84316056>
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -27,4 +27,11 @@
#import "_WKAuthenticationExtensionsClientInputs.h"
@implementation _WKAuthenticationExtensionsClientInputs
+
+- (void)dealloc
+{
+ [_appid release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -42,4 +42,16 @@
return self;
}
+- (void)dealloc
+{
+ [_relyingParty release];
+ [_user release];
+ [_publicKeyCredentialParamaters release];
+ [_timeout release];
+ [_excludeCredentials release];
+ [_authenticatorSelection release];
+ [_extensions release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -37,4 +37,11 @@
return self;
}
+- (void)dealloc
+{
+ [_identifier release];
+ [_transports release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -37,4 +37,11 @@
return self;
}
+- (void)dealloc
+{
+ [_name release];
+ [_icon release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -37,4 +37,10 @@
return self;
}
+- (void)dealloc
+{
+ [_algorithm release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -35,4 +35,10 @@
return self;
}
+- (void)dealloc
+{
+ [_identifier release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -38,4 +38,13 @@
return self;
}
+- (void)dealloc
+{
+ [_timeout release];
+ [_relyingPartyIdentifier release];
+ [_allowCredentials release];
+ [_extensions release];
+ [super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -38,4 +38,11 @@
return self;
}
+- (void)dealloc
+{
+ [_identifier release];
+ [_displayName release];
+ [super dealloc];
+}
+
@end
