Title: [284863] trunk
Revision
284863
Author
an...@apple.com
Date
2021-10-26 05:16:35 -0700 (Tue, 26 Oct 2021)

Log Message

Serialize :part() argument as identifier
https://bugs.webkit.org/show_bug.cgi?id=232297

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-shadow-parts/serialization-expected.txt:

Source/WebCore:

WPT fix.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284862 => 284863)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,5 +1,14 @@
 2021-10-26  Antti Koivisto  <an...@apple.com>
 
+        Serialize :part() argument as identifier
+        https://bugs.webkit.org/show_bug.cgi?id=232297
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/css/css-shadow-parts/serialization-expected.txt:
+
+2021-10-26  Antti Koivisto  <an...@apple.com>
+
         [CSS Cascade Layers] Media queries should be able to affect layer order
         https://bugs.webkit.org/show_bug.cgi?id=232238
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt (284862 => 284863)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt	2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-shadow-parts/serialization-expected.txt	2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,5 +1,5 @@
 
-FAIL Escape start parenthesis in ::part name. assert_equals: expected "::part(\\(foo)" but got "::part((foo)"
-FAIL Escape start space in ::part name. assert_equals: expected "::part(bar\\ )" but got "::part(bar )"
+PASS Escape start parenthesis in ::part name.
+PASS Escape start space in ::part name.
 PASS Collapse spaces in ::part names list.
 

Modified: trunk/Source/WebCore/ChangeLog (284862 => 284863)


--- trunk/Source/WebCore/ChangeLog	2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/Source/WebCore/ChangeLog	2021-10-26 12:16:35 UTC (rev 284863)
@@ -1,3 +1,15 @@
+2021-10-26  Antti Koivisto  <an...@apple.com>
+
+        Serialize :part() argument as identifier
+        https://bugs.webkit.org/show_bug.cgi?id=232297
+
+        Reviewed by Youenn Fablet.
+
+        WPT fix.
+
+        * css/CSSSelector.cpp:
+        (WebCore::CSSSelector::selectorText const):
+
 2021-10-26  Youenn Fablet  <you...@apple.com>
 
         Only one AudioSampleDataSource::pullSamples is needed

Modified: trunk/Source/WebCore/css/CSSSelector.cpp (284862 => 284863)


--- trunk/Source/WebCore/css/CSSSelector.cpp	2021-10-26 09:46:47 UTC (rev 284862)
+++ trunk/Source/WebCore/css/CSSSelector.cpp	2021-10-26 12:16:35 UTC (rev 284863)
@@ -724,7 +724,7 @@
                     if (!isFirst)
                         builder.append(' ');
                     isFirst = false;
-                    builder.append(partName);
+                    serializeIdentifier(partName, builder);
                 }
                 builder.append(')');
                 break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to