Log Message
Fix CSS serialization affecting grid-auto-flow https://bugs.webkit.org/show_bug.cgi?id=232240
Reviewed by Sergio Villar Senin. LayoutTests/imported/w3c: Update the following test and expectation files - * LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: * LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html: * LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt: * LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html: * web-platform-tests/css/css-grid/grid-layout-properties-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt: * web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html: Source/WebCore: This is to fix the serialization issue of grid-auto-flow where the word 'row' has been included necessarily. This Change is an import of chromium CL at https://chromium-review.googlesource.com/c/chromium/src/+/3179598 * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeGridAutoFlow):
Modified Paths
- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt
- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html
- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt
- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html
- trunk/LayoutTests/imported/w3c/ChangeLog
- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt
- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt
- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt
- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html
- trunk/Source/WebCore/ChangeLog
- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
Diff
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt (284875 => 284876)
--- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -6,11 +6,11 @@
Test getting grid-auto-flow set through CSS
PASS window.getComputedStyle(gridAutoFlowColumnSparse, '').getPropertyValue('grid-auto-flow') is 'column'
PASS window.getComputedStyle(gridAutoFlowRowSparse, '').getPropertyValue('grid-auto-flow') is 'row'
-PASS window.getComputedStyle(gridAutoFlowDense, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowDense, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowColumnDense, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS window.getComputedStyle(gridAutoFlowRowDense, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowRowDense, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowDenseColumn, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS window.getComputedStyle(gridAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(gridAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS window.getComputedStyle(gridAutoFlowInherit, '').getPropertyValue('grid-auto-flow') is 'column'
PASS window.getComputedStyle(gridAutoFlowNoInherit, '').getPropertyValue('grid-auto-flow') is 'row'
@@ -32,13 +32,13 @@
PASS element.style.gridAutoFlow is 'column dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column dense'
PASS element.style.gridAutoFlow is 'dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
-PASS element.style.gridAutoFlow is 'row dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'dense'
+PASS element.style.gridAutoFlow is 'dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS element.style.gridAutoFlow is 'column dense'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'column dense'
-PASS element.style.gridAutoFlow is 'row dense'
-PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row dense'
+PASS element.style.gridAutoFlow is 'dense'
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'dense'
PASS element.style.gridAutoFlow is 'row'
PASS window.getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is 'row'
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html (284875 => 284876)
--- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html 2021-10-26 17:08:08 UTC (rev 284876)
@@ -71,11 +71,11 @@
debug("Test getting grid-auto-flow set through CSS");
checkGridAutoFlowSetCSSValue("gridAutoFlowColumnSparse", "column");
checkGridAutoFlowSetCSSValue("gridAutoFlowRowSparse", "row");
- checkGridAutoFlowSetCSSValue("gridAutoFlowDense", "row dense");
+ checkGridAutoFlowSetCSSValue("gridAutoFlowDense", "dense");
checkGridAutoFlowSetCSSValue("gridAutoFlowColumnDense", "column dense");
- checkGridAutoFlowSetCSSValue("gridAutoFlowRowDense", "row dense");
+ checkGridAutoFlowSetCSSValue("gridAutoFlowRowDense", "dense");
checkGridAutoFlowSetCSSValue("gridAutoFlowDenseColumn", "column dense");
- checkGridAutoFlowSetCSSValue("gridAutoFlowDenseRow", "row dense");
+ checkGridAutoFlowSetCSSValue("gridAutoFlowDenseRow", "dense");
checkGridAutoFlowSetCSSValue("gridAutoFlowInherit", "column");
checkGridAutoFlowSetCSSValue("gridAutoFlowNoInherit", "row");
@@ -96,10 +96,10 @@
debug("Test getting and setting grid-auto-flow through JS");
checkGridAutoFlowSetJSValue("column", "column", "column");
checkGridAutoFlowSetJSValue("column dense", "column dense", "column dense");
- checkGridAutoFlowSetJSValue("dense", "dense", "row dense");
- checkGridAutoFlowSetJSValue("row dense", "row dense", "row dense");
+ checkGridAutoFlowSetJSValue("dense", "dense", "dense");
+ checkGridAutoFlowSetJSValue("row dense", "dense", "dense");
checkGridAutoFlowSetJSValue("dense column", "column dense", "column dense");
- checkGridAutoFlowSetJSValue("dense row", "row dense", "row dense");
+ checkGridAutoFlowSetJSValue("dense row", "dense", "dense");
checkGridAutoFlowSetJSValue("row", "row", "row");
debug("");
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt (284875 => 284876)
--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -49,7 +49,7 @@
PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-template-columns') is "none"
PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-template-areas') is "none"
-PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is "row dense"
+PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-auto-flow') is "dense"
PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-auto-columns') is "auto"
PASS window.getComputedStyle(gridWithAutoFlowDenseRow, '').getPropertyValue('grid-auto-rows') is "auto"
PASS window.getComputedStyle(gridWithAutoFlowAndAutoRowsAndColumns, '').getPropertyValue('grid-template-columns') is "20px"
@@ -85,7 +85,7 @@
PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-template-columns') is "10px"
PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-template-rows') is "none"
PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-template-areas') is "none"
-PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-auto-flow') is "row dense"
+PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-auto-flow') is "dense"
PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-auto-columns') is "auto"
PASS window.getComputedStyle(gridWithColumnsAndDenseAutoFlow, '').getPropertyValue('grid-auto-rows') is "auto"
PASS window.getComputedStyle(gridWithRowsAndAutoFlowAndAutoColumns, '').getPropertyValue('grid-template-columns') is "none"
@@ -224,7 +224,7 @@
PASS element.style.gridTemplateRows is "initial"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-areas') is "none"
PASS element.style.gridTemplateAreas is "initial"
-PASS getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is "row dense"
+PASS getComputedStyle(element, '').getPropertyValue('grid-auto-flow') is "dense"
PASS element.style.gridAutoFlow is "row dense"
PASS getComputedStyle(element, '').getPropertyValue('grid-auto-columns') is "auto"
PASS element.style.gridAutoColumns is "initial"
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html (284875 => 284876)
--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html 2021-10-26 17:08:08 UTC (rev 284876)
@@ -147,7 +147,7 @@
testGridDefinitionsValues(document.getElementById("gridColumnsAndAutoFlow"), "10px", "none", "none", "row", "auto", "auto");
testGridDefinitionsValues(document.getElementById("gridWithAutoFlowAndAutoRows"), "none", "none", "none", "row", "auto", "10px");
testGridDefinitionsValues(document.getElementById("gridWithAutoFlowColumnDense"), "none", "none", "none", "column dense", "auto", "auto");
- testGridDefinitionsValues(document.getElementById("gridWithAutoFlowDenseRow"), "none", "none", "none", "row dense", "auto", "auto");
+ testGridDefinitionsValues(document.getElementById("gridWithAutoFlowDenseRow"), "none", "none", "none", "dense", "auto", "auto");
testGridDefinitionsValues(document.getElementById("gridWithAutoFlowAndAutoRowsAndColumns"), "20px", "none", "none", "row", "auto", "10px");
testGridDefinitionsValues(document.getElementById("gridWithAutoFlowAndMultipleAutoTracks"), "100px 50px", "none", "none", "row", "auto", "20px 10px");
@@ -154,7 +154,7 @@
testGridDefinitionsValues(document.getElementById("gridWithRowsAndAutoFlow"), "none", "10px", "none", "column", "auto", "auto");
testGridDefinitionsValues(document.getElementById("gridWithRowsNoneAndAutoFlowAndAutoColumn"), "none", "none", "none", "column", "10px", "auto");
testGridDefinitionsValues(document.getElementById("gridWithRowsAndAutoFlowDenseColumn"), "none", "10px", "none", "column dense", "auto", "auto");
- testGridDefinitionsValues(document.getElementById("gridWithColumnsAndDenseAutoFlow"), "10px", "none", "none", "row dense", "auto", "auto");
+ testGridDefinitionsValues(document.getElementById("gridWithColumnsAndDenseAutoFlow"), "10px", "none", "none", "dense", "auto", "auto");
testGridDefinitionsValues(document.getElementById("gridWithRowsAndAutoFlowAndAutoColumns"), "none", "20px", "none", "column", "10px", "auto");
testGridDefinitionsValues(document.getElementById("gridWithRowsAndAutoFlowAndMultipleAutoTracks"), "none", "100px 50px", "none", "column", "20px 10px", "auto");
@@ -180,7 +180,7 @@
debug("Test getting and setting 'grid' shorthand through JS");
testGridDefinitionsSetJSValues("20px / 10px", "10px", "20px", "none", "row", "auto", "auto", "10px", "20px", "none", "initial", "initial", "initial");
testGridDefinitionsSetJSValues("[line] 'a' 20px / 10px", "10px", "[line] 20px", "\"a\"", "row", "auto", "auto", "10px", "[line] 20px", "\"a\"", "initial", "initial", "initial");
- testGridDefinitionsSetJSValues("auto-flow dense 20px / none", "none", "none", "none", "row dense", "auto", "20px", "none", "initial", "initial", "row dense", "initial", "20px");
+ testGridDefinitionsSetJSValues("auto-flow dense 20px / none", "none", "none", "none", "dense", "auto", "20px", "none", "initial", "initial", "row dense", "initial", "20px");
testGridDefinitionsSetJSValues("20px / auto-flow 10px", "none", "20px", "none", "column", "10px", "auto", "initial", "20px", "initial", "column", "10px", "initial");
testGridDefinitionsSetJSValues("none / auto-flow dense 20px", "none", "none", "none", "column dense", "20px", "auto", "initial", "none", "initial", "column dense", "20px", "initial");
testGridDefinitionsSetJSValues("10px / auto-flow 20px", "none", "10px", "none", "column", "20px", "auto", "initial", "10px", "initial", "column", "20px", "initial");
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284875 => 284876)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-26 17:08:08 UTC (rev 284876)
@@ -1,3 +1,20 @@
+2021-10-26 Ziran Sun <z...@igalia.com>
+
+ Fix CSS serialization affecting grid-auto-flow
+ https://bugs.webkit.org/show_bug.cgi?id=232240
+
+ Reviewed by Sergio Villar Senin.
+
+ Update the following test and expectation files -
+ * LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
+ * LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html:
+ * LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
+ * LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html:
+ * web-platform-tests/css/css-grid/grid-layout-properties-expected.txt:
+ * web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt:
+ * web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt:
+ * web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html:
+
2021-10-26 Martin Robinson <mrobin...@webkit.org>
Update import of css/css-transform WPT tests
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt (284875 => 284876)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -62,8 +62,8 @@
PASS grid-auto-flow.initial
PASS grid-auto-flow.row
PASS grid-auto-flow.column
-FAIL grid-auto-flow.dense assert_equals: dense expected "dense" but got "row dense"
-FAIL grid-auto-flow.row dense assert_equals: row dense expected "dense" but got "row dense"
+PASS grid-auto-flow.dense
+PASS grid-auto-flow.row dense
PASS grid-auto-flow.column dense
PASS grid-auto-flow.reset
PASS grid-row-start
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt (284875 => 284876)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -1,9 +1,9 @@
PASS Property grid-auto-flow value 'row'
PASS Property grid-auto-flow value 'column'
-FAIL Property grid-auto-flow value 'row dense' assert_equals: expected "dense" but got "row dense"
+PASS Property grid-auto-flow value 'row dense'
PASS Property grid-auto-flow value 'column dense'
-FAIL Property grid-auto-flow value 'dense row' assert_equals: expected "dense" but got "row dense"
+PASS Property grid-auto-flow value 'dense row'
PASS Property grid-auto-flow value 'dense column'
-FAIL Property grid-auto-flow value 'dense' assert_equals: expected "dense" but got "row dense"
+PASS Property grid-auto-flow value 'dense'
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt (284875 => 284876)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt 2021-10-26 17:08:08 UTC (rev 284876)
@@ -1,8 +1,8 @@
PASS e.style['grid-auto-flow'] = "row" should set the property value
PASS e.style['grid-auto-flow'] = "column" should set the property value
-FAIL e.style['grid-auto-flow'] = "row dense" should set the property value assert_equals: serialization should be canonical expected "dense" but got "row dense"
-FAIL e.style['grid-auto-flow'] = "dense row" should set the property value assert_equals: serialization should be canonical expected "dense" but got "row dense"
+PASS e.style['grid-auto-flow'] = "row dense" should set the property value
+PASS e.style['grid-auto-flow'] = "dense row" should set the property value
PASS e.style['grid-auto-flow'] = "dense" should set the property value
PASS e.style['grid-auto-flow'] = "column dense" should set the property value
PASS e.style['grid-auto-flow'] = "dense column" should set the property value
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html (284875 => 284876)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html 2021-10-26 17:08:08 UTC (rev 284876)
@@ -19,7 +19,7 @@
]);
runUnsupportedPropertyTests('grid-auto-flow', [
- 'row dense', 'column dense',
+ 'column dense',
]);
</script>
Modified: trunk/Source/WebCore/ChangeLog (284875 => 284876)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 17:08:08 UTC (rev 284876)
@@ -1,3 +1,21 @@
+2021-10-26 Ziran Sun <z...@igalia.com>
+
+ Fix CSS serialization affecting grid-auto-flow
+ https://bugs.webkit.org/show_bug.cgi?id=232240
+
+ Reviewed by Sergio Villar Senin.
+
+ This is to fix the serialization issue of grid-auto-flow where the word 'row' has been
+ included necessarily.
+
+ This Change is an import of chromium CL at
+ https://chromium-review.googlesource.com/c/chromium/src/+/3179598
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeGridAutoFlow):
+
2021-10-26 Gabriel Nava Marino <gnavamar...@apple.com>
ASSERT(parent->element()) triggered in Styleable::fromRenderer
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (284875 => 284876)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2021-10-26 17:08:08 UTC (rev 284876)
@@ -3007,10 +3007,10 @@
case CSSPropertyGridAutoFlow: {
auto list = CSSValueList::createSpaceSeparated();
ASSERT(style.isGridAutoFlowDirectionRow() || style.isGridAutoFlowDirectionColumn());
- if (style.isGridAutoFlowDirectionRow())
+ if (style.isGridAutoFlowDirectionColumn())
+ list->append(cssValuePool.createIdentifierValue(CSSValueColumn));
+ else if (!style.isGridAutoFlowAlgorithmDense())
list->append(cssValuePool.createIdentifierValue(CSSValueRow));
- else
- list->append(cssValuePool.createIdentifierValue(CSSValueColumn));
if (style.isGridAutoFlowAlgorithmDense())
list->append(cssValuePool.createIdentifierValue(CSSValueDense));
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (284875 => 284876)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-10-26 17:06:43 UTC (rev 284875)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-10-26 17:08:08 UTC (rev 284876)
@@ -3135,8 +3135,11 @@
return nullptr;
}
RefPtr<CSSValueList> parsedValues = CSSValueList::createSpaceSeparated();
- if (rowOrColumnValue)
- parsedValues->append(rowOrColumnValue.releaseNonNull());
+ if (rowOrColumnValue) {
+ CSSValueID value = rowOrColumnValue->valueID();
+ if (value == CSSValueID::CSSValueColumn || (value == CSSValueID::CSSValueRow && !denseAlgorithm))
+ parsedValues->append(rowOrColumnValue.releaseNonNull());
+ }
if (denseAlgorithm)
parsedValues->append(denseAlgorithm.releaseNonNull());
return parsedValues;
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes