Title: [285110] trunk/Source
- Revision
- 285110
- Author
- ayumi_koj...@apple.com
- Date
- 2021-11-01 09:27:56 -0700 (Mon, 01 Nov 2021)
Log Message
Unreviewed, reverting r285055.
Reverting because this commit may have caused
webgl/1.0.x/conformance/textures/misc/texture-corner-case-
videos.html and webgl/2.0.y/conformance/textures/misc/texture-
corner-case-videos.html to time out
Reverted changeset:
"Avoid sending video data to Web process for
canvas.drawImage(video)"
https://bugs.webkit.org/show_bug.cgi?id=230766
https://commits.webkit.org/r285055
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (285109 => 285110)
--- trunk/Source/WebCore/ChangeLog 2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/ChangeLog 2021-11-01 16:27:56 UTC (rev 285110)
@@ -1,3 +1,19 @@
+2021-11-01 Ayumi Kojima <ayumi_koj...@apple.com>
+
+ Unreviewed, reverting r285055.
+
+ Reverting because this commit may have caused
+ webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+ videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+ corner-case-videos.html to time out
+
+ Reverted changeset:
+
+ "Avoid sending video data to Web process for
+ canvas.drawImage(video)"
+ https://bugs.webkit.org/show_bug.cgi?id=230766
+ https://commits.webkit.org/r285055
+
2021-11-01 Alan Bujtas <za...@apple.com>
Addressing post-commit comment (r285093).
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (285109 => 285110)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2021-11-01 16:27:56 UTC (rev 285110)
@@ -1677,19 +1677,17 @@
checkOrigin(&video);
#if USE(CG)
- if (!canvasBase().buffer()->isRemote()) {
- if (auto image = video.nativeImageForCurrentTime()) {
- c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
+ if (auto image = video.nativeImageForCurrentTime()) {
+ c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
- if (isEntireBackingStoreDirty())
- didDraw(std::nullopt);
- else if (rectContainsCanvas(dstRect))
- didDrawEntireCanvas();
- else
- didDraw(dstRect);
+ if (isEntireBackingStoreDirty())
+ didDraw(std::nullopt);
+ else if (rectContainsCanvas(dstRect))
+ didDrawEntireCanvas();
+ else
+ didDraw(dstRect);
- return { };
- }
+ return { };
}
#endif
Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (285109 => 285110)
--- trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2021-11-01 16:27:56 UTC (rev 285110)
@@ -71,7 +71,6 @@
virtual RenderingMode renderingMode() const = 0;
virtual bool canMapBackingStore() const = 0;
- virtual bool isRemote() const { return false; }
virtual RenderingResourceIdentifier renderingResourceIdentifier() const { return { }; }
virtual GraphicsContext& context() const = 0;
Modified: trunk/Source/WebKit/ChangeLog (285109 => 285110)
--- trunk/Source/WebKit/ChangeLog 2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebKit/ChangeLog 2021-11-01 16:27:56 UTC (rev 285110)
@@ -1,3 +1,19 @@
+2021-11-01 Ayumi Kojima <ayumi_koj...@apple.com>
+
+ Unreviewed, reverting r285055.
+
+ Reverting because this commit may have caused
+ webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+ videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+ corner-case-videos.html to time out
+
+ Reverted changeset:
+
+ "Avoid sending video data to Web process for
+ canvas.drawImage(video)"
+ https://bugs.webkit.org/show_bug.cgi?id=230766
+ https://commits.webkit.org/r285055
+
2021-11-01 Daniel Kolesa <dkol...@igalia.com>
Fix build with GCC 8.4 on Ubuntu 18.04
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (285109 => 285110)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2021-11-01 16:27:56 UTC (rev 285110)
@@ -96,8 +96,6 @@
ASSERT(m_sentFlushIdentifier == targetFlushIdentifier);
}
- bool isRemote() const final { return true; }
-
protected:
RemoteImageBufferProxy(const WebCore::ImageBufferBackend::Parameters& parameters, RemoteRenderingBackendProxy& remoteRenderingBackendProxy)
: BaseConcreteImageBuffer(parameters)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
