Diff
Modified: trunk/Source/WTF/ChangeLog (285198 => 285199)
--- trunk/Source/WTF/ChangeLog 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WTF/ChangeLog 2021-11-03 06:53:13 UTC (rev 285199)
@@ -1,3 +1,12 @@
+2021-11-02 Brady Eidson <beid...@apple.com>
+
+ Notifications on iOS enabled at compile-time, disabled at runtime
+ https://bugs.webkit.org/show_bug.cgi?id=232649
+
+ Reviewed by Tim Horton.
+
+ * wtf/PlatformEnableCocoa.h:
+
2021-11-02 David Kilzer <ddkil...@apple.com>
[WTF] Minor clean-up for format-related functions
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (285198 => 285199)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-11-03 06:53:13 UTC (rev 285199)
@@ -430,7 +430,7 @@
#define ENABLE_NON_VISIBLE_WEBPROCESS_MEMORY_CLEANUP_TIMER 1
#endif
-#if !defined(ENABLE_NOTIFICATIONS) && PLATFORM(MAC)
+#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS))
#define ENABLE_NOTIFICATIONS 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (285198 => 285199)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 06:53:13 UTC (rev 285199)
@@ -1,3 +1,17 @@
+2021-11-02 Brady Eidson <beid...@apple.com>
+
+ Notifications on iOS enabled at compile-time, disabled at runtime
+ https://bugs.webkit.org/show_bug.cgi?id=232649
+
+ Reviewed by Tim Horton.
+
+ No new tests (Changing compiled behavior but definitely not runtime behavior)
+
+ * Modules/notifications/Notification.idl:
+ * Modules/notifications/NotificationPermission.idl:
+ * Modules/notifications/NotificationPermissionCallback.idl:
+ * bindings/js/WebCoreBuiltinNames.h:
+
2021-11-02 Caitln Potter <ca...@igalia.com>
[WebIDL] Support [Exposed=*] extended attribute
Modified: trunk/Source/WebCore/Modules/notifications/Notification.idl (285198 => 285199)
--- trunk/Source/WebCore/Modules/notifications/Notification.idl 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WebCore/Modules/notifications/Notification.idl 2021-11-03 06:53:13 UTC (rev 285199)
@@ -34,8 +34,9 @@
[
Conditional=NOTIFICATIONS,
ActiveDOMObject,
+ EnabledBySetting=NotificationsEnabled,
ExportMacro=WEBCORE_EXPORT,
- Exposed=Window
+ Exposed=Window,
] interface Notification : EventTarget {
[CallWith=Document] constructor(DOMString title, optional NotificationOptions options);
Modified: trunk/Source/WebCore/Modules/notifications/NotificationPermission.idl (285198 => 285199)
--- trunk/Source/WebCore/Modules/notifications/NotificationPermission.idl 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WebCore/Modules/notifications/NotificationPermission.idl 2021-11-03 06:53:13 UTC (rev 285199)
@@ -25,6 +25,7 @@
[
Conditional=NOTIFICATIONS,
+ EnabledBySetting=NotificationsEnabled,
] enum NotificationPermission {
"default",
"denied",
Modified: trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl (285198 => 285199)
--- trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl 2021-11-03 06:53:13 UTC (rev 285199)
@@ -25,4 +25,5 @@
[
Conditional=NOTIFICATIONS,
+ EnabledBySetting=NotificationsEnabled,
] callback NotificationPermissionCallback = undefined (NotificationPermission permission);
Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (285198 => 285199)
--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2021-11-03 03:37:50 UTC (rev 285198)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2021-11-03 06:53:13 UTC (rev 285199)
@@ -183,6 +183,7 @@
macro(NavigatorMediaDevices) \
macro(NavigatorPermissions) \
macro(NavigatorUserMedia) \
+ macro(Notification) \
macro(OfflineAudioContext) \
macro(OffscreenCanvas) \
macro(OffscreenCanvasRenderingContext2D) \
