Title: [285710] trunk
- Revision
- 285710
- Author
- an...@apple.com
- Date
- 2021-11-12 02:50:47 -0800 (Fri, 12 Nov 2021)
Log Message
REGRESSION(r285624) Using revert keyword with a css variable hits assert
https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271
Reviewed by Tim Horton.
Source/WebCore:
Test: fast/selectors/variable-revert-crash.html
* style/StyleBuilderState.h:
Default initialization set the variable to a value that is not in the enumeration.
LayoutTests:
* fast/selectors/variable-revert-crash-expected.txt: Added.
* fast/selectors/variable-revert-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (285709 => 285710)
--- trunk/LayoutTests/ChangeLog 2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/LayoutTests/ChangeLog 2021-11-12 10:50:47 UTC (rev 285710)
@@ -1,3 +1,14 @@
+2021-11-12 Antti Koivisto <an...@apple.com>
+
+ REGRESSION(r285624) Using revert keyword with a css variable hits assert
+ https://bugs.webkit.org/show_bug.cgi?id=233031
+ rdar://85332271
+
+ Reviewed by Tim Horton.
+
+ * fast/selectors/variable-revert-crash-expected.txt: Added.
+ * fast/selectors/variable-revert-crash.html: Added.
+
2021-11-11 Sergio Villar Senin <svil...@igalia.com>
[css-flexbox] Add flex-basis: content support
Added: trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt (0 => 285710)
--- trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt 2021-11-12 10:50:47 UTC (rev 285710)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.
Added: trunk/LayoutTests/fast/selectors/variable-revert-crash.html (0 => 285710)
--- trunk/LayoutTests/fast/selectors/variable-revert-crash.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/variable-revert-crash.html 2021-11-12 10:50:47 UTC (rev 285710)
@@ -0,0 +1,6 @@
+<audio style="--a: revert"></audio>
+This test passes if it doesn't crash.
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
Modified: trunk/Source/WebCore/ChangeLog (285709 => 285710)
--- trunk/Source/WebCore/ChangeLog 2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/Source/WebCore/ChangeLog 2021-11-12 10:50:47 UTC (rev 285710)
@@ -1,3 +1,17 @@
+2021-11-12 Antti Koivisto <an...@apple.com>
+
+ REGRESSION(r285624) Using revert keyword with a css variable hits assert
+ https://bugs.webkit.org/show_bug.cgi?id=233031
+ rdar://85332271
+
+ Reviewed by Tim Horton.
+
+ Test: fast/selectors/variable-revert-crash.html
+
+ * style/StyleBuilderState.h:
+
+ Default initialization set the variable to a value that is not in the enumeration.
+
2021-11-11 Sergio Villar Senin <svil...@igalia.com>
[css-flexbox] Add flex-basis: content support
Modified: trunk/Source/WebCore/style/StyleBuilderState.h (285709 => 285710)
--- trunk/Source/WebCore/style/StyleBuilderState.h 2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/Source/WebCore/style/StyleBuilderState.h 2021-11-12 10:50:47 UTC (rev 285710)
@@ -135,7 +135,7 @@
Bitmap<numCSSProperties> m_inProgressProperties;
HashSet<String> m_inProgressPropertiesCustom;
- CascadeLevel m_cascadeLevel { };
+ CascadeLevel m_cascadeLevel { CascadeLevel::Author };
ScopeOrdinal m_styleScopeOrdinal { };
CascadeLayerPriority m_cascadeLayerPriority { };
SelectorChecker::LinkMatchMask m_linkMatch { };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
