Title: [90741] trunk/LayoutTests
- Revision
- 90741
- Author
- yael.aha...@nokia.com
- Date
- 2011-07-11 06:54:21 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255
Reviewed by Csaba Osztrogonác.
Modify the tests to wait until the icon loading is finished.
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* platform/qt/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90740 => 90741)
--- trunk/LayoutTests/ChangeLog 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 13:54:21 UTC (rev 90741)
@@ -1,3 +1,16 @@
+2011-07-11 Yael Aharon <yael.aha...@nokia.com>
+
+ [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
+ https://bugs.webkit.org/show_bug.cgi?id=63255
+
+ Reviewed by Csaba Osztrogonác.
+
+ Modify the tests to wait until the icon loading is finished.
+
+ * fast/notifications/notifications-double-show.html:
+ * fast/notifications/notifications-with-permission.html:
+ * platform/qt/Skipped:
+
2011-07-11 Csaba Osztrogonác <o...@webkit.org>
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/notifications/notifications-double-show.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission("file://");
layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -19,6 +20,7 @@
}
var N = window.webkitNotifications.createNotification("http://localhost/my_icon.png", "New E-mail", "Meet me tonight at 8!");
+ N._ondisplay_ = function() { layoutTestController.notifyDone(); }
N.show();
N.show();
}
Modified: trunk/LayoutTests/fast/notifications/notifications-with-permission.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission("file://");
layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -22,6 +23,7 @@
N.show();
var M = window.webkitNotifications.createNotification("http://localhost/my_icon.png", "New E-mail", "Meet me tonight at 8!");
+ M._ondisplay_ = function() { layoutTestController.notifyDone(); }
M.show();
}
</script>
Modified: trunk/LayoutTests/platform/qt/Skipped (90740 => 90741)
--- trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:54:21 UTC (rev 90741)
@@ -2156,13 +2156,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=53868
fast/notifications/notifications-document-close-crash.html
-# [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
-# https://bugs.webkit.org/show_bug.cgi?id=63255
-fast/notifications/notifications-no-icon.html
-fast/notifications/notifications-double-show.html
-fast/notifications/notifications-with-permission.html
-fast/notifications/notifications-without-permission.html
-
# [Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html
# https://bugs.webkit.org/show_bug.cgi?id=54725
editing/selection/mixed-editability-10.html
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
