Title: [94953] trunk
- Revision
- 94953
- Author
- commit-qu...@webkit.org
- Date
- 2011-09-12 04:09:55 -0700 (Mon, 12 Sep 2011)
Log Message
Implement a WebKitAnimationEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67922
Patch by Kentaro Hara <hara...@google.com> on 2011-09-12
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/webkit-animation-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
* dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (94952 => 94953)
--- trunk/LayoutTests/ChangeLog 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 11:09:55 UTC (rev 94953)
@@ -1,3 +1,14 @@
+2011-09-12 Kentaro Hara <hara...@google.com>
+
+ Implement a WebKitAnimationEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=67922
+
+ Reviewed by Adam Barth.
+
+ Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-09-12 Zoltan Horvath <zol...@webkit.org>
[Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94952 => 94953)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 11:09:55 UTC (rev 94953)
@@ -68,9 +68,6 @@
BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL
BUGWK60877 SKIP : loader/load-defer-resume-crash.html = FAIL
-// This will soon be fixed after implementing a WebKitAnimationEvent constructor for V8.
-BUGWK67825 : fast/events/constructors/webkit-animation-event-constructor.html = FAIL
-
// CSS3 Selectors3 test suite
BUGCR89468 : css3/selectors3 = PASS FAIL
Modified: trunk/Source/WebCore/ChangeLog (94952 => 94953)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 11:09:55 UTC (rev 94953)
@@ -1,3 +1,15 @@
+2011-09-12 Kentaro Hara <hara...@google.com>
+
+ Implement a WebKitAnimationEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=67922
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/webkit-animation-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
+ * dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.
+
2011-09-12 Andreas Kling <kl...@webkit.org>
Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (94952 => 94953)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-12 11:09:55 UTC (rev 94953)
@@ -36,6 +36,7 @@
#include "DocumentFragment.h"
#include "Node.h"
#include "ProgressEvent.h"
+#include "WebKitAnimationEvent.h"
#include "OptionsObject.h"
#include "V8Binding.h"
@@ -46,6 +47,7 @@
#include "V8Node.h"
#include "V8ProgressEvent.h"
#include "V8Proxy.h"
+#include "V8WebKitAnimationEvent.h"
#include <wtf/RefPtr.h>
@@ -102,6 +104,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CUSTOM_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PROGRESS_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.idl (94952 => 94953)
--- trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-09-12 11:09:55 UTC (rev 94953)
@@ -27,7 +27,8 @@
interface [
CanBeConstructed,
- CustomConstructFunction
+ CustomConstructFunction,
+ V8CustomConstructor
] WebKitAnimationEvent : Event {
readonly attribute DOMString animationName;
readonly attribute double elapsedTime;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
