Title: [95004] trunk/Source/WebCore
- Revision
- 95004
- Author
- commit-qu...@webkit.org
- Date
- 2011-09-12 20:24:33 -0700 (Mon, 12 Sep 2011)
Log Message
[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
https://bugs.webkit.org/show_bug.cgi?id=67038
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.
Since most of the time it will return the same thing as text(), we
initialize it the same way we initialize m_text. The other case (what
would have been generated if no modifiers were pressed) should be
covered by this as well.
As this method is used when handling access keys, tests such as
fast/events/access-key-self-destruct.html should now pass.
No new tests, as this fixes a problem uncovered by the existing ones.
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (95003 => 95004)
--- trunk/Source/WebCore/ChangeLog 2011-09-13 03:13:33 UTC (rev 95003)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 03:24:33 UTC (rev 95004)
@@ -1,3 +1,23 @@
+2011-09-12 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
+ https://bugs.webkit.org/show_bug.cgi?id=67038
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Since most of the time it will return the same thing as text(), we
+ initialize it the same way we initialize m_text. The other case (what
+ would have been generated if no modifiers were pressed) should be
+ covered by this as well.
+
+ As this method is used when handling access keys, tests such as
+ fast/events/access-key-self-destruct.html should now pass.
+
+ No new tests, as this fixes a problem uncovered by the existing ones.
+
+ * platform/efl/PlatformKeyboardEventEfl.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
2011-09-12 Hyowon Kim <hw1008....@samsung.com>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp (95003 => 95004)
--- trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2011-09-13 03:13:33 UTC (rev 95003)
+++ trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2011-09-13 03:24:33 UTC (rev 95004)
@@ -191,6 +191,7 @@
PlatformKeyboardEvent::PlatformKeyboardEvent(const Evas_Event_Key_Down* event)
: m_type(KeyDown)
, m_text(String::fromUTF8(event->string))
+ , m_unmodifiedText(String::fromUTF8(event->string))
, m_shiftKey(evas_key_modifier_is_set(event->modifiers, "Shift"))
, m_ctrlKey(evas_key_modifier_is_set(event->modifiers, "Control"))
, m_altKey(evas_key_modifier_is_set(event->modifiers, "Alt"))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
