Title: [96074] trunk/Tools
- Revision
- 96074
- Author
- dglaz...@chromium.org
- Date
- 2011-09-26 23:32:10 -0700 (Mon, 26 Sep 2011)
Log Message
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js (96073 => 96074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js 2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js 2011-09-27 06:32:10 UTC (rev 96074)
@@ -123,7 +123,7 @@
failingTestsSummary.addCommitData({
time: minutesAgo(currentMinutesAgo++),
revision: currentRevision++,
- title: bugTitles.cycle(),
+ summary: bugTitles.cycle(),
author: people.cycle(),
reviewer: people.cycle()
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (96073 => 96074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-27 06:32:10 UTC (rev 96074)
@@ -108,24 +108,25 @@
{
this._revision = commitData.revision;
var linkToRevision = this._description.appendChild(document.createElement('a'));
+ this._details = this._description.appendChild(document.createElement('span'));
linkToRevision.href = ""
linkToRevision.target = '_blank';
linkToRevision.textContent = commitData.revision;
- this._addDescriptionPart('summary', commitData);
- this._addDescriptionPart('author', commitData);
- this._addDescriptionPart('reviewer', commitData);
+ this._addDetail('summary', commitData);
+ this._addDetail('author', commitData);
+ this._addDetail('reviewer', commitData);
},
hasRevision: function(revision)
{
return this._revision == revision;
},
- _addDescriptionPart: function(part, commitData)
+ _addDetail: function(part, commitData)
{
var content = commitData[part];
if (!content)
return;
- var span = this._description.appendChild(document.createElement('span'));
+ var span = this._details.appendChild(document.createElement('span'));
span.className = part;
span.textContent = content;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (96073 => 96074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-27 06:32:10 UTC (rev 96074)
@@ -88,9 +88,11 @@
equal(suspiciousCommit.innerHTML,
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="summary">summary</span>' +
- '<span class="author">author</span>' +
- '<span class="reviewer">reviewer</span>' +
+ '<span>' +
+ '<span class="summary">summary</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
+ '</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -195,9 +197,11 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="summary">summary</span>' +
- '<span class="author">author</span>' +
- '<span class="reviewer">reviewer</span>' +
+ '<span>' +
+ '<span class="summary">summary</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
+ '</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -239,9 +243,11 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="summary">summary</span>' +
- '<span class="author">author</span>' +
- '<span class="reviewer">reviewer</span>' +
+ '<span>' +
+ '<span class="summary">summary</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
+ '</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -287,9 +293,11 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="summary">summary</span>' +
- '<span class="author">author</span>' +
- '<span class="reviewer">reviewer</span>' +
+ '<span>' +
+ '<span class="summary">summary</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
+ '</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (96073 => 96074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-27 06:32:10 UTC (rev 96074)
@@ -100,7 +100,8 @@
}
ol.notifications>li ul.causes>li>div.description {
- padding: 0 10px 0 0;
+ padding: 0 10px 5px 0;
+ display: -webkit-box;
}
ol.notifications>li ul.causes>li>div.description>a {
@@ -111,8 +112,9 @@
ol.notifications>li ul.causes>li:hover>div.description>a {
background-color: #555;
padding: 5px 10px 5px 10px;
- margin: 0 10px 0 0;
+ margin: -5px 10px -1px 0;
color: White;
+ display: inline-block;
}
ol.notifications>li ul.causes>li:hover>div.description>a::after {
@@ -129,22 +131,26 @@
ol.notifications>li ul.causes>li>div.description>span {
padding: 0 10px 0 0;
- display: inline-block;
+ display: block;
+ cursor: default;
+ pointer-events: none;
+ -webkit-box-flex: 1;
}
- ol.notifications>li ul.causes>li>div.description>span.author {
+ ol.notifications>li ul.causes>li>div.description>span>span.author {
+ padding: 0 0 0 5px;
font-style: italic;
}
- ol.notifications>li ul.causes>li>div.description>span.reviewer {
+ ol.notifications>li ul.causes>li>div.description>span>span.reviewer {
color: Gray;
}
- ol.notifications>li ul.causes>li>div.description>span.reviewer::before {
- content: '(';
+ ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {
+ content: ' (';
}
- ol.notifications>li ul.causes>li>div.description>span.reviewer::after {
+ ol.notifications>li ul.causes>li>div.description>span>span.reviewer::after {
content: ')';
}
Modified: trunk/Tools/ChangeLog (96073 => 96074)
--- trunk/Tools/ChangeLog 2011-09-27 06:27:02 UTC (rev 96073)
+++ trunk/Tools/ChangeLog 2011-09-27 06:32:10 UTC (rev 96074)
@@ -1,3 +1,15 @@
+2011-09-26 Dimitri Glazkov <dglaz...@chromium.org>
+
+ garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
+ https://bugs.webkit.org/show_bug.cgi?id=68864
+
+ Reviewed by Adam Barth.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
+
2011-09-26 Csaba Osztrogonác <o...@webkit.org>
[Qt][WK2] One more unreviewed buildfix after r96005.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
