Diff
Modified: trunk/Source/WebCore/ChangeLog (96929 => 96930)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 12:17:00 UTC (rev 96930)
@@ -1,3 +1,14 @@
+2011-10-07 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r96879.
+ http://trac.webkit.org/changeset/96879
+ https://bugs.webkit.org/show_bug.cgi?id=69618
+
+ Broke CCLayerTreeHostTestShortlived1 on chromium mac.
+ (Requested by podivilov on #webkit).
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h:
+
2011-10-07 Pavel Feldman <pfeld...@google.com>
Web Inspector: add ResourcesPanel to the compilation.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (96929 => 96930)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-10-07 12:17:00 UTC (rev 96930)
@@ -54,10 +54,9 @@
virtual void applyScrollDelta(const IntSize&) = 0;
virtual PassRefPtr<GraphicsContext3D> createLayerTreeHostContext3D() = 0;
virtual void didRecreateGraphicsContext(bool success) = 0;
-
- // Used in the non-threaded path
+#if !USE(THREADED_COMPOSITING)
virtual void scheduleComposite() = 0;
-
+#endif
protected:
virtual ~CCLayerTreeHostClient() { }
};
Modified: trunk/Source/WebKit/chromium/ChangeLog (96929 => 96930)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-07 12:17:00 UTC (rev 96930)
@@ -1,5 +1,20 @@
2011-10-07 Sheriff Bot <webkit.review....@gmail.com>
+ Unreviewed, rolling out r96879.
+ http://trac.webkit.org/changeset/96879
+ https://bugs.webkit.org/show_bug.cgi?id=69618
+
+ Broke CCLayerTreeHostTestShortlived1 on chromium mac.
+ (Requested by podivilov on #webkit).
+
+ * features.gypi:
+ * src/WebViewImpl.h:
+ * tests/CCLayerTreeHostTest.cpp:
+ (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
+ (WTF::CCLayerTreeHostTest::onEndTest):
+
+2011-10-07 Sheriff Bot <webkit.review....@gmail.com>
+
Unreviewed, rolling out r96909.
http://trac.webkit.org/changeset/96909
https://bugs.webkit.org/show_bug.cgi?id=69616
Modified: trunk/Source/WebKit/chromium/features.gypi (96929 => 96930)
--- trunk/Source/WebKit/chromium/features.gypi 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/features.gypi 2011-10-07 12:17:00 UTC (rev 96930)
@@ -108,6 +108,7 @@
# through GYP_DEFINES.
'variables': {
'use_accelerated_compositing%': 1,
+ 'use_threaded_compositing%': 0,
'enable_svg%': 1,
'enable_touch_events%': 1,
'use_skia_gpu%': 0,
@@ -116,6 +117,7 @@
'enable_css3_flexbox%': 0,
},
'use_accelerated_compositing%': '<(use_accelerated_compositing)',
+ 'use_threaded_compositing%': '<(use_threaded_compositing)',
'enable_svg%': '<(enable_svg)',
'enable_touch_events%': '<(enable_touch_events)',
'use_skia%': '<(use_skia)',
@@ -140,6 +142,11 @@
'ENABLE_ACCELERATED_2D_CANVAS=1',
],
}],
+ ['use_accelerated_compositing==1 and use_threaded_compositing==1', {
+ 'feature_defines': [
+ 'WTF_USE_THREADED_COMPOSITING=1',
+ ],
+ }],
['touchui==1', {
'enable_touch_icon_loading': 1,
}],
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (96929 => 96930)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-10-07 12:17:00 UTC (rev 96930)
@@ -223,8 +223,9 @@
virtual void applyScrollDelta(const WebCore::IntSize&);
virtual PassRefPtr<WebCore::GraphicsContext3D> createLayerTreeHostContext3D();
virtual void didRecreateGraphicsContext(bool success);
-
+#if !USE(THREADED_COMPOSITING)
virtual void scheduleComposite();
+#endif
// WebViewImpl
@@ -451,6 +452,9 @@
#if USE(ACCELERATED_COMPOSITING)
void setIsAcceleratedCompositingActive(bool);
+#if !USE(THREADED_COMPOSITING)
+ void doComposite();
+#endif
void doPixelReadbackToCanvas(WebCanvas*, const WebCore::IntRect&);
void reallocateRenderer();
void updateLayerTreeViewport();
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (96929 => 96930)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2011-10-07 11:35:25 UTC (rev 96929)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp 2011-10-07 12:17:00 UTC (rev 96930)
@@ -24,6 +24,8 @@
#include "config.h"
+#if USE(THREADED_COMPOSITING)
+
#include "cc/CCLayerTreeHost.h"
#include "cc/CCLayerImpl.h"
@@ -168,7 +170,9 @@
{
}
+#if !USE(THREADED_COMPOSITING)
virtual void scheduleComposite() { }
+#endif
private:
explicit MockLayerTreeHostClient(TestHooks* testHooks) : m_testHooks(testHooks) { }
@@ -212,7 +216,11 @@
{
m_webThread = adoptPtr(webKitPlatformSupport()->createThread("CCLayerTreeHostTest"));
WebCompositor::setThread(m_webThread.get());
+#if USE(THREADED_COMPOSITING)
m_settings.enableCompositorThread = true;
+#else
+ m_settings.enableCompositorThread = false;
+#endif
}
void doBeginTest();
@@ -225,11 +233,7 @@
static void onEndTest(void* self)
{
ASSERT(isMainThread());
- // webkit_support::QuitMessageLoop() simply posts a task on the loop to quit. Any pending messages enqueued
- // before the Quit task will still run. For this test scenario we want to run all pending messages before
- // tearing down m_layerTreeHost, so we spin the loop after posting the Quit task.
webkit_support::QuitMessageLoop();
- webkit_support::RunAllPendingMessages();
CCLayerTreeHostTest* test = static_cast<CCLayerTreeHostTest*>(self);
ASSERT(test);
test->m_layerTreeHost.clear();
@@ -712,3 +716,5 @@
}
} // namespace
+
+#endif
