Title: [98239] trunk
Revision
98239
Author
carlo...@webkit.org
Date
2011-10-24 07:56:39 -0700 (Mon, 24 Oct 2011)

Log Message

[GTK] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=70717

Reviewed by Xan Lopez.

With newer glib it's not needed anymore and with previous versions
it was already called by g_type_init().

Source/WebKit/gtk:

* tests/testapplicationcache.c:
(main):
* tests/testatk.c:
(main):
* tests/testatkroles.c:
(main):
* tests/testcopyandpaste.c:
(main):
* tests/testdomdocument.c:
(main):
* tests/testdomdomwindow.c:
(main):
* tests/testdomnode.c:
(main):
* tests/testdownload.c:
(main):
* tests/testglobals.c:
(main):
* tests/testhittestresult.c:
(main):
* tests/testhttpbackend.c:
(main):
* tests/testkeyevents.c:
(main):
* tests/testloading.c:
(main):
* tests/testmimehandling.c:
(main):
* tests/testnetworkrequest.c:
(main):
* tests/testnetworkresponse.c:
(main):
* tests/testwebbackforwardlist.c:
(main):
* tests/testwebdatasource.c:
(main):
* tests/testwebframe.c:
(main):
* tests/testwebhistoryitem.c:
(main):
* tests/testwebplugindatabase.c:
(main):
* tests/testwebresource.c:
(main):
* tests/testwebsettings.c:
(main):
* tests/testwebview.c:
* tests/testwindow.c:
(main):

Source/WebKit2:

* UIProcess/API/gtk/tests/TestMain.cpp:
(main):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(main):
* GtkLauncher/main.c:
(main):
* MiniBrowser/gtk/main.c:
(main):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (98238 => 98239)


--- trunk/Source/WebKit/gtk/ChangeLog	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-10-24 14:56:39 UTC (rev 98239)
@@ -1,3 +1,63 @@
+2011-10-24  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Remove g_thread_init() calls
+        https://bugs.webkit.org/show_bug.cgi?id=70717
+
+        Reviewed by Xan Lopez.
+
+        With newer glib it's not needed anymore and with previous versions
+        it was already called by g_type_init().
+
+        * tests/testapplicationcache.c:
+        (main):
+        * tests/testatk.c:
+        (main):
+        * tests/testatkroles.c:
+        (main):
+        * tests/testcopyandpaste.c:
+        (main):
+        * tests/testdomdocument.c:
+        (main):
+        * tests/testdomdomwindow.c:
+        (main):
+        * tests/testdomnode.c:
+        (main):
+        * tests/testdownload.c:
+        (main):
+        * tests/testglobals.c:
+        (main):
+        * tests/testhittestresult.c:
+        (main):
+        * tests/testhttpbackend.c:
+        (main):
+        * tests/testkeyevents.c:
+        (main):
+        * tests/testloading.c:
+        (main):
+        * tests/testmimehandling.c:
+        (main):
+        * tests/testnetworkrequest.c:
+        (main):
+        * tests/testnetworkresponse.c:
+        (main):
+        * tests/testwebbackforwardlist.c:
+        (main):
+        * tests/testwebdatasource.c:
+        (main):
+        * tests/testwebframe.c:
+        (main):
+        * tests/testwebhistoryitem.c:
+        (main):
+        * tests/testwebplugindatabase.c:
+        (main):
+        * tests/testwebresource.c:
+        (main):
+        * tests/testwebsettings.c:
+        (main):
+        * tests/testwebview.c:
+        * tests/testwindow.c:
+        (main):
+
 2011-10-20  Gustavo Noronha Silva  <g...@gnome.org>
 
         [GTK] webkitgtk's pkgconfig file needs to require _javascript_coregtk

Modified: trunk/Source/WebKit/gtk/tests/testapplicationcache.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testapplicationcache.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testapplicationcache.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -39,7 +39,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testatk.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testatk.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testatk.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -1660,7 +1660,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(0);
     gtk_test_init(&argc, &argv, 0);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testatkroles.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testatkroles.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testatkroles.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -302,7 +302,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testcopyandpaste.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testcopyandpaste.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testcopyandpaste.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -228,7 +228,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testdomdocument.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testdomdocument.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testdomdocument.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -319,9 +319,6 @@
 
 int main(int argc, char** argv)
 {
-    if (!g_thread_supported())
-        g_thread_init(NULL);
-
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testdomdomwindow.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testdomdomwindow.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testdomdomwindow.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -197,9 +197,6 @@
 
 int main(int argc, char** argv)
 {
-    if (!g_thread_supported())
-        g_thread_init(NULL);
-
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testdomnode.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testdomnode.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testdomnode.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -174,9 +174,6 @@
 
 int main(int argc, char** argv)
 {
-    if (!g_thread_supported())
-        g_thread_init(NULL);
-
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testdownload.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testdownload.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testdownload.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -250,7 +250,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testglobals.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testglobals.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testglobals.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -47,7 +47,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testhittestresult.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testhittestresult.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testhittestresult.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -136,7 +136,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testhttpbackend.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testhttpbackend.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testhttpbackend.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -68,7 +68,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testkeyevents.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testkeyevents.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testkeyevents.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -303,7 +303,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testloading.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testloading.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testloading.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -400,7 +400,6 @@
 {
     SoupServer* server;
 
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     server = soup_server_new(SOUP_SERVER_PORT, 0, NULL);

Modified: trunk/Source/WebKit/gtk/tests/testmimehandling.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testmimehandling.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testmimehandling.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -176,7 +176,6 @@
     SoupServer* server;
     SoupURI* soup_uri;
 
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     /* Hopefully make test independent of the path it's called from. */

Modified: trunk/Source/WebKit/gtk/tests/testnetworkrequest.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testnetworkrequest.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testnetworkrequest.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -88,7 +88,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testnetworkresponse.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testnetworkresponse.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testnetworkresponse.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -89,7 +89,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebbackforwardlist.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebbackforwardlist.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebbackforwardlist.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -316,7 +316,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebdatasource.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebdatasource.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebdatasource.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -226,7 +226,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebframe.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebframe.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebframe.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -209,7 +209,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebhistoryitem.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebhistoryitem.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebhistoryitem.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -58,7 +58,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebplugindatabase.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebplugindatabase.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebplugindatabase.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -71,7 +71,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebresource.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebresource.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebresource.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -295,7 +295,6 @@
     SoupServer* server;
     SoupURI* soup_uri;
 
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     server = soup_server_new(SOUP_SERVER_PORT, 0, NULL);

Modified: trunk/Source/WebKit/gtk/tests/testwebsettings.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebsettings.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebsettings.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -149,7 +149,6 @@
 
 int main(int argc, char **argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit/gtk/tests/testwebview.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwebview.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwebview.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -368,7 +368,6 @@
     SoupServer* server;
     SoupURI* soup_uri;
 
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     /* Hopefully make test independent of the path it's called from. */

Modified: trunk/Source/WebKit/gtk/tests/testwindow.c (98238 => 98239)


--- trunk/Source/WebKit/gtk/tests/testwindow.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit/gtk/tests/testwindow.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -112,7 +112,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(NULL);
     gtk_test_init(&argc, &argv, NULL);
 
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Source/WebKit2/ChangeLog (98238 => 98239)


--- trunk/Source/WebKit2/ChangeLog	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-24 14:56:39 UTC (rev 98239)
@@ -1,3 +1,16 @@
+2011-10-24  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Remove g_thread_init() calls
+        https://bugs.webkit.org/show_bug.cgi?id=70717
+
+        Reviewed by Xan Lopez.
+
+        With newer glib it's not needed anymore and with previous versions
+        it was already called by g_type_init().
+
+        * UIProcess/API/gtk/tests/TestMain.cpp:
+        (main):
+
 2011-10-24  Zeno Albisser  <zeno.albis...@nokia.com>
 
         [Qt][WK2] WebView does not get focus when being clicked / touched in MiniBrowser.

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp (98238 => 98239)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp	2011-10-24 14:56:39 UTC (rev 98239)
@@ -27,7 +27,6 @@
 
 int main(int argc, char** argv)
 {
-    g_thread_init(0);
     gtk_test_init(&argc, &argv, 0);
     g_setenv("WEBKIT_EXEC_PATH", WEBKIT_EXEC_PATH, FALSE);
     g_test_bug_base("https://bugs.webkit.org/");

Modified: trunk/Tools/ChangeLog (98238 => 98239)


--- trunk/Tools/ChangeLog	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Tools/ChangeLog	2011-10-24 14:56:39 UTC (rev 98239)
@@ -1,3 +1,20 @@
+2011-10-24  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Remove g_thread_init() calls
+        https://bugs.webkit.org/show_bug.cgi?id=70717
+
+        Reviewed by Xan Lopez.
+
+        With newer glib it's not needed anymore and with previous versions
+        it was already called by g_type_init().
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (main):
+        * GtkLauncher/main.c:
+        (main):
+        * MiniBrowser/gtk/main.c:
+        (main):
+
 2011-10-24  Alejandro G. Castro  <a...@igalia.com>
 
         [WK2] [GTK] WebKitTestRunner crashes with heap corruption

Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (98238 => 98239)


--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2011-10-24 14:56:39 UTC (rev 98239)
@@ -1172,7 +1172,6 @@
 
 int main(int argc, char* argv[])
 {
-    g_thread_init(NULL);
     gtk_init(&argc, &argv);
 
     // Some plugins might try to use the GLib logger for printing debug

Modified: trunk/Tools/GtkLauncher/main.c (98238 => 98239)


--- trunk/Tools/GtkLauncher/main.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Tools/GtkLauncher/main.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -392,8 +392,6 @@
     };
 
     gtk_init(&argc, &argv);
-    if (!g_thread_supported())
-        g_thread_init(NULL);
 
     GOptionContext *context = g_option_context_new(0);
     g_option_context_add_main_entries(context, commandLineOptions, 0);

Modified: trunk/Tools/MiniBrowser/gtk/main.c (98238 => 98239)


--- trunk/Tools/MiniBrowser/gtk/main.c	2011-10-24 14:41:26 UTC (rev 98238)
+++ trunk/Tools/MiniBrowser/gtk/main.c	2011-10-24 14:56:39 UTC (rev 98239)
@@ -78,8 +78,7 @@
 
 int main(int argc, char *argv[])
 {
-    if (!g_thread_supported())
-        g_thread_init(NULL);
+    gtk_init(&argc, &argv);
 
     GOptionContext *context = g_option_context_new(NULL);
     g_option_context_add_main_entries(context, commandLineOptions, 0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to