Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 338528b22bcdcf17efacf0e7084f562f7f044a0d https://github.com/WebKit/WebKit/commit/338528b22bcdcf17efacf0e7084f562f7f044a0d Author: Claudio Saavedra <csaave...@igalia.com> Date: 2024-03-07 (Thu, 07 Mar 2024)
Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: ----------- [Skia] fast/canvas/canvas-webkitLineDash-invalid.html is crashing https://bugs.webkit.org/show_bug.cgi?id=270633 Reviewed by Carlos Garcia Campos. The assert in setLineDash() is problematic because setting canvas.webkitLineDash with an odd-sized vector will pass it down unchecked (contrary to using canvas.setLineDash(), which will double the size in that case). Skia can handle an odd-sized vector just fine, so there's no need for this assert. This fixes the crashing fast/canvas/canvas-webkitLineDash-invalid.html test, caused by the assert. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::setLineDash): Canonical link: https://commits.webkit.org/275787@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes