Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 6fc661206fd08055f15923113a93ad97ee5b601e https://github.com/WebKit/WebKit/commit/6fc661206fd08055f15923113a93ad97ee5b601e Author: Youenn Fablet <youe...@gmail.com> Date: 2023-02-02 (Thu, 02 Feb 2023)
Changed paths: A LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt A LayoutTests/http/wpt/fetch/fetch-stream-source.html M Source/WebCore/Modules/streams/ReadableStream.js M Source/WebCore/Modules/streams/ReadableStreamSource.idl M Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h Log Message: ----------- Cherry-pick 257063@main (f44648f07471). https://bugs.webkit.org/show_bug.cgi?id=248268 Type getter is not needed for internal ReadableStream sources https://bugs.webkit.org/show_bug.cgi?id=248268 rdar://102338913 Reviewed by Eric Carlson. Make ReadableStreamSource method privates. In ReadableStream, use @getters instead of private getters to allow getting private values from prototype. Covered by added test. * LayoutTests/http/wpt/fetch/fetch-stream-source-expected.txt: Added. * LayoutTests/http/wpt/fetch/fetch-stream-source.html: Added. * Source/WebCore/Modules/streams/ReadableStream.js: (initializeReadableStream): * Source/WebCore/Modules/streams/ReadableStreamSource.idl: * Source/WebCore/bindings/js/JSDOMOperationReturningPromise.h: (WebCore::IDLOperationReturningPromise::call): Canonical link: https://commits.webkit.org/257063@main Commit: b177a6504931ce0ccd3bcccb06b402a4a0b9d48e https://github.com/WebKit/WebKit/commit/b177a6504931ce0ccd3bcccb06b402a4a0b9d48e Author: Chris Dumez <cdu...@apple.com> Date: 2023-02-02 (Thu, 02 Feb 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/HistoryController.cpp M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm Log Message: ----------- Cherry-pick 252432.826@safari-7614-branch (baca9afc289e). https://bugs.webkit.org/show_bug.cgi?id=247909 Properly mark history items added without user gesture https://bugs.webkit.org/show_bug.cgi?id=247909 rdar://100579077 Reviewed by Geoffrey Garen. We recently introduced logic to mark history items as "created by JavaScript without a user gesture" so that those could be skipped when the user navigates back/forward via the browser UI. However, which history items we marked with such flag was a little unexpected and didn't quite match what Chrome did to address the same problem. In particular, if on URL1 and then calling `pushState(null, null, 'a')` in JS without a user gesture. We would previously mark the HistoryItem for URL1 as created without a user gesture, instead of marking the one for URL1#a. URL1#a is the actual HistoryItem created by JS so it makes more sense to mark this one (which also matches Chrome's behavior). * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): * Source/WebCore/loader/HistoryController.cpp: (WebCore::FrameLoader::HistoryController::pushState): * Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm: (TEST): Canonical link: https://commits.webkit.org/252432.826@safari-7614-branch Compare: https://github.com/WebKit/WebKit/compare/9293a4e88efd...b177a6504931 _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes