Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b975729cd495d6e06a8ce8ca0edbe8c44db97fd2 https://github.com/WebKit/WebKit/commit/b975729cd495d6e06a8ce8ca0edbe8c44db97fd2 Author: Tim Nguyen <n...@apple.com> Date: 2023-02-15 (Wed, 15 Feb 2023)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-animation-corner-cases.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/toggleevent-interface.tentative-expected.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/dom/Event.h M Source/WebCore/dom/EventNames.h M Source/WebCore/dom/EventNames.in A Source/WebCore/dom/ToggleEvent.cpp A Source/WebCore/dom/ToggleEvent.h A Source/WebCore/dom/ToggleEvent.idl M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h Log Message: ----------- [popover] Implement beforetoggle event https://bugs.webkit.org/show_bug.cgi?id=252214 rdar://105471198 Reviewed by Ryosuke Niwa. - Add ToggleEvent interface used by beforetoggle & toggle events. - Fire beforetoggle events when appropriate * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-animation-corner-cases.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.tentative-expected.txt: This test still fails because it needs special [popup=auto] behavior to be implemented. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/toggleevent-interface.tentative-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/Event.h: (WebCore::Event::isToggleEvent const): * Source/WebCore/dom/EventNames.h: * Source/WebCore/dom/EventNames.in: * Source/WebCore/dom/ToggleEvent.cpp: Added. (WebCore::ToggleEvent::ToggleEvent): (WebCore::ToggleEvent::create): (WebCore::ToggleEvent::createForBindings): (WebCore::ToggleEvent::eventInterface const): * Source/WebCore/dom/ToggleEvent.h: Added. * Source/WebCore/dom/ToggleEvent.idl: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::hidePopoverInternal): (WebCore::HTMLElement::hidePopover): (WebCore::HTMLElement::popoverAttributeChanged): * Source/WebCore/html/HTMLElement.h: Canonical link: https://commits.webkit.org/260329@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes