Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e327d4468b6d6c0366404ed9e35dd215d4062610
https://github.com/WebKit/WebKit/commit/e327d4468b6d6c0366404ed9e35dd215d4062610
Author: Kiara Rose <kiara_r...@apple.com>
Date: 2024-04-24 (Wed, 24 Apr 2024)
Changed paths:
M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h
M Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/page/PageDebuggable.cpp
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm
M
Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Inspector/WebPageDebuggable.cpp
M Source/WebKit/UIProcess/Inspector/WebPageDebuggable.h
Log Message:
-----------
Allow apps to set a custom inspection name for web extension background and
popup web views
https://bugs.webkit.org/show_bug.cgi?id=273161
rdar://125874004
Reviewed by Timothy Hatcher.
Add API to allow apps to set a custom inspection name for background and popup
web views.
Also, add a `nameOverride()` method to WebPageDebuggable. This will allow us to
keep
track of overrides that are set for the web pages.
* Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h:
* Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:
* Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::listingForInspectionTarget const):
Set the name override on the listing.
* Source/WebCore/en.lproj/Localizable.strings:
Add localized strings for text shown when inspecting the extension popup.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm:
(-[_WKWebExtensionAction inspectionName]):
(-[_WKWebExtensionAction setInspectionName:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:
(-[_WKWebExtensionContext inspectionName]):
(-[_WKWebExtensionContext setInspectionName:]):
*
Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h
Remove guards since _WKWebExtensionDataRecord.errors API has made it into the
build.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::popupWebViewInspectionName):
(WebKit::WebExtensionAction::setPopupWebViewInspectionName):
(WebKit::WebExtensionAction::popupWebView):
Set the _remoteInspectionNameOverride for the popup web view.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::loadBackgroundWebView):
(WebKit::WebExtensionContext::backgroundWebViewInspectionName):
(WebKit::WebExtensionContext::setBackgroundWebViewInspectionName):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Inspector/WebPageDebuggable.cpp:
(WebKit::WebPageDebuggable::name const):
* Source/WebKit/UIProcess/Inspector/WebPageDebuggable.h:
Canonical link: https://commits.webkit.org/277937@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
