Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0a74ba686ad09f95cbe896871dbac4d46f8be6a https://github.com/WebKit/WebKit/commit/f0a74ba686ad09f95cbe896871dbac4d46f8be6a Author: Joseph Griego <jgri...@igalia.com> Date: 2023-10-24 (Tue, 24 Oct 2023)
Changed paths: M Source/JavaScriptCore/assembler/MacroAssembler.cpp M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h M Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h Log Message: ----------- [JSC] Macro assemblers: add ResultCondition::Carry https://bugs.webkit.org/show_bug.cgi?id=263559 Reviewed by Yusuke Suzuki. We want to perform a fast 32-bit addition while branching on _unsigned_ overflow for the ARMv7 wasm BBQ JIT; heretofore we've not needed this in the macroassemblers, especially on 64-bit where we seem to only care about signed overflow; add this case to ResultCondition. On many archs there's a condition code we can reach for and use; this is not the case on MIPS and RISC-V where I've left the condition unimplemented for now; (MIPS is going away soon, RISCV64 is unlikely to need branch-on-carry any time soon in my estimation) * Source/JavaScriptCore/assembler/MacroAssembler.cpp: (WTF::printInternal): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: * Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h: * Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h: * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::branchTestFinalize): * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: Canonical link: https://commits.webkit.org/269717@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes