from:"achristensen"

[webkit-changes] [212699] trunk

2017-02-20 Thread achristensen

Title: [212699] trunk








Revision 212699
Author achristen...@apple.com
Date 2017-02-20 21:50:06 -0800 (Mon, 20 Feb 2017)


Log Message
[WebRTC][Mac] Activate libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167293
LayoutTests/imported/w3c:



Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

* web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
* web-platform-tests/webrtc/no-media-call-expected.txt:
* web-platform-tests/webrtc/promises-call-expected.txt:

Source/ThirdParty/libwebrtc:



Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

Doing some clean-up.

* Configurations/libwebrtc.xcconfig:
* Source/webrtc/base/checks.h:
* libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:


Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:

Source/WebKit2:



Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

Activating PeerConnection runtime flag based on successful loading of libwebrtc.dylib.

* Configurations/WebKit.xcconfig:
* Shared/WebPreferencesDefinitions.h:
* UIProcess/WebPreferences.cpp:
(WebKit::checkWebRTCAvailability):

Source/WTF:


Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

* wtf/Platform.h:

Tools:



Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

Fixing paths to allow loading libwebrtc.dylib successfully.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(setupMacWebKitEnvironment):
(setupIOSWebKitEnvironment):

LayoutTests:



Patch by Youenn Fablet  on 2017-02-20
Reviewed by Alex Christensen.

* TestExpectations:
* fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
* fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt:
* fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt:
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt:
* platform/gtk/TestExpectations:
* platform/gtk/fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-closed-state-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCRtpSender-replaceTrack-expected.txt: Added.
* platform/gtk/fast/mediastream/no-media-call-expected.txt: Added.
* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/WebKit.xcconfig
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webk

[webkit-changes] [212701] trunk/Source/WebCore

2017-02-20 Thread achristensen

Title: [212701] trunk/Source/WebCore








Revision 212701
Author achristen...@apple.com
Date 2017-02-20 22:37:06 -0800 (Mon, 20 Feb 2017)


Log Message
Fix some 32-bit builds after r212699

* platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::OnFrame):
Explicitly cast OSStatus to int for logging.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212700 => 212701)

--- trunk/Source/WebCore/ChangeLog	2017-02-21 05:51:36 UTC (rev 212700)
+++ trunk/Source/WebCore/ChangeLog	2017-02-21 06:37:06 UTC (rev 212701)
@@ -1,3 +1,11 @@
+2017-02-20  Alex Christensen  
+
+Fix some 32-bit builds after r212699
+
+* platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:
+(WebCore::RealtimeIncomingVideoSource::OnFrame):
+Explicitly cast OSStatus to int for logging.
+
 2017-02-20  Joseph Pecoraro  
 
 Remove unnecessary PerformanceEntry virtual methods


Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp (212700 => 212701)

--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp	2017-02-21 05:51:36 UTC (rev 212700)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp	2017-02-21 06:37:06 UTC (rev 212701)
@@ -110,7 +110,7 @@
 CMVideoFormatDescriptionRef formatDescription;
 OSStatus ostatus = CMVideoFormatDescriptionCreateForImageBuffer(kCFAllocatorDefault, (CVImageBufferRef)pixelBuffer, &formatDescription);
 if (ostatus != noErr) {
-LOG_ERROR("Failed to initialize CMVideoFormatDescription: %d", ostatus);
+LOG_ERROR("Failed to initialize CMVideoFormatDescription: %d", static_cast(ostatus));
 return;
 }
 
@@ -117,7 +117,7 @@
 CMSampleBufferRef sampleBuffer;
 ostatus = CMSampleBufferCreateReadyWithImageBuffer(kCFAllocatorDefault, (CVImageBufferRef)pixelBuffer, formatDescription, &timingInfo, &sampleBuffer);
 if (ostatus != noErr) {
-LOG_ERROR("Failed to create the sample buffer: %d", ostatus);
+LOG_ERROR("Failed to create the sample buffer: %d", static_cast(ostatus));
 return;
 }
 CFRelease(formatDescription);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212704] trunk

2017-02-21 Thread achristensen

Title: [212704] trunk








Revision 212704
Author achristen...@apple.com
Date 2017-02-21 00:19:34 -0800 (Tue, 21 Feb 2017)


Log Message
Unreviewed, rolling out r212699.

Internal build not ready

Reverted changeset:

"[WebRTC][Mac] Activate libwebrtc"
https://bugs.webkit.org/show_bug.cgi?id=167293
http://trac.webkit.org/changeset/212699

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/WebKit.xcconfig
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webkitdirs.pm


Removed Paths

trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-closed-state-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCRtpSender-replaceTrack-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/no-media-call-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (212703 => 212704)

--- trunk/LayoutTests/ChangeLog	2017-02-21 07:12:17 UTC (rev 212703)
+++ trunk/LayoutTests/ChangeLog	2017-02-21 08:19:34 UTC (rev 212704)
@@ -1,3 +1,15 @@
+2017-02-21  Alex Christensen  
+
+Unreviewed, rolling out r212699.
+
+Internal build not ready
+
+Reverted changeset:
+
+"[WebRTC][Mac] Activate libwebrtc"
+https://bugs.webkit.org/show_bug.cgi?id=167293
+http://trac.webkit.org/changeset/212699
+
 2017-02-20  Youenn Fablet  
 
 [WebRTC][Mac] Activate libwebrtc


Modified: trunk/LayoutTests/TestExpectations (212703 => 212704)

--- trunk/LayoutTests/TestExpectations	2017-02-21 07:12:17 UTC (rev 212703)
+++ trunk/LayoutTests/TestExpectations	2017-02-21 08:19:34 UTC (rev 212704)
@@ -692,14 +692,6 @@
 # WebRTC backend not enabled by default.
 webrtc [ Skip ]
 fast/mediastream/getUserMedia-webaudio.html [ Skip ]
-fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
-fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ]
-fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html [ Skip ]
-fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html [ Skip ]
-fast/mediastream/RTCPeerConnection-onnegotiationneeded.html [ Skip ]
-fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Skip ]
-fast/mediastream/RTCRtpSender-replaceTrack.html [ Skip ]
-fast/mediastream/RTCPeerConnection-icecandidate-event.html [ Pass Failure ]
 
 # Only iOS WK1 has testRunner.setPagePaused.
 fast/dom/timer-fire-after-page-pause.html [ Skip ]


Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt (212703 => 212704)

--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt	2017-02-21 07:12:17 UTC (rev 212703)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt	2017-02-21 08:19:34 U

[webkit-changes] [212756] trunk/Source

2017-02-21 Thread achristensen

Title: [212756] trunk/Source








Revision 212756
Author achristen...@apple.com
Date 2017-02-21 14:14:50 -0800 (Tue, 21 Feb 2017)


Log Message
Fix CMake build.

* PlatformMac.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (212755 => 212756)

--- trunk/Source/WebCore/ChangeLog	2017-02-21 22:13:33 UTC (rev 212755)
+++ trunk/Source/WebCore/ChangeLog	2017-02-21 22:14:50 UTC (rev 212756)
@@ -1,3 +1,9 @@
+2017-02-21  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+
 2017-02-21  Simon Fraser  
 
 Add Media Streams and Capture to features.json.


Modified: trunk/Source/WebCore/PlatformMac.cmake (212755 => 212756)

--- trunk/Source/WebCore/PlatformMac.cmake	2017-02-21 22:13:33 UTC (rev 212755)
+++ trunk/Source/WebCore/PlatformMac.cmake	2017-02-21 22:14:50 UTC (rev 212756)
@@ -467,6 +467,7 @@
 platform/mac/MediaRemoteSoftLink.cpp
 platform/mac/NSScrollerImpDetails.mm
 platform/mac/PasteboardMac.mm
+platform/mac/PasteboardWriter.mm
 platform/mac/PlatformClockCA.cpp
 platform/mac/PlatformClockCM.mm
 platform/mac/PlatformEventFactoryMac.mm


Modified: trunk/Source/WebKit2/ChangeLog (212755 => 212756)

--- trunk/Source/WebKit2/ChangeLog	2017-02-21 22:13:33 UTC (rev 212755)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-21 22:14:50 UTC (rev 212756)
@@ -1,3 +1,9 @@
+2017-02-21  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+
 2017-02-21  Youenn Fablet  
 
 [WebRTC][Mac] Network process sandbox does not allow WebRTC networking


Modified: trunk/Source/WebKit2/PlatformMac.cmake (212755 => 212756)

--- trunk/Source/WebKit2/PlatformMac.cmake	2017-02-21 22:13:33 UTC (rev 212755)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2017-02-21 22:14:50 UTC (rev 212756)
@@ -238,6 +238,7 @@
 
 UIProcess/Cocoa/AutomationClient.mm
 UIProcess/Cocoa/AutomationSessionClient.mm
+UIProcess/Cocoa/CustomProtocolManagerClient.mm
 UIProcess/Cocoa/DiagnosticLoggingClient.mm
 UIProcess/Cocoa/DownloadClient.mm
 UIProcess/Cocoa/FindClient.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212772] trunk/Source/ThirdParty/libwebrtc

2017-02-21 Thread achristensen

Title: [212772] trunk/Source/ThirdParty/libwebrtc








Revision 212772
Author achristen...@apple.com
Date 2017-02-21 15:23:38 -0800 (Tue, 21 Feb 2017)


Log Message
[Xcode] libwebrtc installhdrs doesn’t install any of the headers
https://bugs.webkit.org/show_bug.cgi?id=168634

Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* Configurations/libwebrtc.xcconfig:
* libwebrtc.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212771 => 212772)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-21 23:18:36 UTC (rev 212771)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-21 23:23:38 UTC (rev 212772)
@@ -1,3 +1,13 @@
+2017-02-21  Youenn Fablet  
+
+[Xcode] libwebrtc installhdrs doesn’t install any of the headers
+https://bugs.webkit.org/show_bug.cgi?id=168634
+
+Reviewed by Alex Christensen.
+
+* Configurations/libwebrtc.xcconfig:
+* libwebrtc.xcodeproj/project.pbxproj:
+
 2017-02-21  Alex Christensen  
 
 Unreviewed, rolling out r212699.


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (212771 => 212772)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig	2017-02-21 23:18:36 UTC (rev 212771)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig	2017-02-21 23:23:38 UTC (rev 212772)
@@ -11,6 +11,7 @@
 INSTALL_PATH = /usr/local/lib;
 PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
 USE_HEADERMAP = NO;
+INSTALLHDRS_SCRIPT_PHASE = YES;
 WARNING_CFLAGS = -Wno-exit-time-destructors -Wno-objc-property-no-attribute -Wno-objc-missing-super-calls -Wno-deprecated-declarations;
 
 GCC_PREPROCESSOR_DEFINITIONS = WEBRTC_POSIX WEBRTC_MAC SSL_USE_OPENSSL FEATURE_ENABLE_SSL HAVE_SRTP HAVE_OPENSSL_SSL_H SCTP_PROCESS_LEVEL_LOCKS SCTP_SIMPLE_ALLOCATOR SCTP_USE_OPENSSL_SHA1 __Userspace__ HAVE_SA_LEN HAVE_SCONN_LEN __APPLE_USE_RFC_2292 __Userspace_os_Darwin NON_WINDOWS_DEFINE HAVE_WEBRTC_VIDEO HAVE_WEBRTC_VOICE WEBRTC_INTELLIGIBILITY_ENHANCER=0 WEBRTC_APM_DEBUG_DUMP=0 WEBRTC_NS_FLOAT WEBRTC_CODEC_ILBC WEBRTC_CODEC_OPUS WEBRTC_CODEC_ISAC WEBRTC_CODEC_RED RTC_DISABLE_VP9 RTC_DISABLE_VP8 HAVE_STDINT_H HAVE_STDLIB_H HAVE_UINT64_T OPENSSL HAVE_CONFIG_H WEBRTC_WEBKIT_BUILD HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE  HAVE_SCTP WEBRTC_CODEC_G711 WEBRTC_CODEC_G722;


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (212771 => 212772)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-21 23:18:36 UTC (rev 212771)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-21 23:23:38 UTC (rev 212772)
@@ -11951,6 +11951,7 @@
 		};
 		5C63F6631E414AB6002CA531 /* Debug */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = 5D7C59C51208C68B001C873E /* libwebrtc.xcconfig */;
 			buildSettings = {
 PRODUCT_NAME = "$(TARGET_NAME)";
 			};
@@ -11958,6 +11959,7 @@
 		};
 		5C63F6641E414AB6002CA531 /* Release */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = 5D7C59C51208C68B001C873E /* libwebrtc.xcconfig */;
 			buildSettings = {
 PRODUCT_NAME = "$(TARGET_NAME)";
 			};
@@ -11965,6 +11967,7 @@
 		};
 		5C63F6651E414AB6002CA531 /* Production */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = 5D7C59C51208C68B001C873E /* libwebrtc.xcconfig */;
 			buildSettings = {
 PRODUCT_NAME = "$(TARGET_NAME)";
 			};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212777] trunk/Source/ThirdParty/libwebrtc

2017-02-21 Thread achristensen

Title: [212777] trunk/Source/ThirdParty/libwebrtc








Revision 212777
Author achristen...@apple.com
Date 2017-02-21 16:53:19 -0800 (Tue, 21 Feb 2017)


Log Message
Don't build libwebrtc on 32-bit architectures
https://bugs.webkit.org/show_bug.cgi?id=168692

Reviewed by Dan Bernstein.

* Configurations/Base.xcconfig:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212776 => 212777)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-22 00:30:32 UTC (rev 212776)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-22 00:53:19 UTC (rev 212777)
@@ -1,3 +1,12 @@
+2017-02-21  Alex Christensen  
+
+Don't build libwebrtc on 32-bit architectures
+https://bugs.webkit.org/show_bug.cgi?id=168692
+
+Reviewed by Dan Bernstein.
+
+* Configurations/Base.xcconfig:
+
 2017-02-21  Youenn Fablet  
 
 [Xcode] libwebrtc installhdrs doesn’t install any of the headers


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (212776 => 212777)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2017-02-22 00:30:32 UTC (rev 212776)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig	2017-02-22 00:53:19 UTC (rev 212777)
@@ -44,7 +44,8 @@
 STRIP_INSTALLED_PRODUCT = NO;
 WARNING_CFLAGS = -Wexit-time-destructors -Wglobal-constructors;
 
-SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx;
+VALID_ARCHS = $(ARCHS_STANDARD_64_BIT);
 
 TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
 TARGET_MAC_OS_X_VERSION_MAJOR_10 = 101000;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212812] trunk

2017-02-21 Thread achristensen

Title: [212812] trunk








Revision 212812
Author achristen...@apple.com
Date 2017-02-21 23:59:59 -0800 (Tue, 21 Feb 2017)


Log Message
[WebRTC][Mac] Activate libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167293
LayoutTests/imported/w3c:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
* web-platform-tests/webrtc/no-media-call-expected.txt:
* web-platform-tests/webrtc/promises-call-expected.txt:

Source/_javascript_Core:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* Configurations/FeatureDefines.xcconfig:

Source/ThirdParty/libwebrtc:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

Doing some clean-up.

* Configurations/libwebrtc.xcconfig:
* Source/webrtc/base/checks.h:
* libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:


Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:


Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

Activating PeerConnection runtime flag based on successful loading of libwebrtc.dylib.

* Configurations/WebKit.xcconfig:
* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesDefinitions.h:
* UIProcess/WebPreferences.cpp:
(WebKit::checkWebRTCAvailability):

Source/WTF:


Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* wtf/Platform.h:

Tools:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

Fixing paths to allow loading libwebrtc.dylib successfully.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(setupMacWebKitEnvironment):
(setupIOSWebKitEnvironment):
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:



Patch by Youenn Fablet  on 2017-02-21
Reviewed by Alex Christensen.

* TestExpectations:
* fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
* fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt:
* fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt:
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt:
* platform/gtk/TestExpectations:
* platform/gtk/fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-closed-state-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt.
* platform/gtk/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Added.
* platform/gtk/fast/mediastream/RTCRtpSender-replaceTrack-expected.txt: Added.
* platform/gtk/fast/mediastream/no-media-call-expected.txt: Added.
* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/Third

[webkit-changes] [212817] trunk/Source/WTF

2017-02-22 Thread achristensen

Title: [212817] trunk/Source/WTF








Revision 212817
Author achristen...@apple.com
Date 2017-02-22 00:55:30 -0800 (Wed, 22 Feb 2017)


Log Message
Fix ASAN build after activating libwebrtc.

* wtf/Ref.h:
__asan_address_is_poisoned returns an int, not a bool.
This didn't cause a problem before because we didn't include the real definition anywhere,
but libwebrtc includes  directly now so the return types need to be correct.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Ref.h




Diff

Modified: trunk/Source/WTF/ChangeLog (212816 => 212817)

--- trunk/Source/WTF/ChangeLog	2017-02-22 08:33:41 UTC (rev 212816)
+++ trunk/Source/WTF/ChangeLog	2017-02-22 08:55:30 UTC (rev 212817)
@@ -1,3 +1,12 @@
+2017-02-22  Alex Christensen  
+
+Fix ASAN build after activating libwebrtc.
+
+* wtf/Ref.h:
+__asan_address_is_poisoned returns an int, not a bool.
+This didn't cause a problem before because we didn't include the real definition anywhere,
+but libwebrtc includes  directly now so the return types need to be correct.
+
 2017-02-22  Carlos Garcia Campos  
 
 [GTK] Test fast/events/message-port-postMessage-recursive.html times out


Modified: trunk/Source/WTF/wtf/Ref.h (212816 => 212817)

--- trunk/Source/WTF/wtf/Ref.h	2017-02-22 08:33:41 UTC (rev 212816)
+++ trunk/Source/WTF/wtf/Ref.h	2017-02-22 08:55:30 UTC (rev 212817)
@@ -35,7 +35,7 @@
 #if ASAN_ENABLED
 extern "C" void __asan_poison_memory_region(void const volatile *addr, size_t size);
 extern "C" void __asan_unpoison_memory_region(void const volatile *addr, size_t size);
-extern "C" bool __asan_address_is_poisoned(void const volatile *addr);
+extern "C" int __asan_address_is_poisoned(void const volatile *addr);
 #endif
 
 namespace WTF {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212849] trunk/Source/WTF

2017-02-22 Thread achristensen

Title: [212849] trunk/Source/WTF








Revision 212849
Author achristen...@apple.com
Date 2017-02-22 13:33:10 -0800 (Wed, 22 Feb 2017)


Log Message
Re-commit part of r212812 accidentally rolled out with r212841.
https://bugs.webkit.org/show_bug.cgi?id=167293

* wtf/Platform.h:
Use libwebrtc on Mac if webrtc is enabled.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (212848 => 212849)

--- trunk/Source/WTF/ChangeLog	2017-02-22 20:59:21 UTC (rev 212848)
+++ trunk/Source/WTF/ChangeLog	2017-02-22 21:33:10 UTC (rev 212849)
@@ -1,5 +1,13 @@
 2017-02-22  Alex Christensen  
 
+Re-commit part of r212812 accidentally rolled out with r212841.
+https://bugs.webkit.org/show_bug.cgi?id=167293
+
+* wtf/Platform.h:
+Use libwebrtc on Mac if webrtc is enabled.
+
+2017-02-22  Alex Christensen  
+
 Fix ASAN build after activating libwebrtc.
 
 * wtf/Ref.h:


Modified: trunk/Source/WTF/wtf/Platform.h (212848 => 212849)

--- trunk/Source/WTF/wtf/Platform.h	2017-02-22 20:59:21 UTC (rev 212848)
+++ trunk/Source/WTF/wtf/Platform.h	2017-02-22 21:33:10 UTC (rev 212849)
@@ -1208,4 +1208,8 @@
 #endif
 #endif /* PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201 && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 */
 
+#if PLATFORM(MAC) && ENABLE(WEB_RTC)
+#define USE_LIBWEBRTC 1
+#endif
+
 #endif /* WTF_Platform_h */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212906] trunk/Source/WebCore

2017-02-23 Thread achristensen

Title: [212906] trunk/Source/WebCore








Revision 212906
Author achristen...@apple.com
Date 2017-02-23 11:22:34 -0800 (Thu, 23 Feb 2017)


Log Message
Fix iOS WebRTC build after r212812
https://bugs.webkit.org/show_bug.cgi?id=168790

Reviewed by Tim Horton.

* Configurations/WebCore.xcconfig:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig




Diff

Modified: trunk/Source/WebCore/ChangeLog (212905 => 212906)

--- trunk/Source/WebCore/ChangeLog	2017-02-23 19:04:33 UTC (rev 212905)
+++ trunk/Source/WebCore/ChangeLog	2017-02-23 19:22:34 UTC (rev 212906)
@@ -1,3 +1,12 @@
+2017-02-23  Alex Christensen  
+
+Fix iOS WebRTC build after r212812
+https://bugs.webkit.org/show_bug.cgi?id=168790
+
+Reviewed by Tim Horton.
+
+* Configurations/WebCore.xcconfig:
+
 2017-02-23  Carlos Garcia Campos  
 
 [GStreamer] Several layout tests trigger GStreamer-CRITICAL **: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed


Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (212905 => 212906)

--- trunk/Source/WebCore/Configurations/WebCore.xcconfig	2017-02-23 19:04:33 UTC (rev 212905)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig	2017-02-23 19:22:34 UTC (rev 212906)
@@ -68,7 +68,7 @@
 
 LIBWEBRTC_LDFLAGS = $(LIBWEBRTC_LDFLAGS_$(ENABLE_WEB_RTC));
 LIBWEBRTC_LDFLAGS_ = ;
-LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -weak-lwebrtc;
+LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -framework CoreVideo -weak-lwebrtc;
 
 OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_PLATFORM)
 OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212907] trunk/Websites/webkit.org

2017-02-23 Thread achristensen

Title: [212907] trunk/Websites/webkit.org








Revision 212907
Author achristen...@apple.com
Date 2017-02-23 11:25:10 -0800 (Thu, 23 Feb 2017)


Log Message
Add WebRTC to experimental-features.html
https://bugs.webkit.org/show_bug.cgi?id=168757

Reviewed by Tim Horton.

* experimental-features.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/experimental-features.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (212906 => 212907)

--- trunk/Websites/webkit.org/ChangeLog	2017-02-23 19:22:34 UTC (rev 212906)
+++ trunk/Websites/webkit.org/ChangeLog	2017-02-23 19:25:10 UTC (rev 212907)
@@ -1,3 +1,12 @@
+2017-02-23  Alex Christensen  
+
+Add WebRTC to experimental-features.html
+https://bugs.webkit.org/show_bug.cgi?id=168757
+
+Reviewed by Tim Horton.
+
+* experimental-features.html:
+
 2017-02-23  Jon Davis  
 
 Fixed saving survey data


Modified: trunk/Websites/webkit.org/experimental-features.html (212906 => 212907)

--- trunk/Websites/webkit.org/experimental-features.html	2017-02-23 19:22:34 UTC (rev 212906)
+++ trunk/Websites/webkit.org/experimental-features.html	2017-02-23 19:25:10 UTC (rev 212907)
@@ -87,6 +87,10 @@
 return navigator.getGamepads;
 }
 
+function testWebRTC() {
+return window.RTCPeerConnection;
+}
+
 function testSpringAnimation() {
 return CSS.supports("transition-timing-function", "spring(1 100 10 0)");
 }
@@ -151,6 +155,7 @@
 User Timing
 Web Animations
 WebGL 2.0
+WebRTC
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212927] trunk/Source/WebCore

2017-02-23 Thread achristensen

Title: [212927] trunk/Source/WebCore








Revision 212927
Author achristen...@apple.com
Date 2017-02-23 14:52:55 -0800 (Thu, 23 Feb 2017)


Log Message
Re-soft-link CoreVideo after r212906
https://bugs.webkit.org/show_bug.cgi?id=168803

Reviewed by Jer Noble.

CoreVideo should be soft linked to reduce startup time.
Linking against the framework just for a few symbols used in one file was the wrong solution.

* Configurations/WebCore.xcconfig:
* platform/cocoa/CoreVideoSoftLink.cpp:
* platform/cocoa/CoreVideoSoftLink.h:
* platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp
trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (212926 => 212927)

--- trunk/Source/WebCore/ChangeLog	2017-02-23 22:51:03 UTC (rev 212926)
+++ trunk/Source/WebCore/ChangeLog	2017-02-23 22:52:55 UTC (rev 212927)
@@ -1,3 +1,18 @@
+2017-02-23  Alex Christensen  
+
+Re-soft-link CoreVideo after r212906
+https://bugs.webkit.org/show_bug.cgi?id=168803
+
+Reviewed by Jer Noble.
+
+CoreVideo should be soft linked to reduce startup time.
+Linking against the framework just for a few symbols used in one file was the wrong solution.
+
+* Configurations/WebCore.xcconfig:
+* platform/cocoa/CoreVideoSoftLink.cpp:
+* platform/cocoa/CoreVideoSoftLink.h:
+* platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
+
 2017-02-23  Chris Dumez  
 
 Report domains using abnormally high CPU usage via enhanced privacy logging


Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (212926 => 212927)

--- trunk/Source/WebCore/Configurations/WebCore.xcconfig	2017-02-23 22:51:03 UTC (rev 212926)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig	2017-02-23 22:52:55 UTC (rev 212927)
@@ -68,7 +68,7 @@
 
 LIBWEBRTC_LDFLAGS = $(LIBWEBRTC_LDFLAGS_$(ENABLE_WEB_RTC));
 LIBWEBRTC_LDFLAGS_ = ;
-LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -framework CoreVideo -weak-lwebrtc;
+LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -weak-lwebrtc;
 
 OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_PLATFORM)
 OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE;


Modified: trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp (212926 => 212927)

--- trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp	2017-02-23 22:51:03 UTC (rev 212926)
+++ trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp	2017-02-23 22:52:55 UTC (rev 212927)
@@ -36,6 +36,7 @@
 SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetBytesPerRow, size_t, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
 SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetDataSize, size_t, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
 SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetPixelFormatType, OSType, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
+SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetBaseAddressOfPlane, void *, (CVPixelBufferRef pixelBuffer, size_t planeIndex), (pixelBuffer, planeIndex));
 SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferLockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))
 SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferUnlockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))
 SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreVideo, kCVPixelBufferPixelFormatTypeKey, CFStringRef)


Modified: trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h (212926 => 212927)

--- trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h	2017-02-23 22:51:03 UTC (rev 212926)
+++ trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h	2017-02-23 22:52:55 UTC (rev 212927)
@@ -43,6 +43,8 @@
 #define CVPixelBufferGetDataSize softLink_CoreVideo_CVPixelBufferGetDataSize
 SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferGetPixelFormatType, OSType, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
 #define CVPixelBufferGetPixelFormatType softLink_CoreVideo_CVPixelBufferGetPixelFormatType
+SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferGetBaseAddressOfPlane, void *, (CVPixelBufferRef pixelBuffer, size_t planeIndex), (pixelBuffer, planeIndex));
+#define CVPixelBufferGetBaseAddressOfPlane softLink_CoreVideo_CVPixelBufferGetBaseAddressOfPlane
 SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferLockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))
 #define CVPixelBufferLockBaseAddress softLink_CoreVideo_CVPixelBufferLockBaseAddress
 SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVid

[webkit-changes] [212953] trunk

2017-02-24 Thread achristensen

Title: [212953] trunk








Revision 212953
Author achristen...@apple.com
Date 2017-02-24 08:45:32 -0800 (Fri, 24 Feb 2017)


Log Message
.. should not remove windows drive letters in paths of file URLs
https://bugs.webkit.org/show_bug.cgi?id=168824

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

It's specified in https://url.spec.whatwg.org/#shorten-a-urls-path and helps behavior for browsers on Windows.
It can't hurt to pass a few more web platform tests, though.

* platform/URLParser.cpp:
(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):
* platform/URLParser.h:

LayoutTests:

* fast/url/file-expected.txt:
* fast/url/file-http-base-expected.txt:
* fast/url/relative-win-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/file-expected.txt
trunk/LayoutTests/fast/url/file-http-base-expected.txt
trunk/LayoutTests/fast/url/relative-win-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/platform/URLParser.h




Diff

Modified: trunk/LayoutTests/ChangeLog (212952 => 212953)

--- trunk/LayoutTests/ChangeLog	2017-02-24 13:17:48 UTC (rev 212952)
+++ trunk/LayoutTests/ChangeLog	2017-02-24 16:45:32 UTC (rev 212953)
@@ -1,3 +1,14 @@
+2017-02-24  Alex Christensen  
+
+.. should not remove windows drive letters in paths of file URLs
+https://bugs.webkit.org/show_bug.cgi?id=168824
+
+Reviewed by Youenn Fablet.
+
+* fast/url/file-expected.txt:
+* fast/url/file-http-base-expected.txt:
+* fast/url/relative-win-expected.txt:
+
 2017-02-24  Antti Koivisto  
 
 Reverting https://trac.webkit.org/r212951, landing this doesn't actually work due to Git infrastucture.


Modified: trunk/LayoutTests/fast/url/file-expected.txt (212952 => 212953)

--- trunk/LayoutTests/fast/url/file-expected.txt	2017-02-24 13:17:48 UTC (rev 212952)
+++ trunk/LayoutTests/fast/url/file-expected.txt	2017-02-24 16:45:32 UTC (rev 212953)
@@ -19,7 +19,7 @@
 PASS canonicalize('file:///foo/bar.txt') is 'file:///foo/bar.txt'
 FAIL canonicalize('FILE:/\\/\\7://foo\\bar.html') should be file://7:foo/bar.html. Was file:7:foo/bar.html.
 FAIL canonicalize('file:filer/home\\me') should be file://filer/home/me. Was file:///tmp/mock/filer/home/me.
-FAIL canonicalize('file:///C:/foo/../../../bar.html') should be file:///C:/bar.html. Was file:///bar.html.
+PASS canonicalize('file:///C:/foo/../../../bar.html') is 'file:///C:/bar.html'
 FAIL canonicalize('file:///C:/asdf#\xc2') should be file:///C:/asdf#ï¿½. Was file:///C:/asdf#%C3%82.
 PASS canonicalize('file:///home/me') is 'file:///home/me'
 PASS canonicalize('file:c:\\foo\\bar.html') is 'file:///c:/foo/bar.html'


Modified: trunk/LayoutTests/fast/url/file-http-base-expected.txt (212952 => 212953)

--- trunk/LayoutTests/fast/url/file-http-base-expected.txt	2017-02-24 13:17:48 UTC (rev 212952)
+++ trunk/LayoutTests/fast/url/file-http-base-expected.txt	2017-02-24 16:45:32 UTC (rev 212953)
@@ -19,7 +19,7 @@
 PASS canonicalize('file:///foo/bar.txt') is 'file:///foo/bar.txt'
 FAIL canonicalize('FILE:/\\/\\7://foo\\bar.html') should be file://7:foo/bar.html. Was file:7:foo/bar.html.
 FAIL canonicalize('file:filer/home\\me') should be file://filer/home/me. Was file:///filer/home/me.
-FAIL canonicalize('file:///C:/foo/../../../bar.html') should be file:///C:/bar.html. Was file:///bar.html.
+PASS canonicalize('file:///C:/foo/../../../bar.html') is 'file:///C:/bar.html'
 FAIL canonicalize('file:///C:/asdf#\xc2') should be file:///C:/asdf#Â. Was file:///C:/asdf#%C3%82.
 FAIL canonicalize('file:///C:/asdf#Â') should be file:///C:/asdf#Â. Was file:///C:/asdf#%C3%82.
 PASS canonicalize('file:///home/me') is 'file:///home/me'


Modified: trunk/LayoutTests/fast/url/relative-win-expected.txt (212952 => 212953)

--- trunk/LayoutTests/fast/url/relative-win-expected.txt	2017-02-24 13:17:48 UTC (rev 212952)
+++ trunk/LayoutTests/fast/url/relative-win-expected.txt	2017-02-24 16:45:32 UTC (rev 212953)
@@ -5,7 +5,7 @@
 
 PASS canonicalize('http://host/') is 'http://host/'
 PASS canonicalize('bar') is 'file:///C:/bar'
-FAIL canonicalize('../../../bar.html') should be file:///C:/bar.html. Was file:///bar.html.
+PASS canonicalize('../../../bar.html') is 'file:///C:/bar.html'
 FAIL canonicalize('/../bar.html') should be file:///C:/bar.html. Was file:///bar.html.
 FAIL canonicalize('another\\path') should be . Was http

[webkit-changes] [212971] trunk/Source/ThirdParty/libwebrtc

2017-02-24 Thread achristensen

Title: [212971] trunk/Source/ThirdParty/libwebrtc








Revision 212971
Author achristen...@apple.com
Date 2017-02-24 15:16:10 -0800 (Fri, 24 Feb 2017)


Log Message
Remove unneeded protobuf tests directory.

Rubber-stamped by Joe Pecoraro.

This directory contained a swift file that was causing problems in an internal verification step.

* Source/third_party/protobuf/objectivec/Tests: Removed.
(And everything in this subdirectory)

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog


Removed Paths

trunk/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/objectivec/Tests/




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (212970 => 212971)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-24 22:50:00 UTC (rev 212970)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-24 23:16:10 UTC (rev 212971)
@@ -1,3 +1,14 @@
+2017-02-24  Alex Christensen  
+
+Remove unneeded protobuf tests directory.
+
+Rubber-stamped by Joe Pecoraro.
+
+This directory contained a swift file that was causing problems in an internal verification step.
+
+* Source/third_party/protobuf/objectivec/Tests: Removed.
+(And everything in this subdirectory)
+
 2017-02-22  Youenn Fablet  
 
 [WebRTC] Disable libwebrtc stderr logging in release mode






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [212977] trunk

2017-02-24 Thread achristensen

Title: [212977] trunk








Revision 212977
Author achristen...@apple.com
Date 2017-02-24 16:36:19 -0800 (Fri, 24 Feb 2017)


Log Message
Non-special relative URLs should not ignore extra slashes
https://bugs.webkit.org/show_bug.cgi?id=168834

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Special authority ignore slashes state should, as its name implies,
only be reached by special URLs.  See https://url.spec.whatwg.org/#relative-slash-state

Covered by newly passing web platform tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212976 => 212977)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-25 00:20:12 UTC (rev 212976)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-02-25 00:36:19 UTC (rev 212977)
@@ -1,5 +1,16 @@
 2017-02-24  Alex Christensen  
 
+Non-special relative URLs should not ignore extra slashes
+https://bugs.webkit.org/show_bug.cgi?id=168834
+
+Reviewed by Sam Weinig.
+
+* web-platform-tests/url/a-element-expected.txt:
+* web-platform-tests/url/a-element-xhtml-expected.txt:
+* web-platform-tests/url/url-constructor-expected.txt:
+
+2017-02-24  Alex Christensen  
+
 .. should not remove windows drive letters in paths of file URLs
 https://bugs.webkit.org/show_bug.cgi?id=168824
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (212976 => 212977)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt	2017-02-25 00:20:12 UTC (rev 212976)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt	2017-02-25 00:36:19 UTC (rev 212977)
@@ -403,9 +403,9 @@
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: href expected "sc:///" but got "///"
-FAIL Parsing:  against  assert_equals: href expected "sc:" but got ""
-FAIL Parsing:  against  assert_equals: href expected "sc:x/" but got "sc://x/"
+PASS Parsing:  against  
+PASS Parsing:  against  
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt (212976 => 212977)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt	2017-02-25 00:20:12 UTC (rev 212976)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt	2017-02-25 00:36:19 UTC (rev 212977)
@@ -403,9 +403,9 @@
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: href expected "sc:///" but got "///"
-FAIL Parsing:  against  assert_equals: href expected "sc:" but got ""
-FAIL Parsing:  against  assert_equals: href expected "sc:x/" but got "sc://x/"
+PASS Parsing:  against  
+PASS Parsing:  against  
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt (212976 => 212977)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt	2017-02-25 00:20:12 UTC (rev 212976)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt	2017-02-25 00:36:19 UTC (rev 212977)
@@ -411,9 +411,9 @@
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  Type error
-FAIL Parsing:  against  Type error
-FAIL Parsing:  against  assert_equals: href expected "sc:x/" but got "sc://x/"
+PASS Parsing:  against  
+PASS Parsing:  against  
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  


Modified: trunk/Source/WebCore/ChangeLog (212976 => 212977)

--- trunk/Source/WebCore/ChangeLog	2017-02-25 00:20:12 UTC (rev 212976)
+++ trunk/Source/WebCore/ChangeLog	2017-02-25 00:36:19 UTC (rev 212977)
@@ -1,3 +1,18 @@
+2017-02-24  Alex Christensen  
+
+Non-special relative URLs should not ignore extra slashes
+https://bugs.webkit.org/show_bug.cgi?id=168834
+
+Reviewed by Sam Weinig.
+
+Special authority ignore slashes state should, as its name implies,
+only be reached by special URLs.  See https://url.spec.whatwg.org/#relative-slash-state
+
+Covered

[webkit-changes] [213054] trunk

2017-02-27 Thread achristensen

Title: [213054] trunk








Revision 213054
Author achristen...@apple.com
Date 2017-02-27 06:09:50 -0800 (Mon, 27 Feb 2017)


Log Message
[libwebrtc] Enable WebRTC in some Production Builds
https://bugs.webkit.org/show_bug.cgi?id=168858

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213053 => 213054)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-27 14:09:50 UTC (rev 213054)
@@ -1,3 +1,10 @@
+2017-02-27  Alex Christensen  
+
+[libwebrtc] Enable WebRTC in some Production Builds
+https://bugs.webkit.org/show_bug.cgi?id=168858
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-26  Caio Lima  
 
 op_get_by_id_with_this should use inline caching


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213053 => 213054)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-02-27 14:09:50 UTC (rev 213054)
@@ -164,13 +164,12 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
-ENABLE_WEB_RTC = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
-ENABLE_WEB_RTC_macosx = ;
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
-ENABLE_WEB_RTC_macosx_Production = ;
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC;
 
 ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API;
 


Modified: trunk/Source/WebCore/ChangeLog (213053 => 213054)

--- trunk/Source/WebCore/ChangeLog	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/WebCore/ChangeLog	2017-02-27 14:09:50 UTC (rev 213054)
@@ -1,3 +1,10 @@
+2017-02-27  Alex Christensen  
+
+[libwebrtc] Enable WebRTC in some Production Builds
+https://bugs.webkit.org/show_bug.cgi?id=168858
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-27  Zan Dobersek  
 
 [TextureMapper] Clean up BitmapTextureGL construction


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213053 => 213054)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-02-27 14:09:50 UTC (rev 213054)
@@ -164,13 +164,12 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
-ENABLE_WEB_RTC = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
-ENABLE_WEB_RTC_macosx = ;
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
-ENABLE_WEB_RTC_macosx_Production = ;
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC;
 
 ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API;
 


Modified: trunk/Source/WebCore/PAL/ChangeLog (213053 => 213054)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-02-27 14:09:50 UTC (rev 213054)
@@ -1,3 +1,10 @@
+2017-02-27  Alex Christensen  
+
+[libwebrtc] Enable WebRTC in some Production Builds
+https://bugs.webkit.org/show_bug.cgi?id=168858
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-21  Youenn Fablet  
 
 [WebRTC][Mac] Activate libwebrtc


Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (213053 => 213054)

--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-02-27 13:59:12 UTC (rev 213053)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-02-

[webkit-changes] [213074] trunk/Source/WebKit2

2017-02-27 Thread achristensen

Title: [213074] trunk/Source/WebKit2








Revision 213074
Author achristen...@apple.com
Date 2017-02-27 09:21:55 -0800 (Mon, 27 Feb 2017)


Log Message
Optimize checkWebRTCAvailability
https://bugs.webkit.org/show_bug.cgi?id=168913

Reviewed by Darin Adler.

We can optimize startup time by using RTLD_LAZY instead of RTLD_NOW because we don't need to load all the symbols.
We just need to check whether libwebrtc.dylib can be found and is a valid dylib for the current architecture.
Also, initialize a static bool so it only needs to be checked once.  Right now it's only used when initializing settings,
but if we use it for other things in the future there will be no need to reopen the dylib.

* UIProcess/WebPreferences.cpp:
(WebKit::checkWebRTCAvailability):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (213073 => 213074)

--- trunk/Source/WebKit2/ChangeLog	2017-02-27 17:20:29 UTC (rev 213073)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-27 17:21:55 UTC (rev 213074)
@@ -1,3 +1,18 @@
+2017-02-27  Alex Christensen  
+
+Optimize checkWebRTCAvailability
+https://bugs.webkit.org/show_bug.cgi?id=168913
+
+Reviewed by Darin Adler.
+
+We can optimize startup time by using RTLD_LAZY instead of RTLD_NOW because we don't need to load all the symbols.
+We just need to check whether libwebrtc.dylib can be found and is a valid dylib for the current architecture.
+Also, initialize a static bool so it only needs to be checked once.  Right now it's only used when initializing settings,
+but if we use it for other things in the future there will be no need to reopen the dylib.
+
+* UIProcess/WebPreferences.cpp:
+(WebKit::checkWebRTCAvailability):
+
 2017-02-26  Wenson Hsieh  
 
 Unreviewed, revert all temporary build fixes for data interaction


Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.cpp (213073 => 213074)

--- trunk/Source/WebKit2/UIProcess/WebPreferences.cpp	2017-02-27 17:20:29 UTC (rev 213073)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.cpp	2017-02-27 17:21:55 UTC (rev 213074)
@@ -199,11 +199,14 @@
 bool checkWebRTCAvailability()
 {
 #if USE(LIBWEBRTC)
-void* libwebrtcLibrary = dlopen("libwebrtc.dylib", RTLD_NOW);
-if (!libwebrtcLibrary)
-return false;
-dlclose(libwebrtcLibrary);
-return true;
+static bool available = [&] {
+void* libwebrtcLibrary = dlopen("libwebrtc.dylib", RTLD_LAZY);
+if (!libwebrtcLibrary)
+return false;
+dlclose(libwebrtcLibrary);
+return true;
+}();
+return available;
 #else
 return true;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213123] trunk

2017-02-27 Thread achristensen

Title: [213123] trunk








Revision 213123
Author achristen...@apple.com
Date 2017-02-27 23:11:13 -0800 (Mon, 27 Feb 2017)


Log Message
Begin enabling WebRTC on 64-bit
https://bugs.webkit.org/show_bug.cgi?id=168915

Reviewed by Eric Carlson.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213122 => 213123)

--- trunk/Source/_javascript_Core/ChangeLog	2017-02-28 05:01:45 UTC (rev 213122)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-28 07:11:13 UTC (rev 213123)
@@ -1,3 +1,12 @@
+2017-02-27  Alex Christensen  
+
+Begin enabling WebRTC on 64-bit
+https://bugs.webkit.org/show_bug.cgi?id=168915
+
+Reviewed by Eric Carlson.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-27  Mark Lam  
 
 Introduce a VM Traps mechanism and refactor Watchdog to use it.


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213122 => 213123)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-02-28 05:01:45 UTC (rev 213122)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-02-28 07:11:13 UTC (rev 213123)
@@ -164,6 +164,12 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
+ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/ChangeLog (213122 => 213123)

--- trunk/Source/WebCore/ChangeLog	2017-02-28 05:01:45 UTC (rev 213122)
+++ trunk/Source/WebCore/ChangeLog	2017-02-28 07:11:13 UTC (rev 213123)
@@ -1,3 +1,12 @@
+2017-02-27  Alex Christensen  
+
+Begin enabling WebRTC on 64-bit
+https://bugs.webkit.org/show_bug.cgi?id=168915
+
+Reviewed by Eric Carlson.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-27  Antoine Quint  
 
 [Modern Media Controls] Use compact mode by default on macOS


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213122 => 213123)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-02-28 05:01:45 UTC (rev 213122)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-02-28 07:11:13 UTC (rev 213123)
@@ -164,6 +164,12 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
+ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/PAL/ChangeLog (213122 => 213123)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-02-28 05:01:45 UTC (rev 213122)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-02-28 07:11:13 UTC (rev 213123)
@@ -1,5 +1,14 @@
 2017-02-27  Alex Christensen  
 
+Begin enabling WebRTC on 64-bit
+https://bugs.webkit.org/show_bug.cgi?id=168915
+
+Reviewed by Eric Carlson.
+
+* Configurations/FeatureDefines.xcconfig:
+
+2017-02-27  Alex Christensen  
+
 [libwebrtc] Enable WebRTC in some Production Builds
 https://bugs.webkit.org

[webkit-changes] [213124] trunk/Source/WebCore

2017-02-27 Thread achristensen

Title: [213124] trunk/Source/WebCore








Revision 213124
Author achristen...@apple.com
Date 2017-02-27 23:39:59 -0800 (Mon, 27 Feb 2017)


Log Message
Fix WinCairo build.

* PlatformWinCairo.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWinCairo.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (213123 => 213124)

--- trunk/Source/WebCore/ChangeLog	2017-02-28 07:11:13 UTC (rev 213123)
+++ trunk/Source/WebCore/ChangeLog	2017-02-28 07:39:59 UTC (rev 213124)
@@ -1,5 +1,11 @@
 2017-02-27  Alex Christensen  
 
+Fix WinCairo build.
+
+* PlatformWinCairo.cmake:
+
+2017-02-27  Alex Christensen  
+
 Begin enabling WebRTC on 64-bit
 https://bugs.webkit.org/show_bug.cgi?id=168915
 


Modified: trunk/Source/WebCore/PlatformWinCairo.cmake (213123 => 213124)

--- trunk/Source/WebCore/PlatformWinCairo.cmake	2017-02-28 07:11:13 UTC (rev 213123)
+++ trunk/Source/WebCore/PlatformWinCairo.cmake	2017-02-28 07:39:59 UTC (rev 213124)
@@ -37,6 +37,8 @@
 platform/graphics/cairo/RefPtrCairo.cpp
 platform/graphics/cairo/TransformationMatrixCairo.cpp
 
+platform/graphics/texmap/TextureMapperTiledBackingStore.cpp
+
 platform/graphics/win/FontCustomPlatformDataCairo.cpp
 platform/graphics/win/FontPlatformDataCairoWin.cpp
 platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213125] trunk

2017-02-28 Thread achristensen

Title: [213125] trunk








Revision 213125
Author achristen...@apple.com
Date 2017-02-28 00:28:33 -0800 (Tue, 28 Feb 2017)


Log Message
REGRESSION: LayoutTest http/tests/security/credentials-iframes.html is failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=167967

Reviewed by Brady Eidson.

Source/WebCore:

XHR credentials have a persistence of CredentialPersistenceNone because we keep
them in the WebCore::CredentialStorage.  We were storing them to CFNetwork's NSURLCredentialStorage
on iOS and then they were being given as the proposedCredential in
NetworkDataTaskCocoa::tryPasswordBasedAuthentication even though we set CredentialPersistenceNone.

This fixes http/tests/security/credentials-iframes.html

* platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
* platform/network/CredentialStorage.h:
* platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::saveToPersistentStorage): Deleted.
* platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::saveToPersistentStorage): Deleted.

LayoutTests:

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/CredentialStorage.cpp
trunk/Source/WebCore/platform/network/CredentialStorage.h
trunk/Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp
trunk/Source/WebCore/platform/network/mac/CredentialStorageMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (213124 => 213125)

--- trunk/LayoutTests/ChangeLog	2017-02-28 07:39:59 UTC (rev 213124)
+++ trunk/LayoutTests/ChangeLog	2017-02-28 08:28:33 UTC (rev 213125)
@@ -1,3 +1,12 @@
+2017-02-28  Alex Christensen  
+
+REGRESSION: LayoutTest http/tests/security/credentials-iframes.html is failing on ios-simulator
+https://bugs.webkit.org/show_bug.cgi?id=167967
+
+Reviewed by Brady Eidson.
+
+* platform/ios-simulator/TestExpectations:
+
 2017-02-27  Antoine Quint  
 
 [Modern Media Controls] Use compact mode by default on macOS


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (213124 => 213125)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-28 07:39:59 UTC (rev 213124)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-02-28 08:28:33 UTC (rev 213125)
@@ -2869,8 +2869,6 @@
 
 webkit.org/b/167619 css3/filters/backdrop/dynamic-with-clip-path.html [ ImageOnlyFailure ]
 
-webkit.org/b/167967 http/tests/security/credentials-iframes.html [ Failure ]
-
 webkit.org/b/168054 compositing/masks/solid-color-masked.html [ ImageOnlyFailure ]
 
 webkit.org/b/168215 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Skip ]


Modified: trunk/Source/WebCore/ChangeLog (213124 => 213125)

--- trunk/Source/WebCore/ChangeLog	2017-02-28 07:39:59 UTC (rev 213124)
+++ trunk/Source/WebCore/ChangeLog	2017-02-28 08:28:33 UTC (rev 213125)
@@ -1,3 +1,25 @@
+2017-02-28  Alex Christensen  
+
+REGRESSION: LayoutTest http/tests/security/credentials-iframes.html is failing on ios-simulator
+https://bugs.webkit.org/show_bug.cgi?id=167967
+
+Reviewed by Brady Eidson.
+
+XHR credentials have a persistence of CredentialPersistenceNone because we keep
+them in the WebCore::CredentialStorage.  We were storing them to CFNetwork's NSURLCredentialStorage
+on iOS and then they were being given as the proposedCredential in
+NetworkDataTaskCocoa::tryPasswordBasedAuthentication even though we set CredentialPersistenceNone.
+
+This fixes http/tests/security/credentials-iframes.html
+
+* platform/network/CredentialStorage.cpp:
+(WebCore::CredentialStorage::set):
+* platform/network/CredentialStorage.h:
+* platform/network/cf/CredentialStorageCFNet.cpp:
+(WebCore::CredentialStorage::saveToPersistentStorage): Deleted.
+* platform/network/mac/CredentialStorageMac.mm:
+(WebCore::CredentialStorage::saveToPersistentStorage): Deleted.
+
 2017-02-27  Alex Christensen  
 
 Fix WinCairo build.


Modified: trunk/Source/WebCore/platform/network/CredentialStorage.cpp (213124 => 213125)

--- trunk/Source/WebCore/platform/network/CredentialStorage.cpp	2017-02-28 07:39:59 UTC (rev 213124)
+++ trunk/Source/WebCore/platform/network/CredentialStorage.cpp	2017-02-28 08:28:33 UTC (rev 213125)
@@ -70,11 +70,6 @@
 
 m_protectionSpaceToCredentialMap.set(std::make_pair(partitionName, protectionSpace), credential);
 
-#if PLATFORM(IOS)
-if (protectionSpace.authenticationScheme() != ProtectionSpaceAuthenticationSchemeClientCertificateRequested)
-saveToPersistentStorage(protectionSpace, credential);
-#endif
-
 if (!protectionSpace.isProxy() && protectionSpace.authenticationScheme() != ProtectionSpaceAuthenticationSchemeClientCertificateRequested) {
 m

[webkit-changes] [213126] trunk

2017-02-28 Thread achristensen

Title: [213126] trunk








Revision 213126
Author achristen...@apple.com
Date 2017-02-28 00:30:44 -0800 (Tue, 28 Feb 2017)


Log Message
Main resource requests need cachePartition
https://bugs.webkit.org/show_bug.cgi?id=168806
Source/WebCore:



Reviewed by Brady Eidson.

Test: http/tests/security/credentials-main-resource.html

r211751 caused an unintended regression on pages whose main resource is protected
by basic authentication.  We were not setting the cache partition for main resource
requests, and we use the cache partition now for credentials, so the credentials for
the main resource were not being put into a partition in the CredentialStorage that
would not be used for subresources of the page, whose requests had the correct partition
for the domain of the page.  This caused users to have to enter their credentials twice,
once for the main resource and once for any subresources.  This is fixed by using the
domain from the main resource request as the cache partition.  Elsewhere the Document is
used to get the cache partition, but there is no Document yet when requesting the main resource.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
Set the cache partition for the main resource loads based on the SecurityOrigin of the
initial request if we are loading the main resource for a new top document.  If the main resource
request is redirected, then we will still use the partition of the initial request because that is
what the user requested and that is where the user entered the credentials.
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setDomainForCachePartition):
* loader/cache/CachedResourceRequest.h:

Source/WebKit2:


Reviewed by Brady Eidson.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):

LayoutTests:


Reviewed by Brady Eidson.

* http/tests/security/credentials-main-resource-expected.txt: Added.
* http/tests/security/credentials-main-resource.html: Added.
* http/tests/security/resources/credentials-main-resource.php: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequest.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp


Added Paths

trunk/LayoutTests/http/tests/security/credentials-main-resource-expected.txt
trunk/LayoutTests/http/tests/security/credentials-main-resource.html
trunk/LayoutTests/http/tests/security/resources/credentials-main-resource.php




Diff

Modified: trunk/LayoutTests/ChangeLog (213125 => 213126)

--- trunk/LayoutTests/ChangeLog	2017-02-28 08:28:33 UTC (rev 213125)
+++ trunk/LayoutTests/ChangeLog	2017-02-28 08:30:44 UTC (rev 213126)
@@ -1,5 +1,16 @@
 2017-02-28  Alex Christensen  
 
+Main resource requests need cachePartition
+https://bugs.webkit.org/show_bug.cgi?id=168806
+
+Reviewed by Brady Eidson.
+
+* http/tests/security/credentials-main-resource-expected.txt: Added.
+* http/tests/security/credentials-main-resource.html: Added.
+* http/tests/security/resources/credentials-main-resource.php: Added.
+
+2017-02-28  Alex Christensen  
+
 REGRESSION: LayoutTest http/tests/security/credentials-iframes.html is failing on ios-simulator
 https://bugs.webkit.org/show_bug.cgi?id=167967
 


Added: trunk/LayoutTests/http/tests/security/credentials-main-resource-expected.txt (0 => 213126)

--- trunk/LayoutTests/http/tests/security/credentials-main-resource-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/credentials-main-resource-expected.txt	2017-02-28 08:30:44 UTC (rev 213126)
@@ -0,0 +1,3 @@
+ALERT: Authenticated as user: testuser password: testpass
+Main Resource Credentials: testuser, testpass
+


Added: trunk/LayoutTests/http/tests/security/credentials-main-resource.html (0 => 213126)

--- trunk/LayoutTests/http/tests/security/credentials-main-resource.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/credentials-main-resource.html	2017-02-28 08:30:44 UTC (rev 213126)
@@ -0,0 +1,8 @@
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+internals.settings.setStorageBlockingPolicy('BlockThirdParty');
+}
+window.location = "http://testuser:testpass@127.0.0.1:8000/security/resources/credentials-main-resource.php";
+


Added: trunk/LayoutTests/http/tests/security/resources/credentials-main-resource.php (0 => 213126)

--- trunk/LayoutTests/http/tests/security/resources/credentials-main-resource.php	(rev 0)
+++ trunk/LayoutTests/http/tests/security/resources/credentials-main-resource.php	2017-02-28 08:30:44 UTC (rev 213126)
@@ -0,0 +1,2

[webkit-changes] [213180] trunk/Source/ThirdParty/libwebrtc

2017-02-28 Thread achristensen

Title: [213180] trunk/Source/ThirdParty/libwebrtc








Revision 213180
Author achristen...@apple.com
Date 2017-02-28 15:05:13 -0800 (Tue, 28 Feb 2017)


Log Message
[WebRTC] Fix an internal production build
https://bugs.webkit.org/show_bug.cgi?id=168992

Reviewed by Youenn Fablet.

* libwebrtc.xcodeproj/project.pbxproj:
Link with Foundation and CoreFoundation frameworks.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (213179 => 213180)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-28 23:02:23 UTC (rev 213179)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-02-28 23:05:13 UTC (rev 213180)
@@ -1,3 +1,13 @@
+2017-02-28  Alex Christensen  
+
+[WebRTC] Fix an internal production build
+https://bugs.webkit.org/show_bug.cgi?id=168992
+
+Reviewed by Youenn Fablet.
+
+* libwebrtc.xcodeproj/project.pbxproj:
+Link with Foundation and CoreFoundation frameworks.
+
 2017-02-28  Youenn Fablet  
 
 [WebRTC] LibWebRTC frame dropper is not working consistently


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (213179 => 213180)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-28 23:02:23 UTC (rev 213179)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-02-28 23:05:13 UTC (rev 213180)
@@ -169,6 +169,8 @@
 		5C11A0201E457578004F0987 /* file_audio_device_factory.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C11A01A1E457578004F0987 /* file_audio_device_factory.h */; };
 		5C11A0211E457578004F0987 /* file_audio_device.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5C11A01B1E457578004F0987 /* file_audio_device.cc */; };
 		5C11A0221E457578004F0987 /* file_audio_device.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C11A01C1E457578004F0987 /* file_audio_device.h */; };
+		5C316D891E66323F008BE64D /* CoreFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5C316D881E66323F008BE64D /* CoreFoundation.framework */; };
+		5C316D8B1E66333C008BE64D /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5C316D8A1E66333C008BE64D /* Foundation.framework */; };
 		5C4B463A1E42AA2C002651C8 /* constant_time_test.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B451C1E42A71B002651C8 /* constant_time_test.c */; };
 		5C4B463B1E42AA2C002651C8 /* cpu-intel.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B451D1E42A71B002651C8 /* cpu-intel.c */; };
 		5C4B463C1E42AA2C002651C8 /* crypto.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B451E1E42A71B002651C8 /* crypto.c */; };
@@ -2740,6 +2742,8 @@
 		5C11A01C1E457578004F0987 /* file_audio_device.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = file_audio_device.h; path = dummy/file_audio_device.h; sourceTree = ""; };
 		5C11A0331E4576A9004F0987 /* usrsctp.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = usrsctp.xcconfig; sourceTree = ""; };
 		5C11A12D1E4577E1004F0987 /* libusrsctp.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libusrsctp.a; sourceTree = BUILT_PRODUCTS_DIR; };
+		5C316D881E66323F008BE64D /* CoreFoundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreFoundation.framework; path = System/Library/Frameworks/CoreFoundation.framework; sourceTree = SDKROOT; };
+		5C316D8A1E66333C008BE64D /* Foundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Foundation.framework; path = System/Library/Frameworks/Foundation.framework; sourceTree = SDKROOT; };
 		5C4B43B01E42877A002651C8 /* boringssl.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = boringssl.xcconfig; sourceTree = ""; };
 		5C4B43B21E42A49E002651C8 /* a_bitstr.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = a_bitstr.c; sourceTree = ""; };
 		5C4B43B31E42A49E002651C8 /* a_bool.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = a_bool.c; sourceTree = ""; };
@@ -5138,6 +5142,8 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+5C316D8B1E66333C008BE64D /* Foundation.framework in Frameworks */,
+5C316D891E66323F008BE64D /* CoreFoundation.framework in Frameworks */,
 5C85C4CB1E5780DD00D097B1 /* CFNetwork.framework in Frameworks */,
 5C0073461E552CA20042215A /* SystemConfiguration.framework in Frameworks */,
 5C0073431E552C800042215A /* CoreGraphics.framework in Frameworks */,
@@ -7196,6 +7202,8 @@
 		5CB3048A1DE4143400D2C405 /* Frameworks */ = {
 			isa = PBXGroup;
 			children = (
+5C316D8A1E66333C008BE64D /* Foundation.framework */,
+5C316D881E66323F008BE64D /* CoreFo

[webkit-changes] [213190] trunk/Source

2017-02-28 Thread achristensen

Title: [213190] trunk/Source








Revision 213190
Author achristen...@apple.com
Date 2017-02-28 16:07:23 -0800 (Tue, 28 Feb 2017)


Log Message
LibWebRTCProvider should check existence of libwebrtc.dylib
https://bugs.webkit.org/show_bug.cgi?id=168986
Source/WebCore:



Reviewed by Youenn Fablet.

Some configurations of the webrtc tests overwrite the availability of WebRTC in order to test it
with MockLibWebRTCPeerConnection.  If the dylib can not be found, we can't use it, so we want to
fail these tests rather than crashing calling rtc::LogMessage::LogToDebug.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::factory):
(WebCore::LibWebRTCProvider::webRTCAvailable):
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:
* testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::useMockRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):

Source/WebKit2:


Reviewed by Youenn Fablet.

* Shared/WebPreferencesDefinitions.h:
* Shared/WebPreferencesStore.cpp:
* UIProcess/WebPreferences.cpp:
(WebKit::checkWebRTCAvailability): Deleted.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (213189 => 213190)

--- trunk/Source/WebCore/CMakeLists.txt	2017-03-01 00:01:57 UTC (rev 213189)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-03-01 00:07:23 UTC (rev 213190)
@@ -2300,6 +2300,8 @@
 platform/mediastream/RealtimeMediaSourceSettings.cpp
 platform/mediastream/SDPProcessorScriptResource.cpp
 
+platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
+
 platform/mock/DeviceOrientationClientMock.cpp
 platform/mock/GeolocationClientMock.cpp
 platform/mock/MockMediaEndpoint.cpp


Modified: trunk/Source/WebCore/ChangeLog (213189 => 213190)

--- trunk/Source/WebCore/ChangeLog	2017-03-01 00:01:57 UTC (rev 213189)
+++ trunk/Source/WebCore/ChangeLog	2017-03-01 00:07:23 UTC (rev 213190)
@@ -1,3 +1,26 @@
+2017-02-28  Alex Christensen  
+
+LibWebRTCProvider should check existence of libwebrtc.dylib
+https://bugs.webkit.org/show_bug.cgi?id=168986
+
+
+Reviewed by Youenn Fablet.
+
+Some configurations of the webrtc tests overwrite the availability of WebRTC in order to test it
+with MockLibWebRTCPeerConnection.  If the dylib can not be found, we can't use it, so we want to
+fail these tests rather than crashing calling rtc::LogMessage::LogToDebug.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
+(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
+* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+(WebCore::LibWebRTCProvider::factory):
+(WebCore::LibWebRTCProvider::webRTCAvailable):
+* platform/mediastream/libwebrtc/LibWebRTCProvider.h:
+* testing/MockLibWebRTCPeerConnection.cpp:
+(WebCore::useMockRTCPeerConnectionFactory):
+(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):
+
 2017-02-28  Tim Horton  
 
 Apply a review comment that was missing in r213182


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (213189 => 213190)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2017-03-01 00:01:57 UTC (rev 213189)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2017-03-01 00:07:23 UTC (rev 213190)
@@ -155,11 +155,16 @@
 
 void LibWebRTCMediaEndpoint::doCreateOffer()
 {
+if (!LibWebRTCProvider::factory()) {
+m_peerConnectionBackend.createOfferFailed(Exception { NOT_SUPPORTED_ERR, ASCIILiteral("libwebrtc backend is missing.") });
+return;
+}
+
 m_isInitiator = true;
 auto& senders = m_peerConnectionBackend.connection().getSenders();
 if (senders.size()) {
 // FIXME: We only support one stream for the moment.
-auto stream = LibWebRTCProvider::factory().CreateLocalMediaStream(streamId(m_peerConnectionBackend.connection()));
+auto stream = LibWebRTCProvider::factory()->CreateLocalMediaStream(streamId(m_peerConnectionBackend.connection()));
 for (RTCRtpSender& sender : senders) {
 auto* track = sender.track();
 if

[webkit-changes] [213234] trunk/Source/WebCore

2017-03-01 Thread achristensen

Title: [213234] trunk/Source/WebCore








Revision 213234
Author achristen...@apple.com
Date 2017-03-01 11:30:29 -0800 (Wed, 01 Mar 2017)


Log Message
Don't call libwebrtc functions if libwebrtc.dylib doesn't exist while testing
https://bugs.webkit.org/show_bug.cgi?id=169045


Reviewed by Youenn Fablet.

WebRTC tests fail instead of crashing now if libwebrtc.dylib is missing.
All other tests pass instead of crashing immediately when creating an Internals object.

* Modules/mediastream/RTCController.cpp:
(WebCore::RTCController::disableICECandidateFiltering):
(WebCore::RTCController::enableICECandidateFiltering):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::createLibWebRTCPeerConnectionBackend):
* testing/Internals.cpp:
(WebCore::Internals::enableMockMediaEndpoint):
(WebCore::Internals::emulateRTCPeerConnectionPlatformEvent):
(WebCore::Internals::useMockRTCPeerConnectionFactory):
* testing/Internals.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCController.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (213233 => 213234)

--- trunk/Source/WebCore/ChangeLog	2017-03-01 19:13:37 UTC (rev 213233)
+++ trunk/Source/WebCore/ChangeLog	2017-03-01 19:30:29 UTC (rev 213234)
@@ -1,3 +1,25 @@
+2017-03-01  Alex Christensen  
+
+Don't call libwebrtc functions if libwebrtc.dylib doesn't exist while testing
+https://bugs.webkit.org/show_bug.cgi?id=169045
+
+
+Reviewed by Youenn Fablet.
+
+WebRTC tests fail instead of crashing now if libwebrtc.dylib is missing.
+All other tests pass instead of crashing immediately when creating an Internals object.
+
+* Modules/mediastream/RTCController.cpp:
+(WebCore::RTCController::disableICECandidateFiltering):
+(WebCore::RTCController::enableICECandidateFiltering):
+* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+(WebCore::createLibWebRTCPeerConnectionBackend):
+* testing/Internals.cpp:
+(WebCore::Internals::enableMockMediaEndpoint):
+(WebCore::Internals::emulateRTCPeerConnectionPlatformEvent):
+(WebCore::Internals::useMockRTCPeerConnectionFactory):
+* testing/Internals.h:
+
 2017-03-01  Javier Fernandez  
 
 [css-align] Implement the place-content shorthand


Modified: trunk/Source/WebCore/Modules/mediastream/RTCController.cpp (213233 => 213234)

--- trunk/Source/WebCore/Modules/mediastream/RTCController.cpp	2017-03-01 19:13:37 UTC (rev 213233)
+++ trunk/Source/WebCore/Modules/mediastream/RTCController.cpp	2017-03-01 19:30:29 UTC (rev 213234)
@@ -27,6 +27,7 @@
 
 #if ENABLE(WEB_RTC)
 
+#include "LibWebRTCProvider.h"
 #include "RTCPeerConnection.h"
 
 namespace WebCore {
@@ -47,6 +48,9 @@
 
 void RTCController::disableICECandidateFiltering()
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return;
+
 m_shouldFilterICECandidates = false;
 for (RTCPeerConnection& connection : m_peerConnections)
 connection.disableICECandidateFiltering();
@@ -54,6 +58,9 @@
 
 void RTCController::enableICECandidateFiltering()
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return;
+
 m_shouldFilterICECandidates = true;
 for (RTCPeerConnection& connection : m_peerConnections)
 connection.enableICECandidateFiltering();


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (213233 => 213234)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-03-01 19:13:37 UTC (rev 213233)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-03-01 19:30:29 UTC (rev 213234)
@@ -45,6 +45,8 @@
 
 static std::unique_ptr createLibWebRTCPeerConnectionBackend(RTCPeerConnection& peerConnection)
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return nullptr;
 return std::make_unique(peerConnection);
 }
 


Modified: trunk/Source/WebCore/testing/Internals.cpp (213233 => 213234)

--- trunk/Source/WebCore/testing/Internals.cpp	2017-03-01 19:13:37 UTC (rev 213233)
+++ trunk/Source/WebCore/testing/Internals.cpp	2017-03-01 19:30:29 UTC (rev 213234)
@@ -1138,16 +1138,25 @@
 
 void Internals::enableMockMediaEndpoint()
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return;
+
 MediaEndpoint::create = MockMediaEndpoint::create;
 }
 
 void Internals::emulateRTCPeerConnectionPlatformEvent(RTCPeerConnection& connection, const String& action)
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return;
+
 connection.emulatePlatformEvent(action);
 }
 
 void Internals::useMockRTCPeerConnectionFactory(const String& testCase)
 {
+if (!LibWebRTCProvider::webRTCAvailable())
+return;
+
 #if USE(LIBWEBRTC)

[webkit-changes] [213259] trunk

2017-03-01 Thread achristensen

Title: [213259] trunk








Revision 213259
Author achristen...@apple.com
Date 2017-03-01 19:48:41 -0800 (Wed, 01 Mar 2017)


Log Message
Continue enabling WebRTC
https://bugs.webkit.org/show_bug.cgi?id=169056

Reviewed by Jon Lee.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213258 => 213259)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-02 03:46:01 UTC (rev 213258)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
@@ -1,3 +1,12 @@
+2017-03-01  Alex Christensen  
+
+Continue enabling WebRTC
+https://bugs.webkit.org/show_bug.cgi?id=169056
+
+Reviewed by Jon Lee.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-03-01  Michael Saboff  
 
 Source/_javascript_Core/ChangeLog


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213258 => 213259)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 03:46:01 UTC (rev 213258)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 03:48:41 UTC (rev 213259)
@@ -165,11 +165,9 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Production = ;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/ChangeLog (213258 => 213259)

--- trunk/Source/WebCore/ChangeLog	2017-03-02 03:46:01 UTC (rev 213258)
+++ trunk/Source/WebCore/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
@@ -1,3 +1,12 @@
+2017-03-01  Alex Christensen  
+
+Continue enabling WebRTC
+https://bugs.webkit.org/show_bug.cgi?id=169056
+
+Reviewed by Jon Lee.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-03-01  Chris Dumez  
 
 [WK2][!NETWORK_SESSION] Failure to download when using a download attribute with no value on an anchor


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213258 => 213259)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 03:46:01 UTC (rev 213258)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 03:48:41 UTC (rev 213259)
@@ -165,11 +165,9 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Production = ;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/PAL/ChangeLog (213258 => 213259)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 03:46:01 UTC (rev 213258)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
@@ -1,3 +1,12 @@
+2017-03-01  Alex Christensen  
+
+Continue enabling WebRTC
+

[webkit-changes] [213260] trunk

2017-03-01 Thread achristensen

Title: [213260] trunk








Revision 213260
Author achristen...@apple.com
Date 2017-03-01 20:34:33 -0800 (Wed, 01 Mar 2017)


Log Message
Unreviewed, rolling out r213259.

Broke an internal build

Reverted changeset:

"Continue enabling WebRTC"
https://bugs.webkit.org/show_bug.cgi?id=169056
http://trac.webkit.org/changeset/213259

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213259 => 213260)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-02 04:34:33 UTC (rev 213260)
@@ -1,5 +1,17 @@
 2017-03-01  Alex Christensen  
 
+Unreviewed, rolling out r213259.
+
+Broke an internal build
+
+Reverted changeset:
+
+"Continue enabling WebRTC"
+https://bugs.webkit.org/show_bug.cgi?id=169056
+http://trac.webkit.org/changeset/213259
+
+2017-03-01  Alex Christensen  
+
 Continue enabling WebRTC
 https://bugs.webkit.org/show_bug.cgi?id=169056
 


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213259 => 213260)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 03:48:41 UTC (rev 213259)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 04:34:33 UTC (rev 213260)
@@ -165,9 +165,11 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/ChangeLog (213259 => 213260)

--- trunk/Source/WebCore/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
+++ trunk/Source/WebCore/ChangeLog	2017-03-02 04:34:33 UTC (rev 213260)
@@ -1,5 +1,17 @@
 2017-03-01  Alex Christensen  
 
+Unreviewed, rolling out r213259.
+
+Broke an internal build
+
+Reverted changeset:
+
+"Continue enabling WebRTC"
+https://bugs.webkit.org/show_bug.cgi?id=169056
+http://trac.webkit.org/changeset/213259
+
+2017-03-01  Alex Christensen  
+
 Continue enabling WebRTC
 https://bugs.webkit.org/show_bug.cgi?id=169056
 


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213259 => 213260)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 03:48:41 UTC (rev 213259)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 04:34:33 UTC (rev 213260)
@@ -165,9 +165,11 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
-ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
+ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios_11_Production = ;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/PAL/ChangeLog (213259 => 213260)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 03:48:41 UTC (rev 213259)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 04:34:33 UTC (rev 213260)
@@ -1,5 +1,17 @@
 2017-03-01  Alex Christensen  
 
+Unreviewed, rolling out r213259.
+
+Broke an internal build
+
+Reverted changeset:
+
+"Continue e

[webkit-changes] [213268] trunk/Source/WebKit/win

2017-03-01 Thread achristensen

Title: [213268] trunk/Source/WebKit/win








Revision 213268
Author achristen...@apple.com
Date 2017-03-01 23:02:54 -0800 (Wed, 01 Mar 2017)


Log Message
Fix Windows build after r213266
https://bugs.webkit.org/show_bug.cgi?id=169049

* WebFrame.cpp:
(WebFrame::invalidate):

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebFrame.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (213267 => 213268)

--- trunk/Source/WebKit/win/ChangeLog	2017-03-02 06:45:29 UTC (rev 213267)
+++ trunk/Source/WebKit/win/ChangeLog	2017-03-02 07:02:54 UTC (rev 213268)
@@ -1,3 +1,11 @@
+2017-03-01  Alex Christensen  
+
+Fix Windows build after r213266
+https://bugs.webkit.org/show_bug.cgi?id=169049
+
+* WebFrame.cpp:
+(WebFrame::invalidate):
+
 2017-02-27  Per Arne Vollan  
 
 [Win] Http preload tests are failing.


Modified: trunk/Source/WebKit/win/WebFrame.cpp (213267 => 213268)

--- trunk/Source/WebKit/win/WebFrame.cpp	2017-03-02 06:45:29 UTC (rev 213267)
+++ trunk/Source/WebKit/win/WebFrame.cpp	2017-03-02 07:02:54 UTC (rev 213268)
@@ -1067,7 +1067,7 @@
 ASSERT(coreFrame);
 
 if (Document* document = coreFrame->document())
-document->recalcStyle(Style::Force);
+document->resolveStyle(Style::Force);
 }
 
 HRESULT WebFrame::inViewSourceMode(BOOL* flag)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213269] trunk/Source/WebCore

2017-03-01 Thread achristensen

Title: [213269] trunk/Source/WebCore








Revision 213269
Author achristen...@apple.com
Date 2017-03-01 23:07:44 -0800 (Wed, 01 Mar 2017)


Log Message
Fix WinCairo build after r213214
https://bugs.webkit.org/show_bug.cgi?id=168908

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (213268 => 213269)

--- trunk/Source/WebCore/ChangeLog	2017-03-02 07:02:54 UTC (rev 213268)
+++ trunk/Source/WebCore/ChangeLog	2017-03-02 07:07:44 UTC (rev 213269)
@@ -1,3 +1,10 @@
+2017-03-01  Alex Christensen  
+
+Fix WinCairo build after r213214
+https://bugs.webkit.org/show_bug.cgi?id=168908
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+
 2017-03-01  Myles C. Maxfield  
 
 Implement font-stretch for installed fonts


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (213268 => 213269)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h	2017-03-02 07:02:54 UTC (rev 213268)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h	2017-03-02 07:07:44 UTC (rev 213269)
@@ -24,8 +24,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef MediaPlayerPrivateMediaFoundation_h
-#define MediaPlayerPrivateMediaFoundation_h
+#pragma once
 
 #include "COMPtr.h"
 #include "MediaPlayerPrivate.h"
@@ -43,7 +42,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 namespace WebCore {
 
@@ -483,5 +482,3 @@
 };
 
 }
-
-#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213271] trunk/Source

2017-03-01 Thread achristensen

Title: [213271] trunk/Source








Revision 213271
Author achristen...@apple.com
Date 2017-03-01 23:32:40 -0800 (Wed, 01 Mar 2017)


Log Message
Actually fix Windows build.

Source/WebCore:

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
Win32Handle is now in WTF namespace.

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::invalidate):
r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebFrame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (213270 => 213271)

--- trunk/Source/WebCore/ChangeLog	2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebCore/ChangeLog	2017-03-02 07:32:40 UTC (rev 213271)
@@ -1,5 +1,12 @@
 2017-03-01  Alex Christensen  
 
+Actually fix Windows build.
+
+* platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+Win32Handle is now in WTF namespace.
+
+2017-03-01  Alex Christensen  
+
 Fix WinCairo build after r213214
 https://bugs.webkit.org/show_bug.cgi?id=168908
 


Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (213270 => 213271)

--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h	2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h	2017-03-02 07:32:40 UTC (rev 213271)
@@ -245,9 +245,9 @@
 Direct3DPresenter* m_presenter { nullptr };
 
 DWORD m_threadID { 0 };
-Win32Handle m_schedulerThread;
-Win32Handle m_threadReadyEvent;
-Win32Handle m_flushEvent;
+WTF::Win32Handle m_schedulerThread;
+WTF::Win32Handle m_threadReadyEvent;
+WTF::Win32Handle m_flushEvent;
 
 float m_playbackRate { 1.0f };
 MFTIME m_frameDuration { 0 };


Modified: trunk/Source/WebKit/win/ChangeLog (213270 => 213271)

--- trunk/Source/WebKit/win/ChangeLog	2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebKit/win/ChangeLog	2017-03-02 07:32:40 UTC (rev 213271)
@@ -1,5 +1,13 @@
 2017-03-01  Alex Christensen  
 
+Actually fix Windows build.
+
+* WebFrame.cpp:
+(WebFrame::invalidate):
+r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
+
+2017-03-01  Alex Christensen  
+
 Fix Windows build after r213266
 https://bugs.webkit.org/show_bug.cgi?id=169049
 


Modified: trunk/Source/WebKit/win/WebFrame.cpp (213270 => 213271)

--- trunk/Source/WebKit/win/WebFrame.cpp	2017-03-02 07:20:12 UTC (rev 213270)
+++ trunk/Source/WebKit/win/WebFrame.cpp	2017-03-02 07:32:40 UTC (rev 213271)
@@ -1067,7 +1067,7 @@
 ASSERT(coreFrame);
 
 if (Document* document = coreFrame->document())
-document->resolveStyle(Style::Force);
+document->resolveStyle(WebCore::Document::ResolveStyleType::Rebuild);
 }
 
 HRESULT WebFrame::inViewSourceMode(BOOL* flag)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213294] trunk

2017-03-02 Thread achristensen

Title: [213294] trunk








Revision 213294
Author achristen...@apple.com
Date 2017-03-02 12:19:35 -0800 (Thu, 02 Mar 2017)


Log Message
Continue enabling WebRTC
https://bugs.webkit.org/show_bug.cgi?id=169056

Reviewed by Jon Lee.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213293 => 213294)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-02 19:30:05 UTC (rev 213293)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-02 20:19:35 UTC (rev 213294)
@@ -1,3 +1,12 @@
+2017-03-02  Alex Christensen  
+
+Continue enabling WebRTC
+https://bugs.webkit.org/show_bug.cgi?id=169056
+
+Reviewed by Jon Lee.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-03-02  Tomas Popela  
 
 Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (213293 => 213294)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 19:30:05 UTC (rev 213293)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-03-02 20:19:35 UTC (rev 213294)
@@ -165,11 +165,9 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Production = ;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/ChangeLog (213293 => 213294)

--- trunk/Source/WebCore/ChangeLog	2017-03-02 19:30:05 UTC (rev 213293)
+++ trunk/Source/WebCore/ChangeLog	2017-03-02 20:19:35 UTC (rev 213294)
@@ -1,3 +1,12 @@
+2017-03-02  Alex Christensen  
+
+Continue enabling WebRTC
+https://bugs.webkit.org/show_bug.cgi?id=169056
+
+Reviewed by Jon Lee.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-03-02  Ryan Haddad  
 
 Unreviewed, rolling out r213281.


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (213293 => 213294)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 19:30:05 UTC (rev 213293)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-03-02 20:19:35 UTC (rev 213294)
@@ -165,11 +165,9 @@
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base)_$(CONFIGURATION))
-ENABLE_WEB_RTC_ios_11_Debug = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Release = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios_11_Production = ;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;


Modified: trunk/Source/WebCore/PAL/ChangeLog (213293 => 213294)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 19:30:05 UTC (rev 213293)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-03-02 20:19:35 UTC (rev 213294)
@@ -1,3 +1,12 @@
+2017-03-02  Alex Christensen  
+
+Continue enabling WebRTC
+https://bugs.webkit.org/show_bug.cgi?

[webkit-changes] [213322] trunk/Source/WebCore

2017-03-02 Thread achristensen

Title: [213322] trunk/Source/WebCore








Revision 213322
Author achristen...@apple.com
Date 2017-03-02 16:18:44 -0800 (Thu, 02 Mar 2017)


Log Message
Modernize ContentExtensionParser
https://bugs.webkit.org/show_bug.cgi?id=169106

Reviewed by Andy Estes.

We were returning std::error_code and passing the return value as a parameter reference.
because we wrote this code before we had WTF::Expected.

No change in behavior, verified by many API tests.

* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):
* contentextensions/ContentExtensionParser.h:
* contentextensions/ContentExtensionRule.cpp:
(WebCore::ContentExtensions::ContentExtensionRule::ContentExtensionRule):
* contentextensions/ContentExtensionRule.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionParser.h
trunk/Source/WebCore/contentextensions/ContentExtensionRule.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionRule.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (213321 => 213322)

--- trunk/Source/WebCore/ChangeLog	2017-03-03 00:10:24 UTC (rev 213321)
+++ trunk/Source/WebCore/ChangeLog	2017-03-03 00:18:44 UTC (rev 213322)
@@ -1,3 +1,29 @@
+2017-03-02  Alex Christensen  
+
+Modernize ContentExtensionParser
+https://bugs.webkit.org/show_bug.cgi?id=169106
+
+Reviewed by Andy Estes.
+
+We were returning std::error_code and passing the return value as a parameter reference.
+because we wrote this code before we had WTF::Expected.
+
+No change in behavior, verified by many API tests.
+
+* contentextensions/ContentExtensionCompiler.cpp:
+(WebCore::ContentExtensions::compileRuleList):
+* contentextensions/ContentExtensionParser.cpp:
+(WebCore::ContentExtensions::getDomainList):
+(WebCore::ContentExtensions::loadTrigger):
+(WebCore::ContentExtensions::loadAction):
+(WebCore::ContentExtensions::loadRule):
+(WebCore::ContentExtensions::loadEncodedRules):
+(WebCore::ContentExtensions::parseRuleList):
+* contentextensions/ContentExtensionParser.h:
+* contentextensions/ContentExtensionRule.cpp:
+(WebCore::ContentExtensions::ContentExtensionRule::ContentExtensionRule):
+* contentextensions/ContentExtensionRule.h:
+
 2017-03-02  Ryan Haddad  
 
 Unreviewed, rolling out r213301.


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (213321 => 213322)

--- trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp	2017-03-03 00:10:24 UTC (rev 213321)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp	2017-03-03 00:18:44 UTC (rev 213322)
@@ -205,13 +205,12 @@
 root.setActions(actionsStart, static_cast(actionsLength));
 }
 
-std::error_code compileRuleList(ContentExtensionCompilationClient& client, String&& ruleList)
+std::error_code compileRuleList(ContentExtensionCompilationClient& client, String&& ruleJSON)
 {
-Vector parsedRuleList;
-auto parserError = parseRuleList(ruleList, parsedRuleList);
-ruleList = String();
-if (parserError)
-return parserError;
+auto ruleList = parseRuleList(WTFMove(ruleJSON));
+if (!ruleList.hasValue())
+return ruleList.error();
+Vector parsedRuleList = WTFMove(ruleList.value());
 
 #if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
 double patternPartitioningStart = monotonicallyIncreasingTime();


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp (213321 => 213322)

--- trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp	2017-03-03 00:10:24 UTC (rev 213321)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp	2017-03-03 00:18:44 UTC (rev 213322)
@@ -40,6 +40,7 @@
 #include <_javascript_Core/JSONObject.h>
 #include <_javascript_Core/VM.h>
 #include 
+#include 
 #include 
 
 using namespace JSC;
@@ -58,31 +59,31 @@
 return true;
 }
 
-static std::error_code getDomainList(ExecState& exec, const JSObject* arrayObject, Vector& vector)
+static Expected, std::error_code> getDomainList(ExecState& exec, const JSObject* arrayObject)
 {
 VM& vm = exec.vm();
 auto scope = DECLARE_THROW_SCOPE(vm);
 
-ASSERT(vector.isEmpty());
 if (!arrayObject || !isJSArray(arrayObject))
-return ContentExtensionError::JSONInvalidDomainList;
+return makeUnexpected(ContentExtensionError::JSONInvalidDomainList);
 const JSArray* array = jsCast(arrayObject);

[webkit-changes] [213384] trunk

2017-03-03 Thread achristensen

Title: [213384] trunk








Revision 213384
Author achristen...@apple.com
Date 2017-03-03 13:50:07 -0800 (Fri, 03 Mar 2017)


Log Message
[URLParser] Fix file: as a relative file URL
https://bugs.webkit.org/show_bug.cgi?id=169122

Reviewed by Tim Horton.

Source/WebCore:

This is clearly defined in https://url.spec.whatwg.org/#file-state with the EOF code point.
I got it wrong and didn't test it.  It's been added to the web platform tests since we last updated.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* TestExpectations:
We don't need to skip url-setters.html any more.  It used to assert before the new URLParser was enabled.
* fast/loader/url-parse-1-expected.txt:
* fast/url/file-expected.txt:
We used to add a strange and unnecessary :/// at the end of the URL.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/loader/url-parse-1-expected.txt
trunk/LayoutTests/fast/url/file-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (213383 => 213384)

--- trunk/LayoutTests/ChangeLog	2017-03-03 21:38:39 UTC (rev 213383)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 21:50:07 UTC (rev 213384)
@@ -1,3 +1,16 @@
+2017-03-03  Alex Christensen  
+
+[URLParser] Fix file: as a relative file URL
+https://bugs.webkit.org/show_bug.cgi?id=169122
+
+Reviewed by Tim Horton.
+
+* TestExpectations:
+We don't need to skip url-setters.html any more.  It used to assert before the new URLParser was enabled.
+* fast/loader/url-parse-1-expected.txt:
+* fast/url/file-expected.txt:
+We used to add a strange and unnecessary :/// at the end of the URL.
+
 2017-03-03  Ryan Haddad  
 
 Add Debug flag to TestExpectation for webrtc/audio-peer-connection-webaudio.html.


Modified: trunk/LayoutTests/TestExpectations (213383 => 213384)

--- trunk/LayoutTests/TestExpectations	2017-03-03 21:38:39 UTC (rev 213383)
+++ trunk/LayoutTests/TestExpectations	2017-03-03 21:50:07 UTC (rev 213384)
@@ -314,8 +314,6 @@
 webkit.org/b/168448 imported/w3c/web-platform-tests/resource-timing/rt-shared-resource-in-workers.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/test_resource_timing.html [ Pass Failure ]
 
-webkit.org/b/161176 [ Debug ] imported/w3c/web-platform-tests/url/url-setters.html [ Skip ]
-
 webkit.org/b/157068 imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Skip ]
 webkit.org/b/157145 imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html [ Failure Pass ]
 webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]


Modified: trunk/LayoutTests/fast/loader/url-parse-1-expected.txt (213383 => 213384)

--- trunk/LayoutTests/fast/loader/url-parse-1-expected.txt	2017-03-03 21:38:39 UTC (rev 213383)
+++ trunk/LayoutTests/fast/loader/url-parse-1-expected.txt	2017-03-03 21:50:07 UTC (rev 213384)
@@ -9,7 +9,7 @@
 //test	file://test/	test	/
 ///	file:///		/
 ///test	file:///test		/test
-file:	file:///BASE/:///		/
+file:	file:///BASE/		/BASE/
 file:test	file:///BASE/test		/BASE/test
 file:/	file:///		/
 file:/test	file:///test		/test


Modified: trunk/LayoutTests/fast/url/file-expected.txt (213383 => 213384)

--- trunk/LayoutTests/fast/url/file-expected.txt	2017-03-03 21:38:39 UTC (rev 213383)
+++ trunk/LayoutTests/fast/url/file-expected.txt	2017-03-03 21:50:07 UTC (rev 213384)
@@ -5,7 +5,7 @@
 
 FAIL canonicalize('file:c:\\foo\\bar.html') should be file:///C:/foo/bar.html. Was file:///c:/foo/bar.html.
 FAIL canonicalize('  File:c|foo\\bar.html') should be file:///C:foo/bar.html. Was file:///c:foo/bar.html.
-FAIL canonicalize('file:') should be file:///. Was file:///tmp/mock/path:///.
+FAIL canonicalize('file:') should be file:///. Was file:///tmp/mock/path.
 FAIL canonicalize('file:UNChost/path') should be file://unchost/path. Was file:///tmp/mock/UNChost/path.
 FAIL canonicalize('c:\\foo\\bar') should be file:///C:/foo/bar. Was c:\foo\bar.
 PASS canonicalize('C|/foo/bar') is 'file:///C:/foo/bar'


Modified: trunk/Source/WebCore/ChangeLog (213383 => 213384)

--- trunk/Source/WebCore/ChangeLog	2017-03-03 21:38:39 UTC (rev 213383)
+++ trunk/Source/WebCore/ChangeLog	2017-03-03 21:50:07 UTC (rev 213384)
@@ -1,3 +1,16 @@
+2017-03-03  Alex Christensen  
+
+[URLParser] Fix file: as a relative file URL
+https://bugs.webkit.org/show_bug.cgi?id=169122
+
+Reviewed by Tim Horton.
+
+This is clearly defined in https://url.spec.whatwg.org/#file-state with the EOF code point.
+I got it wrong and didn't test it.  It's been added to the web platform tests since we last updated.
+
+* platf

[webkit-changes] [213391] trunk/Source/ThirdParty/libwebrtc

2017-03-03 Thread achristensen

Title: [213391] trunk/Source/ThirdParty/libwebrtc








Revision 213391
Author achristen...@apple.com
Date 2017-03-03 14:38:11 -0800 (Fri, 03 Mar 2017)


Log Message
Remove empty build directories.

* build: Removed.
* build/Debug: Removed.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog


Removed Paths

trunk/Source/ThirdParty/libwebrtc/build/




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (213390 => 213391)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-03-03 22:35:27 UTC (rev 213390)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-03-03 22:38:11 UTC (rev 213391)
@@ -1,3 +1,10 @@
+2017-03-03  Alex Christensen  
+
+Remove empty build directories.
+
+* build: Removed.
+* build/Debug: Removed.
+
 2017-03-01  Joseph Pecoraro  
 
 [WebRTC] Install libwebrtc.dylib inside of WebCore.framework






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213419] trunk/Source/WTF

2017-03-04 Thread achristensen

Title: [213419] trunk/Source/WTF








Revision 213419
Author achristen...@apple.com
Date 2017-03-04 00:20:27 -0800 (Sat, 04 Mar 2017)


Log Message
[Win64] '__int128_t': undeclared identifier in MediaTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=169123

Patch by Jer Noble  on 2017-03-03
Reviewed by Alex Christensen.

Don't perform the 128-bit optimized path on Windows, where the __int128_t intrinsic isn't available.

* wtf/MediaTime.cpp:
(WTF::MediaTime::setTimeScale):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MediaTime.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (213418 => 213419)

--- trunk/Source/WTF/ChangeLog	2017-03-04 07:57:50 UTC (rev 213418)
+++ trunk/Source/WTF/ChangeLog	2017-03-04 08:20:27 UTC (rev 213419)
@@ -1,3 +1,15 @@
+2017-03-03  Jer Noble  
+
+[Win64] '__int128_t': undeclared identifier in MediaTime.cpp
+https://bugs.webkit.org/show_bug.cgi?id=169123
+
+Reviewed by Alex Christensen.
+
+Don't perform the 128-bit optimized path on Windows, where the __int128_t intrinsic isn't available.
+
+* wtf/MediaTime.cpp:
+(WTF::MediaTime::setTimeScale):
+
 2017-03-03  Keith Miller  
 
 WASM should support faster loads.


Modified: trunk/Source/WTF/wtf/MediaTime.cpp (213418 => 213419)

--- trunk/Source/WTF/wtf/MediaTime.cpp	2017-03-04 07:57:50 UTC (rev 213418)
+++ trunk/Source/WTF/wtf/MediaTime.cpp	2017-03-04 08:20:27 UTC (rev 213419)
@@ -489,7 +489,7 @@
 
 timeScale = std::min(MaximumTimeScale, timeScale);
 
-#if CPU(X86_64) || CPU(ARM64)
+#if !PLATFORM(WIN) && (CPU(X86_64) || CPU(ARM64))
 __int128_t newValue = static_cast<__int128_t>(m_timeValue) * timeScale;
 int64_t remainder = newValue % m_timeScale;
 newValue = newValue / m_timeScale;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213468] trunk/Source/ThirdParty/libwebrtc

2017-03-06 Thread achristensen

Title: [213468] trunk/Source/ThirdParty/libwebrtc








Revision 213468
Author achristen...@apple.com
Date 2017-03-06 14:46:57 -0800 (Mon, 06 Mar 2017)


Log Message
Fix Production libwebrtc build after r213418
https://bugs.webkit.org/show_bug.cgi?id=169217


Reviewed by Tim Horton.

* Source/webrtc/base/checks.h:
* libwebrtc.xcodeproj/project.pbxproj:
MakeCheckOpString was a weak export, and it wasn't needed.
There is an internal build that checks for weak exports and fails if there is one.
Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (213467 => 213468)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-03-06 22:03:56 UTC (rev 213467)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-03-06 22:46:57 UTC (rev 213468)
@@ -1,3 +1,17 @@
+2017-03-06  Alex Christensen  
+
+Fix Production libwebrtc build after r213418
+https://bugs.webkit.org/show_bug.cgi?id=169217
+
+
+Reviewed by Tim Horton.
+
+* Source/webrtc/base/checks.h:
+* libwebrtc.xcodeproj/project.pbxproj:
+MakeCheckOpString was a weak export, and it wasn't needed.
+There is an internal build that checks for weak exports and fails if there is one.
+Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.
+
 2017-03-04  Dan Bernstein  
 
 [Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h (213467 => 213468)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h	2017-03-06 22:03:56 UTC (rev 213467)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/checks.h	2017-03-06 22:46:57 UTC (rev 213468)
@@ -136,13 +136,13 @@
 }
 
 // MSVC doesn't like complex extern templates and DLLs.
-#if !defined(COMPILER_MSVC)
+#if 0
 // Commonly used instantiations of MakeCheckOpString<>. Explicitly instantiated
 // in logging.cc.
 extern template std::string* MakeCheckOpString(
 const int&, const int&, const char* names);
 extern template
-WEBRTC_DYLIB_EXPORT std::string* MakeCheckOpString(
+std::string* MakeCheckOpString(
 const unsigned long&, const unsigned long&, const char* names);
 extern template
 std::string* MakeCheckOpString(


Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (213467 => 213468)

--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-03-06 22:03:56 UTC (rev 213467)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj	2017-03-06 22:46:57 UTC (rev 213468)
@@ -10591,6 +10591,7 @@
 FB39D77B1201110C00088E69 /* Headers */,
 FB39D0CE1200F0E300088E69 /* Sources */,
 FB39D0CF1200F0E300088E69 /* Frameworks */,
+5CD286461E6E154E0094FDC8 /* Check for Weak VTables and Externals */,
 312BDB0B15FECAB00097EBC7 /* CopyFiles */,
 312BDB0D15FECACE0097EBC7 /* CopyFiles */,
 			);
@@ -10665,6 +10666,21 @@
 			shellPath = /bin/sh;
 			shellScript = "PRIVATE_HEADERS_FOLDER_PATH=usr/local/include\n\nif [[ \"${DEPLOYMENT_LOCATION}\" == \"NO\" ]]; then\nPRIVATE_HEADERS_PATH=\"${TARGET_BUILD_DIR%/}/${PRIVATE_HEADERS_FOLDER_PATH}\"\nelse\nPRIVATE_HEADERS_PATH=\"${DSTROOT}${INSTALL_PATH_PREFIX%/}/${PRIVATE_HEADERS_FOLDER_PATH}\"\nfi;\n\nmkdir -p \"${PRIVATE_HEADERS_PATH}\"\n\nrsync -av --no-owner --no-group --prune-empty-dirs --exclude \".svn\" --exclude \"usr\" --include \"*/\" --include \"*.h\" --exclude \"*\" \"${SRCROOT}/Source/webrtc\" \"${PRIVATE_HEADERS_PATH}\"\n";
 		};
+		5CD286461E6E154E0094FDC8 /* Check for Weak VTables and Externals */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputPaths = (
+"$(TARGET_BUILD_DIR)/$(EXECUTABLE_PATH)",
+			);
+			name = "Check for Weak VTables and Externals";
+			outputPaths = (
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\nexit 0;\nfi\n\nif [ -f ../../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n../../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+		};
 /* End PBXShellScriptBuildPhase section */
 
 /* Begin PBXSourcesBuildPhase section */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213469] trunk

2017-03-06 Thread achristensen

Title: [213469] trunk








Revision 213469
Author achristen...@apple.com
Date 2017-03-06 14:55:33 -0800 (Mon, 06 Mar 2017)


Log Message
Fix URLs relative to file URLs with paths beginning with Windows drive letters
https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as file:///C:/
which should not be removed when making other URLs relative to them.
See https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

* platform/URLParser.cpp:
(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):
* platform/URLParser.h:

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/relative-win-expected.txt:
Some tests pass now.  localhost should indeed be removed according to the latest spec.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/relative-win-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/platform/URLParser.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (213468 => 213469)

--- trunk/LayoutTests/ChangeLog	2017-03-06 22:46:57 UTC (rev 213468)
+++ trunk/LayoutTests/ChangeLog	2017-03-06 22:55:33 UTC (rev 213469)
@@ -1,3 +1,13 @@
+2017-03-06  Alex Christensen  
+
+Fix URLs relative to file URLs with paths beginning with Windows drive letters
+https://bugs.webkit.org/show_bug.cgi?id=169178
+
+Reviewed by Tim Horton.
+
+* fast/url/relative-win-expected.txt:
+Some tests pass now.  localhost should indeed be removed according to the latest spec.
+
 2017-03-06  Simon Fraser  
 
 Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it


Modified: trunk/LayoutTests/fast/url/relative-win-expected.txt (213468 => 213469)

--- trunk/LayoutTests/fast/url/relative-win-expected.txt	2017-03-06 22:46:57 UTC (rev 213468)
+++ trunk/LayoutTests/fast/url/relative-win-expected.txt	2017-03-06 22:55:33 UTC (rev 213469)
@@ -6,7 +6,7 @@
 PASS canonicalize('http://host/') is 'http://host/'
 PASS canonicalize('bar') is 'file:///C:/bar'
 PASS canonicalize('../../../bar.html') is 'file:///C:/bar.html'
-FAIL canonicalize('/../bar.html') should be file:///C:/bar.html. Was file:///bar.html.
+PASS canonicalize('/../bar.html') is 'file:///C:/bar.html'
 FAIL canonicalize('another\\path') should be . Was http://another/path.
 FAIL canonicalize('//c:/foo') should be file:///C:/foo. Was file:///c:/foo.
 FAIL canonicalize('//localhost/c:/foo') should be file:///C:/foo. Was file:///c:/foo.
@@ -14,9 +14,9 @@
 FAIL canonicalize('c:/foo') should be . Was c:/foo.
 FAIL canonicalize('c:\\foo') should be . Was c:\foo.
 FAIL canonicalize('/z:/bar') should be file:///Z:/bar. Was file:///z:/bar.
-FAIL canonicalize('/bar') should be file:///C:/bar. Was file:///bar.
-FAIL canonicalize('/bar') should be file://localhost/C:/bar. Was file:///bar.
-FAIL canonicalize('/bar') should be file:///C:/bar. Was file:///bar.
+PASS canonicalize('/bar') is 'file:///C:/bar'
+FAIL canonicalize('/bar') should be file://localhost/C:/bar. Was file:///C:/bar.
+PASS canonicalize('/bar') is 'file:///C:/bar'
 PASS canonicalize('//somehost/path') is 'file://somehost/path'
 FAIL canonicalize('/\\//somehost/path') should be file://somehost/path. Was file:somehost/path.
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (213468 => 213469)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-06 22:46:57 UTC (rev 213468)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-06 22:55:33 UTC (rev 213469)
@@ -1,3 +1,14 @@
+2017-03-06  Alex Christensen  
+
+Fix URLs relative to file URLs with paths beginning with Windows drive letters
+https://bugs.webkit.org/show_bug.cgi?id=169178
+
+Reviewed by Tim Horton.
+
+* web-platform-tests/url/a-element-expected.txt:
+* web-platform-tests/url/a-element-xhtml-expected.txt:
+* web-platform-tests/url/url-constructor-expected.txt:
+
 2017-03-06  Manuel Rego Casasnovas  
 
 [css-grid] Import W3C Test Suite


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (213468 => 213469)

--- trunk/LayoutTests/imported/w3c

[webkit-changes] [213470] trunk/Source/WebCore

2017-03-06 Thread achristensen

Title: [213470] trunk/Source/WebCore








Revision 213470
Author achristen...@apple.com
Date 2017-03-06 14:56:43 -0800 (Mon, 06 Mar 2017)


Log Message
Refactor ContentExtensionParser
https://bugs.webkit.org/show_bug.cgi?id=169214

Reviewed by Brady Eidson.

No change in behavior, as verified by existing API tests.
This will make it easier to use getStringList for other things in coming patches.

* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getStringList):
(WebCore::ContentExtensions::getDomainList):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (213469 => 213470)

--- trunk/Source/WebCore/ChangeLog	2017-03-06 22:55:33 UTC (rev 213469)
+++ trunk/Source/WebCore/ChangeLog	2017-03-06 22:56:43 UTC (rev 213470)
@@ -1,5 +1,19 @@
 2017-03-06  Alex Christensen  
 
+Refactor ContentExtensionParser
+https://bugs.webkit.org/show_bug.cgi?id=169214
+
+Reviewed by Brady Eidson.
+
+No change in behavior, as verified by existing API tests.
+This will make it easier to use getStringList for other things in coming patches.
+
+* contentextensions/ContentExtensionParser.cpp:
+(WebCore::ContentExtensions::getStringList):
+(WebCore::ContentExtensions::getDomainList):
+
+2017-03-06  Alex Christensen  
+
 Fix URLs relative to file URLs with paths beginning with Windows drive letters
 https://bugs.webkit.org/show_bug.cgi?id=169178
 


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp (213469 => 213470)

--- trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp	2017-03-06 22:55:33 UTC (rev 213469)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionParser.cpp	2017-03-06 22:56:43 UTC (rev 213470)
@@ -59,13 +59,13 @@
 return true;
 }
 
-static Expected, std::error_code> getDomainList(ExecState& exec, const JSObject* arrayObject)
+static Expected, std::error_code> getStringList(ExecState& exec, const JSObject* arrayObject, ContentExtensionError error)
 {
 VM& vm = exec.vm();
 auto scope = DECLARE_THROW_SCOPE(vm);
 
 if (!arrayObject || !isJSArray(arrayObject))
-return makeUnexpected(ContentExtensionError::JSONInvalidDomainList);
+return makeUnexpected(error);
 const JSArray* array = jsCast(arrayObject);
 
 Vector domains;
@@ -73,19 +73,29 @@
 for (unsigned i = 0; i < length; ++i) {
 const JSValue value = array->getIndex(&exec, i);
 if (scope.exception() || !value.isString())
-return makeUnexpected(ContentExtensionError::JSONInvalidDomainList);
+return makeUnexpected(error);
 
-// Domains should be punycode encoded lower case.
 const String& domain = asString(value)->value(&exec);
 if (domain.isEmpty())
-return makeUnexpected(ContentExtensionError::JSONInvalidDomainList);
-if (!containsOnlyASCIIWithNoUppercase(domain))
-return makeUnexpected(ContentExtensionError::JSONDomainNotLowerCaseASCII);
+return makeUnexpected(error);
 domains.append(domain);
 }
 return WTFMove(domains);
 }
 
+static Expected, std::error_code> getDomainList(ExecState& exec, const JSObject* arrayObject)
+{
+auto strings = getStringList(exec, arrayObject, ContentExtensionError::JSONInvalidDomainList);
+if (!strings.hasValue())
+return strings;
+for (auto& domain : strings.value()) {
+// Domains should be punycode encoded lower case.
+if (!containsOnlyASCIIWithNoUppercase(domain))
+return makeUnexpected(ContentExtensionError::JSONDomainNotLowerCaseASCII);
+}
+return strings;
+}
+
 static std::error_code getTypeFlags(ExecState& exec, const JSValue& typeValue, ResourceFlags& flags, uint16_t (*stringToType)(const String&))
 {
 VM& vm = exec.vm();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213669] trunk

2017-03-09 Thread achristensen

Title: [213669] trunk








Revision 213669
Author achristen...@apple.com
Date 2017-03-09 14:17:13 -0800 (Thu, 09 Mar 2017)


Log Message
[Content Extensions] Introduce if-top-url and unless-top-url
https://bugs.webkit.org/show_bug.cgi?id=169433

Reviewed by Brady Eidson.

Source/WebCore:

In r184116 I added if-domain and unless-domain to control whether a rule applies
based on the domain of the main document URL.  I'm expanding this by adding if-top-url
and unless-top-url that run regular expressions on the entire main document URL so that
example.com/user1content can be distinguished from example.com/user2content.
To not add to the number of passes we make on the URLs for each load and to maintain JSON
backwards compatibility, I've made it so that if-top-url and unless-top-url can be used
instead of if-domain and unless-domain (which continue to work) but the two condition types
cannot be used together since running regular expressions on the entire main document URL
is strictly more powerful than checking the domain and subdomains.
As a minor detail, content extension regexes are by default ASCII-case-insensitive, so I've
done the same with top URL regexes, adding top-url-filter-is-case-sensitive to mirror the existing
url-filter-is-case-sensitive if the JSON author decides to make regexes case sensitive.

Covered by new API tests.

* contentextensions/CompiledContentExtension.h:
* contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::populateConditionCacheIfNeeded):
(WebCore::ContentExtensions::ContentExtension::topURLActions):
(WebCore::ContentExtensions::ContentExtension::cachedConditionedActions): Deleted.
* contentextensions/ContentExtension.h:
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::addUniversalActionsToDFA):
(WebCore::ContentExtensions::compileToBytecode):
We had three copies of compiling to bytecode that were almost the same and would've been made into three copies of the same code.
I moved them to one helper function that is called three times.
(WebCore::ContentExtensions::compileRuleList):
* contentextensions/ContentExtensionCompiler.h:
* contentextensions/ContentExtensionError.cpp:
(WebCore::ContentExtensions::contentExtensionErrorCategory):
Add the new error type for JSON that tries to use if-top-url and unless-top-url with if-domain and unless-domain.
* contentextensions/ContentExtensionError.h:
* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::loadTrigger):
Parse the new values if-top-url, unless-top-url, and top-url-filter-is-case-sensitive.
* contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::Trigger::~Trigger):
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
* contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithConditions):
* contentextensions/DFABytecodeInterpreter.h:

Source/WebKit2:

Rename conditionedFilters to topURLFilters to reflect the fact that they are the filters
that are run on the top URL, and possibly just the domain of the top url.
I was a bit too aggressive when renaming domain* to condition* in r213533.

* Shared/WebCompiledContentExtension.cpp:
(WebKit::WebCompiledContentExtension::conditionsApplyOnlyToDomain):
(WebKit::WebCompiledContentExtension::topURLFiltersBytecode):
(WebKit::WebCompiledContentExtension::topURLFiltersBytecodeLength):
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecode): Deleted.
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecodeLength): Deleted.
* Shared/WebCompiledContentExtension.h:
* Shared/WebCompiledContentExtensionData.cpp:
(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):
* Shared/WebCompiledContentExtensionData.h:
(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):
* UIProcess/API/APIUserContentExtensionStore.cpp:
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::UserContentExtensionStore::invalidateContentExtensionVersion):
(API::userContentExtensionStoreErrorCategory):
* UIProcess/API/APIUserContentExtensionStore.h:
Increment CurrentContentExtensionFileVersion because we have changed the format of the binary on disk.
We only added 4 bytes, but that's binary incompatible and requires re-compiling any existing content extensions.

Tools:

* TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
Add tests for new functionality and new failure types.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/CompiledContentExtension.h
trunk/Source/WebCore/contentextensions/ContentExtension.cp

[webkit-changes] [207700] trunk

2016-10-21 Thread achristensen

Title: [207700] trunk








Revision 207700
Author achristen...@apple.com
Date 2016-10-21 16:55:23 -0700 (Fri, 21 Oct 2016)


Log Message
Unreviewed, rolling out r207582.
https://bugs.webkit.org/show_bug.cgi?id=163819

Not quite ready rdar://problem/28897179 (Requested by
alexchristensen on #webkit).

Reverted changeset:

"Re-enable URLParser for non-Safari Cocoa apps after r207321"
https://bugs.webkit.org/show_bug.cgi?id=163690
http://trac.webkit.org/changeset/207582

Patch by Commit Queue  on 2016-10-21

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm
trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207699 => 207700)

--- trunk/Source/WebCore/ChangeLog	2016-10-21 23:20:11 UTC (rev 207699)
+++ trunk/Source/WebCore/ChangeLog	2016-10-21 23:55:23 UTC (rev 207700)
@@ -1,3 +1,17 @@
+2016-10-21  Commit Queue  
+
+Unreviewed, rolling out r207582.
+https://bugs.webkit.org/show_bug.cgi?id=163819
+
+Not quite ready rdar://problem/28897179 (Requested by
+alexchristensen on #webkit).
+
+Reverted changeset:
+
+"Re-enable URLParser for non-Safari Cocoa apps after r207321"
+https://bugs.webkit.org/show_bug.cgi?id=163690
+http://trac.webkit.org/changeset/207582
+
 2016-10-21  Gavin Barraclough  
 
 WebPage should take UserActivity directly for user input


Modified: trunk/Source/WebCore/platform/URLParser.cpp (207699 => 207700)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-21 23:20:11 UTC (rev 207699)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-21 23:55:23 UTC (rev 207700)
@@ -2843,16 +2843,31 @@
 // It should be able to be deduced from m_isValid and m_string.length() to save memory.
 }
 
-static bool urlParserEnabled = true;
+enum class URLParserEnabled {
+Undetermined,
+Yes,
+No
+};
 
+static URLParserEnabled urlParserEnabled = URLParserEnabled::Undetermined;
+
 void URLParser::setEnabled(bool enabled)
 {
-urlParserEnabled = enabled;
+urlParserEnabled = enabled ? URLParserEnabled::Yes : URLParserEnabled::No;
 }
 
 bool URLParser::enabled()
 {
-return urlParserEnabled;
+if (urlParserEnabled == URLParserEnabled::Undetermined) {
+#if PLATFORM(MAC)
+urlParserEnabled = MacApplication::isSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
+#elif PLATFORM(IOS)
+urlParserEnabled = IOSApplication::isMobileSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
+#else
+urlParserEnabled = URLParserEnabled::Yes;
+#endif
+}
+return urlParserEnabled == URLParserEnabled::Yes;
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (207699 => 207700)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-21 23:20:11 UTC (rev 207699)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-21 23:55:23 UTC (rev 207700)
@@ -121,6 +121,11 @@
 InternalSettings::setAllowsAnySSLCertificate(allowAnySSLCertificate);
 }
 
+void setURLParserEnabled(bool enabled)
+{
+URLParser::setEnabled(enabled);
+}
+
 void installMockGamepadProvider()
 {
 #if ENABLE(GAMEPAD)


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (207699 => 207700)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-21 23:20:11 UTC (rev 207699)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-21 23:55:23 UTC (rev 207700)
@@ -56,6 +56,7 @@
 void setLogChannelToAccumulate(const WTF::String& name) TEST_SUPPORT_EXPORT;
 void initializeLogChannelsIfNecessary() TEST_SUPPORT_EXPORT;
 void setAllowsAnySSLCertificate(bool) TEST_SUPPORT_EXPORT;
+void setURLParserEnabled(bool) TEST_SUPPORT_EXPORT;
 
 void installMockGamepadProvider() TEST_SUPPORT_EXPORT;
 void connectMockGamepad(unsigned index) TEST_SUPPORT_EXPORT;


Modified: trunk/Tools/ChangeLog (207699 => 207700)

--- trunk/Tools/ChangeLog	2016-10-21 23:20:11 UTC (rev 207699)
+++ trunk/Tools/ChangeLog	2016-10-21 23:55:23 UTC (rev 207700)
@@ -1,3 +1,17 @@
+2016-10-21  Commit Queue  
+
+Unreviewed, rolling out r207582.
+https://bugs.webkit.org/show_bug.cgi?id=163819
+
+Not quite ready rdar://problem/28897179 (Requested by
+alexchristensen on #webkit).
+
+Reverted changeset:
+
+"Re-enable URLParser for non-Safari Cocoa apps after r207321"
+https://bugs.webkit.org/show_bug.cgi?id=163690
+http://trac.webkit.org/changeset/207582
+
 2016-10-21  Jonathan Bedard  
 
 WebKitTestRunnerApp packages .idl file


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (207699 => 207700)

--- trunk/Tools/Dum

[webkit-changes] [207769] trunk

2016-10-24 Thread achristensen

Title: [207769] trunk








Revision 207769
Author achristen...@apple.com
Date 2016-10-24 11:25:40 -0700 (Mon, 24 Oct 2016)


Log Message
URL::port should return Optional
https://bugs.webkit.org/show_bug.cgi?id=163806

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

A URL without a port is different than a URL with port 0.
This matches the spec, Chrome, and Firefox.

Covered by newly-passing web platform tests.

* Modules/indexeddb/IDBDatabaseIdentifier.h:
(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::isHashTableDeletedValue):
(WebCore::IDBDatabaseIdentifier::hash):
(WebCore::IDBDatabaseIdentifier::isValid):
(WebCore::IDBDatabaseIdentifier::isEmpty):
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName):
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::applyBlockedStatusToRequest):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
* html/URLUtils.h:
(WebCore::URLUtils::protocol):
(WebCore::URLUtils::host):
(WebCore::URLUtils::port):
* loader/CrossOriginAccessControl.cpp:
(WebCore::isValidCrossOriginRedirectionURL):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
(WebCore::isRemoteWebArchive):
(WebCore::DocumentLoader::maybeLoadEmpty):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
* loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely):
(WebCore::CachedResource::freshnessLifetime):
* page/Location.cpp:
(WebCore::Location::protocol):
(WebCore::Location::host):
(WebCore::Location::port):
* page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isSecure):
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::toRawString):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::databaseIdentifier):
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::port):
* page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::debugString):
* page/SecurityOriginData.h:
(): Deleted.
* page/SecurityOriginHash.h:
(WebCore::SecurityOriginHash::hash):
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowResourceFromSource):
(WebCore::ContentSecurityPolicy::allowConnectToSource):
(WebCore::ContentSecurityPolicy::allowBaseURI):
(WebCore::stripURLForUseInReport):
(WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded):
* page/csp/ContentSecurityPolicySource.cpp:
(WebCore::ContentSecurityPolicySource::ContentSecurityPolicySource):
(WebCore::ContentSecurityPolicySource::portMatches):
* page/csp/ContentSecurityPolicySource.h:
* page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::parse):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parsePort):
* page/csp/ContentSecurityPolicySourceList.h:
* platform/SchemeRegistry.h:
* platform/URL.cpp:
(WebCore::URL::protocol):
(WebCore::URL::port):
(WebCore::URL::serialize):
(WebCore::portAllowed):
(WebCore::defaultPortsMap): Deleted.
(WebCore::defaultPortForProtocol): Deleted.
(WebCore::isDefaultPortForProtocol): Deleted.
* platform/URL.h:
(WebCore::URL::hasPort): Deleted.
* platform/URLParser.cpp:
(WebCore::defaultPortForProtocol):
(WebCore::isDefaultPortForProtocol):
(WebCore::URLParser::parsePort):
(WebCore::isDefaultPort): Deleted.
* platform/network/CredentialStorage.cpp:
(WebCore::originStringFromURL):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::port):
* workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::protocol):
(WebCore::WorkerLocation::host):
(WebCore::WorkerLocation::port):

Source/WebKit/mac:

* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin port]):

Source/WebKit2:

* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::overrideSystemProxies):
* Shared/API/APISecurityOrigin.h:
(API::SecurityOrigin::create):
* Shared/API/APIURL.h:
(API::URL::protocol):
* Shared/API/c/WKSecurityOriginRef.cpp:
(WKSecurityOriginGetPort):
* UIProcess/API/Cocoa/WKSecurityOr

[webkit-changes] [207772] trunk/Source/WebCore

2016-10-24 Thread achristensen

Title: [207772] trunk/Source/WebCore








Revision 207772
Author achristen...@apple.com
Date 2016-10-24 13:19:23 -0700 (Mon, 24 Oct 2016)


Log Message
Try to fix Windows build after r207767
https://bugs.webkit.org/show_bug.cgi?id=163891

* DerivedSources.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207771 => 207772)

--- trunk/Source/WebCore/ChangeLog	2016-10-24 18:53:09 UTC (rev 207771)
+++ trunk/Source/WebCore/ChangeLog	2016-10-24 20:19:23 UTC (rev 207772)
@@ -1,3 +1,10 @@
+2016-10-24  Alex Christensen  
+
+Try to fix Windows build after r207767
+https://bugs.webkit.org/show_bug.cgi?id=163891
+
+* DerivedSources.cpp:
+
 2016-10-24  Zan Dobersek  
 
 [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file


Modified: trunk/Source/WebCore/DerivedSources.cpp (207771 => 207772)

--- trunk/Source/WebCore/DerivedSources.cpp	2016-10-24 18:53:09 UTC (rev 207771)
+++ trunk/Source/WebCore/DerivedSources.cpp	2016-10-24 20:19:23 UTC (rev 207772)
@@ -116,7 +116,6 @@
 #include "JSCoordinates.cpp"
 #include "JSCounter.cpp"
 #include "JSCrypto.cpp"
-#include "JSCSSCharsetRule.cpp"
 #if ENABLE(FONT_LOAD_EVENTS)
 #include "JSCSSFontFaceLoadEvent.cpp"
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207776] trunk/Source/WebCore

2016-10-24 Thread achristensen

Title: [207776] trunk/Source/WebCore








Revision 207776
Author achristen...@apple.com
Date 2016-10-24 13:53:28 -0700 (Mon, 24 Oct 2016)


Log Message
Fix Windows build after r207767 and r207769

* css/CSSAllInOne.cpp:
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSAllInOne.cpp
trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207775 => 207776)

--- trunk/Source/WebCore/ChangeLog	2016-10-24 20:47:04 UTC (rev 207775)
+++ trunk/Source/WebCore/ChangeLog	2016-10-24 20:53:28 UTC (rev 207776)
@@ -1,3 +1,11 @@
+2016-10-24  Alex Christensen  
+
+Fix Windows build after r207767 and r207769
+
+* css/CSSAllInOne.cpp:
+* platform/network/curl/ResourceHandleManager.cpp:
+(WebCore::getProtectionSpace):
+
 2016-10-24  Per Arne Vollan  
 
 [Win] AVCF based media engine does not block cross-site/cross-domain loads.


Modified: trunk/Source/WebCore/css/CSSAllInOne.cpp (207775 => 207776)

--- trunk/Source/WebCore/css/CSSAllInOne.cpp	2016-10-24 20:47:04 UTC (rev 207775)
+++ trunk/Source/WebCore/css/CSSAllInOne.cpp	2016-10-24 20:53:28 UTC (rev 207776)
@@ -32,7 +32,6 @@
 #include "CSSBorderImageSliceValue.cpp"
 #include "CSSCalculationValue.cpp"
 #include "CSSCanvasValue.cpp"
-#include "CSSCharsetRule.cpp"
 #include "CSSComputedStyleDeclaration.cpp"
 #include "CSSContentDistributionValue.cpp"
 #include "CSSCrossfadeValue.cpp"


Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (207775 => 207776)

--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2016-10-24 20:47:04 UTC (rev 207775)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2016-10-24 20:53:28 UTC (rev 207776)
@@ -423,7 +423,7 @@
 return false;
 
 String host = url.host();
-String protocol = url.protocol();
+StringView protocol = url.protocol();
 
 String realm;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207777] trunk/LayoutTests

2016-10-24 Thread achristensen

Title: [20] trunk/LayoutTests








Revision 20
Author achristen...@apple.com
Date 2016-10-24 14:01:53 -0700 (Mon, 24 Oct 2016)


Log Message
Rebase tests after r207767
https://bugs.webkit.org/show_bug.cgi?id=163891

* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
No more CSSCharsetRule.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (207776 => 20)

--- trunk/LayoutTests/ChangeLog	2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/ChangeLog	2016-10-24 21:01:53 UTC (rev 20)
@@ -1,3 +1,17 @@
+2016-10-24  Alex Christensen  
+
+Rebase tests after r207767
+https://bugs.webkit.org/show_bug.cgi?id=163891
+
+* js/dom/global-constructors-attributes-expected.txt:
+* platform/efl/js/dom/global-constructors-attributes-expected.txt:
+* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+* platform/win/js/dom/global-constructors-attributes-expected.txt:
+No more CSSCharsetRule.
+
 2016-10-24  Ryan Haddad  
 
 Rebaseline inspector/dom/getAccessibilityPropertiesForNode.html


Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (207776 => 20)

--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-10-24 21:01:53 UTC (rev 20)
@@ -113,11 +113,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').value is CSSCharsetRule
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').value is CSSFontFaceRule
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('set') is false


Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (207776 => 20)

--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2016-10-24 20:53:28 UTC (rev 207776)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2016-10-24 21:01:53 UTC (rev 20)
@@ -108,11 +108,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSS').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').value is CSSCharsetRule
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'CSSCharsetRule').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').value is CSSFontFaceRule
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSSFontFaceRule').hasOwnProperty('set') is fal

[webkit-changes] [207779] trunk/Source/WebCore

2016-10-24 Thread achristensen

Title: [207779] trunk/Source/WebCore








Revision 207779
Author achristen...@apple.com
Date 2016-10-24 14:17:14 -0700 (Mon, 24 Oct 2016)


Log Message
Fix AppleWin build after r207720.

* bindings/js/JSWebGLRenderingContextBaseCustom.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207778 => 207779)

--- trunk/Source/WebCore/ChangeLog	2016-10-24 21:16:17 UTC (rev 207778)
+++ trunk/Source/WebCore/ChangeLog	2016-10-24 21:17:14 UTC (rev 207779)
@@ -1,5 +1,11 @@
 2016-10-24  Alex Christensen  
 
+Fix AppleWin build after r207720.
+
+* bindings/js/JSWebGLRenderingContextBaseCustom.cpp:
+
+2016-10-24  Alex Christensen  
+
 Fix Windows build after r207767 and r207769
 
 * css/CSSAllInOne.cpp:


Modified: trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp (207778 => 207779)

--- trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp	2016-10-24 21:16:17 UTC (rev 207778)
+++ trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp	2016-10-24 21:17:14 UTC (rev 207779)
@@ -24,10 +24,11 @@
  */
 
 #include "config.h"
-#include "JSWebGLRenderingContextBase.h"
 
 #if ENABLE(WEBGL)
 
+#include "JSWebGLRenderingContextBase.h"
+
 #include "ANGLEInstancedArrays.h"
 #include "EXTBlendMinMax.h"
 #include "EXTFragDepth.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207780] trunk/Source/WebCore

2016-10-24 Thread achristensen

Title: [207780] trunk/Source/WebCore








Revision 207780
Author achristen...@apple.com
Date 2016-10-24 14:34:09 -0700 (Mon, 24 Oct 2016)


Log Message
Fix AppleWin build after r207720.

* html/canvas/OESVertexArrayObject.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207779 => 207780)

--- trunk/Source/WebCore/ChangeLog	2016-10-24 21:17:14 UTC (rev 207779)
+++ trunk/Source/WebCore/ChangeLog	2016-10-24 21:34:09 UTC (rev 207780)
@@ -2,6 +2,12 @@
 
 Fix AppleWin build after r207720.
 
+* html/canvas/OESVertexArrayObject.cpp:
+
+2016-10-24  Alex Christensen  
+
+Fix AppleWin build after r207720.
+
 * bindings/js/JSWebGLRenderingContextBaseCustom.cpp:
 
 2016-10-24  Alex Christensen  


Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp (207779 => 207780)

--- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp	2016-10-24 21:17:14 UTC (rev 207779)
+++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp	2016-10-24 21:34:09 UTC (rev 207780)
@@ -24,10 +24,11 @@
  */
 
 #include "config.h"
-#include "OESVertexArrayObject.h"
 
 #if ENABLE(WEBGL)
 
+#include "OESVertexArrayObject.h"
+
 #include "Extensions3D.h"
 #include "WebGLRenderingContext.h"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207785] trunk/Source/JavaScriptCore

2016-10-24 Thread achristensen

Title: [207785] trunk/Source/_javascript_Core








Revision 207785
Author achristen...@apple.com
Date 2016-10-24 15:51:59 -0700 (Mon, 24 Oct 2016)


Log Message
JSONParse should not crash with null Strings
https://bugs.webkit.org/show_bug.cgi?id=163918


Reviewed by Michael Saboff.

When JSONParse is called with a null String, it calls String::is8bit, which dereferences a null pointer.
This is happening with new work in the Fetch API, but callers of JSONParse should not have to check
if the String is null.

* API/tests/JSONParseTest.cpp: Added.
(testJSONParse):
* API/tests/JSONParseTest.h: Added.
* API/tests/testapi.c:
(main):
Test parsing null Strings.  They should have the same result as parsing empty Strings.
* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/JSONObject.cpp:
(JSC::JSONParse):
Check for null Strings.
* shell/PlatformWin.cmake:

Modified Paths

trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/shell/PlatformWin.cmake


Added Paths

trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp
trunk/Source/_javascript_Core/API/tests/JSONParseTest.h




Diff

Added: trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp (0 => 207785)

--- trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp	(rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSONParseTest.cpp	2016-10-24 22:51:59 UTC (rev 207785)
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSONParseTest.h"
+
+#include "JSCInlines.h"
+#include "JSGlobalObject.h"
+#include "JSONObject.h"
+#include "VM.h"
+#include 
+
+using namespace JSC;
+
+int testJSONParse()
+{
+bool failed = false;
+
+RefPtr vm = VM::create();
+
+JSLockHolder locker(vm.get());
+JSGlobalObject* globalObject = JSGlobalObject::create(*vm, JSGlobalObject::createStructure(*vm, jsNull()));
+
+ExecState* exec = globalObject->globalExec();
+JSValue v0 = JSONParse(exec, "");
+JSValue v1 = JSONParse(exec, "#$%^");
+JSValue v2 = JSONParse(exec, String());
+UChar emptyUCharArray[1] = { '\0' };
+JSValue v3 = JSONParse(exec, String(emptyUCharArray, 0));
+JSValue v4;
+JSValue v5 = JSONParse(exec, "123");
+
+failed = failed || (v0 != v1);
+failed = failed || (v1 != v2);
+failed = failed || (v2 != v3);
+failed = failed || (v3 != v4);
+failed = failed || (v4 == v5);
+
+vm = nullptr;
+
+if (failed)
+printf("FAIL: JSONParse String test.\n");
+else
+printf("PASS: JSONParse String test.\n");
+
+return failed;
+}


Added: trunk/Source/_javascript_Core/API/tests/JSONParseTest.h (0 => 207785)

--- trunk/Source/_javascript_Core/API/tests/JSONParseTest.h	(rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSONParseTest.h	2016-10-24 22:51:59 UTC (rev 207785)
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC.

[webkit-changes] [207795] trunk

2016-10-24 Thread achristensen

Title: [207795] trunk








Revision 207795
Author achristen...@apple.com
Date 2016-10-24 18:31:42 -0700 (Mon, 24 Oct 2016)


Log Message
URLParser should match old URL::parse with %2E in path
https://bugs.webkit.org/show_bug.cgi?id=163929

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Covered by updated API tests, which show that URLParser now matches URL::parse in these cases.
Also covered by newly failing web platform tests, which were failing before URLParser was enabled.
If https://github.com/whatwg/url/issues/87 is resolved we can change behavior to match.

* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
(WebCore::URLParser::parse):
(WebCore::URLParser::isPercentEncodedDot): Deleted.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/path-expected.txt:
* fast/url/standard-url-expected.txt:
* fetch/fetch-url-serialization-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fast/url/standard-url-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (207794 => 207795)

--- trunk/LayoutTests/ChangeLog	2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/ChangeLog	2016-10-25 01:31:42 UTC (rev 207795)
@@ -1,3 +1,14 @@
+2016-10-24  Alex Christensen  
+
+URLParser should match old URL::parse with %2E in path
+https://bugs.webkit.org/show_bug.cgi?id=163929
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/url/path-expected.txt:
+* fast/url/standard-url-expected.txt:
+* fetch/fetch-url-serialization-expected.txt:
+
 2016-10-24  Brady Eidson  
 
 IndexedDB 2.0: Support new IDBKeyRange interfaces.


Modified: trunk/LayoutTests/fast/url/path-expected.txt (207794 => 207795)

--- trunk/LayoutTests/fast/url/path-expected.txt	2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/fast/url/path-expected.txt	2016-10-25 01:31:42 UTC (rev 207795)
@@ -14,9 +14,9 @@
 PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
 PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
 PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
-PASS canonicalize('http://example.com/foo/%2e%2') is 'http://example.com/foo/.%2'
-PASS canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') is 'http://example.com/..bar'
+FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
 PASS canonicalize('http://example.com../..') is 'http://example.com//'
 PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
 PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'


Modified: trunk/LayoutTests/fast/url/standard-url-expected.txt (207794 => 207795)

--- trunk/LayoutTests/fast/url/standard-url-expected.txt	2016-10-25 00:45:03 UTC (rev 207794)
+++ trunk/LayoutTests/fast/url/standard-url-expected.txt	2016-10-25 01:31:42 UTC (rev 207795)
@@ -9,7 +9,7 @@
 PASS canonicalize('http://www.google.com') is 'http://www.google.com/'
 PASS canonicalize('http:user:@google.com:99?foo') is 'http://u...@google.com:99/?foo'
 PASS canonicalize('http://192.0x00A80001') is 'http://192.168.0.1/'
-PASS canonicalize('http://www/foo%2Ehtml') is 'http://www/foo.html'
+FAIL canonicalize('http://www/foo%2Ehtml') should be http://www/foo.html. Was http://www/foo%2Ehtml.
 PASS canonicalize('http://user:pass@/') is 'http://user:pass@/'
 PASS canonicalize('http://%25DOMAIN:foo...@foodomain.com/') is 'http://%25DOMAIN:foo...@foodomain.com/'
 PASS canonicalize('http:www.google.com\\foo') is 'http://www.google.com/foo'


Modified: trunk/LayoutTests/fetch/fetch-url-serializa

[webkit-changes] [207805] trunk

2016-10-24 Thread achristensen

Title: [207805] trunk








Revision 207805
Author achristen...@apple.com
Date 2016-10-24 21:40:23 -0700 (Mon, 24 Oct 2016)


Log Message
URLParser should match old URL::parse with %2E in path
https://bugs.webkit.org/show_bug.cgi?id=163929

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Covered by updated API tests, which show that URLParser now matches URL::parse in these cases.
Also covered by newly failing web platform tests, which were failing before URLParser was enabled.
If https://github.com/whatwg/url/issues/87 is resolved we can change behavior to match.

* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
(WebCore::URLParser::parse):
(WebCore::URLParser::isPercentEncodedDot): Deleted.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/path-expected.txt:
* fast/url/standard-url-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fast/url/standard-url-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (207804 => 207805)

--- trunk/LayoutTests/ChangeLog	2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/ChangeLog	2016-10-25 04:40:23 UTC (rev 207805)
@@ -1,3 +1,13 @@
+2016-10-24  Alex Christensen  
+
+URLParser should match old URL::parse with %2E in path
+https://bugs.webkit.org/show_bug.cgi?id=163929
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/url/path-expected.txt:
+* fast/url/standard-url-expected.txt:
+
 2016-10-24  Zalan Bujtas  
 
 Do not update selection rect on dirty lineboxes.


Modified: trunk/LayoutTests/fast/url/path-expected.txt (207804 => 207805)

--- trunk/LayoutTests/fast/url/path-expected.txt	2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/fast/url/path-expected.txt	2016-10-25 04:40:23 UTC (rev 207805)
@@ -14,9 +14,9 @@
 PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
 PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
 PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
-PASS canonicalize('http://example.com/foo/%2e%2') is 'http://example.com/foo/.%2'
-PASS canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') is 'http://example.com/..bar'
+FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
 PASS canonicalize('http://example.com../..') is 'http://example.com//'
 PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
 PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'


Modified: trunk/LayoutTests/fast/url/standard-url-expected.txt (207804 => 207805)

--- trunk/LayoutTests/fast/url/standard-url-expected.txt	2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/fast/url/standard-url-expected.txt	2016-10-25 04:40:23 UTC (rev 207805)
@@ -9,7 +9,7 @@
 PASS canonicalize('http://www.google.com') is 'http://www.google.com/'
 PASS canonicalize('http:user:@google.com:99?foo') is 'http://u...@google.com:99/?foo'
 PASS canonicalize('http://192.0x00A80001') is 'http://192.168.0.1/'
-PASS canonicalize('http://www/foo%2Ehtml') is 'http://www/foo.html'
+FAIL canonicalize('http://www/foo%2Ehtml') should be http://www/foo.html. Was http://www/foo%2Ehtml.
 PASS canonicalize('http://user:pass@/') is 'http://user:pass@/'
 PASS canonicalize('http://%25DOMAIN:foo...@foodomain.com/') is 'http://%25DOMAIN:foo...@foodomain.com/'
 PASS canonicalize('http:www.google.com\\foo') is 'http://www.google.com/foo'


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207804 => 207805)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-25 04:19:09 UTC (rev 207804)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-25 04:40:23

[webkit-changes] [207808] trunk/Source/ThirdParty/ANGLE

2016-10-25 Thread achristensen

Title: [207808] trunk/Source/ThirdParty/ANGLE








Revision 207808
Author achristen...@apple.com
Date 2016-10-24 22:26:35 -0700 (Mon, 24 Oct 2016)


Log Message
Remove unused ANGLE.vcxproj after switching to CMake on Windows

* ANGLE.vcxproj: Removed.
* ANGLE.vcxproj/ANGLERelease.props: Removed.
* ANGLE.vcxproj/DirectX32.props: Removed.
* ANGLE.vcxproj/DirectX64.props: Removed.
* ANGLE.vcxproj/libEGL.vcxproj: Removed.
* ANGLE.vcxproj/libEGL.vcxproj.filters: Removed.
* ANGLE.vcxproj/libEGLCommon.props: Removed.
* ANGLE.vcxproj/libGLESv2.vcxproj: Removed.
* ANGLE.vcxproj/libGLESv2.vcxproj.filters: Removed.
* ANGLE.vcxproj/libGLESv2Common.props: Removed.
* ANGLE.vcxproj/preprocessor.vcxproj: Removed.
* ANGLE.vcxproj/preprocessor.vcxproj.filters: Removed.
* ANGLE.vcxproj/translatorCommon.props: Removed.
* ANGLE.vcxproj/translator_common.vcxproj: Removed.
* ANGLE.vcxproj/translator_common.vcxproj.filters: Removed.
* ANGLE.vcxproj/translator_glsl.vcxproj: Removed.
* ANGLE.vcxproj/translator_glsl.vcxproj.filters: Removed.
* ANGLE.vcxproj/translator_hlsl.vcxproj: Removed.
* ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Removed.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog


Removed Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.vcxproj/




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (207807 => 207808)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-25 05:22:40 UTC (rev 207807)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-25 05:26:35 UTC (rev 207808)
@@ -1,3 +1,27 @@
+2016-10-24  Alex Christensen  
+
+Remove unused ANGLE.vcxproj after switching to CMake on Windows
+
+* ANGLE.vcxproj: Removed.
+* ANGLE.vcxproj/ANGLERelease.props: Removed.
+* ANGLE.vcxproj/DirectX32.props: Removed.
+* ANGLE.vcxproj/DirectX64.props: Removed.
+* ANGLE.vcxproj/libEGL.vcxproj: Removed.
+* ANGLE.vcxproj/libEGL.vcxproj.filters: Removed.
+* ANGLE.vcxproj/libEGLCommon.props: Removed.
+* ANGLE.vcxproj/libGLESv2.vcxproj: Removed.
+* ANGLE.vcxproj/libGLESv2.vcxproj.filters: Removed.
+* ANGLE.vcxproj/libGLESv2Common.props: Removed.
+* ANGLE.vcxproj/preprocessor.vcxproj: Removed.
+* ANGLE.vcxproj/preprocessor.vcxproj.filters: Removed.
+* ANGLE.vcxproj/translatorCommon.props: Removed.
+* ANGLE.vcxproj/translator_common.vcxproj: Removed.
+* ANGLE.vcxproj/translator_common.vcxproj.filters: Removed.
+* ANGLE.vcxproj/translator_glsl.vcxproj: Removed.
+* ANGLE.vcxproj/translator_glsl.vcxproj.filters: Removed.
+* ANGLE.vcxproj/translator_hlsl.vcxproj: Removed.
+* ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Removed.
+
 2016-09-09  Dean Jackson  
 
 [ANGLE] instantiation of variable 'gl::GLTypeToGLenum::value' required here, but no definition is available






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207811] trunk/LayoutTests

2016-10-25 Thread achristensen

Title: [207811] trunk/LayoutTests








Revision 207811
Author achristen...@apple.com
Date 2016-10-25 00:01:57 -0700 (Tue, 25 Oct 2016)


Log Message
Rebase test after r207805
https://bugs.webkit.org/show_bug.cgi?id=163929

* fetch/fetch-url-serialization-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (207810 => 207811)

--- trunk/LayoutTests/ChangeLog	2016-10-25 06:18:13 UTC (rev 207810)
+++ trunk/LayoutTests/ChangeLog	2016-10-25 07:01:57 UTC (rev 207811)
@@ -1,3 +1,10 @@
+2016-10-25  Alex Christensen  
+
+Rebase test after r207805
+https://bugs.webkit.org/show_bug.cgi?id=163929
+
+* fetch/fetch-url-serialization-expected.txt:
+
 2016-10-24  Ryosuke Niwa  
 
 Custom elements reactions should have a queue per element


Modified: trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt (207810 => 207811)

--- trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-25 06:18:13 UTC (rev 207810)
+++ trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-25 07:01:57 UTC (rev 207811)
@@ -123,9 +123,9 @@
 PASS Testing Request url 'http://example.com/foo/bar/../ton/../../a' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../..' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../../ton' with base 'about:blank' 
-PASS Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' 
-PASS Testing Request url 'http://example.com/foo/%2e%2' with base 'about:blank' 
-PASS Testing Request url 'http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar' with base 'about:blank' 
+FAIL Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' assert_equals: expected "http://example.com/foo/" but got "http://example.com/foo/%2e"
+FAIL Testing Request url 'http://example.com/foo/%2e%2' with base 'about:blank' assert_equals: expected "http://example.com/foo/.%2" but got "http://example.com/foo/%2e%2"
+FAIL Testing Request url 'http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar' with base 'about:blank' assert_equals: expected "http://example.com/..bar" but got "http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar"
 PASS Testing Request url 'http://example.com../..' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/bar//../..' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/bar//..' with base 'about:blank' 
@@ -154,8 +154,8 @@
 PASS Testing Request url 'http://[www.google.com]/' with base 'about:blank' 
 PASS Testing Request url 'http://www.google.com' with base 'about:blank' 
 PASS Testing Request url 'http://192.0x00A80001' with base 'about:blank' 
-PASS Testing Request url 'http://www/foo%2Ehtml' with base 'about:blank' 
-PASS Testing Request url 'http://www/foo/%2E/html' with base 'about:blank' 
+FAIL Testing Request url 'http://www/foo%2Ehtml' with base 'about:blank' assert_equals: expected "http://www/foo.html" but got "http://www/foo%2Ehtml"
+FAIL Testing Request url 'http://www/foo/%2E/html' with base 'about:blank' assert_equals: expected "http://www/foo/html" but got "http://www/foo/%2E/html"
 PASS Testing Request url 'http://user:pass@/' with base 'about:blank' 
 PASS Testing Request url 'http://%25DOMAIN:foo...@foodomain.com/' with base 'about:blank' 
 PASS Testing Request url 'http:\\www.google.com\foo' with base 'about:blank' 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207857] trunk/Source/WebKit2

2016-10-25 Thread achristensen

Title: [207857] trunk/Source/WebKit2








Revision 207857
Author achristen...@apple.com
Date 2016-10-25 16:59:32 -0700 (Tue, 25 Oct 2016)


Log Message
CMake build fix.

* PlatformMac.cmake:
* Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
Explicitly call AtomicString::string to make the String constructor no longer ambiguous.
It couldn't decide whether to use operator const String& or operator NSString*.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake
trunk/Source/WebKit2/Shared/WebHitTestResultData.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (207856 => 207857)

--- trunk/Source/WebKit2/ChangeLog	2016-10-25 23:42:43 UTC (rev 207856)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-25 23:59:32 UTC (rev 207857)
@@ -1,3 +1,13 @@
+2016-10-25  Alex Christensen  
+
+CMake build fix.
+
+* PlatformMac.cmake:
+* Shared/WebHitTestResultData.cpp:
+(WebKit::WebHitTestResultData::WebHitTestResultData):
+Explicitly call AtomicString::string to make the String constructor no longer ambiguous.
+It couldn't decide whether to use operator const String& or operator NSString*.
+
 2016-10-25  Carlos Garcia Campos  
 
 [SOUP] Network process assertion in NetworkDataTask::continueHTTPRedirection


Modified: trunk/Source/WebKit2/PlatformMac.cmake (207856 => 207857)

--- trunk/Source/WebKit2/PlatformMac.cmake	2016-10-25 23:42:43 UTC (rev 207856)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2016-10-25 23:59:32 UTC (rev 207857)
@@ -154,6 +154,7 @@
 Shared/mac/WebHitTestResultData.mm
 Shared/mac/WebMemorySampler.mac.mm
 
+UIProcess/WebContextMenuListenerProxy.cpp
 UIProcess/WebResourceLoadStatisticsStore.cpp
 
 UIProcess/Automation/WebAutomationSession.cpp


Modified: trunk/Source/WebKit2/Shared/WebHitTestResultData.cpp (207856 => 207857)

--- trunk/Source/WebKit2/Shared/WebHitTestResultData.cpp	2016-10-25 23:42:43 UTC (rev 207856)
+++ trunk/Source/WebKit2/Shared/WebHitTestResultData.cpp	2016-10-25 23:59:32 UTC (rev 207857)
@@ -46,7 +46,7 @@
 , absoluteMediaURL(hitTestResult.absoluteMediaURL().string())
 , linkLabel(hitTestResult.textContent())
 , linkTitle(hitTestResult.titleDisplayString())
-, linkSuggestedFilename(hitTestResult.URLElementDownloadAttribute())
+, linkSuggestedFilename(hitTestResult.URLElementDownloadAttribute().string())
 , isContentEditable(hitTestResult.isContentEditable())
 , elementBoundingBox(elementBoundingBoxInWindowCoordinates(hitTestResult))
 , isScrollbar(hitTestResult.scrollbar())
@@ -66,7 +66,7 @@
 , absoluteMediaURL(hitTestResult.absoluteMediaURL().string())
 , linkLabel(hitTestResult.textContent())
 , linkTitle(hitTestResult.titleDisplayString())
-, linkSuggestedFilename(hitTestResult.URLElementDownloadAttribute())
+, linkSuggestedFilename(hitTestResult.URLElementDownloadAttribute().string())
 , isContentEditable(hitTestResult.isContentEditable())
 , elementBoundingBox(elementBoundingBoxInWindowCoordinates(hitTestResult))
 , isScrollbar(hitTestResult.scrollbar())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208037] trunk/Source/ThirdParty/ANGLE

2016-10-27 Thread achristensen

Title: [208037] trunk/Source/ThirdParty/ANGLE








Revision 208037
Author achristen...@apple.com
Date 2016-10-27 23:10:33 -0700 (Thu, 27 Oct 2016)


Log Message
Fix Windows WebGL build after r208036
https://bugs.webkit.org/show_bug.cgi?id=164101

* CMakeLists.txt:
Add new files, remove deleted files.

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208036 => 208037)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:00:29 UTC (rev 208036)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:10:33 UTC (rev 208037)
@@ -54,50 +54,13 @@
 )
 
 add_library(libANGLE STATIC
-src/common/Float16ToFloat32.cpp
-src/common/string_utils.cpp
-src/compiler/translator/AddAndTrueToLoopCondition.cpp
-src/compiler/translator/AddDefaultReturnStatements.cpp
-src/compiler/translator/BreakVariableAliasingInInnerLoops.cpp
-src/compiler/translator/EmulateGLFragColorBroadcast.cpp
-src/compiler/translator/ExpandIntegerPowExpressions.cpp
-src/compiler/translator/RewriteTexelFetchOffset.cpp
-src/compiler/translator/RewriteUnaryMinusOperatorInt.cpp
-src/compiler/translator/SimplifyLoopConditions.cpp
-src/compiler/translator/SplitSequenceOperator.cpp
-src/compiler/translator/TextureFunctionHLSL.cpp
-src/compiler/translator/UseInterfaceBlockFields.cpp
-src/image_util/copyimage.cpp
-src/image_util/imageformats.cpp
-src/image_util/loadimage_etc.cpp
-src/image_util/loadimage.cpp
-src/libANGLE/format_map_autogen.cpp
-src/libANGLE/format_map_autogen.cpp
-src/libANGLE/formatutils.cpp
-src/libANGLE/HandleRangeAllocator.cpp
-src/libANGLE/Path.cpp
-src/libANGLE/queryutils.cpp
-src/libANGLE/renderer/ContextImpl.cpp
-src/libANGLE/renderer/d3d/d3d11/Context11.cpp
-src/libANGLE/renderer/d3d/d3d11/dxgi_format_map_autogen.cpp
-src/libANGLE/renderer/d3d/d3d11/StreamProducerNV12.cpp
-src/libANGLE/renderer/d3d/d3d11/texture_format_table.cpp
-src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
-src/libANGLE/renderer/d3d/d3d11/TransformFeedback11.cpp
-src/libANGLE/renderer/d3d/d3d11/win32/NativeWindow11Win32.cpp
-src/libANGLE/renderer/d3d/d3d9/Context9.cpp
-src/libANGLE/renderer/d3d/d3d9/NativeWindow9.cpp
-src/libANGLE/renderer/d3d/NativeWindowD3D.cpp
-src/libANGLE/renderer/Format_autogen.cpp
-src/libANGLE/renderer/Format.cpp
-src/libANGLE/renderer/load_functions_table_autogen.cpp
-src/libANGLE/signal_utils.cpp
-src/libANGLE/validationES31.cpp
 src/common/angleutils.cpp
 src/common/debug.cpp
 src/common/event_tracer.cpp
+src/common/Float16ToFloat32.cpp
 src/common/mathutil.cpp
 src/common/MemoryBuffer.cpp
+src/common/string_utils.cpp
 src/common/tls.cpp
 src/common/utilities.cpp
 src/compiler/preprocessor/DiagnosticsBase.cpp
@@ -111,10 +74,13 @@
 src/compiler/preprocessor/Preprocessor.cpp
 src/compiler/preprocessor/Token.cpp
 src/compiler/preprocessor/Tokenizer.cpp
+src/compiler/translator/AddAndTrueToLoopCondition.cpp
+src/compiler/translator/AddDefaultReturnStatements.cpp
 src/compiler/translator/ArrayReturnValueToOutParameter.cpp
 src/compiler/translator/ASTMetadataHLSL.cpp
 src/compiler/translator/blocklayout.cpp
 src/compiler/translator/blocklayoutHLSL.cpp
+src/compiler/translator/BreakVariableAliasingInInnerLoops.cpp
 src/compiler/translator/BuiltInFunctionEmulator.cpp
 src/compiler/translator/BuiltInFunctionEmulatorGLSL.cpp
 src/compiler/translator/BuiltInFunctionEmulatorHLSL.cpp
@@ -130,7 +96,9 @@
 src/compiler/translator/depgraph/DependencyGraphTraverse.cpp
 src/compiler/translator/Diagnostics.cpp
 src/compiler/translator/DirectiveHandler.cpp
+src/compiler/translator/EmulateGLFragColorBroadcast.cpp
 src/compiler/translator/EmulatePrecision.cpp
+src/compiler/translator/ExpandIntegerPowExpressions.cpp
 src/compiler/translator/ExtensionGLSL.cpp
 src/compiler/translator/FlagStd140Structs.cpp
 src/compiler/translator/ForLoopUnroll.cpp
@@ -163,6 +131,8 @@
 src/compiler/translator/RemoveSwitchFallThrough.cpp
 src/compiler/translator/RewriteDoWhile.cpp
 src/compiler/translator/RewriteElseBlocks.cpp
+src/compiler/translator/RewriteTexelFetchOffset.cpp
+src/compiler/translator/RewriteUnaryMinusOperatorInt.cpp
 src/compiler/translator/ScalarizeVecAndMatConstructorArgs.cpp
 src/compiler/translator/SearchSymbol.cpp
 src/compiler/translator/SearchSymbol.cpp
@@ -172,8 +142,11 @@
 src/compiler/translator/SeparateExpressionsReturningArrays.cpp
 src/compiler/translator/ShaderLang.cpp
 src/compiler/translator/ShaderVars.cpp
+src/compiler/translator/SimplifyLoopConditions.cpp
+src/compiler/translator/SplitSequenceOperator.cpp
 src/compiler/translator/StructureHLSL.cpp
 src/compiler/transl

[webkit-changes] [208040] trunk/Source

2016-10-28 Thread achristensen

Title: [208040] trunk/Source








Revision 208040
Author achristen...@apple.com
Date 2016-10-28 00:08:32 -0700 (Fri, 28 Oct 2016)


Log Message

Source/ThirdParty/ANGLE:
Fix Windows WebGL build after r208036
https://bugs.webkit.org/show_bug.cgi?id=164101

* CMakeLists.txt:

Source/WebCore:
Fix Windows WebGL build after r208022
https://bugs.webkit.org/show_bug.cgi?id=164091

* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::getExtensions):

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208039 => 208040)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:27:29 UTC (rev 208039)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:08:32 UTC (rev 208040)
@@ -37,7 +37,6 @@
 src/libGLESv2/entry_points_gles_2_0.cpp
 src/libGLESv2/entry_points_gles_2_0_ext.cpp
 src/libGLESv2/entry_points_gles_3_0.cpp
-src/libGLESv2/entry_points_gles_3_0_ext.cpp
 src/libGLESv2/entry_points_gles_3_1.cpp
 src/libGLESv2/global_state.cpp
 src/libGLESv2/libGLESv2.cpp
@@ -90,10 +89,6 @@
 src/compiler/translator/Compiler.cpp
 src/compiler/translator/ConstantUnion.cpp
 src/compiler/translator/DeferGlobalInitializers.cpp
-src/compiler/translator/depgraph/DependencyGraph.cpp
-src/compiler/translator/depgraph/DependencyGraphBuilder.cpp
-src/compiler/translator/depgraph/DependencyGraphOutput.cpp
-src/compiler/translator/depgraph/DependencyGraphTraverse.cpp
 src/compiler/translator/Diagnostics.cpp
 src/compiler/translator/DirectiveHandler.cpp
 src/compiler/translator/EmulateGLFragColorBroadcast.cpp
@@ -147,8 +142,6 @@
 src/compiler/translator/StructureHLSL.cpp
 src/compiler/translator/SymbolTable.cpp
 src/compiler/translator/TextureFunctionHLSL.cpp
-src/compiler/translator/timing/RestrictFragmentShaderTiming.cpp
-src/compiler/translator/timing/RestrictVertexShaderTiming.cpp
 src/compiler/translator/TranslatorESSL.cpp
 src/compiler/translator/TranslatorGLSL.cpp
 src/compiler/translator/TranslatorHLSL.cpp
@@ -180,17 +173,13 @@
 src/libANGLE/Config.cpp
 src/libANGLE/Context.cpp
 src/libANGLE/ContextState.cpp
-src/libANGLE/Data.cpp
 src/libANGLE/Debug.cpp
 src/libANGLE/Device.cpp
 src/libANGLE/Display.cpp
 src/libANGLE/Error.cpp
 src/libANGLE/Fence.cpp
-src/libANGLE/Float16ToFloat32.cpp
 src/libANGLE/format_map_autogen.cpp
-src/libANGLE/format_map_autogen.cpp
 src/libANGLE/formatutils.cpp
-src/libANGLE/formatutils.cpp
 src/libANGLE/Framebuffer.cpp
 src/libANGLE/FramebufferAttachment.cpp
 src/libANGLE/HandleAllocator.cpp
@@ -208,7 +197,6 @@
 src/libANGLE/renderer/ContextImpl.cpp
 src/libANGLE/renderer/d3d/BufferD3D.cpp
 src/libANGLE/renderer/d3d/CompilerD3D.cpp
-src/libANGLE/renderer/d3d/copyimage.cpp
 src/libANGLE/renderer/d3d/d3d11/Blit11.cpp
 src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
 src/libANGLE/renderer/d3d/d3d11/Clear11.cpp
@@ -222,7 +210,6 @@
 src/libANGLE/renderer/d3d/d3d11/Image11.cpp
 src/libANGLE/renderer/d3d/d3d11/IndexBuffer11.cpp
 src/libANGLE/renderer/d3d/d3d11/InputLayoutCache.cpp
-src/libANGLE/renderer/d3d/d3d11/load_functions_table_autogen.cpp
 src/libANGLE/renderer/d3d/d3d11/PixelTransfer11.cpp
 src/libANGLE/renderer/d3d/d3d11/Query11.cpp
 src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
@@ -231,18 +218,15 @@
 src/libANGLE/renderer/d3d/d3d11/RenderTarget11.cpp
 src/libANGLE/renderer/d3d/d3d11/ShaderExecutable11.cpp
 src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
-src/libANGLE/renderer/d3d/d3d11/Stream11.cpp
 src/libANGLE/renderer/d3d/d3d11/StreamProducerNV12.cpp
 src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp
 src/libANGLE/renderer/d3d/d3d11/texture_format_table_autogen.cpp
 src/libANGLE/renderer/d3d/d3d11/texture_format_table.cpp
 src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
-src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
 src/libANGLE/renderer/d3d/d3d11/TransformFeedback11.cpp
 src/libANGLE/renderer/d3d/d3d11/Trim11.cpp
 src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp
 src/libANGLE/renderer/d3d/d3d11/VertexBuffer11.cpp
-src/libANGLE/renderer/d3d/d3d11/win32/NativeWindow.cpp
 src/libANGLE/renderer/d3d/d3d11/win32/Na

[webkit-changes] [208041] trunk/Source/ThirdParty/ANGLE

2016-10-28 Thread achristensen

Title: [208041] trunk/Source/ThirdParty/ANGLE








Revision 208041
Author achristen...@apple.com
Date 2016-10-28 00:17:35 -0700 (Fri, 28 Oct 2016)


Log Message
Another build fix.

* CMakeLists.txt:

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208040 => 208041)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:08:32 UTC (rev 208040)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:17:35 UTC (rev 208041)
@@ -233,6 +233,7 @@
 src/libANGLE/renderer/d3d/d3d9/Context9.cpp
 src/libANGLE/renderer/d3d/d3d9/DebugAnnotator9.cpp
 src/libANGLE/renderer/d3d/d3d9/Fence9.cpp
+src/libANGLE/renderer/d3d/d3d9/formatutils9.cpp
 src/libANGLE/renderer/d3d/d3d9/Framebuffer9.cpp
 src/libANGLE/renderer/d3d/d3d9/Image9.cpp
 src/libANGLE/renderer/d3d/d3d9/IndexBuffer9.cpp
@@ -251,7 +252,6 @@
 src/libANGLE/renderer/d3d/DisplayD3D.cpp
 src/libANGLE/renderer/d3d/DynamicHLSL.cpp
 src/libANGLE/renderer/d3d/EGLImageD3D.cpp
-src/libANGLE/renderer/d3d/formatutilsD3D.cpp
 src/libANGLE/renderer/d3d/FramebufferD3D.cpp
 src/libANGLE/renderer/d3d/HLSLCompiler.cpp
 src/libANGLE/renderer/d3d/ImageD3D.cpp


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (208040 => 208041)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-28 07:08:32 UTC (rev 208040)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-28 07:17:35 UTC (rev 208041)
@@ -1,5 +1,11 @@
 2016-10-28  Alex Christensen  
 
+Another build fix.
+
+* CMakeLists.txt:
+
+2016-10-28  Alex Christensen  
+
 Fix Windows WebGL build after r208036
 https://bugs.webkit.org/show_bug.cgi?id=164101
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208081] trunk/Source/WebKit2

2016-10-28 Thread achristensen

Title: [208081] trunk/Source/WebKit2








Revision 208081
Author achristen...@apple.com
Date 2016-10-28 16:39:36 -0700 (Fri, 28 Oct 2016)


Log Message
Rename SharedMemoryMac to SharedMemoryCocoa
https://bugs.webkit.org/show_bug.cgi?id=164156

Patch by Megan Gardner  on 2016-10-28
Reviewed by Alex Christensen.

Renamed SharedMemoryMac to SharedMemoryCocoa, as it runs on all cocoa platforms, not exclusively just mac, and
thus should be named to reflect that reality.

* Platform/cocoa: Added.
* Platform/cocoa/SharedMemoryCocoa.cpp: Copied from Source/WebKit2/Platform/mac/SharedMemoryMac.cpp.
* Platform/mac/SharedMemoryMac.cpp: Removed.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Platform/cocoa/
trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp


Removed Paths

trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208080 => 208081)

--- trunk/Source/WebKit2/ChangeLog	2016-10-28 23:35:14 UTC (rev 208080)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-28 23:39:36 UTC (rev 208081)
@@ -1,3 +1,18 @@
+2016-10-28  Megan Gardner  
+
+Rename SharedMemoryMac to SharedMemoryCocoa
+https://bugs.webkit.org/show_bug.cgi?id=164156
+
+Reviewed by Alex Christensen.
+
+Renamed SharedMemoryMac to SharedMemoryCocoa, as it runs on all cocoa platforms, not exclusively just mac, and
+thus should be named to reflect that reality.
+
+* Platform/cocoa: Added.
+* Platform/cocoa/SharedMemoryCocoa.cpp: Copied from Source/WebKit2/Platform/mac/SharedMemoryMac.cpp.
+* Platform/mac/SharedMemoryMac.cpp: Removed.
+* WebKit2.xcodeproj/project.pbxproj:
+
 2016-10-28  Antti Koivisto  
 
 Enable CFNetwork connection cache fast lane for WebKit2


Copied: trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp (from rev 208080, trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp) (0 => 208081)

--- trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp	(rev 0)
+++ trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp	2016-10-28 23:39:36 UTC (rev 208081)
@@ -0,0 +1,264 @@
+/*
+ * Copyright (C) 2010 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "SharedMemory.h"
+
+#include "Decoder.h"
+#include "Encoder.h"
+#include "Logging.h"
+#include "MachPort.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+namespace WebKit {
+
+SharedMemory::Handle::Handle()
+: m_port(MACH_PORT_NULL)
+, m_size(0)
+{
+}
+
+SharedMemory::Handle::~Handle()
+{
+clear();
+}
+
+bool SharedMemory::Handle::isNull() const
+{
+return !m_port;
+}
+
+void SharedMemory::Handle::clear()
+{
+if (m_port)
+mach_port_deallocate(mach_task_self(), m_port);
+
+m_port = MACH_PORT_NULL;
+m_size = 0;
+}
+
+void SharedMemory::Handle::encode(IPC::Encoder& encoder) const
+{
+encoder << static_cast(m_size);
+encoder << IPC::MachPort(m_port, MACH_MSG_TYPE_MOVE_SEND);
+m_port = MACH_PORT_NULL;
+}
+
+bool SharedMemory::Handle::decode(IPC::Decoder& decoder, Handle& handle)
+{
+ASSERT(!handle.m_port);
+ASSERT(!handle.m_size);
+
+uint64_t size;
+if (!decoder.decode(size))
+return false;
+
+IPC::MachPort machPort;
+if (!decoder.decode(machPort))
+return false;
+
+handle.m_size = size;
+handle.m_port = machPort.port();
+return true;
+}
+
+static inline void* toPointer(mach_vm_address_t address)
+{
+return reinterpret_cast(static_cast(address));
+}
+
+static inline mach_vm_

[webkit-changes] [208086] trunk

2016-10-28 Thread achristensen

Title: [208086] trunk








Revision 208086
Author achristen...@apple.com
Date 2016-10-28 17:17:01 -0700 (Fri, 28 Oct 2016)


Log Message
URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
https://bugs.webkit.org/show_bug.cgi?id=164154

Reviewed by Andy Estes.

Source/WebCore:

This is needed to match behavior of all browsers.
This is being discussed in the spec at https://github.com/whatwg/url/issues/148

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parseHostAndPort):
Only try to parse and canonicalize the host as an IPv4 address if the scheme is special (http, wss, etc.)

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208085 => 208086)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
@@ -1,3 +1,19 @@
+2016-10-28  Alex Christensen  
+
+URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
+https://bugs.webkit.org/show_bug.cgi?id=164154
+
+Reviewed by Andy Estes.
+
+This is needed to match behavior of all browsers.
+This is being discussed in the spec at https://github.com/whatwg/url/issues/148
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::parseHostAndPort):
+Only try to parse and canonicalize the host as an IPv4 address if the scheme is special (http, wss, etc.)
+
 2016-10-28  Chris Dumez  
 
 DOMStringMap reports properties as non-enumerable


Modified: trunk/Source/WebCore/platform/URLParser.cpp (208085 => 208086)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:17:01 UTC (rev 208086)
@@ -2572,25 +2572,28 @@
 if (isInvalidDomainCharacter(*iterator))
 return false;
 }
-if (auto address = parseIPv4Host(CodePointIterator(hostIterator, iterator))) {
-serializeIPv4(address.value());
-m_url.m_hostEnd = currentPosition(iterator);
-if (iterator.atEnd()) {
-m_url.m_portEnd = currentPosition(iterator);
-return true;
+if (m_urlIsSpecial) {
+if (auto address = parseIPv4Host(CodePointIterator(hostIterator, iterator))) {
+serializeIPv4(address.value());
+m_url.m_hostEnd = currentPosition(iterator);
+if (iterator.atEnd()) {
+m_url.m_portEnd = currentPosition(iterator);
+return true;
+}
+return parsePort(iterator);
 }
-return parsePort(iterator);
 }
 for (; hostIterator != iterator; ++hostIterator) {
-if (LIKELY(!isTabOrNewline(*hostIterator))) {
-if (m_urlIsSpecial) {
-if (UNLIKELY(isASCIIUpper(*hostIterator)))
-syntaxViolation(hostIterator);
-appendToASCIIBuffer(toASCIILower(*hostIterator));
-} else
-appendToASCIIBuffer(*hostIterator);
+if (UNLIKELY(isTabOrNewline(*hostIterator))) {
+syntaxViolation(hostIterator);
+continue;
+}
+if (m_urlIsSpecial) {
+if (UNLIKELY(isASCIIUpper(*hostIterator)))
+syntaxViolation(hostIterator);
+appendToASCIIBuffer(toASCIILower(*hostIterator));
 } else
-syntaxViolation(hostIterator);
+appendToASCIIBuffer(*hostIterator);
 }
 m_url.m_hostEnd = currentPosition(iterator);
 if (!hostIterator.atEnd())


Modified: trunk/Tools/ChangeLog (208085 => 208086)

--- trunk/Tools/ChangeLog	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Tools/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
@@ -1,3 +1,13 @@
+2016-10-28  Alex Christensen  
+
+URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
+https://bugs.webkit.org/show_bug.cgi?id=164154
+
+Reviewed by Andy Estes.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::TEST_F):
+
 2016-10-28  Sam Weinig  
 
 [WebIDL] Update parser and code generators to only access type information through the type property


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (208085 => 208086)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-10-29 00:17:01 UTC (rev 208086)
@@ -949,6 +949,14 @@

[webkit-changes] [208087] trunk

2016-10-28 Thread achristensen

Title: [208087] trunk








Revision 208087
Author achristen...@apple.com
Date 2016-10-28 17:20:38 -0700 (Fri, 28 Oct 2016)


Log Message
Partially revert 207805 after resolution in URL spec issue 87
https://bugs.webkit.org/show_bug.cgi?id=164142

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Covered by updated layout tests and API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
Treat %2e%2e as .. and %2e as . but only if it is entirety of the path segment.
There are tests for URLs like http://host/abc%2edef which have not changed because
the %2e is not the entirety of the path segment.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/path-expected.txt:
* fetch/fetch-url-serialization-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208086 => 208087)

--- trunk/LayoutTests/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/ChangeLog	2016-10-29 00:20:38 UTC (rev 208087)
@@ -1,3 +1,13 @@
+2016-10-28  Alex Christensen  
+
+Partially revert 207805 after resolution in URL spec issue 87
+https://bugs.webkit.org/show_bug.cgi?id=164142
+
+Reviewed by Andy Estes.
+
+* fast/url/path-expected.txt:
+* fetch/fetch-url-serialization-expected.txt:
+
 2016-10-28  Chris Dumez  
 
 DOMStringMap reports properties as non-enumerable


Modified: trunk/LayoutTests/fast/url/path-expected.txt (208086 => 208087)

--- trunk/LayoutTests/fast/url/path-expected.txt	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/fast/url/path-expected.txt	2016-10-29 00:20:38 UTC (rev 208087)
@@ -14,9 +14,9 @@
 PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
 PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
 PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
 FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
-FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/%2e.bar.
 PASS canonicalize('http://example.com../..') is 'http://example.com//'
 PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
 PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'


Modified: trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt (208086 => 208087)

--- trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-29 00:20:38 UTC (rev 208087)
@@ -123,9 +123,9 @@
 PASS Testing Request url 'http://example.com/foo/bar/../ton/../../a' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../..' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../../ton' with base 'about:blank' 
-FAIL Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' assert_equals: expected "http://example.com/foo/" but got "http://example.com/foo/%2e"
+PASS Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' 
 FAIL Testing Request url 'http://example.com/foo/%2e%2' with base 'about:blank' assert_equals: expected "http://example.com/foo/.%2" but got "http://example.com/foo/%2e%2"
-FAIL Testing Request url 'http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar' with base 'about:blank' assert_equals: expected "http://example.com/..bar" but got "http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar"
+FAIL Testing Request url 'http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar' with b

[webkit-changes] [208089] trunk

2016-10-28 Thread achristensen

Title: [208089] trunk








Revision 208089
Author achristen...@apple.com
Date 2016-10-28 17:31:42 -0700 (Fri, 28 Oct 2016)


Log Message
Unreviewed, rolling out r207700.
https://bugs.webkit.org/show_bug.cgi?id=164168

We are ready after r208086 (Requested by alexchristensen on
#webkit).

Reverted changeset:

"Unreviewed, rolling out r207582."
https://bugs.webkit.org/show_bug.cgi?id=163819
http://trac.webkit.org/changeset/207700

Patch by Commit Queue  on 2016-10-28

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm
trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208088 => 208089)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:31:42 UTC (rev 208089)
@@ -1,3 +1,17 @@
+2016-10-28  Commit Queue  
+
+Unreviewed, rolling out r207700.
+https://bugs.webkit.org/show_bug.cgi?id=164168
+
+We are ready after r208086 (Requested by alexchristensen on
+#webkit).
+
+Reverted changeset:
+
+"Unreviewed, rolling out r207582."
+https://bugs.webkit.org/show_bug.cgi?id=163819
+http://trac.webkit.org/changeset/207700
+
 2016-10-28  Dave Hyatt  
 
 [CSS Parser] Allow unknown properties in will-change


Modified: trunk/Source/WebCore/platform/URLParser.cpp (208088 => 208089)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:31:42 UTC (rev 208089)
@@ -2827,31 +2827,16 @@
 // It should be able to be deduced from m_isValid and m_string.length() to save memory.
 }
 
-enum class URLParserEnabled {
-Undetermined,
-Yes,
-No
-};
+static bool urlParserEnabled = true;
 
-static URLParserEnabled urlParserEnabled = URLParserEnabled::Undetermined;
-
 void URLParser::setEnabled(bool enabled)
 {
-urlParserEnabled = enabled ? URLParserEnabled::Yes : URLParserEnabled::No;
+urlParserEnabled = enabled;
 }
 
 bool URLParser::enabled()
 {
-if (urlParserEnabled == URLParserEnabled::Undetermined) {
-#if PLATFORM(MAC)
-urlParserEnabled = MacApplication::isSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#elif PLATFORM(IOS)
-urlParserEnabled = IOSApplication::isMobileSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#else
-urlParserEnabled = URLParserEnabled::Yes;
-#endif
-}
-return urlParserEnabled == URLParserEnabled::Yes;
+return urlParserEnabled;
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (208088 => 208089)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-29 00:31:42 UTC (rev 208089)
@@ -121,11 +121,6 @@
 InternalSettings::setAllowsAnySSLCertificate(allowAnySSLCertificate);
 }
 
-void setURLParserEnabled(bool enabled)
-{
-URLParser::setEnabled(enabled);
-}
-
 void installMockGamepadProvider()
 {
 #if ENABLE(GAMEPAD)


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (208088 => 208089)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-29 00:31:42 UTC (rev 208089)
@@ -56,7 +56,6 @@
 void setLogChannelToAccumulate(const WTF::String& name) TEST_SUPPORT_EXPORT;
 void initializeLogChannelsIfNecessary() TEST_SUPPORT_EXPORT;
 void setAllowsAnySSLCertificate(bool) TEST_SUPPORT_EXPORT;
-void setURLParserEnabled(bool) TEST_SUPPORT_EXPORT;
 
 void installMockGamepadProvider() TEST_SUPPORT_EXPORT;
 void connectMockGamepad(unsigned index) TEST_SUPPORT_EXPORT;


Modified: trunk/Tools/ChangeLog (208088 => 208089)

--- trunk/Tools/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Tools/ChangeLog	2016-10-29 00:31:42 UTC (rev 208089)
@@ -1,3 +1,17 @@
+2016-10-28  Commit Queue  
+
+Unreviewed, rolling out r207700.
+https://bugs.webkit.org/show_bug.cgi?id=164168
+
+We are ready after r208086 (Requested by alexchristensen on
+#webkit).
+
+Reverted changeset:
+
+"Unreviewed, rolling out r207582."
+https://bugs.webkit.org/show_bug.cgi?id=163819
+http://trac.webkit.org/changeset/207700
+
 2016-10-28  Alex Christensen  
 
 Partially revert 207805 after resolution in URL spec issue 87


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (208088 => 208089)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Tools/DumpRenderTree/mac/D

[webkit-changes] [208239] trunk

2016-11-01 Thread achristensen

Title: [208239] trunk








Revision 208239
Author achristen...@apple.com
Date 2016-11-01 14:31:40 -0700 (Tue, 01 Nov 2016)


Log Message
Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
https://bugs.webkit.org/show_bug.cgi?id=164290

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

NSURL fails to parse these URLs, WebKit used to punycode encode them, but now we match Chrome and Firefox,
as well as what will likely become the standard once https://github.com/whatwg/url/issues/148 is resolved.
We continue to parse IPv6 address hosts because otherwise we wouldn't be able to tell where a port
starts in a URL with colons in the IPv6 address and before the port like "a://[b::c]:4"

Covered by new API tests and updated LayoutTests.

* platform/URLParser.cpp:
(WebCore::URLParser::domainToASCII):
(WebCore::URLParser::parseHostAndPort):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):
Move helper functions to the top so I can use them from any tests.
(TestWebKitAPI::shouldFail):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/host-lowercase-per-scheme-expected.txt:
* fast/url/safari-extension-expected.txt:
* fetch/fetch-url-serialization-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/host-lowercase-per-scheme-expected.txt
trunk/LayoutTests/fast/url/safari-extension-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208238 => 208239)

--- trunk/LayoutTests/ChangeLog	2016-11-01 20:40:40 UTC (rev 208238)
+++ trunk/LayoutTests/ChangeLog	2016-11-01 21:31:40 UTC (rev 208239)
@@ -1,3 +1,14 @@
+2016-11-01  Alex Christensen  
+
+Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
+https://bugs.webkit.org/show_bug.cgi?id=164290
+
+Reviewed by Tim Horton.
+
+* fast/url/host-lowercase-per-scheme-expected.txt:
+* fast/url/safari-extension-expected.txt:
+* fetch/fetch-url-serialization-expected.txt:
+
 2016-11-01  Ryan Haddad  
 
 Marking inspector/css/pseudo-element-matches.html as flaky on mac-wk2.


Modified: trunk/LayoutTests/fast/url/host-lowercase-per-scheme-expected.txt (208238 => 208239)

--- trunk/LayoutTests/fast/url/host-lowercase-per-scheme-expected.txt	2016-11-01 20:40:40 UTC (rev 208238)
+++ trunk/LayoutTests/fast/url/host-lowercase-per-scheme-expected.txt	2016-11-01 21:31:40 UTC (rev 208239)
@@ -26,7 +26,7 @@
 PASS src is expected
 PASS src is expected
 PASS src is expected
-FAIL src should be ghost://UnicodeF%C3%AAte/. Was ghost://xn--unicodefte-t7a/.
+PASS src is expected
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/url/safari-extension-expected.txt (208238 => 208239)

--- trunk/LayoutTests/fast/url/safari-extension-expected.txt	2016-11-01 20:40:40 UTC (rev 208238)
+++ trunk/LayoutTests/fast/url/safari-extension-expected.txt	2016-11-01 21:31:40 UTC (rev 208239)
@@ -6,7 +6,7 @@
 PASS src is expected
 PASS src is expected
 PASS src is expected
-FAIL src should be safari-extension://com.f%C3%AAte/. Was safari-extension://com.xn--fte-fma/.
+PASS src is expected
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt (208238 => 208239)

--- trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-11-01 20:40:40 UTC (rev 208238)
+++ trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-11-01 21:31:40 UTC (rev 208239)
@@ -309,7 +309,7 @@
 PASS Testing Request url 'data:/../' with base 'about:blank' 
 PASS Testing Request url '_javascript_:/../' with base 'about:blank' 
 PASS Testing Request url 'mailto:/../' with base 'about:blank' 
-PASS Testing Request url 'sc://ñ.test/' with base 'about:blank' 
+FAIL Testing Request url 'sc://ñ.test/' with base 'about:blank' assert_equals: expected "sc://xn--ida.test/" but got "sc://%C3%B1.test/"
 PASS Testing Request url 'sc:\../' with base 'about:blank' 
 PASS Testing Request url 'sc::a...@example.net' with base 'about:blank' 
 PASS Testing Request url 'http://127.0.0.1:10100/relative_import.html' with base 'about:blank' 


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (20

[webkit-changes] [208257] trunk/Source/WebKit2

2016-11-01 Thread achristensen

Title: [208257] trunk/Source/WebKit2








Revision 208257
Author achristen...@apple.com
Date 2016-11-01 16:23:20 -0700 (Tue, 01 Nov 2016)


Log Message
Fix CMake build.

* PlatformMac.cmake:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208256 => 208257)

--- trunk/Source/WebKit2/ChangeLog	2016-11-01 23:16:49 UTC (rev 208256)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-01 23:23:20 UTC (rev 208257)
@@ -1,3 +1,9 @@
+2016-11-01  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+
 2016-11-01  Ryosuke Niwa  
 
 Remove CUSTOM_ELEMENTS build flag


Modified: trunk/Source/WebKit2/PlatformMac.cmake (208256 => 208257)

--- trunk/Source/WebKit2/PlatformMac.cmake	2016-11-01 23:16:49 UTC (rev 208256)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2016-11-01 23:23:20 UTC (rev 208257)
@@ -50,10 +50,11 @@
 
 Platform/foundation/LoggingFoundation.mm
 
+Platform/cocoa/SharedMemoryCocoa.cpp
+
 Platform/mac/LayerHostingContext.mm
 Platform/mac/MachUtilities.cpp
 Platform/mac/MenuUtilities.mm
-Platform/mac/SharedMemoryMac.cpp
 Platform/mac/StringUtilities.mm
 
 Platform/unix/EnvironmentUtilities.cpp
@@ -228,6 +229,7 @@
 UIProcess/Cocoa/DiagnosticLoggingClient.mm
 UIProcess/Cocoa/DownloadClient.mm
 UIProcess/Cocoa/FindClient.mm
+UIProcess/Cocoa/FullscreenClient.mm
 UIProcess/Cocoa/NavigationState.mm
 UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm
 UIProcess/Cocoa/SessionStateCoding.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208258] trunk/LayoutTests/imported/w3c

2016-11-01 Thread achristensen

Title: [208258] trunk/LayoutTests/imported/w3c








Revision 208258
Author achristen...@apple.com
Date 2016-11-01 16:31:33 -0700 (Tue, 01 Nov 2016)


Log Message
Rebase test after r208239
https://bugs.webkit.org/show_bug.cgi?id=164290

* web-platform-tests/url/url-setters-expected.txt:
This was an expected change.  Non-special hosts are parsed differently than special hosts.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208257 => 208258)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-01 23:23:20 UTC (rev 208257)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-01 23:31:33 UTC (rev 208258)
@@ -1,5 +1,13 @@
 2016-11-01  Alex Christensen  
 
+Rebase test after r208239
+https://bugs.webkit.org/show_bug.cgi?id=164290
+
+* web-platform-tests/url/url-setters-expected.txt:
+This was an expected change.  Non-special hosts are parsed differently than special hosts.
+
+2016-11-01  Alex Christensen  
+
 Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
 https://bugs.webkit.org/show_bug.cgi?id=164290
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt (208257 => 208258)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt	2016-11-01 23:23:20 UTC (rev 208257)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt	2016-11-01 23:31:33 UTC (rev 208258)
@@ -165,7 +165,7 @@
 PASS URL: Setting .host = 'example.com:8080\stuff' Stuff after a \ delimiter is ignored for special schemes 
 PASS : Setting .host = 'example.com:8080\stuff' Stuff after a \ delimiter is ignored for special schemes 
 PASS : Setting .host = 'example.com:8080\stuff' Stuff after a \ delimiter is ignored for special schemes 
-PASS URL: Setting .host = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain 
+FAIL URL: Setting .host = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 FAIL : Setting .host = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 FAIL : Setting .host = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 PASS URL: Setting .host = 'example.com:8080stuff2' Anything other than ASCII digit stops the port parser in a setter but is not an error 
@@ -225,7 +225,7 @@
 FAIL URL: Setting .hostname = 'example.com\stuff' Stuff after a \ delimiter is ignored for special schemes assert_equals: expected "http://example.com/path" but got "http://example.com/stuff/path"
 FAIL : Setting .hostname = 'example.com\stuff' Stuff after a \ delimiter is ignored for special schemes assert_equals: expected "http://example.com/path" but got "http://example.com/stuff/path"
 FAIL : Setting .hostname = 'example.com\stuff' Stuff after a \ delimiter is ignored for special schemes assert_equals: expected "http://example.com/path" but got "http://example.com/stuff/path"
-PASS URL: Setting .hostname = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain 
+FAIL URL: Setting .hostname = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 FAIL : Setting .hostname = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 FAIL : Setting .hostname = 'example.com\stuff' \ is not a delimiter for non-special schemes, and it’s invalid in a domain assert_equals: expected "view-source+http://example.net/path" but got "view-source+http://example.com\\stuff/path"
 PASS URL: Setting .port = '8080' 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208289] trunk

2016-11-02 Thread achristensen

Title: [208289] trunk








Revision 208289
Author achristen...@apple.com
Date 2016-11-02 10:43:32 -0700 (Wed, 02 Nov 2016)


Log Message
Remove PassRefPtr from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=164307

Reviewed by Sam Weinig.

Source/WebKit/ios:

* Misc/WebGeolocationProviderIOS.mm:

Source/WebKit/mac:

* WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPosition initWithGeolocationPosition:]):

Tools:

* DumpRenderTree/PixelDumpSupport.h:
* DumpRenderTree/TestRunner.cpp:
(TestRunner::create):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(createBitmapContext):
* DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::createByAdoptingBitmapAndContext):
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
(createPagedBitmapContext):
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
* DumpRenderTree/win/TextInputController.h:

Modified Paths

trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/PixelDumpSupport.h
trunk/Tools/DumpRenderTree/TestRunner.cpp
trunk/Tools/DumpRenderTree/TestRunner.h
trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.h
trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm
trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm
trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp
trunk/Tools/DumpRenderTree/win/TextInputController.h




Diff

Modified: trunk/Source/WebKit/ios/ChangeLog (208288 => 208289)

--- trunk/Source/WebKit/ios/ChangeLog	2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/ios/ChangeLog	2016-11-02 17:43:32 UTC (rev 208289)
@@ -1,3 +1,12 @@
+2016-11-01  Alex Christensen  
+
+Remove PassRefPtr from DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=164307
+
+Reviewed by Sam Weinig.
+
+* Misc/WebGeolocationProviderIOS.mm:
+
 2016-10-26  Dan Bernstein  
 
 Tried to fix the iOS build after r207934.


Modified: trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm (208288 => 208289)

--- trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm	2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm	2016-11-02 17:43:32 UTC (rev 208289)
@@ -44,7 +44,7 @@
 using namespace WebCore;
 
 @interface WebGeolocationPosition (Internal)
-- (id)initWithGeolocationPosition:(PassRefPtr)coreGeolocationPosition;
+- (id)initWithGeolocationPosition:(RefPtr)coreGeolocationPosition;
 @end
 
 // CoreLocation runs in the main thread. WebGeolocationProviderIOS lives on the WebThread.


Modified: trunk/Source/WebKit/mac/ChangeLog (208288 => 208289)

--- trunk/Source/WebKit/mac/ChangeLog	2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-11-02 17:43:32 UTC (rev 208289)
@@ -1,3 +1,13 @@
+2016-11-01  Alex Christensen  
+
+Remove PassRefPtr from DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=164307
+
+Reviewed by Sam Weinig.
+
+* WebView/WebGeolocationPosition.mm:
+(-[WebGeolocationPosition initWithGeolocationPosition:]):
+
 2016-11-02  Romain Bellessort  
 
 [Readable Streams API] Enable creation of ReadableByteStreamController


Modified: trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm (208288 => 208289)

--- trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm	2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm	2016-11-02 17:43:32 UTC (rev 208289)
@@ -71,7 +71,7 @@
 return self;
 }
 
-- (id)initWithGeolocationPosition:(PassRefPtr)coreGeolocationPosition
+- (id)initWithGeolocationPosition:(RefPtr)coreGeolocationPosition
 {
 self = [super init];
 if (!self)


Modified: trunk/Tools/ChangeLog (208288 => 208289)

--- trunk/Tools/ChangeLog	2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/ChangeLog	2016-11-02 17:43:32 UTC (rev 208289)
@@ -1,3 +1,28 @@
+2016-11-01  Alex Christensen  
+
+Remove PassRefPtr from DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=164307
+
+Reviewed by Sam Weinig.
+
+* DumpRenderTree/PixelDumpSupport.h:
+* DumpRenderTree/TestRunner.cpp:
+(TestRunner::create):
+* DumpRenderTree/TestRunner.h:
+* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
+(createBitmapContext):
+* DumpRenderTree/cg/PixelDumpSupportCG.h:
+(BitmapContext::createByAdoptingBitmapAndContext):
+* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
+(createBitmapContextFromWebView):
+* DumpRenderTree/mac/PixelDumpSupportMac.mm:
+(createBitmapCo

[webkit-changes] [208293] trunk

2016-11-02 Thread achristensen

Title: [208293] trunk








Revision 208293
Author achristen...@apple.com
Date 2016-11-02 11:24:18 -0700 (Wed, 02 Nov 2016)


Log Message
NetworkSession: Network process crash when converting main resource to download
https://bugs.webkit.org/show_bug.cgi?id=164220

Patch by Carlos Garcia Campos  on 2016-11-02
Reviewed by Alex Christensen.

Source/WebKit2:

Right after the main resource load is converted to a download, the web process deletes the ResourceLoader which
sends the RemoveLoadIdentifier to the network process and the load is aborted. Sometimes it happens that
NetworkResourceLoader::abort() is called while the NetworkLoad is still deciding the destination of the
download. In such case, NetworkResourceLoader::didConvertToDownload() has already been called, but not
NetworkResourceLoader::didBecomeDownload(). In NetworkResourceLoader::abort() we already handle the case of
having a NetworkLoad after NetworkResourceLoader::didConvertToDownload() has been called, to avoid canceling the
load in such case, however cleanup() is always called unconditionally and the NetworkLoad is deleted before
NetworkResourceLoader::didBecomeDownload() is called. When the NetworkLoad is destroyed the NetworkDataTask
client becomes nullptr, leaving it in a state where both the client is nullptr and the download hasn't been
created yet. That's not expected to happen and when the response completion handler is called in the
NetworkDataTask it tries to use either the client or the download and it crashes.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier): Update ASSERT, because abort doesn't cleanup the
resource loader in case it's becoming a download.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didBecomeDownload): Call cleanup() instead of just deleting the network load.
(WebKit::NetworkResourceLoader::isBecomingDownload): Helper method to check if the resource load was converted to a
download, but didBecomeDownload() hasn't been called yet.
(WebKit::NetworkResourceLoader::abort): If the resource load is becoming a download do not call cleanup()
because it will be called by didBecomeDownload() later.
* NetworkProcess/NetworkResourceLoader.h:

Tools:

Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
converted to a download and another one to test the cancellation as the test was doing before. When doing the
full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
download.

* TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(beforeAll):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208292 => 208293)

--- trunk/Source/WebKit2/ChangeLog	2016-11-02 18:11:13 UTC (rev 208292)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-02 18:24:18 UTC (rev 208293)
@@ -1,3 +1,33 @@
+2016-11-02  Carlos Garcia Campos  
+
+NetworkSession: Network process crash when converting main resource to download
+https://bugs.webkit.org/show_bug.cgi?id=164220
+
+Reviewed by Alex Christensen.
+
+Right after the main resource load is converted to a download, the web process deletes the ResourceLoader which
+sends the RemoveLoadIdentifier to the network process and the load is aborted. Sometimes it happens that
+NetworkResourceLoader::abort() is called while the NetworkLoad is still deciding the destination of the
+download. In such case, NetworkResourceLoader::didConvertToDownload() has already been called, but not
+NetworkResourceLoader::didBecomeDownload(). In NetworkResourceLoader::abort() we already handle the case of
+having a NetworkLoad after NetworkResourceLoader::didConvertToDownload() has been called, to avoid canceling the
+load in such case, however cleanup() is always called unconditionally and the NetworkLoad is deleted before
+NetworkResourceLoader::didBecomeDownload() is called. When the NetworkLoad is destroyed the NetworkDataTask
+client becomes nullptr, leaving it in a state where both the client is nullptr and the download hasn't been
+created yet. That's not expected to happen and when the response completion handler is called in the
+NetworkDataTask it tries to use either the client or the download and it crashes.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier): Update ASSERT, because abort doesn't cleanup the
+resource loader in case it's becoming

[webkit-changes] [208298] trunk/Source

2016-11-02 Thread achristensen

Title: [208298] trunk/Source








Revision 208298
Author achristen...@apple.com
Date 2016-11-02 13:38:23 -0700 (Wed, 02 Nov 2016)


Log Message
NetworkSession: Add NetworkDataTask implementation for blobs
https://bugs.webkit.org/show_bug.cgi?id=163939

Source/WebCore:

Patch by Keith Rollin  on 2016-11-02
Reviewed by Alex Christensen.

* WebCore.xcodeproj/project.pbxproj: Mark HTTPParsers.h and AsyncFileStream.h as private.
* fileapi/AsyncFileStream.h: Add WEBCORE_EXPORT to AsyncFileStream class.
* platform/network/BlobData.h: Add WEBCORE_EXPORT to length().
* platform/network/HTTPParsers.h: Add WEBCORE_EXPORT to parseRange().
* platform/network/ResourceResponseBase.h: Add WEBCORE_EXPORT to setHTTPHeaderField().

Source/WebCore/platform/gtk/po:

Patch by Carlos Garcia Campos  on 2016-11-02
Reviewed by Alex Christensen.

* POTFILES.in: Remove DownloadSoup.cpp

Source/WebKit2:

Patch by Carlos Garcia Campos  on 2016-11-02
Reviewed by Alex Christensen.

Add NetworkDataTaskBlob to handle blobs when using NetworkSession instead of using ResourceHandle. This patch
adds more USE(NETWORK_SESSION) ifdefs to not use ResourceHandle in Downloads and NetworkLoad when NetworkSession
is enabled.

* CMakeLists.txt: Add new files to compilation.
* NetworkProcess/Downloads/BlobDownloadClient.cpp:
* NetworkProcess/Downloads/BlobDownloadClient.h:
* NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::Download): Split the constructor again and remove the PlatformDownloadTaskRef
definitions. Now Cocoa specific constructor receives a NSURLSessionDownloadTask and the general constructor
reveices a NetworkDataTask and is used by Soup backend and blobs.
(WebKit::Download::~Download):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didReceiveAuthenticationChallenge):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::platformCancelNetworkLoad): Rename cancelNetworkLoad() as platformCancelNetworkLoad() since
this is now used only by Cocoa platform to cancel the NSURLSessionDownloadTask.
* NetworkProcess/Downloads/Download.h:
(WebKit::Download::Download):
(WebKit::Download::suggestedName):
(WebKit::Download::request):
* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload): Remove blobs specific code when using NetworkSession.
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
* NetworkProcess/Downloads/DownloadManager.h:
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::platformCancelNetworkLoad):
* NetworkProcess/Downloads/soup/DownloadSoup.cpp: Removed.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Remove blobs specific code when
using NetworkSession.
* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create): If request is a blob, create a NetworkDataTaskBlob.
* NetworkProcess/NetworkDataTask.h: Add invalidateAndCancel pure virtual method.
* NetworkProcess/NetworkDataTaskBlob.cpp: Added.
(WebKit::NetworkDataTaskBlob::NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::~NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::clearStream):
(WebKit::NetworkDataTaskBlob::resume):
(WebKit::NetworkDataTaskBlob::suspend):
(WebKit::NetworkDataTaskBlob::cancel):
(WebKit::NetworkDataTaskBlob::invalidateAndCancel):
(WebKit::NetworkDataTaskBlob::getSizeForNext):
(WebKit::NetworkDataTaskBlob::didGetSize):
(WebKit::NetworkDataTaskBlob::seek):
(WebKit::NetworkDataTaskBlob::didReceiveResponse):
(WebKit::NetworkDataTaskBlob::read):
(WebKit::NetworkDataTaskBlob::readData):
(WebKit::NetworkDataTaskBlob::readFile):
(WebKit::NetworkDataTaskBlob::didOpen):
(WebKit::NetworkDataTaskBlob::didRead):
(WebKit::NetworkDataTaskBlob::consumeData):
(WebKit::NetworkDataTaskBlob::setPendingDownloadLocation):
(WebKit::NetworkDataTaskBlob::suggestedFilename):
(WebKit::NetworkDataTaskBlob::download):
(WebKit::NetworkDataTaskBlob::writeDownload):
(WebKit::NetworkDataTaskBlob::cleanDownloadFiles):
(WebKit::NetworkDataTaskBlob::didFailDownload):
(WebKit::NetworkDataTaskBlob::didFinishDownload):
(WebKit::NetworkDataTaskBlob::didFail):
(WebKit::NetworkDataTaskBlob::didFinish):
* NetworkProcess/NetworkDataTaskBlob.h: Added.
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad): Remove blobs specific code when using NetworkSession.
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::setDefersLoading):
(WebKit::NetworkLoad::cancel):
(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::invalidateAndCancel): Moved from NetworkSessionSoup, since this is now used also by blobs.
* NetworkProcess/NetworkSession.h:
(WebKit::N

[webkit-changes] [208330] trunk/Source/WebKit2

2016-11-03 Thread achristensen

Title: [208330] trunk/Source/WebKit2








Revision 208330
Author achristen...@apple.com
Date 2016-11-03 10:47:37 -0700 (Thu, 03 Nov 2016)


Log Message
Reduce PassRefPtr use in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=164360

Reviewed by Tim Horton.

* Shared/API/APISecurityOrigin.h:
(API::SecurityOrigin::SecurityOrigin):
* Shared/API/APISerializedScriptValue.h:
(API::SerializedScriptValue::create):
(API::SerializedScriptValue::SerializedScriptValue):
* Shared/API/c/WKSharedAPICast.h:
(WebKit::ProxyingRefPtr::ProxyingRefPtr):
(WebKit::toAPI):
* Shared/APIWebArchive.h:
* Shared/APIWebArchive.mm:
(API::WebArchive::create):
(API::WebArchive::WebArchive):
* UIProcess/API/APIHitTestResult.cpp:
(API::HitTestResult::create):
* UIProcess/API/APIHitTestResult.h:
* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WebKit::RunBeforeUnloadConfirmPanelResultListener::create):
(WebKit::RunBeforeUnloadConfirmPanelResultListener::RunBeforeUnloadConfirmPanelResultListener):
(WebKit::RunJavaScriptAlertResultListener::create):
(WebKit::RunJavaScriptAlertResultListener::RunJavaScriptAlertResultListener):
(WebKit::RunJavaScriptConfirmResultListener::create):
(WebKit::RunJavaScriptConfirmResultListener::RunJavaScriptConfirmResultListener):
(WebKit::RunJavaScriptPromptResultListener::create):
(WebKit::RunJavaScriptPromptResultListener::RunJavaScriptPromptResultListener):
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _takeViewSnapshot]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* UIProcess/ios/WKGeolocationProviderIOS.mm:
(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]):
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _webHitTestResult]):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(contextMenuItems):
(WKBundlePageCopyContextMenuItems):
(WKBundlePageCopyContextMenuAtPointInWindow):
* WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserMessageHandlerDescriptorProxy::create):
* WebProcess/WebPage/WebUndoStep.cpp:
(WebKit::WebUndoStep::create):
* WebProcess/WebPage/WebUndoStep.h:
(WebKit::WebUndoStep::WebUndoStep):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/APISecurityOrigin.h
trunk/Source/WebKit2/Shared/API/APISerializedScriptValue.h
trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
trunk/Source/WebKit2/Shared/APIWebArchive.h
trunk/Source/WebKit2/Shared/APIWebArchive.mm
trunk/Source/WebKit2/UIProcess/API/APIHitTestResult.cpp
trunk/Source/WebKit2/UIProcess/API/APIHitTestResult.h
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm
trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208329 => 208330)

--- trunk/Source/WebKit2/ChangeLog	2016-11-03 16:34:33 UTC (rev 208329)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-03 17:47:37 UTC (rev 208330)
@@ -1,3 +1,58 @@
+2016-11-02  Alex Christensen  
+
+Reduce PassRefPtr use in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=164360
+
+Reviewed by Tim Horton.
+
+* Shared/API/APISecurityOrigin.h:
+(API::SecurityOrigin::SecurityOrigin):
+* Shared/API/APISerializedScriptValue.h:
+(API::SerializedScriptValue::create):
+(API::SerializedScriptValue::SerializedScriptValue):
+* Shared/API/c/WKSharedAPICast.h:
+(WebKit::ProxyingRefPtr::ProxyingRefPtr):
+(WebKit::toAPI):
+* Shared/APIWebArchive.h:
+* Shared/APIWebArchive.mm:
+(API::WebArchive::create):
+(API::WebArchive::WebArchive):
+* UIProcess/API/APIHitTestResult.cpp:
+(API::HitTestResult::create):
+* UIProcess/API/APIHitTestResult.h:
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::createNewPage):
+* UIProcess/API/C/WKPage.cpp:
+(WebKit::RunBeforeUnloadConfirmPanelResultListener::create):
+(WebKit::RunBeforeUnloadConfirmPanelResultListener::RunBeforeUnloadConfirmPanelResultListener):
+(WebKit::RunJavaScriptAlertResultListener::create):
+(WebKit::RunJavaScriptAlertResultListener::RunJavaScriptAlertResultListener):
+(WebKit::RunJavaScriptConfirmResultListener:

[webkit-changes] [208344] trunk/Source

2016-11-03 Thread achristensen

Title: [208344] trunk/Source








Revision 208344
Author achristen...@apple.com
Date 2016-11-03 14:06:31 -0700 (Thu, 03 Nov 2016)


Log Message
Unreviewed, rolling out r208298.
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=163939

caused asan crashes

Reverted changeset:

"NetworkSession: Add NetworkDataTask implementation for blobs"
https://bugs.webkit.org/show_bug.cgi?id=163939
http://trac.webkit.org/changeset/208298

Source/WebCore/platform/gtk/po:


caused

Reverted changeset:

"NetworkSession: Add NetworkDataTask implementation for blobs"
https://bugs.webkit.org/show_bug.cgi?id=163939
http://trac.webkit.org/changeset/208298

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=163939

caused asan crashes

Reverted changeset:

"NetworkSession: Add NetworkDataTask implementation for blobs"
https://bugs.webkit.org/show_bug.cgi?id=163939
http://trac.webkit.org/changeset/208298

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/fileapi/AsyncFileStream.h
trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/POTFILES.in
trunk/Source/WebCore/platform/network/BlobData.h
trunk/Source/WebCore/platform/network/HTTPParsers.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/Downloads/BlobDownloadClient.cpp
trunk/Source/WebKit2/NetworkProcess/Downloads/BlobDownloadClient.h
trunk/Source/WebKit2/NetworkProcess/Downloads/Download.cpp
trunk/Source/WebKit2/NetworkProcess/Downloads/Download.h
trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.h
trunk/Source/WebKit2/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
trunk/Source/WebKit2/NetworkProcess/Downloads/ios/DownloadIOS.mm
trunk/Source/WebKit2/NetworkProcess/Downloads/mac/DownloadMac.mm
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit2/NetworkProcess/NetworkSession.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkSession.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit2/NetworkProcess/mac/NetworkLoadMac.mm
trunk/Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp
trunk/Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.h
trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp
trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/NetworkProcess/Downloads/soup/DownloadSoup.cpp


Removed Paths

trunk/Source/WebKit2/NetworkProcess/NetworkDataTaskBlob.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTaskBlob.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208343 => 208344)

--- trunk/Source/WebCore/ChangeLog	2016-11-03 20:53:27 UTC (rev 208343)
+++ trunk/Source/WebCore/ChangeLog	2016-11-03 21:06:31 UTC (rev 208344)
@@ -1,3 +1,16 @@
+2016-11-03  Alex Christensen  
+
+Unreviewed, rolling out r208298.
+https://bugs.webkit.org/show_bug.cgi?id=163939
+
+caused asan crashes
+
+Reverted changeset:
+
+"NetworkSession: Add NetworkDataTask implementation for blobs"
+https://bugs.webkit.org/show_bug.cgi?id=163939
+http://trac.webkit.org/changeset/208298
+
 2016-11-03  Brent Fulgham  
 
 [Win][Direct2D] Native Windows widgets are drawn upside-down


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (208343 => 208344)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-11-03 20:53:27 UTC (rev 208343)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-11-03 21:06:31 UTC (rev 208344)
@@ -2060,7 +2060,7 @@
 		514C76700CE923A1007EF3CD /* FormData.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C765B0CE923A1007EF3CD /* FormData.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		514C76710CE923A1007EF3CD /* HTTPHeaderMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C765C0CE923A1007EF3CD /* HTTPHeaderMap.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		514C76720CE923A1007EF3CD /* HTTPParsers.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 514C765D0CE923A1007EF3CD /* HTTPParsers.cpp */; };
-		514C76730CE923A1007EF3CD /* HTTPParsers.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C765E0CE923A1007EF3CD /* HTTPParsers.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		514C76730CE923A1007EF3CD /* HTTPParsers.h in Headers */ = {isa = PBXBuildFile; fileRef = 514C765E0CE923A1007EF3CD /* HTTPParsers.h */; };
 		514C76740

[webkit-changes] [208388] trunk/Source

2016-11-04 Thread achristensen

Title: [208388] trunk/Source








Revision 208388
Author achristen...@apple.com
Date 2016-11-04 11:08:05 -0700 (Fri, 04 Nov 2016)


Log Message
NetworkSession: Add NetworkDataTask implementation for blobs
https://bugs.webkit.org/show_bug.cgi?id=163939

Source/WebCore:

Patch by Keith Rollin  on 2016-11-04
Reviewed by Alex Christensen.

* WebCore.xcodeproj/project.pbxproj: Mark HTTPParsers.h and AsyncFileStream.h as private.
* fileapi/AsyncFileStream.h: Add WEBCORE_EXPORT to AsyncFileStream class.
* platform/network/BlobData.h: Add WEBCORE_EXPORT to length().
* platform/network/HTTPParsers.h: Add WEBCORE_EXPORT to parseRange().
* platform/network/ResourceResponseBase.h: Add WEBCORE_EXPORT to setHTTPHeaderField().

Source/WebCore/platform/gtk/po:

Patch by Carlos Garcia Campos  on 2016-11-04
Reviewed by Alex Christensen.

* POTFILES.in: Remove DownloadSoup.cpp

Source/WebKit2:

Patch by Carlos Garcia Campos  on 2016-11-04
Reviewed by Alex Christensen.

Add NetworkDataTaskBlob to handle blobs when using NetworkSession instead of using ResourceHandle. This patch
adds more USE(NETWORK_SESSION) ifdefs to not use ResourceHandle in Downloads and NetworkLoad when NetworkSession
is enabled.

* CMakeLists.txt: Add new files to compilation.
* NetworkProcess/Downloads/BlobDownloadClient.cpp:
* NetworkProcess/Downloads/BlobDownloadClient.h:
* NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::Download): Split the constructor again and remove the PlatformDownloadTaskRef
definitions. Now Cocoa specific constructor receives a NSURLSessionDownloadTask and the general constructor
reveices a NetworkDataTask and is used by Soup backend and blobs.
(WebKit::Download::~Download):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didReceiveAuthenticationChallenge):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::platformCancelNetworkLoad): Rename cancelNetworkLoad() as platformCancelNetworkLoad() since
this is now used only by Cocoa platform to cancel the NSURLSessionDownloadTask.
* NetworkProcess/Downloads/Download.h:
(WebKit::Download::Download):
(WebKit::Download::suggestedName):
(WebKit::Download::request):
* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload): Remove blobs specific code when using NetworkSession.
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
* NetworkProcess/Downloads/DownloadManager.h:
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::platformCancelNetworkLoad):
* NetworkProcess/Downloads/soup/DownloadSoup.cpp: Removed.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Remove blobs specific code when
using NetworkSession.
* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create): If request is a blob, create a NetworkDataTaskBlob.
* NetworkProcess/NetworkDataTask.h: Add invalidateAndCancel pure virtual method.
* NetworkProcess/NetworkDataTaskBlob.cpp: Added.
(WebKit::NetworkDataTaskBlob::NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::~NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::clearStream):
(WebKit::NetworkDataTaskBlob::resume):
(WebKit::NetworkDataTaskBlob::suspend):
(WebKit::NetworkDataTaskBlob::cancel):
(WebKit::NetworkDataTaskBlob::invalidateAndCancel):
(WebKit::NetworkDataTaskBlob::getSizeForNext):
(WebKit::NetworkDataTaskBlob::didGetSize):
(WebKit::NetworkDataTaskBlob::seek):
(WebKit::NetworkDataTaskBlob::didReceiveResponse):
(WebKit::NetworkDataTaskBlob::read):
(WebKit::NetworkDataTaskBlob::readData):
(WebKit::NetworkDataTaskBlob::readFile):
(WebKit::NetworkDataTaskBlob::didOpen):
(WebKit::NetworkDataTaskBlob::didRead):
(WebKit::NetworkDataTaskBlob::consumeData):
(WebKit::NetworkDataTaskBlob::setPendingDownloadLocation):
(WebKit::NetworkDataTaskBlob::suggestedFilename):
(WebKit::NetworkDataTaskBlob::download):
(WebKit::NetworkDataTaskBlob::writeDownload):
(WebKit::NetworkDataTaskBlob::cleanDownloadFiles):
(WebKit::NetworkDataTaskBlob::didFailDownload):
(WebKit::NetworkDataTaskBlob::didFinishDownload):
(WebKit::NetworkDataTaskBlob::didFail):
(WebKit::NetworkDataTaskBlob::didFinish):
* NetworkProcess/NetworkDataTaskBlob.h: Added.
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad): Remove blobs specific code when using NetworkSession.
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::setDefersLoading):
(WebKit::NetworkLoad::cancel):
(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::invalidateAndCancel): Moved from NetworkSessionSoup, since this is now used also by blobs.
* NetworkProcess/NetworkSession.h:
(WebKit::N

[webkit-changes] [208400] trunk

2016-11-04 Thread achristensen

Title: [208400] trunk








Revision 208400
Author achristen...@apple.com
Date 2016-11-04 15:02:19 -0700 (Fri, 04 Nov 2016)


Log Message
Unreviewed, rolling out r208293.

asserts in API tests.

Reverted changeset:

"NetworkSession: Network process crash when converting main
resource to download"
https://bugs.webkit.org/show_bug.cgi?id=164220
http://trac.webkit.org/changeset/208293

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208399 => 208400)

--- trunk/Source/WebKit2/ChangeLog	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-04 22:02:19 UTC (rev 208400)
@@ -1,3 +1,16 @@
+2016-11-04  Alex Christensen  
+
+Unreviewed, rolling out r208293.
+
+asserts in API tests.
+
+Reverted changeset:
+
+"NetworkSession: Network process crash when converting main
+resource to download"
+https://bugs.webkit.org/show_bug.cgi?id=164220
+http://trac.webkit.org/changeset/208293
+
 2016-11-04  Said Abou-Hallawa  
 
 Add a setting and preferences to enable/disable async image decoding


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (208399 => 208400)

--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp	2016-11-04 22:02:19 UTC (rev 208400)
@@ -158,7 +158,7 @@
 // Abort the load now, as the WebProcess won't be able to respond to messages any more which might lead
 // to leaked loader resources (connections, threads, etc).
 loader->abort();
-ASSERT(!m_networkResourceLoaders.contains(identifier) || loader->isBecomingDownload());
+ASSERT(!m_networkResourceLoaders.contains(identifier));
 }
 
 void NetworkConnectionToWebProcess::setDefersLoading(ResourceLoadIdentifier identifier, bool defers)


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (208399 => 208400)

--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp	2016-11-04 22:02:19 UTC (rev 208400)
@@ -286,19 +286,10 @@
 {
 ASSERT(m_didConvertToDownload);
 ASSERT(m_networkLoad);
-cleanup();
+m_networkLoad = nullptr;
 }
 #endif
 
-bool NetworkResourceLoader::isBecomingDownload() const
-{
-#if USE(NETWORK_SESSION)
-return m_networkLoad && m_didConvertToDownload;
-#else
-return false;
-#endif
-}
-
 void NetworkResourceLoader::abort()
 {
 ASSERT(RunLoop::isMain());
@@ -317,9 +308,6 @@
 m_networkLoad->cancel();
 }
 
-if (isBecomingDownload())
-return;
-
 cleanup();
 }
 


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h (208399 => 208400)

--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h	2016-11-04 22:02:19 UTC (rev 208400)
@@ -81,7 +81,6 @@
 ResourceLoadIdentifier identifier() const { return m_parameters.identifier; }
 uint64_t frameID() const { return m_parameters.webFrameID; }
 uint64_t pageID() const { return m_parameters.webPageID; }
-bool isBecomingDownload() const;
 
 struct SynchronousLoadData;
 


Modified: trunk/Tools/ChangeLog (208399 => 208400)

--- trunk/Tools/ChangeLog	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Tools/ChangeLog	2016-11-04 22:02:19 UTC (rev 208400)
@@ -1,3 +1,16 @@
+2016-11-04  Alex Christensen  
+
+Unreviewed, rolling out r208293.
+
+asserts in API tests.
+
+Reverted changeset:
+
+"NetworkSession: Network process crash when converting main
+resource to download"
+https://bugs.webkit.org/show_bug.cgi?id=164220
+http://trac.webkit.org/changeset/208293
+
 2016-11-04  Said Abou-Hallawa  
 
 Add a setting and preferences to enable/disable async image decoding


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp (208399 => 208400)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp	2016-11-04 21:54:44 UTC (rev 208399)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp	2016-11-04 22:02:19 UTC (rev 208400)
@@ -515,8 +515,6 @@
 {
 test->m_download = download;
 test->assertObjectIsDeletedWhenTestFinishes(G_OBJECT(download));
-g_signal_connect(download, "decide-destination", G_CALLBACK(downloadDecideDestinationCallback), test);
-g_signal_connect(download, "finished", G_CALLBACK(downloadFinishedCallback), test);
 test->quitMainLoop();
 }
 
@@ -541,8 +539,6 @@

[webkit-changes] [208407] trunk/Source/WebCore

2016-11-04 Thread achristensen

Title: [208407] trunk/Source/WebCore








Revision 208407
Author achristen...@apple.com
Date 2016-11-04 16:59:03 -0700 (Fri, 04 Nov 2016)


Log Message
Move isDefaultPortForProtocol from URLParser.cpp back to URL.cpp
https://bugs.webkit.org/show_bug.cgi?id=164439

Reviewed by Daniel Bates.

No change in behaviour.

* platform/URL.cpp:
(WebCore::defaultPortForProtocol):
(WebCore::isDefaultPortForProtocol):
* platform/URLParser.cpp:
(WebCore::URLParser::defaultPortForProtocol):
(WebCore::URLParser::parsePort):
(WebCore::defaultPortForProtocol): Deleted.
(WebCore::isDefaultPortForProtocol): Deleted.
* platform/URLParser.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/platform/URLParser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208406 => 208407)

--- trunk/Source/WebCore/ChangeLog	2016-11-04 23:55:00 UTC (rev 208406)
+++ trunk/Source/WebCore/ChangeLog	2016-11-04 23:59:03 UTC (rev 208407)
@@ -1,3 +1,22 @@
+2016-11-04  Alex Christensen  
+
+Move isDefaultPortForProtocol from URLParser.cpp back to URL.cpp
+https://bugs.webkit.org/show_bug.cgi?id=164439
+
+Reviewed by Daniel Bates.
+
+No change in behaviour.
+
+* platform/URL.cpp:
+(WebCore::defaultPortForProtocol):
+(WebCore::isDefaultPortForProtocol):
+* platform/URLParser.cpp:
+(WebCore::URLParser::defaultPortForProtocol):
+(WebCore::URLParser::parsePort):
+(WebCore::defaultPortForProtocol): Deleted.
+(WebCore::isDefaultPortForProtocol): Deleted.
+* platform/URLParser.h:
+
 2016-11-04  Wenson Hsieh  
 
 Safari does not emit composition end if blurred for dead key / Japanese IME


Modified: trunk/Source/WebCore/platform/URL.cpp (208406 => 208407)

--- trunk/Source/WebCore/platform/URL.cpp	2016-11-04 23:55:00 UTC (rev 208406)
+++ trunk/Source/WebCore/platform/URL.cpp	2016-11-04 23:59:03 UTC (rev 208407)
@@ -800,6 +800,16 @@
 
 #endif
 
+Optional defaultPortForProtocol(StringView protocol)
+{
+return URLParser::defaultPortForProtocol(protocol);
+}
+
+bool isDefaultPortForProtocol(uint16_t port, StringView protocol)
+{
+return defaultPortForProtocol(protocol) == port;
+}
+
 bool URL::protocolIs(const char* protocol) const
 {
 assertProtocolIsGood(StringView(reinterpret_cast(protocol), strlen(protocol)));


Modified: trunk/Source/WebCore/platform/URLParser.cpp (208406 => 208407)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-11-04 23:55:00 UTC (rev 208406)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-11-04 23:59:03 UTC (rev 208407)
@@ -624,7 +624,7 @@
 }
 }
 
-Optional defaultPortForProtocol(StringView scheme)
+Optional URLParser::defaultPortForProtocol(StringView scheme)
 {
 static const uint16_t ftpPort = 21;
 static const uint16_t gopherPort = 70;
@@ -689,11 +689,6 @@
 }
 }
 
-bool isDefaultPortForProtocol(uint16_t port, StringView protocol)
-{
-return defaultPortForProtocol(protocol) == port;
-}
-
 enum class Scheme {
 WS,
 WSS,
@@ -2560,7 +2555,8 @@
 if (!port && digitCount > 1)
 syntaxViolation(colonIterator);
 
-if (UNLIKELY(isDefaultPortForProtocol(port, parsedDataView(0, m_url.m_schemeEnd
+ASSERT(port == static_cast(port));
+if (UNLIKELY(defaultPortForProtocol(parsedDataView(0, m_url.m_schemeEnd)) == static_cast(port)))
 syntaxViolation(colonIterator);
 else {
 appendToASCIIBuffer(':');


Modified: trunk/Source/WebCore/platform/URLParser.h (208406 => 208407)

--- trunk/Source/WebCore/platform/URLParser.h	2016-11-04 23:55:00 UTC (rev 208406)
+++ trunk/Source/WebCore/platform/URLParser.h	2016-11-04 23:59:03 UTC (rev 208407)
@@ -49,6 +49,9 @@
 static String serialize(const URLEncodedForm&);
 
 private:
+static Optional defaultPortForProtocol(StringView);
+friend Optional defaultPortForProtocol(StringView);
+
 URL m_url;
 Vector m_asciiBuffer;
 bool m_urlIsSpecial { false };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208457] trunk/LayoutTests/imported/w3c

2016-11-09 Thread achristensen

Title: [208457] trunk/LayoutTests/imported/w3c








Revision 208457
Author achristen...@apple.com
Date 2016-11-09 11:40:37 -0800 (Wed, 09 Nov 2016)


Log Message
Ignore URL.origin in URL web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=164553

Reviewed by Tim Horton.

Spec-noncompliance in our SecurityOrigin class is covering up URLParser bugs.
Let's ignore those bugs for now in our copy of the web-platform-tests so we can see URLParser conformance improvement in our results.
I've proposed moving these URL.origin checks to different tests in https://github.com/w3c/web-platform-tests/pull/4182

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/a-element.js:
(runURLTests):
* web-platform-tests/url/url-constructor-expected.txt:
* web-platform-tests/url/url-constructor.html:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element.js
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208456 => 208457)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-09 19:37:22 UTC (rev 208456)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-09 19:40:37 UTC (rev 208457)
@@ -1,3 +1,21 @@
+2016-11-09  Alex Christensen  
+
+Ignore URL.origin in URL web-platform-tests
+https://bugs.webkit.org/show_bug.cgi?id=164553
+
+Reviewed by Tim Horton.
+
+Spec-noncompliance in our SecurityOrigin class is covering up URLParser bugs.
+Let's ignore those bugs for now in our copy of the web-platform-tests so we can see URLParser conformance improvement in our results.
+I've proposed moving these URL.origin checks to different tests in https://github.com/w3c/web-platform-tests/pull/4182
+
+* web-platform-tests/url/a-element-expected.txt:
+* web-platform-tests/url/a-element-xhtml-expected.txt:
+* web-platform-tests/url/a-element.js:
+(runURLTests):
+* web-platform-tests/url/url-constructor-expected.txt:
+* web-platform-tests/url/url-constructor.html:
+
 2016-11-04  Brady Eidson  
 
 IndexedDB 2.0: Clean up more transaction abort and exception throwing behavior from IDBObjectStore.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (208456 => 208457)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt	2016-11-09 19:37:22 UTC (rev 208456)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt	2016-11-09 19:40:37 UTC (rev 208457)
@@ -7,7 +7,7 @@
 PASS Parsing: <	   :foo.com   
 > against  
 PASS Parsing: < foo.com  > against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "a://"
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
@@ -48,12 +48,12 @@
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "foo://"
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "foo://"
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "foo://"
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "foo://"
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "foo://"
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "c://"
+PASS Parsing:  against  
+PASS Parsing:  against  
+FAIL Parsing:  against  assert_equals: pathname expected "///" but got "/"
+FAIL Parsing:  against  assert_equals: pathname expected "///bar.com/" but got "/bar.com/"
+FAIL Parsing:  against  assert_equals: pathname expected "//:/" but got ":/"
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
@@ -69,26 +69,26 @@
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "madeupscheme://"
+PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "ftps://"
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing: <_javascript_:/example.com/> against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "mailto://"
+PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
 PASS Parsing:  against  
-FAIL Parsing:  against  assert_equals: origin expected "null" but got "madeupscheme://"
-FAIL

[webkit-changes] [208499] trunk/Source

2016-11-09 Thread achristensen

Title: [208499] trunk/Source








Revision 208499
Author achristen...@apple.com
Date 2016-11-09 15:28:12 -0800 (Wed, 09 Nov 2016)


Log Message
Clean up Storage code
https://bugs.webkit.org/show_bug.cgi?id=164562

Reviewed by Brady Eidson.

Source/WebKit:

Some classes were in WebCore namespace instead of WebKit.

* Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::copy):
(WebCore::StorageAreaImpl::~StorageAreaImpl): Deleted.
(WebCore::StorageAreaImpl::StorageAreaImpl): Deleted.
(WebCore::StorageAreaImpl::create): Deleted.
(WebCore::StorageAreaImpl::copy): Deleted.
(WebCore::StorageAreaImpl::canAccessStorage): Deleted.
(WebCore::StorageAreaImpl::storageType): Deleted.
(WebCore::StorageAreaImpl::length): Deleted.
(WebCore::StorageAreaImpl::key): Deleted.
(WebCore::StorageAreaImpl::item): Deleted.
(WebCore::StorageAreaImpl::setItem): Deleted.
(WebCore::StorageAreaImpl::removeItem): Deleted.
(WebCore::StorageAreaImpl::clear): Deleted.
(WebCore::StorageAreaImpl::contains): Deleted.
(WebCore::StorageAreaImpl::importItems): Deleted.
(WebCore::StorageAreaImpl::close): Deleted.
(WebCore::StorageAreaImpl::clearForOriginDeletion): Deleted.
(WebCore::StorageAreaImpl::sync): Deleted.
(WebCore::StorageAreaImpl::blockUntilImportComplete): Deleted.
(WebCore::StorageAreaImpl::memoryBytesUsedByCache): Deleted.
(WebCore::StorageAreaImpl::incrementAccessCount): Deleted.
(WebCore::StorageAreaImpl::decrementAccessCount): Deleted.
(WebCore::StorageAreaImpl::closeDatabaseTimerFired): Deleted.
(WebCore::StorageAreaImpl::closeDatabaseIfIdle): Deleted.
(WebCore::StorageAreaImpl::dispatchStorageEvent): Deleted.
* Storage/StorageAreaImpl.h:
* Storage/StorageAreaSync.cpp:
(WebKit::StorageAreaSync::StorageAreaSync):
(WebKit::StorageAreaSync::create):
(WebCore::StorageAreaSync::StorageAreaSync): Deleted.
(WebCore::StorageAreaSync::create): Deleted.
(WebCore::StorageAreaSync::~StorageAreaSync): Deleted.
(WebCore::StorageAreaSync::scheduleFinalSync): Deleted.
(WebCore::StorageAreaSync::scheduleItemForSync): Deleted.
(WebCore::StorageAreaSync::scheduleClear): Deleted.
(WebCore::StorageAreaSync::scheduleCloseDatabase): Deleted.
(WebCore::StorageAreaSync::syncTimerFired): Deleted.
(WebCore::StorageAreaSync::openDatabase): Deleted.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded): Deleted.
(WebCore::StorageAreaSync::performImport): Deleted.
(WebCore::StorageAreaSync::markImported): Deleted.
(WebCore::StorageAreaSync::blockUntilImportComplete): Deleted.
(WebCore::StorageAreaSync::sync): Deleted.
(WebCore::StorageAreaSync::performSync): Deleted.
(WebCore::StorageAreaSync::deleteEmptyDatabase): Deleted.
(WebCore::StorageAreaSync::scheduleSync): Deleted.
* Storage/StorageAreaSync.h:
* Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
(WebKit::StorageNamespaceImpl::getOrCreateLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::storageArea):
(WebCore::localStorageNamespaceMap): Deleted.
(WebCore::StorageNamespaceImpl::createSessionStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::getOrCreateLocalStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl): Deleted.
(WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): Deleted.
(WebCore::StorageNamespaceImpl::copy): Deleted.
(WebCore::StorageNamespaceImpl::storageArea): Deleted.
(WebCore::StorageNamespaceImpl::close): Deleted.
(WebCore::StorageNamespaceImpl::clearOriginForDeletion): Deleted.
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion): Deleted.
(WebCore::StorageNamespaceImpl::sync): Deleted.
(WebCore::StorageNamespaceImpl::closeIdleLocalStorageDatabases): Deleted.
* Storage/StorageNamespaceImpl.h:
* Storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker): Deleted.
(WebCore::StorageTracker::internalInitialize): Deleted.
(WebCore::StorageTracker::tracker): Deleted.
(WebCore::StorageTracker::StorageTracker): Deleted.
(WebCore::StorageTracker::setDatabaseDirectoryPath): Deleted.
(WebCore::StorageTracker::databaseDirectoryPath): Deleted.
(WebCore::StorageTracker::trackerDatabasePath): Deleted.
(WebCore::ensureDatabaseFileExists): Deleted.
(WebCore::StorageTracker::openTrackerDatabase): Deleted.
(WebCore::StorageTracker::importOriginIdentifiers): Deleted.
(WebCore::StorageTracker::finishedImportingOriginIdentifiers): Deleted.
(WebCore::StorageTracker::syncImportOriginIdentifiers): Deleted.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): Deleted.
(WebCore::StorageTracker::setOriginDetails): Deleted.
(WebCore::StorageTracker::syncSetOriginDetails): Deleted.
(WebCore::StorageTracker::origins): Deleted.
(WebCore::StorageTracker::deleteAllOrigins): Deleted.
(WebCore::truncateDatabaseFile): Deleted.
(WebCore::StorageTracker::syncDeleteAllOrigins): Deleted.
(WebCore::StorageTracker::deleteOriginWithIdentifier): Deleted.
(WebCore::StorageTracker::deleteOrigin): Deleted.
(WebCore::StorageTracker::s

[webkit-changes] [208505] trunk/Source/WebKit/win

2016-11-09 Thread achristensen

Title: [208505] trunk/Source/WebKit/win








Revision 208505
Author achristen...@apple.com
Date 2016-11-09 15:59:58 -0800 (Wed, 09 Nov 2016)


Log Message
Fix Windows build after r208499
https://bugs.webkit.org/show_bug.cgi?id=164562

* WebKitDLL.cpp:
(shutDownWebKit):

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKitDLL.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (208504 => 208505)

--- trunk/Source/WebKit/win/ChangeLog	2016-11-09 23:51:28 UTC (rev 208504)
+++ trunk/Source/WebKit/win/ChangeLog	2016-11-09 23:59:58 UTC (rev 208505)
@@ -1,3 +1,11 @@
+2016-11-09  Alex Christensen  
+
+Fix Windows build after r208499
+https://bugs.webkit.org/show_bug.cgi?id=164562
+
+* WebKitDLL.cpp:
+(shutDownWebKit):
+
 2016-11-09  Darin Adler  
 
 Move Range from ExceptionCode to ExceptionOr


Modified: trunk/Source/WebKit/win/WebKitDLL.cpp (208504 => 208505)

--- trunk/Source/WebKit/win/WebKitDLL.cpp	2016-11-09 23:51:28 UTC (rev 208504)
+++ trunk/Source/WebKit/win/WebKitDLL.cpp	2016-11-09 23:59:58 UTC (rev 208505)
@@ -146,7 +146,7 @@
 void shutDownWebKit()
 {
 WebCore::iconDatabase().close();
-WebStorageNamespaceProvider::closeLocalStorage();
+WebKit::WebStorageNamespaceProvider::closeLocalStorage();
 }
 
 //FIXME: We should consider moving this to a new file for cross-project functionality






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208507] trunk/Source/WebCore

2016-11-09 Thread achristensen

Title: [208507] trunk/Source/WebCore








Revision 208507
Author achristen...@apple.com
Date 2016-11-09 16:18:54 -0800 (Wed, 09 Nov 2016)


Log Message
Simplify logic of SecurityOrigin::databaseIdentifier
https://bugs.webkit.org/show_bug.cgi?id=164565

Reviewed by Brady Eidson.

No change in behavior.

SecurityOrigins with the file scheme need a special database identifier to be backwards-compatible with existing storage.
Instead of determining whether this is a file SecurityOrigin at parsing time and only using that information when
making the database identifier, just determine whether we need this quirk when making the database identifier.
I'm planning to move this logic to SecurityOriginData in another patch.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::databaseIdentifier):
* page/SecurityOrigin.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208506 => 208507)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 00:11:30 UTC (rev 208506)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 00:18:54 UTC (rev 208507)
@@ -1,3 +1,23 @@
+2016-11-09  Alex Christensen  
+
+Simplify logic of SecurityOrigin::databaseIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=164565
+
+Reviewed by Brady Eidson.
+
+No change in behavior.
+
+SecurityOrigins with the file scheme need a special database identifier to be backwards-compatible with existing storage.
+Instead of determining whether this is a file SecurityOrigin at parsing time and only using that information when
+making the database identifier, just determine whether we need this quirk when making the database identifier.
+I'm planning to move this logic to SecurityOriginData in another patch.
+
+* page/SecurityOrigin.cpp:
+(WebCore::SecurityOrigin::SecurityOrigin):
+(WebCore::SecurityOrigin::create):
+(WebCore::SecurityOrigin::databaseIdentifier):
+* page/SecurityOrigin.h:
+
 2016-11-09  Jaehun Lim  
 
 Unreviewed, build fix after r208460


Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (208506 => 208507)

--- trunk/Source/WebCore/page/SecurityOrigin.cpp	2016-11-10 00:11:30 UTC (rev 208506)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp	2016-11-10 00:18:54 UTC (rev 208507)
@@ -110,7 +110,6 @@
 , m_domainWasSetInDOM(false)
 , m_storageBlockingPolicy(AllowAllStorage)
 , m_enforceFilePathSeparation(false)
-, m_needsDatabaseIdentifierQuirkForFiles(false)
 {
 // document.domain starts as m_host, but can be set by the DOM.
 m_domain = m_host;
@@ -135,7 +134,6 @@
 , m_canLoadLocalResources(false)
 , m_storageBlockingPolicy(AllowAllStorage)
 , m_enforceFilePathSeparation(false)
-, m_needsDatabaseIdentifierQuirkForFiles(false)
 {
 }
 
@@ -151,7 +149,6 @@
 , m_canLoadLocalResources(other->m_canLoadLocalResources)
 , m_storageBlockingPolicy(other->m_storageBlockingPolicy)
 , m_enforceFilePathSeparation(other->m_enforceFilePathSeparation)
-, m_needsDatabaseIdentifierQuirkForFiles(other->m_needsDatabaseIdentifierQuirkForFiles)
 {
 }
 
@@ -160,20 +157,9 @@
 if (RefPtr cachedOrigin = getCachedOrigin(url))
 return cachedOrigin.releaseNonNull();
 
-if (shouldTreatAsUniqueOrigin(url)) {
-Ref origin(adoptRef(*new SecurityOrigin));
+if (shouldTreatAsUniqueOrigin(url))
+return adoptRef(*new SecurityOrigin);
 
-if (url.protocolIs("file")) {
-// Unfortunately, we can't represent all unique origins exactly
-// the same way because we need to produce a quirky database
-// identifier for file URLs due to persistent storage in some
-// embedders of WebKit.
-origin->m_needsDatabaseIdentifierQuirkForFiles = true;
-}
-
-return origin;
-}
-
 if (shouldUseInnerURL(url))
 return adoptRef(*new SecurityOrigin(extractInnerURL(url)));
 
@@ -564,7 +550,7 @@
 // string because of a bug in how we handled the scheme for file URLs.
 // Now that we've fixed that bug, we still need to produce this string
 // to avoid breaking existing persistent state.
-if (m_needsDatabaseIdentifierQuirkForFiles)
+if (equalIgnoringASCIICase(m_protocol, "file"))
 return ASCIILiteral("file__0");
 
 StringBuilder stringBuilder;


Modified: trunk/Source/WebCore/page/SecurityOrigin.h (208506 => 208507)

--- trunk/Source/WebCore/page/SecurityOrigin.h	2016-11-10 00:11:30 UTC (rev 208506)
+++ trunk/Source/WebCore/page/SecurityOrigin.h	2016-11-10 00:18:54 UTC (rev 208507)
@@ -232,7 +232,6 @@
 bool m_canLoadLocalResources;
 StorageBlockingPolicy m_storageBlockingPolicy;
 bool m_enforceFilePathSeparation;
-bool m_needsDatabaseIdentifierQuirkForFiles;
 };
 
 /

[webkit-changes] [208513] trunk

2016-11-09 Thread achristensen

Title: [208513] trunk








Revision 208513
Author achristen...@apple.com
Date 2016-11-09 17:21:56 -0800 (Wed, 09 Nov 2016)


Log Message
Unreviewed, rolling out r208438.

crashes

Reverted changeset:

"[WK2][NETWORK_SESSION] Add support for downloading file
backed blobs"
https://bugs.webkit.org/show_bug.cgi?id=164458
http://trac.webkit.org/changeset/208438

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp
trunk/Source/WebKit2/NetworkProcess/Downloads/DownloadManager.h
trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit2/NetworkProcess/NetworkDataTaskBlob.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkDataTaskBlob.h
trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkLoadParameters.h
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/NetworkProcess/PingLoad.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp


Removed Paths

trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt
trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html
trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt
trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208512 => 208513)

--- trunk/LayoutTests/ChangeLog	2016-11-10 01:16:20 UTC (rev 208512)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 01:21:56 UTC (rev 208513)
@@ -1,3 +1,16 @@
+2016-11-09  Alex Christensen  
+
+Unreviewed, rolling out r208438.
+
+crashes
+
+Reverted changeset:
+
+"[WK2][NETWORK_SESSION] Add support for downloading file
+backed blobs"
+https://bugs.webkit.org/show_bug.cgi?id=164458
+http://trac.webkit.org/changeset/208438
+
 2016-11-09  Ryan Haddad  
 
 Marking two media/modern-media-controls tests as flaky.


Deleted: trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt (208512 => 208513)

--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt	2016-11-10 01:16:20 UTC (rev 208512)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt	2016-11-10 01:21:56 UTC (rev 208513)
@@ -1,6 +0,0 @@
-Download started.
-Downloading URL with suggested filename "unknown"
-Download completed.
-The download should succeed.
-
-File backed blob URL


Deleted: trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html (208512 => 208513)

--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html	2016-11-10 01:16:20 UTC (rev 208512)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html	2016-11-10 01:21:56 UTC (rev 208513)
@@ -1,37 +0,0 @@
-
-
-
-
-if (window.testRunner) {
-  testRunner.dumpAsText();
-  testRunner.waitUntilDone();
-  testRunner.setShouldDownloadUndisplayableMIMETypes(true);
-}
-
-
-
-The download should succeed.
-File backed blob URL
-
-function click(elmt)
-{
-if (!window.eventSender) {
-alert('Click the link to run the test.');
-return;
-}
-eventSender.mouseMoveTo(elmt.offsetLeft + 5, elmt.offsetTop + 5);
-eventSender.mouseDown();
-eventSender.mouseUp();
-}
-
-function runTest()
-{
-file = internals.createFile("../../../resources/Ahem.otf");
-var link = document.getElementById("blob-url");
-link.href = ""
-click(link);
-}
-runTest();
-
-
-


Deleted: trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt (208512 => 208513)

--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt	2016-11-10 01:16:20 UTC (rev 208512)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt	2016-11-10 01:21:56 UTC (rev 208513)
@@ -1,6 +0,0 @@
-Download started.
-Downloading URL with suggested filename "abe.png"
-Download completed.
-The suggested filename above should

[webkit-changes] [208558] trunk/Source

2016-11-10 Thread achristensen

Title: [208558] trunk/Source








Revision 208558
Author achristen...@apple.com
Date 2016-11-10 12:52:17 -0800 (Thu, 10 Nov 2016)


Log Message
Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
https://bugs.webkit.org/show_bug.cgi?id=164573

Reviewed by Brady Eidson.

Source/WebCore:

No change in behavior.

* Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
(WebCore::WebKitMediaKeySession::mediaKeysStorageDirectory):
* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot):
* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasEntryForOriginNoLock):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::deleteOriginLockFor):
(WebCore::DatabaseTracker::quotaForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
* dom/Document.cpp:
(WebCore::Document::origin):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::calculateQuotaForOrigin):
(WebCore::ApplicationCacheStorage::calculateUsageForOrigin):
(WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache):
(WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::ensureOriginRecord):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::databaseIdentifier): Deleted.
* page/SecurityOrigin.h:
* page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::databaseIdentifier):
* page/SecurityOriginData.h:

Source/WebKit:

* Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::create):
* Storage/StorageTracker.cpp:
(WebKit::StorageTracker::deleteOrigin):
(WebKit::StorageTracker::diskUsageForOrigin):

Source/WebKit/mac:

* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin databaseIdentifier]):

Source/WebKit2:

* Shared/API/c/WKSecurityOriginRef.cpp:
(WKSecurityOriginCopyDatabaseIdentifier):
* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath):
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteDatabaseWithOrigin):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeMediaKeys):
* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyOriginsWithApplicationCache):
* WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectoryForOrigin):
* WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::startUserMediaRequest):
(WebKit::UserMediaPermissionRequestManager::enumerateMediaDevices):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebCore/page/SecurityOriginData.cpp
trunk/Source/WebCore/page/SecurityOriginData.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Storage/StorageAreaImpl.cpp
trunk/Source/WebKit/Storage/StorageTracker.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOrigin.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKSecurityOriginRef.cpp
trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestM

[webkit-changes] [208580] trunk

2016-11-10 Thread achristensen

Title: [208580] trunk








Revision 208580
Author achristen...@apple.com
Date 2016-11-10 22:16:08 -0800 (Thu, 10 Nov 2016)


Log Message
Fix assertion after r208534.
https://bugs.webkit.org/show_bug.cgi?id=160497

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):
WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
(TestWebKitAPI::TEST):
Add a regression test.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (208579 => 208580)

--- trunk/Source/WebKit/mac/ChangeLog	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1,5 +1,17 @@
 2016-11-10  Alex Christensen  
 
+Fix assertion after r208534.
+https://bugs.webkit.org/show_bug.cgi?id=160497
+
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+(WebInstallMemoryPressureHandler):
+WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
+When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
+only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
+
+2016-11-10  Alex Christensen  
+
 Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
 https://bugs.webkit.org/show_bug.cgi?id=164573
 


Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (208579 => 208580)

--- trunk/Source/WebKit/mac/WebView/WebView.mm	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1430,19 +1430,8 @@
 _private->page->settings().setFontFallbackPrefersPictographs(true);
 #endif
 
-if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"]) {
-WebCore::registerMemoryReleaseNotifyCallbacks();
+WebInstallMemoryPressureHandler();
 
-static std::once_flag onceFlag;
-std::call_once(onceFlag, [] {
-auto& memoryPressureHandler = MemoryPressureHandler::singleton();
-memoryPressureHandler.setLowMemoryHandler([] (Critical critical, Synchronous synchronous) {
-WebCore::releaseMemory(critical, synchronous);
-});
-memoryPressureHandler.install();
-});
-}
-
 if (!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_LOCAL_RESOURCE_SECURITY_RESTRICTION)) {
 // Originally, we allowed all local loads.
 SecurityPolicy::setLocalLoadPolicy(SecurityPolicy::AllowLocalLoadsForAll);
@@ -9800,6 +9789,16 @@
 
 void WebInstallMemoryPressureHandler(void)
 {
-if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"])
-MemoryPressureHandler::singleton().install();
+if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"]) {
+WebCore::registerMemoryReleaseNotifyCallbacks();
+
+static std::once_flag onceFlag;
+std::call_once(onceFlag, [] {
+auto& memoryPressureHandler = MemoryPressureHandler::singleton();
+memoryPressureHandler.setLowMemoryHandler([] (Critical critical, Synchronous synchronous) {
+WebCore::releaseMemory(critical, synchronous);
+});
+memoryPressureHandler.install();
+});
+}
 }


Modified: trunk/Tools/ChangeLog (208579 => 208580)

--- trunk/Tools/ChangeLog	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Tools/ChangeLog	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1,3 +1,13 @@
+2016-11-10  Alex Christensen  
+
+Fix assertion after r208534.
+https://bugs.webkit.org/show_bug.cgi?id=160497
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
+(TestWebKitAPI::TEST):
+Add a regression test.
+
 2016-11-10  Chris Dumez  
 
 REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (208579 => 208580)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2016-11-11 06:08:18 UTC (rev 208579)
+++ tr

[webkit-changes] [208600] trunk

2016-11-11 Thread achristensen

Title: [208600] trunk








Revision 208600
Author achristen...@apple.com
Date 2016-11-11 11:11:28 -0800 (Fri, 11 Nov 2016)


Log Message
Allow mutable lambdas in HashMap::ensure
https://bugs.webkit.org/show_bug.cgi?id=164642

Reviewed by Sam Weinig.

Source/WTF:

* wtf/HashMap.h:
(WTF::HashMapEnsureTranslator::translate):
(WTF::X>::removeIf):

Tools:

* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashMap.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (208599 => 208600)

--- trunk/Source/WTF/ChangeLog	2016-11-11 19:09:01 UTC (rev 208599)
+++ trunk/Source/WTF/ChangeLog	2016-11-11 19:11:28 UTC (rev 208600)
@@ -1,3 +1,14 @@
+2016-11-11  Alex Christensen  
+
+Allow mutable lambdas in HashMap::ensure
+https://bugs.webkit.org/show_bug.cgi?id=164642
+
+Reviewed by Sam Weinig.
+
+* wtf/HashMap.h:
+(WTF::HashMapEnsureTranslator::translate):
+(WTF::X>::removeIf):
+
 2016-11-11  Beth Dakin  
 
 Get touch bar code building for open source builds


Modified: trunk/Source/WTF/wtf/HashMap.h (208599 => 208600)

--- trunk/Source/WTF/wtf/HashMap.h	2016-11-11 19:09:01 UTC (rev 208599)
+++ trunk/Source/WTF/wtf/HashMap.h	2016-11-11 19:11:28 UTC (rev 208600)
@@ -122,13 +122,13 @@
 template AddResult fastAdd(const KeyType&, V&&);
 template AddResult fastAdd(KeyType&&, V&&);
 
-template AddResult ensure(const KeyType&, const Functor&);
-template AddResult ensure(KeyType&&, const Functor&);
+template AddResult ensure(const KeyType&, Functor&&);
+template AddResult ensure(KeyType&&, Functor&&);
 
 bool remove(const KeyType&);
 bool remove(iterator);
 template
-void removeIf(const Functor& functor);
+void removeIf(Functor&&);
 void clear();
 
 MappedTakeType take(const KeyType&); // efficient combination of get with remove
@@ -171,7 +171,7 @@
 AddResult inlineAdd(K&&, V&&);
 
 template
-AddResult inlineEnsure(K&&, const F&);
+AddResult inlineEnsure(K&&, F&&);
 
 HashTableType m_impl;
 };
@@ -191,7 +191,7 @@
 struct HashMapEnsureTranslator {
 template static unsigned hash(const T& key) { return HashFunctions::hash(key); }
 template static bool equal(const T& a, const U& b) { return HashFunctions::equal(a, b); }
-template static void translate(T& location, U&& key, const Functor& functor)
+template static void translate(T& location, U&& key, Functor&& functor)
 {
 ValueTraits::KeyTraits::assignToEmpty(location.key, std::forward(key));
 ValueTraits::ValueTraits::assignToEmpty(location.value, functor());
@@ -319,9 +319,9 @@
 
 template
 template
-ALWAYS_INLINE auto HashMap::inlineEnsure(K&& key, const F& functor) -> AddResult
+ALWAYS_INLINE auto HashMap::inlineEnsure(K&& key, F&& functor) -> AddResult
 {
-return m_impl.template add>(std::forward(key), functor);
+return m_impl.template add>(std::forward(key), std::forward(functor));
 }
 
 template
@@ -375,16 +375,16 @@
 
 template
 template
-auto HashMap::ensure(const KeyType& key, const Functor& functor) -> AddResult
+auto HashMap::ensure(const KeyType& key, Functor&& functor) -> AddResult
 {
-return inlineEnsure(key, functor);
+return inlineEnsure(key, std::forward(functor));
 }
 
 template
 template
-auto HashMap::ensure(KeyType&& key, const Functor& functor) -> AddResult
+auto HashMap::ensure(KeyType&& key, Functor&& functor) -> AddResult
 {
-return inlineEnsure(WTFMove(key), functor);
+return inlineEnsure(std::forward(key), std::forward(functor));
 }
 
 template
@@ -417,9 +417,9 @@
 
 template
 template
-inline void HashMap::removeIf(const Functor& functor)
+inline void HashMap::removeIf(Functor&& functor)
 {
-m_impl.removeIf(functor);
+m_impl.removeIf(std::forward(functor));
 }
 
 template


Modified: trunk/Tools/ChangeLog (208599 => 208600)

--- trunk/Tools/ChangeLog	2016-11-11 19:09:01 UTC (rev 208599)
+++ trunk/Tools/ChangeLog	2016-11-11 19:11:28 UTC (rev 208600)
@@ -1,3 +1,13 @@
+2016-11-11  Alex Christensen  
+
+Allow mutable lambdas in HashMap::ensure
+https://bugs.webkit.org/show_bug.cgi?id=164642
+
+Reviewed by Sam Weinig.
+
+* TestWebKitAPI/Tests/WTF/HashMap.cpp:
+(TestWebKitAPI::TEST):
+
 2016-11-11  Wenson Hsieh  
 
 Composition state should be cleared when changing focus to a non-editable element


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp (208599 => 208600)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp	2016-11-11 19:09:01 UTC (rev 208599)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp	2016-11-11 19:11:28 UTC (rev 208600)
@@ -895,7 +895,7 @@
 HashMap> map;
 
 RefLogger a("a");
-map.ensure(1, [&]() { 
+map.ensure(1, [&]() mutable {
 Ref ref(a);
 return ref; 
 });

[webkit-changes] [200614] trunk/Source/WebCore

2016-05-09 Thread achristensen

Title: [200614] trunk/Source/WebCore








Revision 200614
Author achristen...@apple.com
Date 2016-05-09 22:04:24 -0700 (Mon, 09 May 2016)


Log Message
Fix GTK build after r200607

* Modules/notifications/Notification.h:
dir and replaceId are used in WebNotificationManager with NOTIFICATIONS and with LEGACY_NOTIFICATIONS

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/notifications/Notification.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (200613 => 200614)

--- trunk/Source/WebCore/ChangeLog	2016-05-10 04:58:30 UTC (rev 200613)
+++ trunk/Source/WebCore/ChangeLog	2016-05-10 05:04:24 UTC (rev 200614)
@@ -1,3 +1,10 @@
+2016-05-09  Alex Christensen  
+
+Fix GTK build after r200607
+
+* Modules/notifications/Notification.h:
+dir and replaceId are used in WebNotificationManager with NOTIFICATIONS and with LEGACY_NOTIFICATIONS
+
 2016-05-09  Simon Fraser  
 
 Fix the Windows build after r200602, and do some minor tidyup.


Modified: trunk/Source/WebCore/Modules/notifications/Notification.h (200613 => 200614)

--- trunk/Source/WebCore/Modules/notifications/Notification.h	2016-05-10 04:58:30 UTC (rev 200613)
+++ trunk/Source/WebCore/Modules/notifications/Notification.h	2016-05-10 05:04:24 UTC (rev 200614)
@@ -80,13 +80,11 @@
 const String& body() const { return m_body; }
 const String& lang() const { return m_lang; }
 
-#if ENABLE(LEGACY_NOTIFICATIONS)
 const String& dir() const { return m_direction; }
 void setDir(const String& dir) { m_direction = dir; }
 
 const String& replaceId() const { return m_tag; }
 void setReplaceId(const String& replaceId) { m_tag = replaceId; }
-#endif
 
 const String& tag() const { return m_tag; }
 void setTag(const String& tag) { m_tag = tag; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [200655] trunk/Source

2016-05-10 Thread achristensen

Title: [200655] trunk/Source








Revision 200655
Author achristen...@apple.com
Date 2016-05-10 16:49:01 -0700 (Tue, 10 May 2016)


Log Message
Handle _schemeUpgraded delegate callbacks in NSURLSessionDataDelegate
https://bugs.webkit.org/show_bug.cgi?id=157354
rdar://problem/25842107

Reviewed by Darin Adler.

Source/WebCore:

No new tests.  This cannot be tested with a self-signed certificate.
This needs to be tested once we use real ssl certificates for testing.

* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
* platform/network/mac/WebCoreURLResponse.h:
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::synthesizeRedirectResponseIfNecessary):
Take the NSURLRequest instead of the NSURLConnection as a parameter so we can share this code with the NSURLSession loader,
which has an NSURLSessionDataTask.  Both have the currentRequest, which is all we need in this function anyway.

Source/WebKit2:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
When we make a request to a http url and CFNetwork determines that that url would have redirected to an HSTS site
and it is going to change the request to an https request, this delegate callback is called.  We need to call the
redirection code to have the same behavior as the NSURLConnection-based loader.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.h
trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (200654 => 200655)

--- trunk/Source/WebCore/ChangeLog	2016-05-10 23:47:10 UTC (rev 200654)
+++ trunk/Source/WebCore/ChangeLog	2016-05-10 23:49:01 UTC (rev 200655)
@@ -1,3 +1,24 @@
+2016-05-10  Alex Christensen  
+
+Handle _schemeUpgraded delegate callbacks in NSURLSessionDataDelegate
+https://bugs.webkit.org/show_bug.cgi?id=157354
+rdar://problem/25842107
+
+Reviewed by Darin Adler.
+
+No new tests.  This cannot be tested with a self-signed certificate.
+This needs to be tested once we use real ssl certificates for testing.
+
+* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
+(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
+* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
+* platform/network/mac/WebCoreURLResponse.h:
+* platform/network/mac/WebCoreURLResponse.mm:
+(WebCore::synthesizeRedirectResponseIfNecessary):
+Take the NSURLRequest instead of the NSURLConnection as a parameter so we can share this code with the NSURLSession loader,
+which has an NSURLSessionDataTask.  Both have the currentRequest, which is all we need in this function anyway.
+
 2016-05-10  Joseph Pecoraro  
 
 Web Inspector: Backend should initiate timeline recordings on page navigations to ensure nothing is missed


Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm (200654 => 200655)

--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm	2016-05-10 23:47:10 UTC (rev 200654)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm	2016-05-10 23:49:01 UTC (rev 200655)
@@ -64,7 +64,7 @@
 if (!m_handle)
 return nil;
 
-redirectResponse = synthesizeRedirectResponseIfNecessary(connection, newRequest, redirectResponse);
+redirectResponse = synthesizeRedirectResponseIfNecessary([connection currentRequest], newRequest, redirectResponse);
 
 // See . This is a workaround for a behavior change in CFNetwork where willSendRequest gets called more often.
 if (!redirectResponse)


Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (200654 => 200655)

--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm	2016-05-10 23:47:10 UTC (rev 200654)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm	2016-05-10 23:49:01 UTC (rev 200655)
@@ -100,7 +100,7 @@
 ASSERT(!isMainThread());
 UNUSED_PARAM(connection);
 
-redirectResponse = synthesizeRedirectResponseIfNecessary(connection, newRequest, redirectResponse);
+redirectResponse = synthesi

[webkit-changes] [200977] trunk/Source/WebCore

2016-05-16 Thread achristensen

Title: [200977] trunk/Source/WebCore








Revision 200977
Author achristen...@apple.com
Date 2016-05-16 16:11:08 -0700 (Mon, 16 May 2016)


Log Message
Don't include CSSParser.h from other headers
https://bugs.webkit.org/show_bug.cgi?id=157765

Reviewed by Zalan Bujtas.

No change in behavior.  This just makes it so touching CSSParser.h doesn't rebuild as many files.

* css/CSSCalculationValue.cpp:
* css/CSSParser.cpp:
(WebCore::CSSParser::sourceSize):
(WebCore::filterProperties):
* css/CSSParser.h:
(WebCore::CSSParser::ValueWithCalculation::ValueWithCalculation):
* css/CSSProperty.h:
(WebCore::prefixingVariantForPropertyId):
* css/FontFace.cpp:
* css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::parseDeclaration):
(WebCore::MutableStyleProperties::addParsedProperties):
* css/StyleProperties.h:
* css/StyleResolver.h:
* rendering/style/RenderStyle.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCalculationValue.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSProperty.h
trunk/Source/WebCore/css/FontFace.cpp
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
trunk/Source/WebCore/css/StyleResolver.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (200976 => 200977)

--- trunk/Source/WebCore/ChangeLog	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/ChangeLog	2016-05-16 23:11:08 UTC (rev 200977)
@@ -1,3 +1,28 @@
+2016-05-16  Alex Christensen  
+
+Don't include CSSParser.h from other headers
+https://bugs.webkit.org/show_bug.cgi?id=157765
+
+Reviewed by Zalan Bujtas.
+
+No change in behavior.  This just makes it so touching CSSParser.h doesn't rebuild as many files.
+
+* css/CSSCalculationValue.cpp:
+* css/CSSParser.cpp:
+(WebCore::CSSParser::sourceSize):
+(WebCore::filterProperties):
+* css/CSSParser.h:
+(WebCore::CSSParser::ValueWithCalculation::ValueWithCalculation):
+* css/CSSProperty.h:
+(WebCore::prefixingVariantForPropertyId):
+* css/FontFace.cpp:
+* css/StyleProperties.cpp:
+(WebCore::MutableStyleProperties::parseDeclaration):
+(WebCore::MutableStyleProperties::addParsedProperties):
+* css/StyleProperties.h:
+* css/StyleResolver.h:
+* rendering/style/RenderStyle.cpp:
+
 2016-05-16  Aaron Chu  
 
 REGRESSION (r200441): Yahoo sports, finance and news pages automatically scroll


Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (200976 => 200977)

--- trunk/Source/WebCore/css/CSSCalculationValue.cpp	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp	2016-05-16 23:11:08 UTC (rev 200977)
@@ -32,6 +32,7 @@
 #include "config.h"
 #include "CSSCalculationValue.h"
 
+#include "CSSParser.h"
 #include "CSSPrimitiveValueMappings.h"
 #include "StyleResolver.h"
 #include 


Modified: trunk/Source/WebCore/css/CSSParser.cpp (200976 => 200977)

--- trunk/Source/WebCore/css/CSSParser.cpp	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2016-05-16 23:11:08 UTC (rev 200977)
@@ -1595,7 +1595,7 @@
 return SourceSize(WTFMove(_expression_), WTFMove(value));
 }
 
-static inline void filterProperties(bool important, const CSSParser::ParsedPropertyVector& input, Vector& output, size_t& unusedEntries, std::bitset& seenProperties, HashSet& seenCustomProperties)
+static inline void filterProperties(bool important, const ParsedPropertyVector& input, Vector& output, size_t& unusedEntries, std::bitset& seenProperties, HashSet& seenCustomProperties)
 {
 // Add properties in reverse order so that highest priority definitions are reached first. Duplicate definitions can then be ignored when found.
 for (int i = input.size() - 1; i >= 0; --i) {


Modified: trunk/Source/WebCore/css/CSSParser.h (200976 => 200977)

--- trunk/Source/WebCore/css/CSSParser.h	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSParser.h	2016-05-16 23:11:08 UTC (rev 200977)
@@ -88,8 +88,6 @@
 Error
 };
 
-using ParsedPropertyVector = Vector;
-
 class ValueWithCalculation {
 public:
 explicit ValueWithCalculation(CSSParserValue& value)


Modified: trunk/Source/WebCore/css/CSSProperty.h (200976 => 200977)

--- trunk/Source/WebCore/css/CSSProperty.h	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSProperty.h	2016-05-16 23:11:08 UTC (rev 200977)
@@ -104,6 +104,8 @@
 RefPtr m_value;
 };
 
+typedef Vector ParsedPropertyVector;
+
 inline CSSPropertyID prefixingVariantForPropertyId(CSSPropertyID propertyID)
 {
 ASSERT(propertyID != CSSPropertyInvalid);


Modified: trunk/Source/WebCore/css/FontFace.cpp (200976 => 200977)

--- trunk/Source/WebCore/css/FontFace.cpp	2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/FontFace.cpp	2016-

[webkit-changes] [201108] trunk/Source/WebKit2

2016-05-18 Thread achristensen

Title: [201108] trunk/Source/WebKit2








Revision 201108
Author achristen...@apple.com
Date 2016-05-18 15:45:37 -0700 (Wed, 18 May 2016)


Log Message
Build fix when not using CredentialStorage with NetworkSession.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::clearCredentials):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (201107 => 201108)

--- trunk/Source/WebKit2/ChangeLog	2016-05-18 22:40:26 UTC (rev 201107)
+++ trunk/Source/WebKit2/ChangeLog	2016-05-18 22:45:37 UTC (rev 201108)
@@ -1,3 +1,10 @@
+2016-05-18  Alex Christensen  
+
+Build fix when not using CredentialStorage with NetworkSession.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSession::clearCredentials):
+
 2016-05-18  Brady Eidson  
 
 Fix null-deref crash sporadically seen after http://trac.webkit.org/changeset/201098


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm (201107 => 201108)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2016-05-18 22:40:26 UTC (rev 201107)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2016-05-18 22:45:37 UTC (rev 201108)
@@ -392,7 +392,7 @@
 ASSERT(m_dataTaskMapWithCredentials.isEmpty());
 ASSERT(m_dataTaskMapWithoutCredentials.isEmpty());
 ASSERT(m_downloadMap.isEmpty());
-m_sessionWithCredentialStorage = [NSURLSession sessionWithConfiguration:m_sessionWithCredentialStorage.get().configuration delegate:static_cast(m_sessionDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]];
+m_sessionWithCredentialStorage = [NSURLSession sessionWithConfiguration:m_sessionWithCredentialStorage.get().configuration delegate:static_cast(m_sessionWithCredentialStorageDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]];
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201113] trunk/Source

2016-05-18 Thread achristensen

Title: [201113] trunk/Source








Revision 201113
Author achristen...@apple.com
Date 2016-05-18 16:09:09 -0700 (Wed, 18 May 2016)


Log Message
Clean up CSS code
https://bugs.webkit.org/show_bug.cgi?id=157808

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. Just cleaning up and modernizing code.

* css/BasicShapeFunctions.cpp:
(WebCore::convertToCenterCoordinate):
(WebCore::cssValueToBasicShapeRadius):
(WebCore::basicShapeForValue):
* css/BasicShapeFunctions.h:
* css/CSSAnimationTriggerScrollValue.h:
(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):
* css/CSSAspectRatioValue.h:
* css/CSSBasicShapes.h:
* css/CSSBorderImage.cpp:
(WebCore::createBorderImageValue):
* css/CSSBorderImage.h:
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::create):
* css/CSSCalculationValue.h:
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
* css/CSSComputedStyleDeclaration.h:
* css/CSSFontFaceLoadEvent.cpp:
(WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
* css/CSSFontFaceLoadEvent.h:
* css/CSSFontValue.h:
* css/CSSFunctionValue.h:
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::setFirstX):
(WebCore::CSSGradientValue::setFirstY):
(WebCore::CSSGradientValue::setSecondX):
(WebCore::CSSGradientValue::setSecondY):
(WebCore::CSSGradientValue::addStop):
(WebCore::CSSLinearGradientValue::create):
(WebCore::CSSLinearGradientValue::setAngle):
(WebCore::CSSRadialGradientValue::setFirstRadius):
(WebCore::CSSRadialGradientValue::setSecondRadius):
(WebCore::CSSRadialGradientValue::setShape):
(WebCore::CSSRadialGradientValue::setSizingBehavior):
(WebCore::CSSRadialGradientValue::setEndHorizontalSize):
(WebCore::CSSRadialGradientValue::setEndVerticalSize):
* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
* css/CSSKeyframesRule.cpp:
(WebCore::CSSKeyframesRule::cssRules):
* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
* css/CSSParser.h:
(WebCore::cssyylex):
* css/CSSPrimitiveValue.h:
* css/CSSProperty.cpp:
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
* css/CSSRule.h:
* css/CSSRuleList.h:
* css/CSSSegmentedFontFace.h:
* css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::identifier):
(WebCore::Counter::listStyleIdent):
(WebCore::Counter::setIdentifier):
(WebCore::Counter::setListStyle):
(WebCore::Counter::setSeparator):
(WebCore::Counter::equals):
(WebCore::Counter::cloneForCSSOM):
(WebCore::Counter::Counter):
* css/Pair.h:
* css/Rect.h:
(WebCore::RectBase::bottom):
(WebCore::RectBase::left):
(WebCore::RectBase::setTop):
(WebCore::RectBase::setRight):
(WebCore::RectBase::setBottom):
(WebCore::RectBase::setLeft):
(WebCore::RectBase::equals):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::strokeDashArrayToCSSValueList):
(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertClipPath):
(WebCore::StyleBuilderConverter::convertShapeValue):
* css/StyleProperties.cpp:
(WebCore::StyleProperties::borderPropertyValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getPropertyCSSValueInternal):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::setProperty):
* css/StyleProperties.h:
(WebCore::StyleProperties::isEmpty):
(isType):
* css/StylePropertyShorthand.cpp:
* css/StylePropertyShorthand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::id):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::resolvedVariableValue):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
* css/StyleResolver.h:
(WebCore::StyleResolver::hasViewportDependentMediaQueries):
(WebCore::StyleResolver::state):
(WebCore::checkRegionSelector):
* css/StyleSheetList.h:
* css/WebKitCSSFilterValue.cpp:
* css/WebKitCSS

[webkit-changes] [201295] trunk/Source/WebKit2

2016-05-23 Thread achristensen

Title: [201295] trunk/Source/WebKit2








Revision 201295
Author achristen...@apple.com
Date 2016-05-23 13:54:01 -0700 (Mon, 23 May 2016)


Log Message
Add logging for NSURLSession calls
https://bugs.webkit.org/show_bug.cgi?id=157996

Reviewed by Brady Eidson.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(toNSURLSessionResponseDisposition):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
* Platform/Logging.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit2/Platform/Logging.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (201294 => 201295)

--- trunk/Source/WebKit2/ChangeLog	2016-05-23 20:44:06 UTC (rev 201294)
+++ trunk/Source/WebKit2/ChangeLog	2016-05-23 20:54:01 UTC (rev 201295)
@@ -1,3 +1,23 @@
+2016-05-23  Alex Christensen  
+
+Add logging for NSURLSession calls
+https://bugs.webkit.org/show_bug.cgi?id=157996
+
+Reviewed by Brady Eidson.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTask::NetworkDataTask):
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(toNSURLSessionResponseDisposition):
+(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
+(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
+* Platform/Logging.h:
+
 2016-05-23  Chris Fleizach  
 
 AX: iOS: when bringing focus to a text field we may zoom the page even if author wanted max scale = 1


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (201294 => 201295)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-05-23 20:44:06 UTC (rev 201294)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-05-23 20:54:01 UTC (rev 201295)
@@ -30,6 +30,7 @@
 
 #import "Download.h"
 #import "DownloadProxyMessages.h"
+#import "Logging.h"
 #import "NetworkProcess.h"
 #import "SessionTracker.h"
 #import "WebCoreArgumentCoders.h"
@@ -109,6 +110,7 @@
 ASSERT(!m_session->m_dataTaskMapWithoutCredentials.contains([m_task taskIdentifier]));
 m_session->m_dataTaskMapWithoutCredentials.add([m_task taskIdentifier], this);
 }
+LOG(NetworkSession, "%llu Creating NetworkDataTask with URL %s", [m_task taskIdentifier], nsRequest.URL.absoluteString.UTF8String);
 
 #if HAVE(CFNETWORK_STORAGE_PARTITIONING)
 String storagePartition = WebCore::cookieStoragePartition(request);


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm (201294 => 201295)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2016-05-23 20:44:06 UTC (rev 201294)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2016-05-23 20:54:01 UTC (rev 201295)
@@ -31,6 +31,7 @@
 #import "CustomProtocolManager.h"
 #import "DataReference.h"
 #import "Download.h"
+#import "Logging.h"
 #import "NetworkCache.h"
 #import "NetworkLoad.h"
 #import "NetworkProcess.h"
@@ -51,6 +52,8 @@
 #import 
 #import 
 
+using namespace WebKit;
+
 static NSURLSessionResponseDisposition toNSURLSessionResponseDisposition(WebCore::PolicyAction disposition)
 {
 switch (disposition) {
@@ -114,28 +117,40 @@
 
 - (void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task willPerformHTTPRedirection:(NSHTTPURLResponse *)response newRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURLRequest *))completionHandler
 {
+auto taskIdentifier = task.taskIdentifier;
+LOG(NetworkSession, "%llu willPerformHTTPRedirection from %s to %s", taskIdentifier, response.URL.absoluteString.UTF8String, request.URL.absoluteString.UTF8String);
+
 auto storedCredentials = _withCredentials ? WebCore::StoredCredentials::AllowStoredCredentials : WebCore::StoredCredentials

[webkit-changes] [201318] trunk/Source/WebCore

2016-05-23 Thread achristensen

Title: [201318] trunk/Source/WebCore








Revision 201318
Author achristen...@apple.com
Date 2016-05-23 22:34:49 -0700 (Mon, 23 May 2016)


Log Message
Modernize CSS code
https://bugs.webkit.org/show_bug.cgi?id=157875

Reviewed by Chris Dumez.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::setJSTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
* css/CSSBasicShapes.cpp:
(WebCore::serializePositionOffset):
(WebCore::buildSerializablePositionOffset):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeEllipse::cssText):
* css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::media):
* css/CSSMediaRule.h:
* css/CSSOMUtils.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
* css/CSSReflectValue.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::setMediaQueries):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):
(WebCore::CSSStyleSheet::ownerDocument):
(WebCore::CSSStyleSheet::clearChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
* css/CSSStyleSheet.h:
* css/PropertySetCSSStyleDeclaration.cpp:
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::StyleRuleMedia::StyleRuleMedia):
* css/StyleRule.h:
(WebCore::StyleRuleBase::deref):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleMedia::mediaQueries):
(WebCore::StyleRuleMedia::copy):
(isType):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
* css/StyleRuleImport.h:
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
* css/StyleSheetContents.h:
(WebCore::StyleSheetContents::hasSyntacticallyValidCSSHeader):
(WebCore::StyleSheetContents::parserSetUsesRemUnits):
(WebCore::StyleSheetContents::parserSetUsesStyleBasedEditability):
(WebCore::StyleSheetContents::copy):
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):
* inspector/InspectorStyleSheet.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
trunk/Source/WebCore/css/CSSBasicShapes.cpp
trunk/Source/WebCore/css/CSSCalculationValue.cpp
trunk/Source/WebCore/css/CSSMediaRule.cpp
trunk/Source/WebCore/css/CSSMediaRule.h
trunk/Source/WebCore/css/CSSOMUtils.h
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSReflectValue.h
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/css/StyleRule.h
trunk/Source/WebCore/css/StyleRuleImport.cpp
trunk/Source/WebCore/css/StyleRuleImport.h
trunk/Source/WebCore/css/StyleSheetContents.cpp
trunk/Source/WebCore/css/StyleSheetContents.h
trunk/Source/WebCore/dom/InlineStyleSheetOwner.cpp
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201317 => 201318)

--- trunk/Source/WebCore/ChangeLog	2016-05-24 05:19:00 UTC (rev 201317)
+++ trunk/Source/WebCore/ChangeLog	2016-05-24 05:34:49 UTC (rev 201318)
@@ -1,3 +1,86 @@
+2016-05-23  Alex Christensen  
+
+Modernize CSS code
+https://bugs.webkit.org/show_bug.cgi?id=157875
+
+Reviewed by Chris Dumez.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+(GenerateParametersCheck):
+* bindings/scripts/test/JS/JSTe

[webkit-changes] [201336] trunk/Source/ThirdParty/ANGLE

2016-05-24 Thread achristensen

Title: [201336] trunk/Source/ThirdParty/ANGLE








Revision 201336
Author achristen...@apple.com
Date 2016-05-24 10:36:05 -0700 (Tue, 24 May 2016)


Log Message
Fix iOS WebGL after r199738
https://bugs.webkit.org/show_bug.cgi?id=158024
rdar://problem/26446679

Reviewed by Myles Maxfield.

* ANGLE.xcodeproj/project.pbxproj:
iOS needs the ESSL translator.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (201335 => 201336)

--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2016-05-24 17:08:45 UTC (rev 201335)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2016-05-24 17:36:05 UTC (rev 201336)
@@ -1388,6 +1388,7 @@
 GCC_PREPROCESSOR_DEFINITIONS = (
 	ANGLE_ENABLE_OPENGL,
 	ANGLE_ENABLE_GLSL,
+	ANGLE_ENABLE_ESSL,
 );
 			};
 			name = Production;
@@ -1414,6 +1415,7 @@
 GCC_PREPROCESSOR_DEFINITIONS = (
 	ANGLE_ENABLE_OPENGL,
 	ANGLE_ENABLE_GLSL,
+	ANGLE_ENABLE_ESSL,
 );
 			};
 			name = Debug;
@@ -1425,6 +1427,7 @@
 GCC_PREPROCESSOR_DEFINITIONS = (
 	ANGLE_ENABLE_OPENGL,
 	ANGLE_ENABLE_GLSL,
+	ANGLE_ENABLE_ESSL,
 );
 			};
 			name = Release;


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (201335 => 201336)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-05-24 17:08:45 UTC (rev 201335)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-05-24 17:36:05 UTC (rev 201336)
@@ -1,3 +1,14 @@
+2016-05-24  Alex Christensen  
+
+Fix iOS WebGL after r199738
+https://bugs.webkit.org/show_bug.cgi?id=158024
+rdar://problem/26446679
+
+Reviewed by Myles Maxfield.
+
+* ANGLE.xcodeproj/project.pbxproj:
+iOS needs the ESSL translator.
+
 2016-05-22  Brady Eidson  
 
 Move to C++14.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201338] trunk/LayoutTests

2016-05-24 Thread achristensen

Title: [201338] trunk/LayoutTests








Revision 201338
Author achristen...@apple.com
Date 2016-05-24 11:45:21 -0700 (Tue, 24 May 2016)


Log Message
Unskip passing test after r201336
https://bugs.webkit.org/show_bug.cgi?id=156812

* platform/ios-simulator/TestExpectations:
compositing/webgl/webgl-reflection.html passes now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (201337 => 201338)

--- trunk/LayoutTests/ChangeLog	2016-05-24 18:04:03 UTC (rev 201337)
+++ trunk/LayoutTests/ChangeLog	2016-05-24 18:45:21 UTC (rev 201338)
@@ -1,3 +1,11 @@
+2016-05-24  Alex Christensen  
+
+Unskip passing test after r201336
+https://bugs.webkit.org/show_bug.cgi?id=156812
+
+* platform/ios-simulator/TestExpectations:
+compositing/webgl/webgl-reflection.html passes now.
+
 2016-05-24  Filip Pizlo  
 
 LLInt64 should have typed array fast paths for get_by_val


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (201337 => 201338)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-05-24 18:04:03 UTC (rev 201337)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-05-24 18:45:21 UTC (rev 201338)
@@ -2981,8 +2981,6 @@
 fast/images/image-map-outline-with-paint-root-offset.html [ Pass ImageOnlyFailure ]
 fast/images/image-map-outline-with-scale-transform.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/156812 compositing/webgl/webgl-reflection.html [ Failure ]
-
 # iOS does not allow you to scroll by dragging the scrollbar thumb.
 webkit.org/b/157201 fast/scrolling/rtl-drag-vertical-scroller.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201345] trunk/Source/WebCore

2016-05-24 Thread achristensen

Title: [201345] trunk/Source/WebCore








Revision 201345
Author achristen...@apple.com
Date 2016-05-24 13:01:50 -0700 (Tue, 24 May 2016)


Log Message
Fix use-after-free after r201318
https://bugs.webkit.org/show_bug.cgi?id=158037
rdar://problem/26446729

Reviewed by Brady Eidson.

This fixes a crash when running fast/dom/navigation-with-sideeffects.html with GuardMalloc.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjPutForwardsNullableAttribute):
Changing RefPtr<${type}> to auto caused the type to sometimes be a raw pointer, which does not keep the object alive.
In the case of JSDocument.cpp, forwardedImpl was what Document::location returned, which is a Location* and not a RefPtr.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201344 => 201345)

--- trunk/Source/WebCore/ChangeLog	2016-05-24 19:56:15 UTC (rev 201344)
+++ trunk/Source/WebCore/ChangeLog	2016-05-24 20:01:50 UTC (rev 201345)
@@ -1,3 +1,20 @@
+2016-05-24  Alex Christensen  
+
+Fix use-after-free after r201318
+https://bugs.webkit.org/show_bug.cgi?id=158037
+rdar://problem/26446729
+
+Reviewed by Brady Eidson.
+
+This fixes a crash when running fast/dom/navigation-with-sideeffects.html with GuardMalloc.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::setJSTestObjPutForwardsNullableAttribute):
+Changing RefPtr<${type}> to auto caused the type to sometimes be a raw pointer, which does not keep the object alive.
+In the case of JSDocument.cpp, forwardedImpl was what Document::location returned, which is a Location* and not a RefPtr.
+
 2016-05-24  Chris Dumez  
 
 Use lambda capture with initializer instead of StringCapture


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (201344 => 201345)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-05-24 19:56:15 UTC (rev 201344)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-05-24 20:01:50 UTC (rev 201345)
@@ -2919,7 +2919,7 @@
 if ($putForwards) {
 my $implGetterFunctionName = $codeGenerator->WK_lcfirst($attribute->signature->extendedAttributes->{"ImplementedAs"} || $name);
 if ($attribute->signature->isNullable) {
-push(@implContent, "auto forwardedImpl = castedThis->wrapped().${implGetterFunctionName}();\n");
+push(@implContent, "RefPtr<${type}> forwardedImpl = castedThis->wrapped().${implGetterFunctionName}();\n");
 push(@implContent, "if (!forwardedImpl)\n");
 push(@implContent, "return false;\n");
 push(@implContent, "auto& impl = *forwardedImpl;\n");


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (201344 => 201345)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2016-05-24 19:56:15 UTC (rev 201344)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2016-05-24 20:01:50 UTC (rev 201345)
@@ -3936,7 +3936,7 @@
 if (UNLIKELY(!castedThis)) {
 return throwSetterTypeError(*state, "TestObj", "putForwardsNullableAttribute");
 }
-auto forwardedImpl = castedThis->wrapped().putForwardsNullableAttribute();
+RefPtr forwardedImpl = castedThis->wrapped().putForwardsNullableAttribute();
 if (!forwardedImpl)
 return false;
 auto& impl = *forwardedImpl;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201392] trunk/Source/JavaScriptCore

2016-05-25 Thread achristensen

Title: [201392] trunk/Source/_javascript_Core








Revision 201392
Author achristen...@apple.com
Date 2016-05-25 11:59:40 -0700 (Wed, 25 May 2016)


Log Message
Fix Win64 build after r201335
https://bugs.webkit.org/show_bug.cgi?id=158078

Reviewed by Mark Lam.

* offlineasm/x86.rb:
Add intel implementations for loadbs and loadhs

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/offlineasm/x86.rb




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (201391 => 201392)

--- trunk/Source/_javascript_Core/ChangeLog	2016-05-25 18:31:39 UTC (rev 201391)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-25 18:59:40 UTC (rev 201392)
@@ -1,3 +1,13 @@
+2016-05-25  Alex Christensen  
+
+Fix Win64 build after r201335
+https://bugs.webkit.org/show_bug.cgi?id=158078
+
+Reviewed by Mark Lam.
+
+* offlineasm/x86.rb:
+Add intel implementations for loadbs and loadhs
+
 2016-05-25  Carlos Garcia Campos  
 
 REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066


Modified: trunk/Source/_javascript_Core/offlineasm/x86.rb (201391 => 201392)

--- trunk/Source/_javascript_Core/offlineasm/x86.rb	2016-05-25 18:31:39 UTC (rev 201391)
+++ trunk/Source/_javascript_Core/offlineasm/x86.rb	2016-05-25 18:59:40 UTC (rev 201392)
@@ -648,7 +648,7 @@
 $asm.puts "xchg#{x86Suffix(:ptr)} #{operand.x86Operand(:ptr)}, #{ax.x86Operand(:ptr)}"
 $asm.puts "#{setOpcode} #{ax.x86Operand(:byte)}"
 if !isIntelSyntax
-		$asm.puts "movzbl #{ax.x86Operand(:byte)}, #{ax.x86Operand(:int)}"
+$asm.puts "movzbl #{ax.x86Operand(:byte)}, #{ax.x86Operand(:int)}"
 else
 $asm.puts "movzx #{ax.x86Operand(:int)}, #{ax.x86Operand(:byte)}"
 end
@@ -954,7 +954,11 @@
 $asm.puts "movzx #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
 end
 when "loadbs"
-$asm.puts "movsbl #{operands[0].x86Operand(:byte)}, #{operands[1].x86Operand(:int)}"
+if !isIntelSyntax
+$asm.puts "movsbl #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
+else
+$asm.puts "movsx #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
+end
 when "loadh"
 if !isIntelSyntax
 $asm.puts "movzwl #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
@@ -962,7 +966,11 @@
 $asm.puts "movzx #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
 end
 when "loadhs"
-$asm.puts "movswl #{operands[0].x86Operand(:half)}, #{operands[1].x86Operand(:int)}"
+if !isIntelSyntax
+$asm.puts "movswl #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
+else
+$asm.puts "movsx #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
+end
 when "storeb"
 $asm.puts "mov#{x86Suffix(:byte)} #{x86Operands(:byte, :byte)}"
 when "loadd"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201398] trunk/Source

2016-05-25 Thread achristensen

Title: [201398] trunk/Source








Revision 201398
Author achristen...@apple.com
Date 2016-05-25 12:49:46 -0700 (Wed, 25 May 2016)


Log Message
Fix CMake build.

* PlatformMac.cmake:
Source/WebCore:

c++14 is needed since r201255.
ColorSync (in ApplicationServices) is needed since r201065.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformMac.cmake
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (201397 => 201398)

--- trunk/Source/WebCore/ChangeLog	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebCore/ChangeLog	2016-05-25 19:49:46 UTC (rev 201398)
@@ -1,3 +1,11 @@
+2016-05-25  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+c++14 is needed since r201255.
+ColorSync (in ApplicationServices) is needed since r201065.
+
 2016-05-25  Zalan Bujtas  
 
 Swap search field's cancel and result button for RTL content.


Modified: trunk/Source/WebCore/PlatformMac.cmake (201397 => 201398)

--- trunk/Source/WebCore/PlatformMac.cmake	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebCore/PlatformMac.cmake	2016-05-25 19:49:46 UTC (rev 201398)
@@ -10,6 +10,7 @@
 link_directories(../../WebKitLibraries)
 
 find_library(ACCELERATE_LIBRARY accelerate)
+find_library(APPLICATIONSERVICES_LIBRARY ApplicationServices)
 find_library(AVFOUNDATION_LIBRARY AVFoundation)
 find_library(AUDIOTOOLBOX_LIBRARY AudioToolbox)
 find_library(AUDIOUNIT_LIBRARY AudioUnit)
@@ -52,6 +53,7 @@
 
 add_definitions(-iframework ${QUARTZ_LIBRARY}/Frameworks)
 add_definitions(-iframework ${AVFOUNDATION_LIBRARY}/Versions/Current/Frameworks)
+add_definitions(-iframework ${APPLICATIONSERVICES_LIBRARY}/Versions/Current/Frameworks)
 
 find_library(DATADETECTORSCORE_FRAMEWORK DataDetectorsCore HINTS /System/Library/PrivateFrameworks)
 if (NOT DATADETECTORSCORE_FRAMEWORK-NOTFOUND)


Modified: trunk/Source/WebKit/ChangeLog (201397 => 201398)

--- trunk/Source/WebKit/ChangeLog	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebKit/ChangeLog	2016-05-25 19:49:46 UTC (rev 201398)
@@ -1,3 +1,9 @@
+2016-05-25  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+
 2016-05-18  Brady Eidson  
 
 Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).


Modified: trunk/Source/WebKit/PlatformMac.cmake (201397 => 201398)

--- trunk/Source/WebKit/PlatformMac.cmake	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebKit/PlatformMac.cmake	2016-05-25 19:49:46 UTC (rev 201398)
@@ -1,5 +1,7 @@
+find_library(APPLICATIONSERVICES_LIBRARY ApplicationServices)
 find_library(QUARTZ_LIBRARY Quartz)
 add_definitions(-iframework ${QUARTZ_LIBRARY}/Frameworks)
+add_definitions(-iframework ${APPLICATIONSERVICES_LIBRARY}/Versions/Current/Frameworks)
 link_directories(../../WebKitLibraries)
 
 list(APPEND WebKit_INCLUDE_DIRECTORIES
@@ -313,7 +315,7 @@
 foreach (_file ${WebKit_SOURCES})
 list(FIND C99_FILES ${_file} _c99_index)
 if (${_c99_index} EQUAL -1)
-set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-ObjC++ -std=c++11")
+set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-ObjC++ -std=c++14")
 else ()
 set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS -std=c99)
 endif ()


Modified: trunk/Source/WebKit2/ChangeLog (201397 => 201398)

--- trunk/Source/WebKit2/ChangeLog	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebKit2/ChangeLog	2016-05-25 19:49:46 UTC (rev 201398)
@@ -1,3 +1,9 @@
+2016-05-25  Alex Christensen  
+
+Fix CMake build.
+
+* PlatformMac.cmake:
+
 2016-05-25  Chris Dumez  
 
 Simplify a few lambda captures in the network cache code


Modified: trunk/Source/WebKit2/PlatformMac.cmake (201397 => 201398)

--- trunk/Source/WebKit2/PlatformMac.cmake	2016-05-25 19:41:34 UTC (rev 201397)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2016-05-25 19:49:46 UTC (rev 201398)
@@ -1,17 +1,18 @@
-add_definitions("-ObjC++ -std=c++11")
+add_definitions("-ObjC++ -std=c++14")
 link_directories(../../WebKitLibraries)
-find_library(APPLICATION_SERVICES_LIBRARY ApplicationServices)
+find_library(APPLICATIONSERVICES_LIBRARY ApplicationServices)
 find_library(CARBON_LIBRARY Carbon)
 find_library(QUARTZ_LIBRARY Quartz)
 find_library(AVFOUNDATION_LIBRARY AVFoundation)
 find_library(AVFAUDIO_LIBRARY AVFAudio HINTS ${AVFOUNDATION_LIBRARY}/Versions/*/Frameworks)
 add_definitions(-iframework ${QUARTZ_LIBRARY}/Frameworks)
 add_definitions(-iframework ${CARBON_LIBRARY}/Frameworks)
+add_definitions(-iframework ${APPLICATIONSERVICES_LIBRARY}/Versions/Current/Frameworks)
 add_definitions(-DWK_XPC_SERVICE_SUFFIX=".Development")
 
 list(APPEND WebKit2_LIBRARIES
 PRIVATE WebKit
-${APPLICATION_SERVICES_LIBRARY}
+${APPLICATIONSERVICES_LIBRARY}
 )
 
 if (NOT AVFAUDIO_LIB

[webkit-changes] [201457] trunk

2016-05-27 Thread achristensen

Title: [201457] trunk








Revision 201457
Author achristen...@apple.com
Date 2016-05-27 11:50:24 -0700 (Fri, 27 May 2016)


Log Message
Expose content extension failure error codes in SPI
https://bugs.webkit.org/show_bug.cgi?id=158095
rdar://problem/26475651

Reviewed by Anders Carlsson.

Source/WebKit2:

* UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::synchronousRemoveAllContentExtensions):
(API::UserContentExtensionStore::invalidateContentExtensionVersion):
Added for testing.
(API::userContentExtensionStoreErrorCategory):
* UIProcess/API/APIUserContentExtensionStore.h:
* UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
Added the new enum, _WKUserContentExtensionStoreErrorCode.
* UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
Sometimes the error code returned by UserContentExtensionStore::compileContentExtension has the error code from compileRuleList.
When this happens, we want to get the message from the internal compiler error, but we want the NSError's code to always be CompileFailed.
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]):
* UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
Added new invalidator for testing.

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
(checkDomain):
(TEST_F):
Add tests that use the new enum.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp
trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (201456 => 201457)

--- trunk/Source/WebKit2/ChangeLog	2016-05-27 18:36:30 UTC (rev 201456)
+++ trunk/Source/WebKit2/ChangeLog	2016-05-27 18:50:24 UTC (rev 201457)
@@ -1,3 +1,30 @@
+2016-05-27  Alex Christensen  
+
+Expose content extension failure error codes in SPI
+https://bugs.webkit.org/show_bug.cgi?id=158095
+rdar://problem/26475651
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/APIUserContentExtensionStore.cpp:
+(API::UserContentExtensionStore::synchronousRemoveAllContentExtensions):
+(API::UserContentExtensionStore::invalidateContentExtensionVersion):
+Added for testing.
+(API::userContentExtensionStoreErrorCategory):
+* UIProcess/API/APIUserContentExtensionStore.h:
+* UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
+Added the new enum, _WKUserContentExtensionStoreErrorCode.
+* UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
+(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
+Sometimes the error code returned by UserContentExtensionStore::compileContentExtension has the error code from compileRuleList.
+When this happens, we want to get the message from the internal compiler error, but we want the NSError's code to always be CompileFailed.
+(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
+(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
+(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
+(-[_WKUserContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]):
+* UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
+Added new invalidator for testing.
+
 2016-05-27  Zalan Bujtas  
 
 Regression(r200972): Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text.


Modified: trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp (201456 => 201457)

--- trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp	2016-05-27 18:36:30 UTC (rev 201456)
+++ trunk/Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp	2016-05-27 18:50:24 UTC (rev 201457)
@@ -391,6 +391,17 @@
 WebCore::deleteFile(path);
 }
 
+void UserContentExtensionStore::invalidateContentExtensionVersion(const WTF::String& identifier)
+{
+auto file = WebCore::openFile(constructedPath(m_storePath, identifier), WebCore::OpenForWrite);
+if (file == WebCore::invalidPlatformFileHandle)
+return;
+ContentExtensionMetaData invalidHeader = {0, 0, 0, 0, 0};

[webkit-changes] [201515] trunk/Source/WebCore

2016-05-31 Thread achristensen

Title: [201515] trunk/Source/WebCore








Revision 201515
Author achristen...@apple.com
Date 2016-05-31 10:53:20 -0700 (Tue, 31 May 2016)


Log Message
Build fix after r201482.

* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
header used to be capturedHeader, which was a StringCapture, which needed .string() to get the String.
Now it's a WTF::String, so we already have the String.  Hooray for c++14!

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201514 => 201515)

--- trunk/Source/WebCore/ChangeLog	2016-05-31 15:58:14 UTC (rev 201514)
+++ trunk/Source/WebCore/ChangeLog	2016-05-31 17:53:20 UTC (rev 201515)
@@ -1,3 +1,12 @@
+2016-05-31  Alex Christensen  
+
+Build fix after r201482.
+
+* platform/network/curl/CurlDownload.cpp:
+(WebCore::CurlDownload::didReceiveHeader):
+header used to be capturedHeader, which was a StringCapture, which needed .string() to get the String.
+Now it's a WTF::String, so we already have the String.  Hooray for c++14!
+
 2016-05-31  Sergio Villar Senin  
 
 Unreviewed build fix.


Modified: trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp (201514 => 201515)

--- trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp	2016-05-31 15:58:14 UTC (rev 201514)
+++ trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp	2016-05-31 17:53:20 UTC (rev 201515)
@@ -413,9 +413,9 @@
 }
 } else {
 callOnMainThread([this, header = header.isolatedCopy(), protectedThis = Ref(*this)] {
-int splitPos = header.string().find(":");
+int splitPos = header.find(":");
 if (splitPos != -1)
-m_response.setHTTPHeaderField(header.string().left(splitPos), header.string().substring(splitPos + 1).stripWhiteSpace());
+m_response.setHTTPHeaderField(header.left(splitPos), header.substring(splitPos + 1).stripWhiteSpace());
 });
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201721] trunk/Source/WebCore

2016-06-06 Thread achristensen

Title: [201721] trunk/Source/WebCore








Revision 201721
Author achristen...@apple.com
Date 2016-06-06 12:23:29 -0700 (Mon, 06 Jun 2016)


Log Message
Remove unused ResourceResponse::platformResponseIsUpToDate
https://bugs.webkit.org/show_bug.cgi?id=158424

Reviewed by Brady Eidson.

No change in behavior, just removing unused code that was introduced in r145007.

* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
* platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
* platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
(WebCore::ResourceResponse::decode):
(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceResponse.h
trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm
trunk/Source/WebCore/platform/network/curl/ResourceResponse.h
trunk/Source/WebCore/platform/network/soup/ResourceResponse.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (201720 => 201721)

--- trunk/Source/WebCore/ChangeLog	2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/ChangeLog	2016-06-06 19:23:29 UTC (rev 201721)
@@ -1,3 +1,26 @@
+2016-06-06  Alex Christensen  
+
+Remove unused ResourceResponse::platformResponseIsUpToDate
+https://bugs.webkit.org/show_bug.cgi?id=158424
+
+Reviewed by Brady Eidson.
+
+No change in behavior, just removing unused code that was introduced in r145007.
+
+* platform/network/cf/ResourceResponse.h:
+(WebCore::ResourceResponse::ResourceResponse):
+(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+* platform/network/cocoa/ResourceResponseCocoa.mm:
+(WebCore::ResourceResponse::ResourceResponse):
+* platform/network/curl/ResourceResponse.h:
+(WebCore::ResourceResponse::cfURLResponse):
+(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+* platform/network/soup/ResourceResponse.h:
+(WebCore::ResourceResponse::soupMessageTLSErrors):
+(WebCore::ResourceResponse::setSoupMessageTLSErrors):
+(WebCore::ResourceResponse::decode):
+(WebCore::ResourceResponse::platformResponseIsUpToDate): Deleted.
+
 2016-06-05  Gavin & Ellie Barraclough  
 
 Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead.


Modified: trunk/Source/WebCore/platform/network/cf/ResourceResponse.h (201720 => 201721)

--- trunk/Source/WebCore/platform/network/cf/ResourceResponse.h	2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/cf/ResourceResponse.h	2016-06-06 19:23:29 UTC (rev 201721)
@@ -40,14 +40,12 @@
 public:
 ResourceResponse()
 : m_initLevel(AllFields)
-, m_platformResponseIsUpToDate(true)
 {
 }
 
 #if USE(CFNETWORK)
 ResourceResponse(CFURLResponseRef cfResponse)
 : m_initLevel(Uninitialized)
-, m_platformResponseIsUpToDate(true)
 , m_cfResponse(cfResponse)
 {
 m_isNull = !cfResponse;
@@ -58,7 +56,6 @@
 #else
 ResourceResponse(NSURLResponse *nsResponse)
 : m_initLevel(Uninitialized)
-, m_platformResponseIsUpToDate(true)
 , m_nsResponse(nsResponse)
 {
 m_isNull = !nsResponse;
@@ -68,7 +65,6 @@
 ResourceResponse(const URL& url, const String& mimeType, long long expectedLength, const String& textEncodingName)
 : ResourceResponseBase(url, mimeType, expectedLength, textEncodingName)
 , m_initLevel(AllFields)
-, m_platformResponseIsUpToDate(false)
 {
 }
 
@@ -91,8 +87,6 @@
 WEBCORE_EXPORT NSURLResponse *nsURLResponse() const;
 #endif
 
-bool platformResponseIsUpToDate() const { return m_platformResponseIsUpToDate; }
-
 private:
 friend class ResourceResponseBase;
 
@@ -109,7 +103,6 @@
 static bool platformCompare(const ResourceResponse& a, const ResourceResponse& b);
 
 unsigned m_initLevel : 3;
-bool m_platformResponseIsUpToDate : 1;
 
 #if USE(CFNETWORK)
 mutable RetainPtr m_cfResponse;


Modified: trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm (201720 => 201721)

--- trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm	2016-06-06 19:16:20 UTC (rev 201720)
+++ trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm	2016-06-06 19:23:29 UTC (rev 201721)
@@ -127,7 +127,6 @@
 
 ResourceResponse::ResourceResponse(NSURLResponse* nsResponse)
 : m_initLevel(Uninitialized)
-, m_platformResponseIsUpToDate(true)
 , m_cfResponse([nsResponse _CFURLResponse])
 , m_

[webkit-changes] [201758] trunk/Source/WebKit/mac

2016-06-07 Thread achristensen

Title: [201758] trunk/Source/WebKit/mac








Revision 201758
Author achristen...@apple.com
Date 2016-06-07 11:13:26 -0700 (Tue, 07 Jun 2016)


Log Message
Adopt [PDFView documentScrollView]
https://bugs.webkit.org/show_bug.cgi?id=158454
rdar://problem/25875390

Reviewed by Tim Horton.

* WebView/PDFViewSPI.h: Added.
* WebView/WebPDFView.mm:
(-[WebPDFView _clipViewForPDFDocumentView]):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPDFView.mm


Added Paths

trunk/Source/WebKit/mac/WebView/PDFViewSPI.h




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (201757 => 201758)

--- trunk/Source/WebKit/mac/ChangeLog	2016-06-07 17:53:15 UTC (rev 201757)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-06-07 18:13:26 UTC (rev 201758)
@@ -1,3 +1,15 @@
+2016-06-07  Alex Christensen  
+
+Adopt [PDFView documentScrollView]
+https://bugs.webkit.org/show_bug.cgi?id=158454
+rdar://problem/25875390
+
+Reviewed by Tim Horton.
+
+* WebView/PDFViewSPI.h: Added.
+* WebView/WebPDFView.mm:
+(-[WebPDFView _clipViewForPDFDocumentView]):
+
 2016-06-05  Anders Carlsson  
 
 Attempt to fix plug-in hangs by adding back empty slots for the removed messages.


Added: trunk/Source/WebKit/mac/WebView/PDFViewSPI.h (0 => 201758)

--- trunk/Source/WebKit/mac/WebView/PDFViewSPI.h	(rev 0)
+++ trunk/Source/WebKit/mac/WebView/PDFViewSPI.h	2016-06-07 18:13:26 UTC (rev 201758)
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2016 Apple Inc.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#if USE(APPLE_INTERNAL_SDK)
+
+#import 
+
+#else
+
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+
+@interface PDFView ()
+- (PDFKitPlatformScrollView *)documentScrollView;
+@end
+
+#endif
+
+#endif


Modified: trunk/Source/WebKit/mac/WebView/WebPDFView.mm (201757 => 201758)

--- trunk/Source/WebKit/mac/WebView/WebPDFView.mm	2016-06-07 17:53:15 UTC (rev 201757)
+++ trunk/Source/WebKit/mac/WebView/WebPDFView.mm	2016-06-07 18:13:26 UTC (rev 201758)
@@ -32,6 +32,7 @@
 
 #import "DOMNodeInternal.h"
 #import "DOMRangeInternal.h"
+#import "PDFViewSPI.h"
 #import "WebDataSourceInternal.h"
 #import "WebDelegateImplementationCaching.h"
 #import "WebDocumentInternal.h"
@@ -1134,7 +1135,11 @@
 
 - (NSClipView *)_clipViewForPDFDocumentView
 {
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+NSClipView *clipView = (NSClipView *)[[PDFSubview documentScrollView] contentView];
+#else
 NSClipView *clipView = (NSClipView *)[[PDFSubview documentView] _web_superviewOfClass:[NSClipView class]];
+#endif
 ASSERT(clipView);
 return clipView;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201761] trunk/Source

2016-06-07 Thread achristensen

Title: [201761] trunk/Source








Revision 201761
Author achristen...@apple.com
Date 2016-06-07 11:52:06 -0700 (Tue, 07 Jun 2016)


Log Message
Modernize loading code
https://bugs.webkit.org/show_bug.cgi?id=158332

Reviewed by Darin Adler.

Source/WebCore:

No new tests, no change in behavior.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
* loader/FrameLoader.h:
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveData):
(WebCore::NetscapePlugInStreamLoader::didReceiveBuffer):
(WebCore::NetscapePlugInStreamLoader::didReceiveDataOrBuffer):
(WebCore::NetscapePlugInStreamLoader::didFinishLoading):
* loader/NetscapePlugInStreamLoader.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::deliverResponseAndData):
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::addDataOrBuffer):
(WebCore::ResourceLoader::clearResourceData):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didReceiveBuffer):
(WebCore::ResourceLoader::didReceiveDataOrBuffer):
(WebCore::ResourceLoader::didFinishLoading):
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::wasCancelled):
(WebCore::ResourceLoader::options):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::didReceiveBuffer):
(WebCore::SubresourceLoader::didReceiveDataOrBuffer):
* loader/SubresourceLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::createResourceHandle):
* loader/appcache/ApplicationCacheGroup.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addData):
* loader/cache/CachedRawResourceClient.h:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::createWithContentsOfFile):
(WebCore::SharedBuffer::adoptVector):
(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):
(WebCore::SharedBuffer::appendToDataBuffer):
(WebCore::SharedBuffer::clearDataBuffer):
* platform/SharedBuffer.h:
(WebCore::SharedBuffer::create):
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::maybeAppendPlatformData):
(WebCore::SharedBuffer::wrapCFDataArray):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(ResourceHandleStreamingClient::didReceiveData):
(ResourceHandleStreamingClient::didReceiveBuffer):
* platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
(WebCore::SharedBuffer::createFromReadingFile):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::~BlobRegistryImpl):
(WebCore::createBlobResourceHandle):
(WebCore::loadBlobResourceSynchronously):
(WebCore::registerBlobResourceHandleConstructor):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::createResourceHandle): Deleted.
(WebCore::loadResourceSynchronously): Deleted.
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):
Removed the overridden didReceiveData and didFinishLoading, 
which did nothing and were identical to the function they overwrote.
* platform/network/BlobResourceHandle.h:
* platform/network/PingHandle.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::scheduleFailure):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::willCacheResponseAsync):
(WebCore::ResourceHandleClient::didReceiveBuffer):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveResponse):
(WebCore::ResourceHandleClient::didReceiveData):
(WebCore::ResourceHandleClient::didFinishLoading):
(WebCore::ResourceHandleClient::didFail):
* platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
This data must be copied in order to put it in a refcounted NSData because it comes
from IPC from the Network Process and is an IPC::DataReference which will be deallocated
when the message handling is done.
* platform/soup/SharedBufferSoup.cpp:
(WebCore::SharedBuffer::SharedBuffer):
* testing/MockContentFilter.cpp:
(WebCore::MockContentFilter::replacementData):
(WebCore::MockContentFilter::unblockHandler):

Source/WebKit2:

* NetworkProcess/Downloads/PendingDownload.h:
* NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::client):
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::didReceiveData):
(WebKit::NetworkLoad::didReceiveBuffer):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkLoadClient.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(We

[webkit-changes] [201767] trunk/Source/WebCore

2016-06-07 Thread achristensen

Title: [201767] trunk/Source/WebCore








Revision 201767
Author achristen...@apple.com
Date 2016-06-07 13:05:36 -0700 (Tue, 07 Jun 2016)


Log Message
Build fix non-cocoa platforms.
https://bugs.webkit.org/show_bug.cgi?id=158332

* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::createCustomFontData):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueWillSendRequest):
* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedFont.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.cpp
trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp
trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201766 => 201767)

--- trunk/Source/WebCore/ChangeLog	2016-06-07 19:51:41 UTC (rev 201766)
+++ trunk/Source/WebCore/ChangeLog	2016-06-07 20:05:36 UTC (rev 201767)
@@ -1,3 +1,17 @@
+2016-06-07  Alex Christensen  
+
+Build fix non-cocoa platforms.
+https://bugs.webkit.org/show_bug.cgi?id=158332
+
+* loader/cache/CachedFont.cpp:
+(WebCore::CachedFont::createCustomFontData):
+* platform/network/ResourceHandle.cpp:
+(WebCore::ResourceHandle::continueWillSendRequest):
+* platform/network/curl/MultipartHandle.cpp:
+(WebCore::MultipartHandle::didReceiveResponse):
+* platform/network/curl/ResourceHandleManager.cpp:
+(WebCore::headerCallback):
+
 2016-06-07  Sam Weinig  
 
 Try to fix the 10.10 build.


Modified: trunk/Source/WebCore/loader/cache/CachedFont.cpp (201766 => 201767)

--- trunk/Source/WebCore/loader/cache/CachedFont.cpp	2016-06-07 19:51:41 UTC (rev 201766)
+++ trunk/Source/WebCore/loader/cache/CachedFont.cpp	2016-06-07 20:05:36 UTC (rev 201767)
@@ -113,7 +113,7 @@
 return nullptr;
 
 auto buffer = SharedBuffer::adoptVector(convertedFont);
-return createFontCustomPlatformData(*buffer);
+return createFontCustomPlatformData(buffer);
 }
 #endif
 


Modified: trunk/Source/WebCore/platform/network/ResourceHandle.cpp (201766 => 201767)

--- trunk/Source/WebCore/platform/network/ResourceHandle.cpp	2016-06-07 19:51:41 UTC (rev 201766)
+++ trunk/Source/WebCore/platform/network/ResourceHandle.cpp	2016-06-07 20:05:36 UTC (rev 201767)
@@ -155,7 +155,7 @@
 
 #if !PLATFORM(COCOA) && !USE(CFNETWORK) && !USE(SOUP)
 // ResourceHandle never uses async client calls on these platforms yet.
-void ResourceHandle::continueWillSendRequest(const ResourceRequest&)
+void ResourceHandle::continueWillSendRequest(ResourceRequest&&)
 {
 notImplemented();
 }


Modified: trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp (201766 => 201767)

--- trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-07 19:51:41 UTC (rev 201766)
+++ trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-07 20:05:36 UTC (rev 201767)
@@ -337,19 +337,19 @@
 {
 ResourceHandleInternal* d = m_resourceHandle->getInternal();
 if (d->client()) {
-std::unique_ptr response = ResourceResponseBase::adopt(d->m_response.copyData());
+auto response = d->m_response;
 
 HTTPHeaderMap::const_iterator end = m_headers.end();
 for (HTTPHeaderMap::const_iterator it = m_headers.begin(); it != end; ++it)
-response->setHTTPHeaderField(it->key, it->value);
+response.setHTTPHeaderField(it->key, it->value);
 
 String contentType = m_headers.get(HTTPHeaderName::ContentType);
 String mimeType = extractMIMETypeFromMediaType(contentType);
 
-response->setMimeType(mimeType.convertToASCIILowercase());
-response->setTextEncodingName(extractCharsetFromMediaType(contentType));
+response.setMimeType(mimeType.convertToASCIILowercase());
+response.setTextEncodingName(extractCharsetFromMediaType(contentType));
 
-d->client()->didReceiveResponse(m_resourceHandle, *response);
+d->client()->didReceiveResponse(m_resourceHandle, response);
 response->setResponseFired(true);
 }
 }


Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (201766 => 201767)

--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2016-06-07 19:51:41 UTC (rev 201766)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp	2016-06-07 20:05:36 UTC (rev 201767)
@@ -522,8 +522,9 @@
 
 ResourceRequest redirectedRequest = job->firstRequest();
 redirectedRequest.setURL(newURL);
+ResourceResponse response = d->m_response;
 if (client)
-client->willSendRequest(job, redirectedRequest, d->m_response);
+client->willSendRequest(job, WTFMove(redirectedRequest), WTFMove(respo

[webkit-changes] [201769] trunk/Source/WebCore

2016-06-07 Thread achristensen

Title: [201769] trunk/Source/WebCore








Revision 201769
Author achristen...@apple.com
Date 2016-06-07 13:24:40 -0700 (Tue, 07 Jun 2016)


Log Message
Fix WinCairo build.

* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201768 => 201769)

--- trunk/Source/WebCore/ChangeLog	2016-06-07 20:07:56 UTC (rev 201768)
+++ trunk/Source/WebCore/ChangeLog	2016-06-07 20:24:40 UTC (rev 201769)
@@ -1,5 +1,12 @@
 2016-06-07  Alex Christensen  
 
+Fix WinCairo build.
+
+* platform/network/curl/MultipartHandle.cpp:
+(WebCore::MultipartHandle::didReceiveResponse):
+
+2016-06-07  Alex Christensen  
+
 Build fix non-cocoa platforms.
 https://bugs.webkit.org/show_bug.cgi?id=158332
 


Modified: trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp (201768 => 201769)

--- trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-07 20:07:56 UTC (rev 201768)
+++ trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-07 20:24:40 UTC (rev 201769)
@@ -350,7 +350,7 @@
 response.setTextEncodingName(extractCharsetFromMediaType(contentType));
 
 d->client()->didReceiveResponse(m_resourceHandle, response);
-response->setResponseFired(true);
+m_response->setResponseFired(true);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201771] trunk/Source/WebCore

2016-06-07 Thread achristensen

Title: [201771] trunk/Source/WebCore








Revision 201771
Author achristen...@apple.com
Date 2016-06-07 13:46:38 -0700 (Tue, 07 Jun 2016)


Log Message
Fix Yosemite build.
https://bugs.webkit.org/show_bug.cgi?id=158403

* platform/spi/cocoa/QuartzCoreSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (201770 => 201771)

--- trunk/Source/WebCore/ChangeLog	2016-06-07 20:32:50 UTC (rev 201770)
+++ trunk/Source/WebCore/ChangeLog	2016-06-07 20:46:38 UTC (rev 201771)
@@ -1,5 +1,12 @@
 2016-06-07  Alex Christensen  
 
+Fix Yosemite build.
+https://bugs.webkit.org/show_bug.cgi?id=158403
+
+* platform/spi/cocoa/QuartzCoreSPI.h:
+
+2016-06-07  Alex Christensen  
+
 Fix WinCairo build.
 
 * platform/network/curl/MultipartHandle.cpp:


Modified: trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h (201770 => 201771)

--- trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h	2016-06-07 20:32:50 UTC (rev 201770)
+++ trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h	2016-06-07 20:46:38 UTC (rev 201771)
@@ -147,6 +147,7 @@
 @property CGFloat stiffness;
 @property CGFloat damping;
 @property CGFloat velocity;
+@property CGFloat initialVelocity;
 @end
 #else
 @interface CASpringAnimation (Private)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201837] trunk/Source/WebCore

2016-06-08 Thread achristensen

Title: [201837] trunk/Source/WebCore








Revision 201837
Author achristen...@apple.com
Date 2016-06-08 15:27:46 -0700 (Wed, 08 Jun 2016)


Log Message
Modernize WebSocket code
https://bugs.webkit.org/show_bug.cgi?id=158539

Reviewed by Brady Eidson.

No new tests, no change in behavior.

* Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
* Modules/websockets/ThreadableWebSocketChannel.h:
(WebCore::ThreadableWebSocketChannel::ThreadableWebSocketChannel):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
* Modules/websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::subprotocol):
(WebCore::WorkerThreadableWebSocketChannel::extensions):
(WebCore::WorkerThreadableWebSocketChannel::resume):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::~Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setMethodNotCompleted):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.h
trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp
trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.h
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp
trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp
trunk/Source/WebCore/Modules/websockets/WebSocketChannel.h
trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp
trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (201836 => 201837)

--- trunk/Source/WebCore/ChangeLog	2016-06-08 22:22:49 UTC (rev 201836)
+++ trunk/Source/WebCore/ChangeLog	2016-06-08 22:27:46 UTC (rev 201837)
@@ -1,3 +1,56 @@
+2016-06-08  Alex Christensen  
+
+Modernize WebSocket code
+https://bugs.webkit.org/show_bug.cgi?id=158539
+
+Reviewed by Brady Eidson.
+
+No new tests, no change in behavior.
+
+* Modules/websockets/ThreadableWebSocketChannel.cpp:
+(WebCore::ThreadableWebSocketChannel::create):
+* Modules/websockets/ThreadableWebSocketChannel.h:
+(WebCore::ThreadableWebSocketChannel::ThreadableWebSocketChannel):
+* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
+(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
+(WebCore::ThreadableWebSocketChannelClientWrapper::create):
+(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
+* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
+* Modules/websockets/WebSocket.cpp:
+(WebCore::WebSocket::connect):
+* Modules/websockets/WebSocketChannel.cpp:
+(WebCore::WebSocketChannel::WebSocketChannel):
+* Modules/websockets/WebSocketChannel.h:
+(WebCore::WebSocketChannel::create):
+*

[webkit-changes] [201844] trunk

2016-06-08 Thread achristensen

Title: [201844] trunk








Revision 201844
Author achristen...@apple.com
Date 2016-06-08 16:19:34 -0700 (Wed, 08 Jun 2016)


Log Message

Source/WebCore:
Fix WinCairo build.

* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):

Tools:
Fix WinCairo build

* DumpRenderTree/cairo/PixelDumpSupportCairo.h:
(BitmapContext::createByAdoptingBitmapAndContext):
(BitmapContext::~BitmapContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (201843 => 201844)

--- trunk/Source/WebCore/ChangeLog	2016-06-08 23:17:11 UTC (rev 201843)
+++ trunk/Source/WebCore/ChangeLog	2016-06-08 23:19:34 UTC (rev 201844)
@@ -1,3 +1,10 @@
+2016-06-08  Alex Christensen  
+
+Fix WinCairo build.
+
+* platform/network/curl/MultipartHandle.cpp:
+(WebCore::MultipartHandle::didReceiveResponse):
+
 2016-06-08  Jer Noble  
 
 With audio user gesture restriction in place, video.src = '', video.play() succeeds where it should fail.


Modified: trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp (201843 => 201844)

--- trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-08 23:17:11 UTC (rev 201843)
+++ trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-08 23:19:34 UTC (rev 201844)
@@ -350,7 +350,7 @@
 response.setTextEncodingName(extractCharsetFromMediaType(contentType));
 
 d->client()->didReceiveResponse(m_resourceHandle, response);
-m_response->setResponseFired(true);
+response->setResponseFired(true);
 }
 }
 


Modified: trunk/Tools/ChangeLog (201843 => 201844)

--- trunk/Tools/ChangeLog	2016-06-08 23:17:11 UTC (rev 201843)
+++ trunk/Tools/ChangeLog	2016-06-08 23:19:34 UTC (rev 201844)
@@ -1,3 +1,11 @@
+2016-06-08  Alex Christensen  
+
+Fix WinCairo build
+
+* DumpRenderTree/cairo/PixelDumpSupportCairo.h:
+(BitmapContext::createByAdoptingBitmapAndContext):
+(BitmapContext::~BitmapContext):
+
 2016-06-08  Benjamin Poulain  
 
 [JSC] Change some parameters based on a random search


Modified: trunk/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.h (201843 => 201844)

--- trunk/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.h	2016-06-08 23:17:11 UTC (rev 201843)
+++ trunk/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.h	2016-06-08 23:19:34 UTC (rev 201844)
@@ -27,10 +27,8 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef PixelDumpSupportCairo_h
-#define PixelDumpSupportCairo_h
+#pragma once
 
-#include 
 #include 
 
 #if PLATFORM(WIN)
@@ -48,9 +46,9 @@
 
 class BitmapContext : public RefCounted {
 public:
-static PassRefPtr createByAdoptingBitmapAndContext(PlatformBitmapBuffer buffer, cairo_t* context)
+static Ref createByAdoptingBitmapAndContext(PlatformBitmapBuffer buffer, cairo_t* context)
 {
-return adoptRef(new BitmapContext(buffer, context));
+return adoptRef(*new BitmapContext(buffer, context));
 }
 
 ~BitmapContext()
@@ -77,5 +75,3 @@
 PlatformBitmapBuffer m_buffer;
 cairo_t* m_context;
 };
-
-#endif // PixelDumpSupportCairo_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [201846] trunk/Source/WebCore

2016-06-08 Thread achristensen

Title: [201846] trunk/Source/WebCore








Revision 201846
Author achristen...@apple.com
Date 2016-06-08 17:49:38 -0700 (Wed, 08 Jun 2016)


Log Message
Fix WinCairo build.

* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (201845 => 201846)

--- trunk/Source/WebCore/ChangeLog	2016-06-09 00:41:28 UTC (rev 201845)
+++ trunk/Source/WebCore/ChangeLog	2016-06-09 00:49:38 UTC (rev 201846)
@@ -5,6 +5,13 @@
 * platform/network/curl/MultipartHandle.cpp:
 (WebCore::MultipartHandle::didReceiveResponse):
 
+2016-06-08  Alex Christensen  
+
+Fix WinCairo build.
+
+* platform/network/curl/MultipartHandle.cpp:
+(WebCore::MultipartHandle::didReceiveResponse):
+
 2016-06-08  Jer Noble  
 
 With audio user gesture restriction in place, video.src = '', video.play() succeeds where it should fail.


Modified: trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp (201845 => 201846)

--- trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-09 00:41:28 UTC (rev 201845)
+++ trunk/Source/WebCore/platform/network/curl/MultipartHandle.cpp	2016-06-09 00:49:38 UTC (rev 201846)
@@ -350,7 +350,7 @@
 response.setTextEncodingName(extractCharsetFromMediaType(contentType));
 
 d->client()->didReceiveResponse(m_resourceHandle, response);
-response->setResponseFired(true);
+response.setResponseFired(true);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

< 4 5 6 7 8 9 10 11 12 13 >

801 - 900 of 2253 matches

Mail list logo