[webkit-dev] Help for Flash Player plugin
Hello all, Sorry if i have reposted this thread. I am developing an application for MAC with loads Flash Player plugin and play SWF. I am abloe to load Plugin and got Entry Points of Flash Player Plugin and able to call that entry points. Problem is that i am not able to load SWF file in that plugin. I am writing a stream of SWF to Plugin but not loaded SWF. So if anyone has done same then please provide me some source code or giude to do so. -- Regards, Manish Patel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Nitro-Extreme branch
Hi, I have made some measurements on ARM. You can read the results on our blog site: http://webkit.sed.hu/node/14 Zoltan Right now, the branch is about even with trunk on SunSpider. Geoff On May 5, 2009, at 6:11 AM, Zoltan Herczeg wrote: Hi, we have noticed that there is a new SquirellFish branch, called Nitro-Extreme. You mentioned before (perhaps a year ago), that you plan to change the JSNumber format to eliminate number (double) allocations. This is the aim of this branch, isn't it? Do you have any results? Is it faster than the old implementation? I'm afraid we have to change a lot of things in both (x86 and arm) jit ports, but it is worth the efforts if your results are encouraging. Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] SVG Element Resizing
Hi, (Apologies if this is the wrong place to ask this question, please direct me elsewhere) Is there a way to stop SVG elements being resized when the user resizes the text in their browser. This example... http://spawn.boxuk.com/webkitsvg/ If you resize the browser text then Hello, World! scales disproportionately with the div it's enclosed within, but the size remains unchanged so I can't adjust for this. What I'd like is to be able to fix the size of the SVG element, is this possible? Thanks, rod. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
Sorry to confuse you.. The buildlog.htm for WebCore showed the below line: e:\cygwin\home\seby\webkit\webcore\svg\SVGElement.h(29) : fatal error C1083: Cannot open include file: 'SVGNames.h': No such file or directory SVGResourceMarker.cpp I meant that the SVGElement.h is there, but i dont see other files SVGNames.h and SVGResourceMarker.cpp in the same location. Where is it supposed to be? Thanks, Seby. On Thu, May 7, 2009 at 12:07 AM, Seby seby.fran...@gmail.com wrote: No, I dont see any errors.. Here is the Results sections from BuildLog.htm: Results Build log was saved at file://E:\Build\obj\WebCoreGenerated\Release\ BuildLog.htm WebCoreGenerated - 0 error(s), 0 warning(s) No, I meant to remove the WebKitBuild directory, like you said you did. Are there any failures in the WebCoreGenerated project? That's the project that generates SVGNames.h. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
On May 7, 2009, at 5:55 AM, Seby wrote: Sorry to confuse you.. The buildlog.htm for WebCore showed the below line: e:\cygwin\home\seby\webkit\webcore\svg\SVGElement.h(29) : fatal error C1083: Cannot open include file: 'SVGNames.h': No such file or directory SVGResourceMarker.cpp I meant that the SVGElement.h is there, but i dont see other files SVGNames.h and SVGResourceMarker.cpp in the same location. Where is it supposed to be? Here's SVGResourceMarker.cpp: % find . -name 'SVGResourceMarker.cpp' ./WebCore/svg/graphics/SVGResourceMarker.cpp SVGNames.h is created by the WebCoreGenerated. It uses WebCore/svg/ svgtags.in and WebCore/svg/svgattrs.in as its input files, and outputs WebKitBuild/obj/WebCore/DerivedSources/SVGNames.h and WebKitBuild/obj/ WebCore/DerivedSources/SVGNames.cpp. On Thu, May 7, 2009 at 12:07 AM, Seby seby.fran...@gmail.com wrote: No, I dont see any errors.. Here is the Results sections from BuildLog.htm: Results Build log was saved at file://E:\Build\obj\WebCoreGenerated\Release\ BuildLog.htm WebCoreGenerated - 0 error(s), 0 warning(s) What about earlier in the log file? It's possible that something could go wrong in WebCoreGenerated and the Results would still says 0 error(s) (though if that is happening it's a bug that it would be good for us to fix). -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
Adam, I can see the 'SVGResourceMarker.cpp' , svgattrs.in, svgtags.in inside the appropriate locations, but could not find SVGNames.h and SVGNames.cpp files. I'm trying once more w/ removing the build directory, update-webkit and then build-webkit. I'll get back to you.. Thank You, Seby. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
Adam, I see that there are almost 675 *.h files inside WebKitBuild/obj/WebCore/DerivedSources/, but none of them starts with SVG*. 98% of the file names start with JS*. As you said, i tried to search the WebCoreGenerated BuildLog.htm to see if there were errors while creating SVGNames.h, but i could not find any. What would be the issue? Do you want me to try anything else or any logs..etc.. Seby. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
Here is it: WebCoreGenerated BuildLog.htm: http://gist.github.com/108249 WebCore BuildLog.htm: http://gist.github.com/108251 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs
I think you may want to look at openembedded and use their way to control those things, rather then a new idea. You can build webkit there too. Most of what you said most is a minor part to me, may be to others. rgds joe --- On Tue, 5/5/09, Maciej Stachowiak m...@apple.com wrote: From: Maciej Stachowiak m...@apple.com Subject: Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs To: mbe...@pleyo.com Cc: webkit-dev@lists.webkit.org Date: Tuesday, May 5, 2009, 11:19 PM On May 4, 2009, at 5:21 AM, Mario Bensi wrote: We pursued the same goal for a couple of years. Since our porting targets are various middleware CE platforms, we had to identify and adapt WebKit needs at a better grained level than platform. In order to do this we collected all dependencies in a Browser Abstraction Layer (BAL directory). The configuration is handled by a Base directory (definition of types, platform specifications) and we use CMake to define platform specificities (and it's a great cross- platform tool). Sure the BAL model has still improvements ahead of it, but it has the merit of existing, being widely tester on a quite wide range of targets, configurations and libraries. My understanding is that BAL injects a platform abstration layer under the platform abstraction layer that is the WebCore/platform directory. Also, I gather that BAL tries to do more things via runtime indirection and subclasses with virtual methods instead of WebCore's compile-time approach. To me, those aspects sound like they may not be good fits for our goals. But I would be glad to hear more details about BAL, and how it would compare to my proposal. Regards, Maciej Regards Mario Le Friday 01 May 2009 01:12:54 Maciej Stachowiak, vous avez écrit : I think our set of porting macros has become somewhat confused. Originally, our idea was that a port represents primarily adaptation to a particular platform. However, over time it has become clear that most of what is decided by a port is not platform adaptation, but rather policy decisions. For example, ports decide to have different features enabled, or to use different sets of system functionality on the same underlying OS. In addition, I think the catchall top-level PLATFORM create confusion, because it is not totally clear if they are policy decisions, platform adaptation decisions, or what. Third, it seems wrong that the policy choices of every port are represented as a bunch of ifdef tomfoolery inside a single Platform.h file. And fourth, many ports often run on the same OS, but with a different set of choices - for example on Mac OS X it is possible to build the Mac, Chromium, Gtk, Qt and Wx ports (at least). Therefore, I propose that we change as follows: 1) Strictly separate platform adaptation (mandatory to run on a given OS, compiler, or CPU at all) from policy choices (what features to enable, what optional libraries to use). 2) Phase out PLATFORM macros completely - each use should be converted to a policy choice, or a platform adaptation decision. 3) Instead of ports being defined by a top-level PLATFORM macro, I propose that each port should have its own header file to define policy decisions. For example, I'd propose that the system Mac OS X WebKit should use PortCocoa.h, and the WebKit used by Safari for Windows should use PortWinCG.h. There may also be a PortIPhone.h. These port definition headers would live in their own top-level WebKit module. Each one would be completely owned by whoever is generally considered the owner of a given port. Because related ports on different platforms may wish to share policy choices, it's ok for Port headers to include shared headers for some choices. For example, all Apple-maintained ports may include PortApple.h. We could go even further and have PortDefault.h to make default choices of what features are enabled, that ports would have to explicitly override. 4) Platform adaptation macros would still be defined in Platform.h based on sniffing the environment, this would include things like the compiler, the underlying OS, available libc functions, and so forth. Platform adaptation macros would be: OS() - underlying operating system; only to be used for mandated low- level services like virtual memory, not to choose a GUI toolkit Examples: OS(UNIX) - Any Unix-like OS OS(DARWIN) - Underlying OS is the base OS X environment OS(FREEBSD) - FreeBSD OS(WIN) - Any version of Windows OS(WINCE) - The embedded version of Windows COMPILER() - the compiler being used to build the project Examples: COMPILER(GCC) - GNU Compiler Collection COMPILER(MSVC) - Microsoft Visual C++ COMPILER(RVCT) - ARM compiler HAVE() - specific
Re: [webkit-dev] the variable of JavaScript function
I don't understand your question. pls don't ask this kind of question on webkit
dev site, it is not related.
rgds
joe
--- On Thu, 3/19/09, zhenghe zhang zhenghe.zh...@gmail.com wrote:
From: zhenghe zhang zhenghe.zh...@gmail.com
Subject: [webkit-dev] the variable of JavaScript function
To: webkit-dev@lists.webkit.org
Date: Thursday, March 19, 2009, 9:26 AM
Hi
There is a javaScript function, as follow:
Function test()
{
Var a = 3;
Var b = 2;
Print(a+b);
}
There are two variables, and the identifiers will stored in
the
identifierTable. When running the function, it will print
5.
When running the code print(a+b),it will use
3 to replace a and 2
replace b. I don't know how to do it
through the c++ functions. I hope you
tell!
Thank you best regards
zhang
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
On May 7, 2009, at 2:16 PM, Seby wrote: WebCoreGenerated BuildLog.htm: http://gist.github.com/108249 I see what look like two errors in here: # Lower case all the values, as CSS values are case-insensitive perl -ne 'print lc' /home/Seby/WebKit/WebCore/css/ CSSValueKeywords.in /home/Seby/WebKit/WebCore/css/ SVGCSSValueKeywords.in CSSValueKeywords.in touch CSSGrammar.cpp.h Invalid switch. This makes me think that some version of perl or touch other than Cygwin's perl or touch is being invoked. cat /home/Seby/WebKit/WebCore/css/CSSPropertyNames.in /home/Seby/ WebKit/WebCore/css/SVGCSSPropertyNames.in CSSPropertyNames.in touch CSSGrammar.hpp echo '#ifndef CSSGrammar_h' CSSGrammar.h gperf -CDEot -L ANSI-C -k '*' -N findColor -D -s 2 /home/Seby/WebKit/ WebCore/platform/ColorData.gperf ColorData.c if sort CSSValueKeywords.in | uniq -d | grep -E '^[^#]'; then echo 'Duplicate value!'; exit 1; fi perl /home/Seby/WebKit/WebCore/css/makeprop.pl echo '#define CSSGrammar_h' CSSGrammar.h Duplicate value! make: *** [CSSValueKeywords.h] Error 1 make: *** Waiting for unfinished jobs I don't know for sure what would be causing this, but maybe it's related to the first problem. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] MessagePorts and garbage collection
BTW, it looks like the current Worker implementation doesn't notify the Worker object when timers/network activity are finished, so an unreferenced Worker thread won't be terminated in that case. When I get done with this design mess, I'll log a bug with some tests. -atw On Thu, May 7, 2009 at 11:54 AM, Alexey Proskuryakov a...@webkit.org wrote: on 07.05.2009 22:25, Maciej Stachowiak at m...@apple.com wrote: The best way I can think of to handle this is to have a special phase after normal marking where objects with an external/cross-thread reference get marked in a distinctive way. Then each MessagePort would know if it was marked solely due to its opposite endpoint being live. I don't recall if there is a way for an unreachable MessagePort to become reachable - I think yes, because the message event listener can stuff the MessagePort in a global variable. But I think an unerachable port can only become reachable by receiving a message. Thus, you need a core data structure for the MessageChannel which detects the case that there are no messages pending in either direct and both endpoints are alive only due to the other endpoint. Something like that. This is a very rough design sketch, Alexey can probably explain in more detail or I can study the code. This design with a separate stage between marking and sweeping is something that I started implementing, and had in ToT for a while last year. As I recall, the big problem with it is the need to detect when there are no messages pending in either direction, which is not possible without temporarily freezing the other thread/process AFAICT. That's something I'd like to avoid (yes, we do have a lock in MessageQueue, but it's not strictly necessary long-term, and there are already reports that it seriously affects performance). My impression is that Workers use a similar scheme with a special additional marking phase, or once did, but Alexey will recall better than I. You are probably thinking about my attempts to implement cross-thread MessagePort here. Worker GC makes use of the ActiveDOMObject concept - for as long as there is an unanswered message, or if it is known that the worker thread has timers (or network requests) running in it, the Worker object in main thread is deemed uncollectable. So, dedicated workers did not require any changes to JavaScriptCore GC behavior. - WBR, Alexey Proskuryakov. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] ASSERT crashes on arm platform
On Tue, 2009-05-05 at 11:22 -0300, Gustavo Chaves wrote: Actually not true: my fault not having realised one of the builds had --enable-debug and the other hadn't. Is anyone maintaining that option, that is, tracking those asserts so they don't crash? One does not expect to fall on such crashes on debug mode... The ASSERT macros are there to _cause_ the crash when something unexpected happens. If you're hitting an ASSERT you are probably doing something wrong in your code somewhere. It may also be the case that the ASSERT is wrong, or wrong specifically for your port, but that should be rare. See you, -- Gustavo Noronha g...@gnome.org GNOME contributor ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Webkit C documentation
On Thu, 2009-04-30 at 11:59 -0700, b-neva wrote: We're using a linux system(Ubuntu) and we just want to get Webkit to show a window using gtk. Were having a hard time finding the include files/compile flags. WebKitGTK+ uses the standard freedesktop.org pkg-config tool to help you with that stuff. You should be able to build a simple app by using #include webkit/webkit.h, and pkg-config --cflags --libs webkit-1.0. See http://webkitgtk.org/ for more information and API reference docs. See you, -- Gustavo Noronha g...@gnome.org GNOME contributor ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so
Dear WebKit contributors, We are attempting to completely unfork Chromium this afternoon and would love to have a no port breakage while we're doing this. If it is at all possible, could you hold off on making big changes to WebCore or JS bindings that may potentially affect Chromium port or layout test results? This should only take a day or so -- once we're pulling from ToT and have our build infrastructure switched over, you can resume breaking stuff :) :DG ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Chromium Unforking: Please hold off on big changes for a day or so
We can try, but there are a lot of critical fixes that need to go in for Safari's purposes, so I can't absolutely promise there won't be any large changes. - Maciej On May 7, 2009, at 2:08 PM, Dimitri Glazkov wrote: Dear WebKit contributors, We are attempting to completely unfork Chromium this afternoon and would love to have a no port breakage while we're doing this. If it is at all possible, could you hold off on making big changes to WebCore or JS bindings that may potentially affect Chromium port or layout test results? This should only take a day or so -- once we're pulling from ToT and have our build infrastructure switched over, you can resume breaking stuff :) :DG ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] MessagePorts and garbage collection
On May 7, 2009, at 12:28 PM, Darin Adler wrote: We consider the current JavaScriptCore protected set to be something deprecated that we’d like to eliminate. We have been steadily decreasing the number of uses of it. All other things being equal, I think it would be good to keep the new mechanism separate. I'm not sure I would go so far as to say that. For one thing, gc protect is exposed through the C API so we are committed to keeping it if only for that reason. However, the purpose of Protect.h is different from the aim here. It is supposed to allow keeping a persistent reference to a JavaScript object from native code, for example if you have a C++ heap object that should keep a JS object alive. It's tricky to use, because it has the potential to create unbreakable GC cycles, but I think there are cases where it is useful. I think two JS objects keeping each other alive across threads/heaps so long as either is rechable (or active), is a qualitatively different purpose which deserves a separate mechanism. Another thing to keep in mind: although JavaScriptCore currently uses a mark/sweep GC, we should design something that can work with a copying GC or other advanced GC algorithms: (a) so it can work with v8 and (b) so we can change JavaScriptCore's garbage collector in the future (this is something we plan to do). - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] PageGroups (and the localStorage being stored in it)
I'm continuing to work on https://bugs.webkit.org/show_bug.cgi?id=25376 and noticed that the map of origins to localStorageAreas is owned by the PageGroup class. I'm having a bit of trouble understanding what exactly page groups are used for. I looked through the code and the wiki but couldn't find any explanations. I did find http://lists.macosforge.org/pipermail/webkit-dev/2008-November/005642.html which was pretty helpful, but it still doesn't make it clear to me why the localStorage map needs to reside here (rather than being some global/singleton object). Thanks! Jeremy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] PageGroups (and the localStorage being stored in it)
On May 7, 2009, at 4:56 PM, Jeremy Orlow wrote: I'm continuing to work on https://bugs.webkit.org/show_bug.cgi?id=25376 and noticed that the map of origins to localStorageAreas is owned by the PageGroup class. I'm having a bit of trouble understanding what exactly page groups are used for. PageGroup exists so you can have multiple web pages in a single application that share state, including frame namespace, such as the multiple windows and tabs in Safari. Separate page groups allow other web views to be separate, allowing the same application to use WebKit for things that should be isolated from web browsing; for example Safari on Windows uses web views for things like Preferences and text input. This is exposed as part of the WebKit API on Mac OS X, with the setGroupName: method. It may be a useless concept for Chromium but it’s critical on Mac OS X. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Problem with building WebKit
Adam, But i see that there were lot of perl command executed just above this one w/out any errors. For eg: perl -I /home/Seby/WebKit/WebCore/bindings/scripts /home/Seby/WebKit/WebCore/bindings/scripts/generate-bindings.pl --include dom --include html --include css --include page --include xml --include svg --outputDir . --defines ENABLE_DATABASE ENABLE_DOM_STORAGE ENABLE_ICONDATABASE ENABLE_JAVASCRIPT_DEBUGGER ENABLE_OFFLINE_WEB_APPLICATIONS ENABLE_SVG ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE ENABLE_VIDEO ENABLE_WORKERS ENABLE_XPATH ENABLE_XSLT LANGUAGE_JAVASCRIPT --generator JS /home/Seby/WebKit/WebCore/page/AbstractView.idl I could not figure out why it says invalid switch. I've tested the cmd directly in cygwin bash shell and is working. Could you suggest me a location (if it is available) to download latest builded WebKit Project(not source). Thanks, Seby. On Thu, May 7, 2009 at 2:42 PM, Adam Roben aro...@apple.com wrote: On May 7, 2009, at 2:16 PM, Seby wrote: WebCoreGenerated BuildLog.htm: http://gist.github.com/108249 I see what look like two errors in here: # Lower case all the values, as CSS values are case-insensitive perl -ne 'print lc' /home/Seby/WebKit/WebCore/css/CSSValueKeywords.in /home/Seby/WebKit/WebCore/css/SVGCSSValueKeywords.in CSSValueKeywords.in touch CSSGrammar.cpp.h Invalid switch. This makes me think that some version of perl or touch other than Cygwin's perl or touch is being invoked. cat /home/Seby/WebKit/WebCore/css/CSSPropertyNames.in /home/Seby/WebKit/WebCore/css/SVGCSSPropertyNames.in CSSPropertyNames.in touch CSSGrammar.hpp echo '#ifndef CSSGrammar_h' CSSGrammar.h gperf -CDEot -L ANSI-C -k '*' -N findColor -D -s 2 /home/Seby/WebKit/WebCore/platform/ColorData.gperf ColorData.c if sort CSSValueKeywords.in | uniq -d | grep -E '^[^#]'; then echo 'Duplicate value!'; exit 1; fi perl /home/Seby/WebKit/WebCore/css/makeprop.pl echo '#define CSSGrammar_h' CSSGrammar.h Duplicate value! make: *** [CSSValueKeywords.h] Error 1 make: *** Waiting for unfinished jobs I don't know for sure what would be causing this, but maybe it's related to the first problem. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] PageGroups (and the localStorage being stored in it)
On Thu, May 7, 2009 at 5:25 PM, Darin Adler da...@apple.com wrote: On May 7, 2009, at 4:56 PM, Jeremy Orlow wrote: I'm continuing to work on https://bugs.webkit.org/show_bug.cgi?id=25376 and noticed that the map of origins to localStorageAreas is owned by the PageGroup class. I'm having a bit of trouble understanding what exactly page groups are used for. PageGroup exists so you can have multiple web pages in a single application that share state, including frame namespace, such as the multiple windows and tabs in Safari. Separate page groups allow other web views to be separate, allowing the same application to use WebKit for things that should be isolated from web browsing; for example Safari on Windows uses web views for things like Preferences and text input. This is exposed as part of the WebKit API on Mac OS X, with the setGroupName: method. It may be a useless concept for Chromium but it’s critical on Mac OS X. Didn't mean to imply they were useless, at all. Was just trying to understand their use. Thanks! J ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] PageGroups (and the localStorage being stored in it)
One more question: are there any use cases where setGroupName could occur after window.localStorage() had been called? If so, this seems like it could be a problem since a Storage object is only created on the first call to DOMWindow::localStorage() and then it's cached as a member variable in DOMWindow. This would mean that any page that calls window.localStorage() before setGroupName is called would not be using the same localStorageArea as a page that calls setGroupName first. Also, is there any significance to setGroupName being reset to nothing during Page's destructor? Jeremy On Thu, May 7, 2009 at 8:07 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, May 7, 2009 at 5:25 PM, Darin Adler da...@apple.com wrote: On May 7, 2009, at 4:56 PM, Jeremy Orlow wrote: I'm continuing to work on https://bugs.webkit.org/show_bug.cgi?id=25376 and noticed that the map of origins to localStorageAreas is owned by the PageGroup class. I'm having a bit of trouble understanding what exactly page groups are used for. PageGroup exists so you can have multiple web pages in a single application that share state, including frame namespace, such as the multiple windows and tabs in Safari. Separate page groups allow other web views to be separate, allowing the same application to use WebKit for things that should be isolated from web browsing; for example Safari on Windows uses web views for things like Preferences and text input. This is exposed as part of the WebKit API on Mac OS X, with the setGroupName: method. It may be a useless concept for Chromium but it’s critical on Mac OS X. Didn't mean to imply they were useless, at all. Was just trying to understand their use. Thanks! J ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
