[webkit-dev] DOM Serialization?
-- Forwarded message -- From: ZHOU Xiao-bo zhxb.u...@gmail.com Date: 2010/1/24 Subject: Re: [webkit-dev] DOM Serialization? To: Christopher White skullkn...@gmail.com I think you can do that, if you don't care about the strick definition of serialization. Actually, a Node is composed of Attrs which are key, value pairs. And 'key' and 'value' are strings. So, you can just use TLVs to store the Node's type and Attrs. You can either ignore its non-string member variables, because you can rebuild them through Attrs or store them in TLVs too. As for the implimentation, you can write a two friend functions for every class derived from Node to make serialization and deserialization. And the function 'createmarkup' may give you some clue. BTW: the DOM Level 3 defines Load Save interface of DOM, does WebCore impliment that. 2010/1/22 Christopher White skullkn...@gmail.com Is it possible to save the DOM resulting from the parsing of HTML / CSS into a file and then read it back instead of re-parsing the HTML (similar to Java object serialization). Does it save any time or is it a wash? I know there is a dump render tree function but does it save everything you need so that you can re-render the HTML page w/o the original HTML / CSS files? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] DOM Serialization?
Thank you for your feedback. Assuming it is not practical, any thoughts on things that can be done to speed up the parsing and loading process for content that is not dynamically generated by JavaScript (i.e. document.write())? On Sat, Jan 23, 2010 at 10:14 AM, Darin Adler da...@apple.com wrote: On Jan 23, 2010, at 8:18 AM, Christopher White wrote: What are the general thoughts whether a binary serialization is possible retaining all needed information for rendering? My general thought is that it is not practical. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] webkit team wiki page
I noticed that the WebKit Team wiki page changed significantly this past week: http://trac.webkit.org/wiki/WebKit%20Team I was curious about the reasons behind the change, and whether people like the change. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
I changed it for two reasons: 1) The old format wasn't scaling to the current team size. The page as become an unwieldy wall of text. 2) The old format emphasized the industrial affiliation of the team members, which seemed counter to a collegial project. The new format emphasizes project role (reviewer / committer / contributor). In the conversion process, I removed the areas of knowledge information because it was often out of date or provincial. svn blame, IRC, or social awareness is a more accurate way of figuring or who to ask about a particular piece of code. I also updated the page to contain all reviewers and committers. (The old page was missing a bunch of folks.) Adam On Sun, Jan 24, 2010 at 9:45 PM, Chris Jerdonek cjerdo...@webkit.org wrote: I noticed that the WebKit Team wiki page changed significantly this past week: http://trac.webkit.org/wiki/WebKit%20Team I was curious about the reasons behind the change, and whether people like the change. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Sun, Jan 24, 2010 at 2:02 PM, Adam Barth aba...@webkit.org wrote: In the conversion process, I removed the areas of knowledge information because it was often out of date or provincial. svn blame, IRC, or social awareness is a more accurate way of figuring or who to ask about a particular piece of code. Thanks for the explanation, Adam. An additional type of information that was removed was the chronology, so you could see roughly who has been involved in the project longer. While this was not explicitly stated, I believe that within each section individuals were added in the order they became involved. I'm not saying this information shouldn't be removed. I'd just like to point out that it's something else that got lost in the change. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
Looking at the old page, it is not an accurate source of chronology information. :) However such is easy to gather from svn/git. I wrote a script a while ago which shows you the latest commit by everyone, but it would be about 2 lines of code change to make it show you the first commit instead: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/validate-committer-lists#L157 -eric On Sun, Jan 24, 2010 at 2:31 PM, Chris Jerdonek cjerdo...@webkit.org wrote: On Sun, Jan 24, 2010 at 2:02 PM, Adam Barth aba...@webkit.org wrote: In the conversion process, I removed the areas of knowledge information because it was often out of date or provincial. svn blame, IRC, or social awareness is a more accurate way of figuring or who to ask about a particular piece of code. Thanks for the explanation, Adam. An additional type of information that was removed was the chronology, so you could see roughly who has been involved in the project longer. While this was not explicitly stated, I believe that within each section individuals were added in the order they became involved. I'm not saying this information shouldn't be removed. I'd just like to point out that it's something else that got lost in the change. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Jan 24, 2010, at 2:02 PM, Adam Barth wrote: I changed it for two reasons: 1) The old format wasn't scaling to the current team size. The page as become an unwieldy wall of text. 2) The old format emphasized the industrial affiliation of the team members, which seemed counter to a collegial project. The new format emphasizes project role (reviewer / committer / contributor). In the conversion process, I removed the areas of knowledge information because it was often out of date or provincial. svn blame, IRC, or social awareness is a more accurate way of figuring or who to ask about a particular piece of code. I think deleting the areas of knowledge is a regrettable loss of information. I think it's helpful to give people at least a few starting points for their questions, because not everyone is going to be comfortable firing random questions at IRC, and svn blame i not a very useful tool if you don't know the code very well yet. Further, even for experienced contributors, I think this information could be useful as a guide to whom you might hassle to review your patch, if it doesn't get reviewed right away. I mean, I've been involved in the project for a pretty long time, and I can't honestly say I know the right people to ask for advice on every possible topic in the code, without a reference. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Sun, January 24, 2010 at 7:09:26 PM, Maciej Stachowiak wrote: I think deleting the areas of knowledge is a regrettable loss of information. I think it's helpful to give people at least a few starting points for their questions, because not everyone is going to be comfortable firing random questions at IRC, and svn blame i not a very useful tool if you don't know the code very well yet. Further, even for experienced contributors, I think this information could be useful as a guide to whom you might hassle to review your patch, if it doesn't get reviewed right away. I mean, I've been involved in the project for a pretty long time, and I can't honestly say I know the right people to ask for advice on every possible topic in the code, without a reference. One possible alternative would be to update the bugs.webkit.org Component page with a list of reviewers by component: https://bugs.webkit.org/describecomponents.cgi?product=WebKit It puts the information closer to where it's needed. The only down sides are that it's not necessarily easy to find (click on the link of the Component: label on any bug page) and it requires special access to bugs.webkit.org to edit the component descriptions. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Jan 24, 2010, at 7:42 PM, David Kilzer wrote: On Sun, January 24, 2010 at 7:09:26 PM, Maciej Stachowiak wrote: I think deleting the areas of knowledge is a regrettable loss of information. I think it's helpful to give people at least a few starting points for their questions, because not everyone is going to be comfortable firing random questions at IRC, and svn blame i not a very useful tool if you don't know the code very well yet. Further, even for experienced contributors, I think this information could be useful as a guide to whom you might hassle to review your patch, if it doesn't get reviewed right away. I mean, I've been involved in the project for a pretty long time, and I can't honestly say I know the right people to ask for advice on every possible topic in the code, without a reference. One possible alternative would be to update the bugs.webkit.org Component page with a list of reviewers by component: https://bugs.webkit.org/describecomponents.cgi?product=WebKit I don't think we're looking to list just reviewers but rather people who know about this topic and therefore might be good to ask about the topic. Often you want to know this before you even start working on a patch. Some types of expert advice are cross-cutting across components as well. For example, if you want to find a person who can help you with performance work, or analyze the security impact of a feature, those kinds of things are not likely to be components. And finally, the only fields we have for components are the description, default assignee and default Cc list. I am not sure any of these is appropriate as a way to indicate people who know most about the topic, given our process. It puts the information closer to where it's needed. The only down sides are that it's not necessarily easy to find (click on the link of the Component: label on any bug page) and it requires special access to bugs.webkit.org to edit the component descriptions. My suggestion would be to put the info back on the wiki page until we find a better place for it. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Mon, Jan 25, 2010 at 4:07 AM, Maciej Stachowiak m...@apple.com wrote: On Jan 24, 2010, at 7:42 PM, David Kilzer wrote: It puts the information closer to where it's needed. The only down sides are that it's not necessarily easy to find (click on the link of the Component: label on any bug page) and it requires special access to bugs.webkit.org to edit the component descriptions. My suggestion would be to put the info back on the wiki page until we find a better place for it. Ok. Will do. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Sun, Jan 24, 2010 at 8:15 PM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Am 25.01.2010 um 05:07 schrieb Maciej Stachowiak: On Jan 24, 2010, at 7:42 PM, David Kilzer wrote: On Sun, January 24, 2010 at 7:09:26 PM, Maciej Stachowiak wrote: I don't think we're looking to list just reviewers but rather people who know about this topic and therefore might be good to ask about the topic. Often you want to know this before you even start working on a patch. Some types of expert advice are cross-cutting across components as well. For example, if you want to find a person who can help you with performance work, or analyze the security impact of a feature, those kinds of things are not likely to be components. And finally, the only fields we have for components are the description, default assignee and default Cc list. I am not sure any of these is appropriate as a way to indicate people who know most about the topic, given our process. Completly agreed. I found those information useful in my past as WebKit beginner and I think we should rather update it and/or make it available on a more prominent place. Agreed. I can usually figure out who has been working on particular area (e.g. CSS, rendering, etc...) by looking at trac or change log, but that isn't usually sufficient when trying to find an expert. But I also agree that the old page was outdated. Maybe what we need is a bugzilla page for each component/expertise that lists contributers and related bugs. Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit team wiki page
On Mon, Jan 25, 2010 at 4:51 AM, Adam Barth aba...@webkit.org wrote: On Mon, Jan 25, 2010 at 4:07 AM, Maciej Stachowiak m...@apple.com wrote: On Jan 24, 2010, at 7:42 PM, David Kilzer wrote: It puts the information closer to where it's needed. The only down sides are that it's not necessarily easy to find (click on the link of the Component: label on any bug page) and it requires special access to bugs.webkit.org to edit the component descriptions. My suggestion would be to put the info back on the wiki page until we find a better place for it. Ok. Will do. I've restored this information to the page. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
