[webkit-dev] svn-apply regression
Hi folks, This e-mail is to let you know about a regression in svn-apply that was discovered and fixed tonight and that may have affected you. The regression is most likely to have affected you if, in the last 5 days (after r58495), you committed a patch that was an "e-mail diff" using svn-apply's --force option (e.g. using the commit-queue). Briefly, the regression would have caused the first file in your patch to be skipped if your patch was an e-mail diff. Thus, you may want to review your recent commits to verify that the first file in each commit was checked in. The regression is described in more detail here: https://bugs.webkit.org/show_bug.cgi?id=38507 We have slowly been increasing the code coverage of svn-apply and -unapply, and the regression happened to be in the part that does not yet have coverage. In the future, we may want to consider adjusting svn-apply and -unapply so that it does not routinely need to be run in --force mode. --force mode connotes something that should be done less frequently and under more closely controlled and observed settings. Thanks, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Announcing WebKit2
Hi, What's the status of Webkit2? I've built the latest webkit version on Windows with --webkit2 option and I see that there is only one process shown in Task Manager irrespective of the number of Windows that I open. Reagrds, Nayan. On 4/13/10, Geoffrey Garen wrote: >> Will I be able to adjust process priorities to keep all processes of a >> certain MIME type (say application/x-shockwave-flash) to receive no more >> than 15% cpu time or monitor its memory usage? > > All process management is behind the API layer, the goal being to shield app > developers from the details of process management. I'm not sure how you'd > control the details of process management. > > Geoff > > -- Regards, _Nayan_ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Function & Property Names
CodeBlock::m_numParameters counts a function's expected parameter count. Geoff On May 3, 2010, at 9:21 PM, Nyx wrote: > > Is there any way to get the number of parameters a function has declared from > a JSFunction object? > > I'm asking because I want to get the argument values a function is receiving > in an op_call (in the interpreter). I copied this snipper of code for the > case where a host function is called: > > Register* thisRegister = callFrame->registers() - > RegisterFile::CallFrameHeaderSize - argCount; > ArgList args(thisRegister + 1, argCount - 1); > > The problem is that argCount is the number of arguments passed, and so, if > the function takes 5 arguments and 3 are passed, I'm not getting the first > 2, only the last 3, two of which show up as "undefined". Hence I believe I > would need the number of arguments the function declares takes to properly > compute the register offset. > > -- > View this message in context: > http://old.nabble.com/Function---Property-Names-tp28394250p28442878.html > Sent from the Webkit mailing list archive at Nabble.com. > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Help with review of EFL CMake patches?
Just a friendly "ping", if someone could help us get this merged, say
it. If you see a big blocker after my last comment, say it.
Meanwhile, Leandro is working on generic webkit option, to be more
generic than my initial {ADD,DEL}_FEATURE().
BR,
On Mon, May 3, 2010 at 6:32 PM, Gustavo Sverzut Barbieri
wrote:
> On Mon, May 3, 2010 at 6:09 PM, Patrick Roland Gansterer
> wrote:
>> Hi,
>>
>> On Mon, 3 May 2010 17:33:45 -0300, Gustavo Sverzut Barbieri
>> wrote:
>>> Did you see this new version? Â Leandro did the work on top of yours.
>>> However he removed the .h from the source list, he did it before he
>>> read that it may be useful to get some IDE to show it. If mandatory we
>>> can add them back.
>> Yes, I've seen it. He did a great job, but there a some parts which are
>> not good for a "general buildsystem".
>> E.g. INCLUDE(Options${PORT}) doesn't support different ports well, since
>> ports share some parts. (There some other points too; I'll post them on the
>> bug)
>>
>> My vision is that the root CMake file will do all the "WTF_USE_*" stuff.
>> It has to decide all "port specific stuff". All other CMake files should
>> only use this "defines". This will provide a central to switch the
>> different implementations (e.g. switch between pthread and native threads
>> on windows).
>
> The point is to split this off to some ports as these things are
> likely to get huge. As said we did some for GTK and EFL, although they
> share a lot, the checks became big to make the file a PITA to read.
> Although CMake does provide if() and indentation, the branches tend to
> be quite long.
>
> also, each folder, like JavaScriptCore/CMakeLists.txt have a
> port-specific file included, that may be used to filter or extend the
> lists, or to change some variables. This way we can turn on "*core
> libraries as shared objects" and have  libJavaScriptCoreGtk.so and
> libJavaScriptGtk.so installed. This is not so useful for deployment,
> but definitely useful for development where link times tend to be
> quite long if you don't have lots of RAM for linking.
>
> Also, this is done in a way that we don't need to anticipate all kind
> of different platform behaviors, they can just change the behavior as
> intended.
>
>
>> I already run in some problem with my JavaScriptCore CMake files, but I
>> hoped for some feedback I didn't get.
>
> Well, the bits you did were quite unchanged, except by delegating the
> options to their own files due the above reasons. So consider these
> patches as feedback that works (in the sense of you can try it)
>
>
>> My big question is if CMake should be added as a universal buildsystem (to
>> get rid of some other buildsystems) or if it is only for the EFL port?
>> I think this depends on ther progress in the CMake vs. GYP discussion. The
>> last post on the mailing list was [1].
>>
>> - Patrick
>>
>> [1] https://lists.webkit.org/pipermail/webkit-dev/2010-April/012662.html
>
> As I said, I really want to get out of the universal thing otherwise
> it will not be merged. IMHO it is a much saner approach to do one
> example and passively convert those that are willing to use CMake (ie:
> Xan said if Gtk works without loss, then he'd be fine to use it).
>
> Alternatively, if moving to GYP will make our build system be accepted
> more easily, then just say and we'll take the burden of going that
> route. We just want to have all we need in SVN, say to users "get svn,
> type this and it is done". Also, maintaining the build off tree proved
> painful over the last weeks when files were moved and we had to play
> catch up (to fix this we need stuff in svn AND a build bot, i know...
> but we'll get there).
>
> BR,
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Announcing WebKit2
> Date: Wed, 28 Apr 2010 16:40:14 +0530 > From: naya...@gmail.com > To: gga...@apple.com > CC: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] Announcing WebKit2 > > Hi, > What's the status of Webkit2? I've built the latest webkit version on > Windows with --webkit2 option and I see that there is only one process > shown in Task Manager irrespective of the number of Windows that I > open. > > Reagrds, > Nayan. > > On 4/13/10, Geoffrey Garen wrote: >>> Will I be able to adjust process priorities to keep all processes of a >>> certain MIME type (say application/x-shockwave-flash) to receive no more >>> than 15% cpu time or monitor its memory usage? >> >> All process management is behind the API layer, the goal being to shield app >> developers from the details of process management. I'm not sure how you'd >> control the details of process management. >> This came up before in the context of security but resource allocation should be given some thought. I'm not always sure if the people who design web pages and serve thid party items care about the user's CPU. When we did java ads, this was a big deal but today it isn't hard to open a window or two and have all resources used doing stuff unrelated to browsing. Memory, CPU, and IO allocation should have some means for monitor if not control. Presonally I wouldn't mind a file in /etc/webkit to control this and other stuff. If you are making an alternative to IE, it may be helpful to remember all the things you don't like about IE and the importance of features in these other environments.. >> Geoff >> >> > > > -- > Regards, > _Nayan_ > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _ The New Busy is not the too busy. Combine all your e-mail accounts with Hotmail. http://www.windowslive.com/campaign/thenewbusy?tile=multiaccount&ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_4 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Announcing WebKit2
On Wed, Apr 28, 2010 at 7:10 AM, Nayan wrote: > Hi, > What's the status of Webkit2? I've built the latest webkit version on > Windows with --webkit2 option and I see that there is only one process > shown in Task Manager irrespective of the number of Windows that I > open. > > Reagrds, > Nayan. > On Windows, the only way to build it right now is from within WebKit2.sln. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
