[webkit-dev] Renaming directories
While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite WebKitExamplePlugins = ExamplePlugins LayoutTests = Tests Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
LayoutTests = Tests That would kill the new Ttab is enough to enter the Tools directory feature :P I like the Ltab for generic tests. Cheers, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
Hm, thinking a bit about it I realized these renamings could help the usability of the source code. I actually use a lot the WebKitBuild directory, and would be happy if it would be renamed to Build (= Btab), and Scripts could go to the root directory. In that case, LayoutTests = Tests would be be OK for me, if Tools would be renamed to anything which does not start with T. It would be good if the renamings would be based on directory entering statistics. Regards, Zoltan LayoutTests = Tests That would kill the new Ttab is enough to enter the Tools directory feature :P I like the Ltab for generic tests. Cheers, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
On Sat, Dec 18, 2010 at 2:54 PM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote: Hm, thinking a bit about it I realized these renamings could help the usability of the source code. I actually use a lot the WebKitBuild directory, and would be happy if it would be renamed to Build (= Btab), and Scripts could go to the root directory. In that case, LayoutTests = Tests would be be OK for me, if Tools would be renamed to anything which does not start with T. It would be good if the renamings would be based on directory entering statistics. I would say a well defined structure for the project is more important than quick access on the command line :) I think renaming LayoutTests to Tests (or UnitTests?) make sense since there is more in there than layout tests. Newcomers would not be surprised to find all tests in there. Regards, Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite WebKitExamplePlugins = ExamplePlugins LayoutTests = Tests I would use Website http://en.wikipedia.org/wiki/Website rather than WebSite. But to me that raises the question of what to call BugsSite. I would call it just Examples rather ExamplePlugins because I think we can put other kinds of examples in there later. If we renamed LayoutTests to Tests then I would wan to put PageLoadTests in there. I’d also like to see us remove any top level files that don’t have to be there. For example, we have to keep the Makefile there so that make works, but I am not so sure that wscript has to be there. It seems some of the build related files could move down one level. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
18.12.2010, в 02:37, Zoltan Herczeg написал(а): LayoutTests = Tests That would kill the new Ttab is enough to enter the Tools directory feature :P I like the Ltab for generic tests. Yes, I think that ease of tab completion should be the primary consideration when renaming directories. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
Didn't we have a discussion about this and concluded that RegressionTests is the best choice? Ryosuke Niwa Software Engineer Google Inc. On Sat, Dec 18, 2010 at 2:37 AM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote: LayoutTests = Tests That would kill the new Ttab is enough to enter the Tools directory feature :P I like the Ltab for generic tests. Cheers, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
On Sat, Dec 18, 2010 at 8:43 AM, Darin Adler da...@apple.com wrote: On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite WebKitExamplePlugins = ExamplePlugins LayoutTests = Tests I would use Website http://en.wikipedia.org/wiki/Website rather than WebSite. But to me that raises the question of what to call BugsSite. Website is fine with me. Presumably if I move this directory myself, I'll break the actual web site. :) I'll coordinate with wms. I would call it just Examples rather ExamplePlugins because I think we can put other kinds of examples in there later. I've posted a patch for this one because it seems easiest: https://bugs.webkit.org/show_bug.cgi?id=51291 If we renamed LayoutTests to Tests then I would wan to put PageLoadTests in there. I’d also like to see us remove any top level files that don’t have to be there. For example, we have to keep the Makefile there so that make works, but I am not so sure that wscript has to be there. It seems some of the build related files could move down one level. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
On Dec 18, 2010, at 11:05 AM, Adam Barth wrote: On Sat, Dec 18, 2010 at 8:43 AM, Darin Adler da...@apple.com wrote: On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite WebKitExamplePlugins = ExamplePlugins LayoutTests = Tests I would use Website http://en.wikipedia.org/wiki/Website rather than WebSite. But to me that raises the question of what to call BugsSite. Website is fine with me. Presumably if I move this directory myself, I'll break the actual web site. :) I'll coordinate with wms. Just cc me on the bug and I'll cleanup the server after the fact. All that will break is future automatic updates of the site for the short time before the wc is switched. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming directories
On Sat, Dec 18, 2010 at 11:39 AM, William Siegrist wsiegr...@apple.com wrote: On Dec 18, 2010, at 11:05 AM, Adam Barth wrote: On Sat, Dec 18, 2010 at 8:43 AM, Darin Adler da...@apple.com wrote: On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite WebKitExamplePlugins = ExamplePlugins LayoutTests = Tests I would use Website http://en.wikipedia.org/wiki/Website rather than WebSite. But to me that raises the question of what to call BugsSite. Website is fine with me. Presumably if I move this directory myself, I'll break the actual web site. :) I'll coordinate with wms. Just cc me on the bug and I'll cleanup the server after the fact. All that will break is future automatic updates of the site for the short time before the wc is switched. Thanks Bill. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Gtk Linux 32btis Release needs a full build.
Building has been failing on it since the WebKitTools - Tools rename (r74301). (...) make: *** No rule to make target `../../WebKitTools/GNUmakefile.am', needed by `../../GNUmakefile.in'. Stop. Failed to build WebKit using 'make'! program finished with exit code 2 elapsedTime=10.943262 (...) GTK Linux 32-bit Debug and GTK Linux 64-bit Debug are ok though. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
