Re: [webkit-dev] Help with GTK build
On Sat, Jan 08, 2011 at 12:50:11PM +0100, Alejandro G. Castro wrote: > On Sat, Jan 08, 2011 at 12:20:18PM +0100, Alejandro G. Castro wrote: > > > > [...] > > > > Yeah, it is the length, we already had that issue when doing "make > > dist". It looks like adding "Source" is adding enough characters to > > cause the same problem: > > > > http://thread.gmane.org/gmane.comp.gnu.make.bugs/4219 > > > > I'm afraid we have to patch the make we are using in the bots. I'll try > > to check it. > > > > I've patched and installed the make package in the 64bits debug bot > and apparently it is working, I'm going to do the same in the 32bit > debug, unfortunately I do not have access to the release bots. > For the record, Xan and Martin just committed the required fix, so we do not need to patch make: http://trac.webkit.org/changeset/75362 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Help with GTK build
On Mon, Jan 10, 2011 at 12:32 AM, Alejandro Garcia Castro wrote: > On Sat, Jan 08, 2011 at 12:50:11PM +0100, Alejandro G. Castro wrote: >> On Sat, Jan 08, 2011 at 12:20:18PM +0100, Alejandro G. Castro wrote: >> > >> > [...] >> > >> > Yeah, it is the length, we already had that issue when doing "make >> > dist". It looks like adding "Source" is adding enough characters to >> > cause the same problem: >> > >> > http://thread.gmane.org/gmane.comp.gnu.make.bugs/4219 >> > >> > I'm afraid we have to patch the make we are using in the bots. I'll try >> > to check it. >> > >> >> I've patched and installed the make package in the 64bits debug bot >> and apparently it is working, I'm going to do the same in the 32bit >> debug, unfortunately I do not have access to the release bots. > > For the record, Xan and Martin just committed the required fix, so we > do not need to patch make: > > http://trac.webkit.org/changeset/75362 Thanks. I really appreciate you all cleaning up after my mess. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Image decoding on demand?
Hi, I am working on improving WebGL texture uploading performance. At the moment, for each texture loaded from HTMLImageElement, images are always decoded twice: the first pass is regular decoding, the second pass is for WebGL only. The reason is that for WebGL, we sometimes want the raw RGBA data without applying gamma and color profile, and without premultiplying alpha. I am wondering if there is any way we can avoid decoding twice. In many cases, the HTMLImageElement used as WebGL texture won't be displayed, so we don't need the first pass regular decoding. The problem is that HTMLImageElement does not know how it is going to be used. So we can not just pass in some parameter and let the first pass decoding behave like we desire. So my question is, is it possible to let HTMLImageElement'd image decoding to be on-demand? Say, only decode it once it's rendered or used by WebGL? Please advise. Mo ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] EventListener Invocation Cost?
On Jan 9, 2011, at 11:56 AM, Alex Milowski wrote: > I'm not sure there is a lot that can be done about it. I’m sure we can speed it up if we have a reason to. Step one is to find out exactly where the time is spent. Then we figure out ways to streamline the code path. The experts on this may not have the same priorities you do, so they may not have plans to spend time improving it. > The only question I have right now is whether the event handler function from > Javascript is JIT compiled. The answer is yes. There’s nothing special about the event handler function. In fact at the time it is compiled the engine doesn’t know it will be an event handler function. Unless you’re talking about a handler from a content attribute such as onclick. Those are also compiled, though. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] [Mac] Pixel test passed but the text dump differs.
Hello, I just noticed that there're a few spelling correction tests are failing on TOT on mac. The pixel tests still pass, but the text dump are different. More specifically, all the differences are on numeral value in the phrase "#document toDOMRange:range from 1 of #text". I have attached a snippet of such diff at the end of email. Is this a known change that requires regenerating expected test results? Thanks Jia ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] [Mac] Pixel test passed but the text dump differs.
Sorry, forgot to attached the sample of diff result: --- /tmp/layout-test-results/platform/mac/editing/spelling/autocorrection-contraction-expected.txt 2011-01-10 11:12:55.0 -0800 +++ /tmp/layout-test-results/platform/mac/editing/spelling/autocorrection-contraction-actual.txt 2011-01-10 11:12:55.0 -0800 @@ -4,37 +4,37 @@ EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification On Jan 10, 2011, at 11:05 AM, Jia Pu wrote: > Hello, > > I just noticed that there're a few spelling correction tests are failing on > TOT on mac. The pixel tests still pass, but the text dump are different. More > specifically, all the differences are on numeral value in the phrase > "#document toDOMRange:range from 1 of #text". I have attached a snippet of > such diff at the end of email. Is this a known change that requires > regenerating expected test results? > > Thanks > Jia > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] EventListener Invocation Cost?
On Mon, Jan 10, 2011 at 10:19 AM, Darin Adler wrote: > On Jan 9, 2011, at 11:56 AM, Alex Milowski wrote: > >> I'm not sure there is a lot that can be done about it. > > I’m sure we can speed it up if we have a reason to. Step one is to find out > exactly where the time is spent. Then we figure out ways to streamline the > code path. The experts on this may not have the same priorities you do, so > they may not have plans to spend time improving it. I will certainly spend some time trying to narrow this down but I also think my current situation is rather extreme and so I may have "spoke too soon." Digging deeper into the performance of the API I'm experimenting with shows, by no surprise, that it delivers an extreme number of small event objects. There is always going to be a penalty for that but the relative performance of the execution of the event listener is actually rather good if you take the number of events delivered into account. I'm certain that a listener within C++ would perform better, but that isn't a big surprise either. When you take the overall application speed into account, things look very different. That is, not just the speed of parsing and delivering the XML information but how long does it take the application to load or use the data it has received. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] [Mac] Pixel test passed but the text dump differs.
On Jan 10, 2011, at 11:05 AM, Jia Pu wrote: > I just noticed that there're a few spelling correction tests are failing on > TOT on mac. The pixel tests still pass, but the text dump are different. More > specifically, all the differences are on numeral value in the phrase > "#document toDOMRange:range from 1 of #text". I have attached a snippet of > such diff at the end of email. Is this a known change that requires > regenerating expected test results? That sounds familiar. There was a change that affected these modification delegate methods, I think done by Ryosuke, and he updated results for many tests. I think he probably missed these when doing that. I couldn’t quickly find the bug number or the revision number. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] [Mac] Pixel test passed but the text dump differs.
On Mon, Jan 10, 2011 at 12:09 PM, Ryosuke Niwa wrote: > This might be due to my first patch for > https://bugs.webkit.org/show_bug.cgi?id=51389 > > Best, > Ryosuke > > On Mon, Jan 10, 2011 at 11:42 AM, Darin Adler wrote: > >> On Jan 10, 2011, at 11:05 AM, Jia Pu wrote: >> >> > I just noticed that there're a few spelling correction tests are failing >> on TOT on mac. The pixel tests still pass, but the text dump are different. >> More specifically, all the differences are on numeral value in the phrase >> "#document toDOMRange:range from 1 of #text". I have attached a snippet of >> such diff at the end of email. Is this a known change that requires >> regenerating expected test results? >> >> That sounds familiar. There was a change that affected these modification >> delegate methods, I think done by Ryosuke, and he updated results for many >> tests. I think he probably missed these when doing that. >> >> I couldn’t quickly find the bug number or the revision number. >> >>-- Darin >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How can I call a javascript function from the hosting application
The function "evaluateJavaScript()"is not in my Frame.h. Do you know why? Is
there some cmake options that makes it appear in the Frame class?
Regards,
Fred
-Original Message-
From: André Pedralho [mailto:apedra...@gmail.com]
Sent: Friday, January 07, 2011 2:21 PM
To: fredx21
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] How can I call a javascript function from the
hosting application
On Fri, Jan 7, 2011 at 14:35, fredx21 wrote:
> My application is hosting a WebView instance to render its GUI using
> the Windows CE port of Webkit.
>
>
>
> I need to be able to call some JavaScript functions that are written
> into the loaded HTML page. For example, I have an
> Init(backgroundColor) function that needs to be called once the page
> is loaded. I guess calling a JavaScript function is trivial, but I did
> not find an answer to my question yet.
>
>
>
> Can anyone give me pointer on how I can call a JavaScript function
> from the hosting application?
>
http://doc.qt.nokia.com/4.7-snapshot/qwebframe.html#evaluateJavaScript
WebView->page()->mainFrame()->evaluateJavaScript("Init(backgroundColor)"
WebView->);
BR,
--
Andre Pedralho
http://pedralho.blogspot.com/
>
>
> Regards,
>
> Fred
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How can I call a javascript function from the hosting application
2011/1/10 fredx21 :
> The function "evaluateJavaScript()"is not in my Frame.h. Do you know why? Is
> there some cmake options that makes it appear in the Frame class?
>
Hi Fred, my bad! Sorry, it is only available in the Qt port.
> Regards,
> Fred
>
> -Original Message-
> From: André Pedralho [mailto:apedra...@gmail.com]
> Sent: Friday, January 07, 2011 2:21 PM
> To: fredx21
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: [webkit-dev] How can I call a javascript function from the
> hosting application
>
> On Fri, Jan 7, 2011 at 14:35, fredx21 wrote:
>> My application is hosting a WebView instance to render its GUI using
>> the Windows CE port of Webkit.
>>
>>
>>
>> I need to be able to call some JavaScript functions that are written
>> into the loaded HTML page. For example, I have an
>> Init(backgroundColor) function that needs to be called once the page
>> is loaded. I guess calling a JavaScript function is trivial, but I did
>> not find an answer to my question yet.
>>
>>
>>
>> Can anyone give me pointer on how I can call a JavaScript function
>> from the hosting application?
>>
> http://doc.qt.nokia.com/4.7-snapshot/qwebframe.html#evaluateJavaScript
>
> WebView->page()->mainFrame()->evaluateJavaScript("Init(backgroundColor)"
> WebView->);
>
> BR,
>
> --
> Andre Pedralho
> http://pedralho.blogspot.com/
>
>>
>>
>> Regards,
>>
>> Fred
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How can I call a javascript function from the hosting application
André Pedralho: > Hi Fred, my bad! Sorry, it is only available in the Qt port. If you have a look at the Qt port you see the following: JSC::JSValue v = d->frame->script()->executeScript(ScriptSourceCode(scriptSource)).jsValue(); There's a Frame::script() method where get the ScriptController. - Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Scope of FrameLoader::isProcessingUserGesture
In our platform implementation of dispatchWillPerformClientRedirect, we check whether the redirect was triggered by a user gesture: m_frame->loader()->isProcessingUserGesture() Since svn rev 65082, isProcessingUserGesture returns true when processing a meta tag refresh. We have a fix for this, but before we submit it - is isProcessingUserGesture SUPPOSED to be returning the correct value at this point? Or is it meant to be undefined except during the actual load? Thanks, Joe - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How can I call a javascript function from the hosting application
Hi Patrick, On Jan 10, 2011, at 12:37 PM, Patrick Gansterer wrote: > André Pedralho: >> Hi Fred, my bad! Sorry, it is only available in the Qt port. > > If you have a look at the Qt port you see the following: > > JSC::JSValue v = > d->frame->script()->executeScript(ScriptSourceCode(scriptSource)).jsValue(); > > There's a Frame::script() method where get the ScriptController. I'm not that familiar with the Windows CE port, but in the regular Windows version you can access the script object via COM interface pointers. The project I link on my blog (http://whtconstruct.blogspot.com/2009/06/calljs-updated.html) shows some examples of using this. -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] #webkit down?
As of this afternoon I'm unable to connect o #webkit. I'm attempting to connect to irc.freenode.net (I was using port 8000, but now I'm using 7000 w/ SSL). NICK eseidel USER eseidel 0 * Eric Seidel NOTICE * *** Looking up your hostname... NOTICE * *** Checking Ident NOTICE * *** Found your hostname NOTICE * *** No Ident response NOTICE *** Notice -- You need to identify via SASL to use this server ERROR Closing Link: m460536d0.tmodns.net (SASL access only) Anyone know what's up? Google seems unhelpful. Mostly I find information about "SASL" related IRC phishing/spam. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] #webkit down?
I can access #webkit as of now. - Ryosuke On Mon, Jan 10, 2011 at 11:19 PM, Eric Seidel wrote: > As of this afternoon I'm unable to connect o #webkit. > > I'm attempting to connect to irc.freenode.net (I was using port 8000, > but now I'm using 7000 w/ SSL). > > NICK eseidel > USER eseidel 0 * Eric Seidel > NOTICE * *** Looking up your hostname... > NOTICE * *** Checking Ident > NOTICE * *** Found your hostname > NOTICE * *** No Ident response > NOTICE *** Notice -- You need to identify via SASL to use this server > ERROR Closing Link: m460536d0.tmodns.net (SASL access only) > > > Anyone know what's up? > > Google seems unhelpful. Mostly I find information about "SASL" > related IRC phishing/spam. > > -eric > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
